Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33759 )
Change subject: soc/amd/picasso: Support reset vector in romstage
......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33759/20/src/soc/amd/picasso/Makef…
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33759/20/src/soc/amd/picasso/Makef…
PS20, Line 211: ifeq ($(CONFIG_RESET_VECTOR_IN_RAM_ROMSTAGE),y)
> Yes, you're right. […]
AFAICS PSP directory should not be allowed to point outside amdfw.rom.
Aaron, I feel this is worth filing a bug or reverting where cbfstool/amdcompress was added.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8c6175de34a0728ad41085e9c7cd310bd280976
Gerrit-Change-Number: 33759
Gerrit-PatchSet: 20
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 07 Jan 2020 13:40:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: comment
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37426 )
Change subject: soc/intel/tigerlake: Update Kconfig
......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37426/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37426/2//COMMIT_MSG@16
PS2, Line 16: 4. Update chip files to include tigerlake PCH DEVFNs
> Having a list in a commit message, indicates that the commit should be split up into separate commit […]
Done
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: I2C
> This is not updated.
Ack
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@11
PS11, Line 11: UART
> This is not updated.
Ack
https://review.coreboot.org/c/coreboot/+/37426/11//COMMIT_MSG@13
PS11, Line 13: PCH baseclock
> Reference?
We'll provide external document if we can find.
We're trying to find out document. PCH base clock which is used for UART is changed from 120MHz to 100MHz.
So, we needed to update M/N setting for 115200 baudrate.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37426
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04020d55f1063d521b15f8d0dabbd6f1dabf577c
Gerrit-Change-Number: 37426
Gerrit-PatchSet: 13
Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 07 Jan 2020 09:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Gerrit-MessageType: comment