Change in coreboot[master]: nb/agesa/family14: Remove wrong _ARD

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

30 Dec 2019 30 Dec '19

8:31 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ARD ......................................................................

nb/agesa/family14: Remove wrong _ARD

A device object must contain either a _HID object or an _ADR object, but should not contain both.

Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/agesa/family14/acpi/northbridge.asl 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/1

diff --git a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl index 6e3bc93..16864b3 100644 --- a/src/northbridge/amd/agesa/family14/acpi/northbridge.asl +++ b/src/northbridge/amd/agesa/family14/acpi/northbridge.asl @@ -128,7 +128,6 @@

/* Northbridge function 3 */ Device(NBF3) { - Name(_ADR, 0x00180003)

/* k10temp thermal zone */ #include "thermal_mixin.asl"

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

HAOUAS Elyes (Code Review)

30 Dec 30 Dec

8:38 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ARD ......................................................................

Patch Set 1:

Please review when you have time. Thx

HAOUAS Elyes (Code Review)

9:44 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38014

to look at the new patch set (#2).

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

nb/agesa/family14: Remove wrong _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/2

Michał Żygowski (Code Review)

31 Dec 31 Dec

11:42 a.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

Patch Set 2:

The _HID object lies under the included ThermalZone. Would it be sufficient to move the ThermalZone outside the PCI device? I assume this blocks migration to the new ACPICA?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 31 Dec 2019 10:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Frans Hendriks (Code Review)

1:42 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... PS2, Line 131: Why removing _ADR? (_HID is not defined and no other _ADR)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 31 Dec 2019 12:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Michał Żygowski (Code Review)

3:24 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... PS2, Line 131:

...

Why removing _ADR? (_HID is not defined and no other _ADR)

_HID is defined under ThermalZone included with thermal_mixin.asl

Secondly, do thermal zones even require _HID? The specification doesn't say it is required or optional.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 31 Dec 2019 14:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: comment

Nico Huber (Code Review)

5:17 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... PS2, Line 131:

...

_HID is defined under ThermalZone included with thermal_mixin.asl […]

`thermal_mixin.asl` uses `PCI_Config` so the address is definitely required to tie it to the correct config space.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 31 Dec 2019 16:17:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:35 p.m.

New subject: Change in coreboot[master]: [any taker?] nb/agesa/family14: Remove wrong _ADR

Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38014

to look at the new patch set (#3).

Change subject: [any taker?] nb/agesa/family14: Remove wrong _ADR ......................................................................

[any taker?] nb/agesa/family14: Remove wrong _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1 Jan 1 Jan

7:16 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Remove wrong _ADR

Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38014

to look at the new patch set (#4).

Change subject: nb/agesa/family14: Remove wrong _ADR ......................................................................

nb/agesa/family14: Remove wrong _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:22 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use -HID and _ADR

Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38014

to look at the new patch set (#5).

Change subject: nb/agesa/family14: Don't use -HID and _ADR ......................................................................

nb/agesa/family14: Don't use -HID and _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:23 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

Hello Kyösti Mälkki, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38014

to look at the new patch set (#6).

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

nb/agesa/family14: Don't use _HID and _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/38014/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

8:42 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Wed, 01 Jan 2020 19:42:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

2 Jan 2 Jan

7:44 a.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Thu, 02 Jan 2020 06:44:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:15 a.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/38014/2/src/northbridge/amd/agesa/f... PS2, Line 131:

...

`thermal_mixin.asl` uses `PCI_Config` so the address is definitely […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Thu, 02 Jan 2020 07:15:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7 Jan 7 Jan

4:52 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

Patch Set 6:

ping :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Comment-Date: Tue, 07 Jan 2020 15:52:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

5:20 p.m.

New subject: Change in coreboot[master]: nb/agesa/family14: Don't use _HID and _ADR

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38014 )

Change subject: nb/agesa/family14: Don't use _HID and _ADR ......................................................................

nb/agesa/family14: Don't use _HID and _ADR

A device object must contain either a _HID object or an _ADR object, but should not contain both.

Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38014 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl 1 file changed, 0 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Frans Hendriks: Looks good to me, approved

diff --git a/src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl b/src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl index fb33772..add58ff 100644 --- a/src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl +++ b/src/northbridge/amd/agesa/family14/acpi/thermal_mixin.asl @@ -56,7 +56,6 @@ }

ThermalZone (TZ00) { - Name (_HID, EisaId ("PNP0C11")) Name (_STR, Unicode ("AMD CPU Core Thermal Sensor"))

Method (_STA) {

-- To view, visit https://review.coreboot.org/c/coreboot/+/38014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I727116cbc38fcd264c684da6ce766ea5e854f58c Gerrit-Change-Number: 38014 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1582

days inactive

1590

days old

coreboot-gerrit@coreboot.org

15 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
HAOUAS Elyes (Code Review)
Michał Żygowski (Code Review)
Nico Huber (Code Review)