coreboot-gerrit January 2020

coreboot-gerrit@coreboot.org

1 participants
1869 discussions

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO config
by Shaunak Saha (Code Review) 14 Jan '20

14 Jan '20

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO config ...................................................................... Patch Set 17: > Patch Set 17: > > Do you have an updated EDS where the updates you mentioned are captured? > > Also, I don't see the rest of the CLs uploaded here? Are those still WIP? Not Yet. Eds team is in the process of releasing the new one.For the next patch which have the chnages in the asl and gpio_soc_defs its WIP and I have one question: in the gpio.h file the chnage should be like this right? #define CROS_GPIO_DEVICE0_NAME "INT34C5:00" #define CROS_GPIO_DEVICE1_NAME "INT34C5:01" #define CROS_GPIO_DEVICE4_NAME "INT34C5:02" #define CROS_GPIO_DEVICE5_NAME "INT34C5:03" And in the mainboard for the cros_gpio we have to use the same? -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 17 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jan 2020 17:46:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: autoport: recognize Xeon E3-1200 v2 series memory controllers as sand...
by Jonathan Kollasch (Code Review) 14 Jan '20

14 Jan '20

Jonathan Kollasch has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38345 ) Change subject: autoport: recognize Xeon E3-1200 v2 series memory controllers as sandybridge ...................................................................... autoport: recognize Xeon E3-1200 v2 series memory controllers as sandybridge Signed-off-by: Jonathan A. Kollasch <jakllsch(a)kollasch.net> Change-Id: Ic5f18669a04397f570d49c1ff056cd90b3eb04a1 --- M util/autoport/sandybridge.go 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/38345/1 diff --git a/util/autoport/sandybridge.go b/util/autoport/sandybridge.go index 718fbe8..acfda6b 100644 --- a/util/autoport/sandybridge.go +++ b/util/autoport/sandybridge.go @@ -126,6 +126,7 @@ RegisterPCI(0x8086, 0x0104, sandybridgemc{}) RegisterPCI(0x8086, 0x0150, sandybridgemc{}) RegisterPCI(0x8086, 0x0154, sandybridgemc{}) + RegisterPCI(0x8086, 0x0158, sandybridgemc{}) for _, id := range []uint16{ 0x0102, 0x0106, 0x010a, 0x0112, 0x0116, 0x0122, 0x0126, -- To view, visit https://review.coreboot.org/c/coreboot/+/38345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5f18669a04397f570d49c1ff056cd90b3eb04a1 Gerrit-Change-Number: 38345 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-MessageType: newchange

6 11

Change in coreboot[master]: soc/intel/tigerlake: Update GPIO config
by Furquan Shaikh (Code Review) 14 Jan '20

14 Jan '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 ) Change subject: soc/intel/tigerlake: Update GPIO config ...................................................................... Patch Set 17: Do you have an updated EDS where the updates you mentioned are captured? Also, I don't see the rest of the CLs uploaded here? Are those still WIP? -- To view, visit https://review.coreboot.org/c/coreboot/+/37427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa Gerrit-Change-Number: 37427 Gerrit-PatchSet: 17 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Francois Toguo Fotso <francois.toguo.fotso(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Venkata Krishna Nimmagadda Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jan 2020 16:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mainboard: Add Dell Inspiron 660s
by Paul Menzel (Code Review) 14 Jan '20

14 Jan '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22682 ) Change subject: mainboard: Add Dell Inspiron 660s ...................................................................... Patch Set 11: Jean, sorry for the hold-up. I’ll try to rebase, and could you tell us the status again? -- To view, visit https://review.coreboot.org/c/coreboot/+/22682 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8dabb1e1d14e60957e8c8800b0c30921d6bb5d8e Gerrit-Change-Number: 22682 Gerrit-PatchSet: 11 Gerrit-Owner: Jean Lucas <jean(a)4ray.co> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Jean Lucas <jean(a)4ray.co> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 14 Jan 2020 16:44:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/at24rf08c: Use `smbus_block_write()`
by Paul Menzel (Code Review) 14 Jan '20

14 Jan '20

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38395 ) Change subject: drivers/i2c/at24rf08c: Use `smbus_block_write()` ...................................................................... drivers/i2c/at24rf08c: Use `smbus_block_write()` Currently, on the Lenovo T60, it takes 22 ms to write the registers. Try to shorten that by usig the block write function. Change-Id: I6c536410263b23cba2fa66605d7b0ff6c5dd20c1 Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- M src/drivers/i2c/at24rf08c/at24rf08c.c 1 file changed, 3 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/38395/1 diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c index 624df7d..a11eaec 100644 --- a/src/drivers/i2c/at24rf08c/at24rf08c.c +++ b/src/drivers/i2c/at24rf08c/at24rf08c.c @@ -19,8 +19,7 @@ static void at24rf08c_init(struct device *dev) { - unsigned int i, j; - + uint8_t block[8] = { 0x0f, 0x0f, 0x0f, 0x0f, 0x0f, 0x0f, 0x0f, 0x0f }; if (!dev->enabled) return; @@ -31,15 +30,8 @@ printk(BIOS_DEBUG, "Locking EEPROM RFID\n"); - for (i = 0; i < 8; i++) { - /* After a register write AT24RF08C sometimes stops responding. - Retry several times in case of failure. */ - for (j = 0; j < 100; j++) - if (smbus_write_byte(dev, i, 0x0f) >= 0) { - printk(BIOS_DEBUG, "i= = %u, j = %u\n", j); - break; - } - } + if (smbus_block_write(dev, 0, 8, block) < 0) + printk(BIOS_ERR, "Failed writing at24rf08c configuration!\n"); printk(BIOS_DEBUG, "init EEPROM done\n"); } -- To view, visit https://review.coreboot.org/c/coreboot/+/38395 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c536410263b23cba2fa66605d7b0ff6c5dd20c1 Gerrit-Change-Number: 38395 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

1 1

Change in libhwbase[master]: [WIP] Printf like debugging
by Thomas Heijligen (Code Review) 14 Jan '20

14 Jan '20

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/libhwbase/+/37530 ) Change subject: [WIP] Printf like debugging ...................................................................... [WIP] Printf like debugging Change-Id: I4989761d1b127c67510e50d7ecc657e4b0f475e5 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M debug/Makefile.inc A debug/hw-print.adb A debug/hw-print.ads M gnat.adc 4 files changed, 282 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/30/37530/1 diff --git a/debug/Makefile.inc b/debug/Makefile.inc index b636a6f..7528e8c 100644 --- a/debug/Makefile.inc +++ b/debug/Makefile.inc @@ -1,4 +1,6 @@ hw-y += hw-debug.ads hw-y += hw-debug.adb +hw-y += hw-print.ads +hw-y += hw-print.adb hw-$(CONFIG_HWBASE_DEBUG_NULL) += null/hw-debug_sink.ads hw-$(CONFIG_HWBASE_DEBUG_TEXT_IO) += text_io/hw-debug_sink.ads diff --git a/debug/hw-print.adb b/debug/hw-print.adb new file mode 100644 index 0000000..ab9e623 --- /dev/null +++ b/debug/hw-print.adb @@ -0,0 +1,269 @@ +with HW; +with HW.Debug; +with Interfaces; +use HW; +use HW.Debug; +use Interfaces; + +package body HW.Print with + SPARK_Mode => On +is + + type Arg_Conversion is + (Arg_Invalid, + Arg_Int, + Arg_UInt, + Arg_Hex, + Arg_Char, + Arg_String + ); + + type Arg_Flags is + (Arg_Flag_Alternate_Form, + Arg_Flag_Padding, + Arg_Flag_Left_Adjusted, + Arg_Flag_Space, + Arg_Flag_Sign + ); + + type Arg_Flag_List is array (Arg_Flags) of Boolean; + + type Arg_Length is + (Arg_Length_Normal, + Arg_Length_Long, + Arg_Length_Long_Long + ); + + type Arg_T is record + Conversion : Arg_Conversion; + Flags : Arg_Flag_List; + Length : Arg_Length; + Padding : Natural; + Position : Integer; + end record; + +----------------------------------------------------------------------------------------------- + + procedure Parse_And_Put (Format_String : in String; Arg : out Arg_T; Pos : in out Integer) with + Pre => Format_String'First <= Format_String'Last and Pos >= Format_String'First and Format_String'Last < Integer'Last + is + + function Char_To_UInt (Item : in Character) return Natural with + Pre => Item in '0' .. '9' + is begin + return Character'Pos (Item) - Character'Pos ('0'); + end Char_To_UInt; + + type State_T is ( + State_Normal, + State_Arg_Flags, + State_Arg_Flag_Padding, + State_Arg_Modifier, + State_Arg_Modifier_Length, + State_Arg_Conversion + ); + + State : State_T := State_Normal; + + begin + + Arg := (Conversion => Arg_Invalid, Flags => (others => false), Length => Arg_Length_Normal, Padding => 0, Position => 0); + + while Pos <= Format_String'Last loop + pragma loop_invariant (Pos >= Format_String'First); + + case State is + when State_Normal => + case Format_String (Pos) is + when '%' => + State := State_Arg_Flags; + Arg.Position := Pos; + when others => + Put (Format_String (Pos .. Pos)); + end case; + + when State_Arg_Flags => + case Format_String (Pos) is + when '%' => + State := State_Normal; + Put ("%"); + when '#' => + Arg.Flags (Arg_Flag_Alternate_Form) := True; + when '0' => + Arg.Flags (Arg_Flag_Padding) := True; + when '-' => + Arg.Flags (Arg_Flag_Left_Adjusted) := True; + when ' ' => + Arg.Flags (Arg_Flag_Space) := True; + when '+' => + Arg.Flags (Arg_Flag_Sign) := True; + when others => + Pos := Pos - 1; + State := State_Arg_Flag_Padding; + end case; + + when State_Arg_Flag_Padding => + case Format_String (Pos) is + when '0' .. '9' => + Arg.Padding := Arg.Padding * 10 + Char_To_UInt (Format_String (Pos)); + when others => + Pos := Pos - 1; + State := State_Arg_Modifier; + end case; + + when State_Arg_Modifier => + case Format_String (Pos) is + when 'l' => + Arg.Length := Arg_Length_Long; + State := State_Arg_Modifier_Length; + when others => + Pos := Pos - 1; + State := State_Arg_Conversion; + end case; + + when State_Arg_Modifier_Length => + case Format_String (Pos) is + when 'l' => + Arg.Length := Arg_Length_Long_Long; + when others => + Pos := Pos - 1; + State := State_Arg_Modifier; + end case; + + when State_Arg_Conversion => + case Format_String (Pos) is + when 'd' => + Arg.Conversion := Arg_Int; + when 'i' => + Arg.Conversion := Arg_Int; + when 'x' => + Arg.Conversion := Arg_Hex; + when 'u' => + Arg.Conversion := Arg_UInt; + when 'c' => + Arg.Conversion := Arg_Char; + when 's' => + Arg.Conversion := Arg_String; + when others => + null; + end case; + Pos := Pos + 1; + exit; + end case; + Pos := Pos + 1; + end loop; + + end Parse_And_Put; + +---------------------------------------------------------------------------------------------- + + subtype Word64_String_Range is Positive range 1 .. 20; + subtype Word64_String is String (Word64_String_Range); + type Int_Format is (Base_10, Base_16); + + procedure Word64_To_String + (Output_String : out Word64_String; + String_Begin : out Word64_String_Range; + Item : in Word64; + Base : in Int_Format) + is + + function Get_Character (Item : Word64; Base : Word64) return Character with + Pre => Base > 0 and Base <= 16 + is + + subtype Hex_Range is Natural range 0 .. 15; + type Hex_Characters is array (Hex_Range) of Character; + Character_Set : constant Hex_Characters := ('0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'); + Tmp : Word64; + begin + Tmp := Item rem Base; + -- GNATprove can't prove mod + --pragma assert ( Tmp = Item mod Base); + if Tmp > 15 then + Tmp := 15; + end if; + return Character_Set (Natural (Tmp)); + end Get_Character; + + + Item_C : Word64; + Item_B : Word64; + begin + Item_C := Item; + Output_String:= " "; + String_Begin := Output_String'Last; + + case (Base) is + when Base_10 => + Item_B := 10; + when Base_16 => + Item_B := 16; + end case; + + loop + Output_String (String_Begin) := Get_Character (Item_C, Item_B); + Item_C := Item_C / Item_B; + pragma loop_invariant (Item_C < Item_B ** String_Begin); + exit when Item_C = 0; + String_Begin := String_Begin - 1; + end loop; + + end Word64_To_String; + +--------------------------------------------------------------------------------------------------------- + + procedure Put_Arg (Item : in Word64; Arg : in Arg_T; Pos : in out Integer) is + Base : Int_Format; + Output : Word64_String; + Output_Begin : Word64_String_Range; + begin + + case Arg.Conversion is + when Arg_UInt => + Base := Base_10; + + when Arg_Hex => + Base := Base_16; + + when others => + Pos := Arg.Position + 1; + Put("%"); + return; + end case; + + Word64_To_String (Output, Output_Begin, Item, Base); + Put (Output (Output_Begin .. Output'Last)); + + end Put_Arg; + + ----------------------------------------------------------------------------------------------- + ----------------------------------------------------------------------------------------------- + + procedure Printf (Format_String : in String) is + begin + Put (Format_String); + end Printf; + + ----------------------------------------------------------------------------------------------- + procedure Printf (Format_String : in String; Arg_1 : in Word64) is + Arg : Arg_T; + Pos : Integer; + begin + Pos := Format_String'First; + Parse_And_Put (Format_String, Arg, Pos); + Put_Arg (Arg_1, Arg, Pos); + + Put (format_String (Pos .. Format_String'Last)); + end Printf; + + ----------------------------------------------------------------------------------------------- + + -- procedure Printk (Level : in Debug_Level; Format_String : in String) is + -- begin + -- if Do_Print (Level) then + -- Printf (Format_String); + -- end if; + -- end Printk; + +end HW.Print; diff --git a/debug/hw-print.ads b/debug/hw-print.ads new file mode 100644 index 0000000..788ffd2 --- /dev/null +++ b/debug/hw-print.ads @@ -0,0 +1,10 @@ +package HW.Print is + + type Debug_Level is (Emerg, Alert, Crit, Err, Warning, Notice, Info, Debug, Spew); + + procedure Printf (Format_String : in String); + procedure Printf (Format_String : in String; Arg_1 : in Word64); + +-- procedure Printk (Level : in Debug_Level; Format_String : in String); + +end HW.Print; diff --git a/gnat.adc b/gnat.adc index 3494eba..2d49df2 100644 --- a/gnat.adc +++ b/gnat.adc @@ -1,6 +1,7 @@ pragma Restrictions (No_Allocators); pragma Restrictions (No_Calendar); pragma Restrictions (No_Dispatch); + pragma Restrictions (No_Fixed_Point); pragma Restrictions (No_Floating_Point); pragma Restrictions (No_Implicit_Dynamic_Code); -- To view, visit https://review.coreboot.org/c/libhwbase/+/37530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: master Gerrit-Change-Id: I4989761d1b127c67510e50d7ecc657e4b0f475e5 Gerrit-Change-Number: 37530 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: nb/intel/sandybridge/raminit: Add ECC detection support
by Felix Held (Code Review) 14 Jan '20

14 Jan '20

Felix Held has uploaded a new patch set (#5) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/22214 ) Change subject: nb/intel/sandybridge/raminit: Add ECC detection support ...................................................................... nb/intel/sandybridge/raminit: Add ECC detection support Add support for detection ECC capability and forced ECC mode. Print the ECC mode in verbose debugging mode. Change-Id: I5b7599746195cfa996a48320404a8dbe6820483a Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu> Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/northbridge/intel/sandybridge/raminit.c M src/northbridge/intel/sandybridge/raminit_common.c M src/northbridge/intel/sandybridge/raminit_common.h 3 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/22214/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/22214 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b7599746195cfa996a48320404a8dbe6820483a Gerrit-Change-Number: 22214 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/sandybridge: Drop 'or zero' instances
by Angel Pons (Code Review) 14 Jan '20

14 Jan '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38339 ) Change subject: nb/intel/sandybridge: Drop 'or zero' instances ...................................................................... nb/intel/sandybridge: Drop 'or zero' instances Change-Id: Icd0dfdf311ac141992ec6a6026ca92e54e8d2094 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 6 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/38339/1 diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index fc4e6f9..795775c 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1771,8 +1771,7 @@ /* DRAM command RD */ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 1)) = 0x1f105; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 1)) = 0x4041003; - MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = - (slotrank << 24) | 0; + MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = slotrank << 24; MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 1)) = 0; /* DRAM command RD */ @@ -1821,8 +1820,7 @@ /* DRAM command RD */ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 1)) = 0x1f105; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 1)) = 0x4041003; - MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = - (slotrank << 24) | 0; + MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = slotrank << 24; MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 1)) = 0; /* DRAM command RD */ @@ -2562,8 +2560,7 @@ /* DRAM command RD */ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 1)) = 0x1f105; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 1)) = 0x4041003; - MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = - (slotrank << 24) | 0; + MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = slotrank << 24; MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 1)) = 0; /* DRAM command RD */ @@ -2617,7 +2614,7 @@ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 1)) = 0x1f105; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 1)) = 0x4041003; MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = - (slotrank << 24) | 0; + (slotrank << 24); MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 1)) = 0; /* DRAM command RD */ @@ -3069,13 +3066,13 @@ /* DRAM command WR */ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 1)) = 0x0001f201; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 1)) = 0x08281064; - MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = 0x00000000 | (slotrank << 24); + MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 1)) = slotrank << 24; MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 1)) = 0x00000242; /* DRAM command RD */ MCHBAR32(IOSAV_n_SP_CMD_CTL_ch(channel, 2)) = 0x0001f105; MCHBAR32(IOSAV_n_SUBSEQ_CTL_ch(channel, 2)) = 0x04281064; - MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 2)) = 0x00000000 | (slotrank << 24); + MCHBAR32(IOSAV_n_SP_CMD_ADDR_ch(channel, 2)) = slotrank << 24; MCHBAR32(IOSAV_n_ADDR_UPD_ch(channel, 2)) = 0x00000242; /* DRAM command PRE */ -- To view, visit https://review.coreboot.org/c/coreboot/+/38339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd0dfdf311ac141992ec6a6026ca92e54e8d2094 Gerrit-Change-Number: 38339 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

5 6

Change in coreboot[master]: mb/intel/tglrvp: Add initial mainboard code
by Aamir Bohra (Code Review) 14 Jan '20

14 Jan '20

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37868 ) Change subject: mb/intel/tglrvp: Add initial mainboard code ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86ada611de1cf28a1b872eea35cf41c0dc1c57f1 Gerrit-Change-Number: 37868 Gerrit-PatchSet: 18 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jan 2020 11:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/tglrvp: Add initial mainboard code
by Subrata Banik (Code Review) 14 Jan '20

14 Jan '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37868 ) Change subject: mb/intel/tglrvp: Add initial mainboard code ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I86ada611de1cf28a1b872eea35cf41c0dc1c57f1 Gerrit-Change-Number: 37868 Gerrit-PatchSet: 18 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jan 2020 11:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2020