Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37427 )
Change subject: soc/intel/tigerlake: Update GPIO config
......................................................................
Patch Set 17:
Patch Set 17:
Do you have an updated EDS where the updates you mentioned are captured?
Also, I don't see the rest of the CLs uploaded here? Are those still WIP?
Not Yet. Eds team is in the process of releasing the new one.For the next patch which have the chnages in the asl and gpio_soc_defs its WIP and I have one question:
in the gpio.h file the chnage should be like this right?
#define CROS_GPIO_DEVICE0_NAME "INT34C5:00"
#define CROS_GPIO_DEVICE1_NAME "INT34C5:01"
#define CROS_GPIO_DEVICE4_NAME "INT34C5:02"
#define CROS_GPIO_DEVICE5_NAME "INT34C5:03"
And in the mainboard for the cros_gpio we have to use the same?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I585100375feee39b5a9105bdf6d9f5ca3a5bb2fa
Gerrit-Change-Number: 37427
Gerrit-PatchSet: 17
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 17:46:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment