HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38164 )
Change subject: util/crossgcc: Add comment on IASL version ......................................................................
util/crossgcc: Add comment on IASL version
Change-Id: I81c6f4134610bcd35e173cdb002ef821788b0538 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/38164/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6150011..b3b92d4 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,6 +54,10 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 + +# Conflicting use of _ADR and _HID in coreboot tree needs +# to be properly addressed before we can upgrade IASL version. +# Use IASL version 20190703 for now. IASL_VERSION=20190703 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38164 )
Change subject: util/crossgcc: Add comment on IASL version ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38164 )
Change subject: util/crossgcc: Add comment on IASL version ......................................................................
util/crossgcc: Add comment on IASL version
Change-Id: I81c6f4134610bcd35e173cdb002ef821788b0538 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38164 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 6150011..b3b92d4 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,6 +54,10 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.33.1 GDB_VERSION=8.3.1 + +# Conflicting use of _ADR and _HID in coreboot tree needs +# to be properly addressed before we can upgrade IASL version. +# Use IASL version 20190703 for now. IASL_VERSION=20190703 PYTHON_VERSION=3.8.1 EXPAT_VERSION=2.2.9
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)