coreboot-gerrit July 2019

coreboot-gerrit@coreboot.org

1 participants
1550 discussions

Change in ...coreboot[master]: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics T...
by David Wu (Code Review) 07 Jul '19

07 Jul '19

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33660 Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ...................................................................... mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad Update ELAN GPIO and IRQ setting and add Synaptics Touchpad BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine. Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/kindred/gpio.c M src/mainboard/google/hatch/variants/kindred/overridetree.cb 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33660/1 diff --git a/src/mainboard/google/hatch/variants/kindred/gpio.c b/src/mainboard/google/hatch/variants/kindred/gpio.c index f6aeb69..ec72f0e 100644 --- a/src/mainboard/google/hatch/variants/kindred/gpio.c +++ b/src/mainboard/google/hatch/variants/kindred/gpio.c @@ -19,6 +19,10 @@ #include <commonlib/helpers.h> static const struct pad_config gpio_table[] = { + /* A21 : TRACKPAD_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE), + /* D21 : GPP_D21 ==> NC */ + PAD_NC(GPP_D21, NONE), /* F3 : MEM_STRAP_3 */ PAD_CFG_GPI(GPP_F3, NONE, PLTRST), /* F10 : MEM_STRAP_2 */ diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index cc068bb..9edb167 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -55,10 +55,19 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" register "wake" = "GPE0_DW0_21" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" + register "generic.wake" = "GPE0_DW2_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/c/coreboot/+/33660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Gerrit-Change-Number: 33660 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

6 17

Change in ...coreboot[master]: mb/google/hatch/variants/kindred: Enable eMMC support
by David Wu (Code Review) 07 Jul '19

07 Jul '19

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33618 Change subject: mb/google/hatch/variants/kindred: Enable eMMC support ...................................................................... mb/google/hatch/variants/kindred: Enable eMMC support Enable eMMC support for kindred. Cq-Depend: chromium:1666982 BUG=b:135464155 BRANCH=none TEST=Boot kindred onboard eMMC. Change-Id: I040af6da30313f8dd59e3ef910b290922e090cdc Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/hatch/variants/kindred/gpio.c M src/mainboard/google/hatch/variants/kindred/overridetree.cb 2 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33618/1 diff --git a/src/mainboard/google/hatch/variants/kindred/gpio.c b/src/mainboard/google/hatch/variants/kindred/gpio.c index 43948a3..f6aeb69 100644 --- a/src/mainboard/google/hatch/variants/kindred/gpio.c +++ b/src/mainboard/google/hatch/variants/kindred/gpio.c @@ -23,6 +23,30 @@ PAD_CFG_GPI(GPP_F3, NONE, PLTRST), /* F10 : MEM_STRAP_2 */ PAD_CFG_GPI(GPP_F10, NONE, PLTRST), + /* F11 : EMMC_CMD ==> EMMC_CMD */ + PAD_CFG_NF(GPP_F11, NONE, DEEP, NF1), + /* F12 : EMMC_DATA0 ==> EMMC_DAT0 */ + PAD_CFG_NF(GPP_F12, NONE, DEEP, NF1), + /* F13 : EMMC_DATA1 ==> EMMC_DAT1 */ + PAD_CFG_NF(GPP_F13, NONE, DEEP, NF1), + /* F14 : EMMC_DATA2 ==> EMMC_DAT2 */ + PAD_CFG_NF(GPP_F14, NONE, DEEP, NF1), + /* F15 : EMMC_DATA3 ==> EMMC_DAT3 */ + PAD_CFG_NF(GPP_F15, NONE, DEEP, NF1), + /* F16 : EMMC_DATA4 ==> EMMC_DAT4 */ + PAD_CFG_NF(GPP_F16, NONE, DEEP, NF1), + /* F17 : EMMC_DATA5 ==> EMMC_DAT5 */ + PAD_CFG_NF(GPP_F17, NONE, DEEP, NF1), + /* F18 : EMMC_DATA6 ==> EMMC_DAT6 */ + PAD_CFG_NF(GPP_F18, NONE, DEEP, NF1), + /* F19 : EMMC_DATA7 ==> EMMC_DAT7 */ + PAD_CFG_NF(GPP_F19, NONE, DEEP, NF1), + /* F20 : EMMC_RCLK ==> EMMC_RCLK */ + PAD_CFG_NF(GPP_F20, NONE, DEEP, NF1), + /* F21 : EMMC_CLK ==> EMMC_CLK */ + PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + /* F22 : EMMC_RESET# ==> EMMC_RST_L */ + PAD_CFG_NF(GPP_F22, NONE, DEEP, NF1), /* H19 : MEM_STRAP_0 */ PAD_CFG_GPI(GPP_H19, NONE, PLTRST), /* H22 : MEM_STRAP_1 */ diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 562bb8b..cc068bb 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -47,6 +47,9 @@ # GPIO for SD card detect register "sdcard_cd_gpio" = "vSD3_CD_B" + # Enable eMMC HS400 + register "ScsEmmcHs400Enabled" = "1" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic @@ -143,6 +146,7 @@ device i2c 1a on end end end #I2C #4 + device pci 1a.0 on end # eMMC device pci 1e.3 on chip drivers/spi/acpi register "name" = ""CRFP"" -- To view, visit https://review.coreboot.org/c/coreboot/+/33618 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I040af6da30313f8dd59e3ef910b290922e090cdc Gerrit-Change-Number: 33618 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

5 6

Change in coreboot[master]: mainboard/portwell/m107: Do initial mainboard commit
by Patrick Rudolph (Code Review) 07 Jul '19

07 Jul '19

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 ) Change subject: mainboard/portwell/m107: Do initial mainboard commit ...................................................................... Patch Set 16: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/29470/16/src/mainboard/portwell/m1… File src/mainboard/portwell/m107/fadt.c: https://review.coreboot.org/c/coreboot/+/29470/16/src/mainboard/portwell/m1… PS16, Line 21: void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) use CONFIG_COMMON_FADT instead ? -- To view, visit https://review.coreboot.org/c/coreboot/+/29470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62 Gerrit-Change-Number: 29470 Gerrit-PatchSet: 16 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 07 Jul 2019 16:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: arch/x86/acpi: Add os.asl
by Richard Spiegel (Code Review) 07 Jul '19

07 Jul '19

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33652 Change subject: arch/x86/acpi: Add os.asl ...................................................................... arch/x86/acpi: Add os.asl As time goes by, newer OS come into the market, requiring modification on ACPI code to identify the new OS. With this new file, a single file will need maintenance in the future, and it will fix the code for every board including this file. It assumes OSVR is already declared elsewhere within the ACPI code. BUG=b:none. TEST=Tested later with padmelon board. Change-Id: I87200cafdafcf078db16c95463a86c3e9105cea6 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- A src/arch/x86/acpi/os.asl 1 file changed, 135 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/33652/1 diff --git a/src/arch/x86/acpi/os.asl b/src/arch/x86/acpi/os.asl new file mode 100644 index 0000000..17fe29e --- /dev/null +++ b/src/arch/x86/acpi/os.asl @@ -0,0 +1,135 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2019 Silverback, Ltd + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/* Assumes OSVR is declared elsewhere */ +Method(OSFL, 0, NotSerialized) +{ + If(LNotEqual(OSVR, Ones)) + { + Return(OSVR) + } + Store(0x03, OSVR) + If(CondRefOf(\_OSI, Local0)) + { + If(_OSI("Windows 2001")) + { + Store(0x04, OSVR) + } + If(_OSI("Windows 2001.1")) + { + Store(0x05, OSVR) + } + If(_OSI("FreeBSD")) + { + Store(0x06, OSVR) + } + If(_OSI("HP-UX")) + { + Store(0x07, OSVR) + } + If(_OSI("OpenVMS")) + { + Store(0x08, OSVR) + } + If(_OSI("Windows 2001 SP1")) + { + Store(0x09, OSVR) + } + If(_OSI("Windows 2001 SP2")) + { + Store(0x0A, OSVR) + } + If(_OSI("Windows 2001 SP3")) + { + Store(0x0B, OSVR) + } + If(_OSI("Windows 2006")) + { + Store(0x0C, OSVR) + } + If(_OSI("Windows 2006 SP1")) + { + Store(0x0D, OSVR) + } + If(_OSI("Windows 2009")) + { + Store(0x0E, OSVR) + } + If(_OSI("Windows 2012")) + { + Store(0x0F, OSVR) + } + If(_OSI("Windows 2013")) + { + Store(0x10, OSVR) + } + } + Else + { + Store (\_OS, local0) + If(SCPM(local0, "Microsoft Windows NT")) + { + Store(Zero, OSVR) + } + If(SCPM(local0, "Microsoft Windows")) + { + Store(One, OSVR) + } + If(SCPM(local0, "Microsoft WindowsME: Millennium Edition")) + { + Store(0x02, OSVR) + } + If(SCPM(local0, "Linux")) + { + Store(0x03, OSVR) + } + If(SCPM(local0, "FreeBSD")) + { + Store(0x06, OSVR) + } + If(SCPM(local0, "HP-UX")) + { + Store(0x07, OSVR) + } + If(SCPM(local0, "OpenVMS")) + { + Store(0x08, OSVR) + } + } + Return(OSVR) +} + +/* String compare */ +Method(SCPM, 2, Serialized) +{ + If(LLess(SizeOf(Arg0), SizeOf(Arg1))) + { + Return(Zero) + } + Add(SizeOf(Arg0), One, Local0) + Name(BUF0, Buffer(Local0){}) + Name(BUF1, Buffer(Local0){}) + Store(Arg0, BUF0) + Store(Arg1, BUF1) + While(Local0) + { + Decrement(Local0) + If(LNotEqual(DerefOf(Index(BUF0, Local0)), DerefOf(Index(BUF1, Local0)))) + { + Return(Zero) + } + } + Return(One) +} -- To view, visit https://review.coreboot.org/c/coreboot/+/33652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87200cafdafcf078db16c95463a86c3e9105cea6 Gerrit-Change-Number: 33652 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-MessageType: newchange

4 11

Change in coreboot[master]: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc
by Subrata Banik (Code Review) 07 Jul '19

07 Jul '19

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34088 ) Change subject: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc ...................................................................... soc/intel/icelake: Remove redundant gpio.c from Makefile.inc Change-Id: Ibddc2363e9bfea9ae41e4807435acb2e788dcb93 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/icelake/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/34088/1 diff --git a/src/soc/intel/icelake/Makefile.inc b/src/soc/intel/icelake/Makefile.inc index 0d4e32d..cd02934 100644 --- a/src/soc/intel/icelake/Makefile.inc +++ b/src/soc/intel/icelake/Makefile.inc @@ -42,7 +42,6 @@ ramstage-y += gpio.c ramstage-y += graphics.c ramstage-y += gspi.c -ramstage-y += gpio.c ramstage-y += i2c.c ramstage-y += lockdown.c ramstage-y += memmap.c -- To view, visit https://review.coreboot.org/c/coreboot/+/34088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibddc2363e9bfea9ae41e4807435acb2e788dcb93 Gerrit-Change-Number: 34088 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: cpu/x86: Fix MSR_PLATFORM_INFO definition
by Kyösti Mälkki (Code Review) 07 Jul '19

07 Jul '19

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34090 ) Change subject: cpu/x86: Fix MSR_PLATFORM_INFO definition ...................................................................... cpu/x86: Fix MSR_PLATFORM_INFO definition While common to many Intel CPUs, this is not an architectural MSR that should be globally defined for all x86. Change-Id: Ibeed022dc2ba2e90f71511f9bd2640a7cafa5292 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/include/cpu/x86/tsc.h M src/northbridge/intel/fsp_rangeley/udelay.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/34090/1 diff --git a/src/include/cpu/x86/tsc.h b/src/include/cpu/x86/tsc.h index 8dd9b75..dd333e8 100644 --- a/src/include/cpu/x86/tsc.h +++ b/src/include/cpu/x86/tsc.h @@ -11,8 +11,6 @@ #define TSC_SYNC #endif -#define MSR_PLATFORM_INFO 0xce - struct tsc_struct { unsigned int lo; unsigned int hi; diff --git a/src/northbridge/intel/fsp_rangeley/udelay.c b/src/northbridge/intel/fsp_rangeley/udelay.c index 01989ab..08301a3 100644 --- a/src/northbridge/intel/fsp_rangeley/udelay.c +++ b/src/northbridge/intel/fsp_rangeley/udelay.c @@ -18,6 +18,8 @@ #include <cpu/x86/tsc.h> #include <cpu/x86/msr.h> +#define MSR_PLATFORM_INFO 0xce + /** * Intel Rangeley CPUs always run the TSC at BCLK = 100MHz */ -- To view, visit https://review.coreboot.org/c/coreboot/+/34090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibeed022dc2ba2e90f71511f9bd2640a7cafa5292 Gerrit-Change-Number: 34090 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default
by Angel Pons (Code Review) 07 Jul '19

07 Jul '19

1 0

Change in coreboot[master]: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default
by Nico Huber (Code Review) 07 Jul '19

07 Jul '19

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34112 ) Change subject: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/34112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dfa9b92dc63375465e3bb87b73eeefad601c810 Gerrit-Change-Number: 34112 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 07 Jul 2019 11:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default
by Kyösti Mälkki (Code Review) 07 Jul '19

07 Jul '19

Hello ron minnich, Julius Werner, Jonathan Neuschäfer, build bot (Jenkins), Philipp Hug, Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/34112 to look at the new patch set (#4). Change subject: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default ...................................................................... arch/non-x86: Flip HAVE_MONOTONIC_TIMER default Change-Id: I9dfa9b92dc63375465e3bb87b73eeefad601c810 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/Kconfig M src/cpu/qemu-power8/Kconfig M src/cpu/ti/am335x/Kconfig M src/mainboard/emulation/qemu-armv7/Kconfig M src/soc/cavium/cn81xx/Kconfig M src/soc/imgtec/pistachio/Kconfig M src/soc/mediatek/mt8173/Kconfig M src/soc/mediatek/mt8183/Kconfig M src/soc/nvidia/tegra124/Kconfig M src/soc/nvidia/tegra210/Kconfig M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig M src/soc/qualcomm/qcs405/Kconfig M src/soc/qualcomm/sdm845/Kconfig M src/soc/rockchip/rk3288/Kconfig M src/soc/rockchip/rk3399/Kconfig M src/soc/samsung/exynos5250/Kconfig M src/soc/samsung/exynos5420/Kconfig M src/soc/sifive/fu540/Kconfig M src/soc/ucb/riscv/Kconfig 20 files changed, 14 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/34112/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/34112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dfa9b92dc63375465e3bb87b73eeefad601c810 Gerrit-Change-Number: 34112 Gerrit-PatchSet: 4 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default
by Angel Pons (Code Review) 07 Jul '19

07 Jul '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34112 ) Change subject: arch/non-x86: Flip HAVE_MONOTONIC_TIMER default ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig File src/Kconfig: https://review.coreboot.org/c/coreboot/+/34112/3/src/Kconfig@509 PS3, Line 509: default > Hmm... no? I don't know what you would want this to look like. Indeed, I was thinking of "depends on !NO_MONOTONIC_TIMER". Currently, one could select both or none, but I don't know if that is a big deal for symbols without a prompt anyway. https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kcon… File src/cpu/allwinner/a10/Kconfig: https://review.coreboot.org/c/coreboot/+/34112/3/src/cpu/allwinner/a10/Kcon… PS3, Line 13: select NO_MONOTONIC_TIMER > Did you see the "implementation" file removed here. Just realized, apologies. I was only considering what was listed in the commit msg. -- To view, visit https://review.coreboot.org/c/coreboot/+/34112 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9dfa9b92dc63375465e3bb87b73eeefad601c810 Gerrit-Change-Number: 34112 Gerrit-PatchSet: 3 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 07 Jul 2019 11:19:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2019