Change in coreboot[master]: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34088 )
Change subject: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc ......................................................................
soc/intel/icelake: Remove redundant gpio.c from Makefile.inc
Change-Id: Ibddc2363e9bfea9ae41e4807435acb2e788dcb93 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/icelake/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/34088/1
diff --git a/src/soc/intel/icelake/Makefile.inc b/src/soc/intel/icelake/Makefile.inc index 0d4e32d..cd02934 100644 --- a/src/soc/intel/icelake/Makefile.inc +++ b/src/soc/intel/icelake/Makefile.inc @@ -42,7 +42,6 @@ ramstage-y += gpio.c ramstage-y += graphics.c ramstage-y += gspi.c -ramstage-y += gpio.c ramstage-y += i2c.c ramstage-y += lockdown.c ramstage-y += memmap.c
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34088 )
Change subject: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34088 )
Change subject: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc ......................................................................
Patch Set 1: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34088 )
Change subject: soc/intel/icelake: Remove redundant gpio.c from Makefile.inc ......................................................................
soc/intel/icelake: Remove redundant gpio.c from Makefile.inc
Change-Id: Ibddc2363e9bfea9ae41e4807435acb2e788dcb93 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34088 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/icelake/Makefile.inc 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/icelake/Makefile.inc b/src/soc/intel/icelake/Makefile.inc index 0d4e32d..cd02934 100644 --- a/src/soc/intel/icelake/Makefile.inc +++ b/src/soc/intel/icelake/Makefile.inc @@ -42,7 +42,6 @@ ramstage-y += gpio.c ramstage-y += graphics.c ramstage-y += gspi.c -ramstage-y += gpio.c ramstage-y += i2c.c ramstage-y += lockdown.c ramstage-y += memmap.c
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Subrata Banik (Code Review)