David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33660
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine.
Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/gpio.c M src/mainboard/google/hatch/variants/kindred/overridetree.cb 2 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33660/1
diff --git a/src/mainboard/google/hatch/variants/kindred/gpio.c b/src/mainboard/google/hatch/variants/kindred/gpio.c index f6aeb69..ec72f0e 100644 --- a/src/mainboard/google/hatch/variants/kindred/gpio.c +++ b/src/mainboard/google/hatch/variants/kindred/gpio.c @@ -19,6 +19,10 @@ #include <commonlib/helpers.h>
static const struct pad_config gpio_table[] = { + /* A21 : TRACKPAD_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE), + /* D21 : GPP_D21 ==> NC */ + PAD_NC(GPP_D21, NONE), /* F3 : MEM_STRAP_3 */ PAD_CFG_GPI(GPP_F3, NONE, PLTRST), /* F10 : MEM_STRAP_2 */ diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index cc068bb..9edb167 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -55,10 +55,19 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" register "wake" = "GPE0_DW0_21" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" + register "generic.wake" = "GPE0_DW2_27" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33660/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/#/c/33660/1/src/mainboard/google/hatch/variants/... PS1, Line 66: GPE0_DW2_27 This is not correct. It will have to be GPE0_DW0_21 since GPP_D21 is NC.
Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33660
to look at the new patch set (#2).
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine.
Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/gpio.c M src/mainboard/google/hatch/variants/kindred/overridetree.cb 2 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33660/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 2:
(1 comment)
Thanks a lot.
https://review.coreboot.org/#/c/33660/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/#/c/33660/1/src/mainboard/google/hatch/variants/... PS1, Line 66: GPE0_DW2_27
This is not correct. It will have to be GPE0_DW0_21 since GPP_D21 is NC.
Done
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/... PS2, Line 22: /* A21 : TRACKPAD_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE), : /* D21 : GPP_D21 ==> NC */ : PAD_NC(GPP_D21, NONE), This will soon be done in baseboard/gpio.c: https://review.coreboot.org/c/coreboot/+/33820
Can you remove this and then test with the patch 33820?
Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33660
to look at the new patch set (#3).
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine.
Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33660/3
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(1 comment)
Thanks.
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kindred/gpio.c:
https://review.coreboot.org/#/c/33660/2/src/mainboard/google/hatch/variants/... PS2, Line 22: /* A21 : TRACKPAD_INT_ODL */ : PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, NONE), : /* D21 : GPP_D21 ==> NC */ : PAD_NC(GPP_D21, NONE),
This will soon be done in baseboard/gpio.c: […]
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@9 PS3, Line 9: Update ELAN GPIO and IRQ setting and add Synaptics Touchpad What changed, that the update is needed? New schematics?
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@13 PS3, Line 13: TEST=Verify ELAN/Synaptics touchpad is working fine. Before it didn’t work?
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@9 PS3, Line 9: Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
What changed, that the update is needed? New schematics?
Yes, new schematics and changed trackpad irq and wake to GPP_A21. please refer to https://review.coreboot.org/c/coreboot/+/33820
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@13 PS3, Line 13: TEST=Verify ELAN/Synaptics touchpad is working fine.
Before it didn’t work?
Sorry. I don't have any motherboard before.
Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@13 PS3, Line 13: TEST=Verify ELAN/Synaptics touchpad is working fine.
Sorry. I don't have any motherboard before.
I think Paul means "is touchpad not working without this patch"?
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33660/3//COMMIT_MSG@13 PS3, Line 13: TEST=Verify ELAN/Synaptics touchpad is working fine.
I think Paul means "is touchpad not working without this patch"?
Yes, touchpad can not work without this patch. Thanks.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33660/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33660/3/src/mainboard/google/hatch/... PS3, Line 59: register "wake" = "GPE0_DW0_21" You will need the probed property here as well.
Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33660
to look at the new patch set (#4).
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine.
Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/33660/4
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 4:
(1 comment)
Thanks
https://review.coreboot.org/c/coreboot/+/33660/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/33660/3/src/mainboard/google/hatch/... PS3, Line 59: register "wake" = "GPE0_DW0_21"
You will need the probed property here as well.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
Patch Set 4: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33660 )
Change subject: mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad ......................................................................
mb/google/hatch/var/kindred: Update ELAN GPIO/IRQ and add Synaptics Touchpad
Update ELAN GPIO and IRQ setting and add Synaptics Touchpad
BUG=b:132708463 BRANCH=None TEST=Verify ELAN/Synaptics touchpad is working fine.
Change-Id: I883ce2e50ca5c6bd2b1ca76cbe24177055cc5d60 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33660 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 11 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index cc068bb..5c812cb 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -55,10 +55,20 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" register "wake" = "GPE0_DW0_21" + register "probed" = "1" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" + register "generic.wake" = "GPE0_DW0_21" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic