Change in ...coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

David Wu (Code Review)

28 Jun 2019 28 Jun '19

1:48 a.m.

David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33857

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add Raydium touchscreen support

- Add Raydium controller - GPIO_COMM_0/1/2/3: Disable gpio community all PM configuration

BUG=b:135728282 BRANCH=master TEST= 1. FW_NAME="kindred" emerge-hatch coreboot chromeos-bootimage 2. boot up on kindred DUT to check touchscreen device by evtest /dev/input/event3: Raydium Touchscreen 3. Raydium TS is working

Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/33857/1

diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index cc068bb..0ddcf43 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -50,6 +50,12 @@ # Enable eMMC HS400 register "ScsEmmcHs400Enabled" = "1"

+ # GPIO community PM configuration + register "gpio_pm[COMM_0]" = "0" + register "gpio_pm[COMM_1]" = "0" + register "gpio_pm[COMM_2]" = "0" + register "gpio_pm[COMM_3]" = "0" + device domain 0 on device pci 15.0 on chip drivers/i2c/generic @@ -74,6 +80,17 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/generic + register "hid" = ""RAYD0001"" + register "desc" = ""Raydium Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "1" + register "reset_off_delay_ms" = "2" + register "has_power_resource" = "1" + device i2c 39 on end + end chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen""

Attachments:

attachment.htm (text/html — 4.8 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

28 Jun 28 Jun

2:56 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 28 Jun 2019 14:56:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

3:09 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 28 Jun 2019 15:09:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4 Jul 4 Jul

12:09 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33857/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/33857/2/src/mainboard/google/hatch/... PS2, Line 53: # GPIO community PM configuration : register "gpio_pm[COMM_0]" = "0" : register "gpio_pm[COMM_1]" = "0" : register "gpio_pm[COMM_2]" = "0" : register "gpio_pm[COMM_3]" = "0" This should be a separate change of its own. Also, we are trying to evaluate the impact of disabling PM configuration for all communities. Let's not add this in here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 00:09:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Wu (Code Review)

6:28 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33857

to look at the new patch set (#3).

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add Raydium touchscreen support

- Add Raydium controller - GPIO_COMM_0/1/2/3: Disable gpio community all PM configuration

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/33857/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

David Wu (Code Review)

6:29 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

Patch Set 3:

(1 comment)

Thanks

https://review.coreboot.org/c/coreboot/+/33857/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

...

This should be a separate change of its own. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 06:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

David Wu (Code Review)

7:03 a.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

Hello Paul Fagerburg, Paul Fagerburg, Tim Wawrzynczak, Philip Chen, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33857

to look at the new patch set (#4).

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add Raydium touchscreen support

Add Raydium controller

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/33857/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

4:21 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 4 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 16:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

7 Jul 7 Jul

8:02 p.m.

New subject: Change in coreboot[master]: mb/google/hatch/var/kindred: Add Raydium touchscreen support

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33857 )

Change subject: mb/google/hatch/var/kindred: Add Raydium touchscreen support ......................................................................

mb/google/hatch/var/kindred: Add Raydium touchscreen support

Add Raydium controller

Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33857 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 11 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index 5c812cb..8993706 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -84,6 +84,17 @@ register "stop_off_delay_ms" = "5" device i2c 49 on end end + chip drivers/i2c/generic + register "hid" = ""RAYD0001"" + register "desc" = ""Raydium Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "reset_delay_ms" = "1" + register "reset_off_delay_ms" = "2" + register "has_power_resource" = "1" + device i2c 39 on end + end chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen""

-- To view, visit https://review.coreboot.org/c/coreboot/+/33857 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id963300ab0dadcb78786c5a1328c2a4098a48a05 Gerrit-Change-Number: 33857 Gerrit-PatchSet: 5 Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1777

days inactive

1786

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

David Wu (Code Review)
Furquan Shaikh (Code Review)
Martin Roth (Code Review)
Paul Fagerburg (Code Review)
Tim Wawrzynczak (Code Review)