coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: superio/{aspeed,nuvoton}: Fix typo
by HAOUAS Elyes (Code Review) 05 Dec '19

05 Dec '19

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37502 ) Change subject: superio/{aspeed,nuvoton}: Fix typo ...................................................................... superio/{aspeed,nuvoton}: Fix typo Change-Id: I7772fadc756ceeef5988e4b1ecf8f93ad3605a84 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/superio/aspeed/ast2400/superio.c M src/superio/nuvoton/nct6791d/superio.c 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/37502/1 diff --git a/src/superio/aspeed/ast2400/superio.c b/src/superio/aspeed/ast2400/superio.c index c5df8b5..a41bba7 100644 --- a/src/superio/aspeed/ast2400/superio.c +++ b/src/superio/aspeed/ast2400/superio.c @@ -48,9 +48,9 @@ return NULL; switch (dev->path.pnp.device & 0xff) { - case AST2400_SUART1: /* falltrough */ - case AST2400_SUART2: /* falltrough */ - case AST2400_SUART3: /* falltrough */ + case AST2400_SUART1: /* fallthrough */ + case AST2400_SUART2: /* fallthrough */ + case AST2400_SUART3: /* fallthrough */ case AST2400_SUART4: return ACPI_HID_COM; case AST2400_KBC: diff --git a/src/superio/nuvoton/nct6791d/superio.c b/src/superio/nuvoton/nct6791d/superio.c index 08f0bfa..ed8f5c3 100644 --- a/src/superio/nuvoton/nct6791d/superio.c +++ b/src/superio/nuvoton/nct6791d/superio.c @@ -48,7 +48,7 @@ return NULL; switch (dev->path.pnp.device & 0xff) { - case NCT6791D_SP1: /* falltrough */ + case NCT6791D_SP1: /* fallthrough */ case NCT6791D_SP2: return ACPI_HID_COM; case NCT6791D_KBC: -- To view, visit https://review.coreboot.org/c/coreboot/+/37502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7772fadc756ceeef5988e4b1ecf8f93ad3605a84 Gerrit-Change-Number: 37502 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

3 3

Change in coreboot[master]: mb/asrock/h110m: fix bug with onboard LAN
by Maxim Polyakov (Code Review) 05 Dec '19

05 Dec '19

Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36377 ) Change subject: mb/asrock/h110m: fix bug with onboard LAN ...................................................................... mb/asrock/h110m: fix bug with onboard LAN Change-Id: I5cbce6177c89052eb50959f43903b6f8a607e77f Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36377/1 diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 4323028..8f64d02 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -219,10 +219,6 @@ # Enable Root port 6(x1) for LAN. register "PcieRpEnable[5]" = "1" - # Enable CLKREQ# - register "PcieRpClkReqSupport[5]" = "1" - # Use SRCCLKREQ1# - register "PcieRpClkReqNumber[5]" = "1" # Enable Advanced Error Reporting register "PcieRpAdvancedErrorReporting[5]" = "1" # Enable Latency Tolerance Reporting Mechanism -- To view, visit https://review.coreboot.org/c/coreboot/+/36377 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cbce6177c89052eb50959f43903b6f8a607e77f Gerrit-Change-Number: 36377 Gerrit-PatchSet: 1 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-MessageType: newchange

5 10

Change in coreboot[4.11_branch]: mainboard/facebook/watson: Reclaim unused flash space
by Frans Hendriks (Code Review) 05 Dec '19

05 Dec '19

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37474 ) Change subject: mainboard/facebook/watson: Reclaim unused flash space ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/37474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I5f407c11031822d58f11f1a4684845d57653b190 Gerrit-Change-Number: 37474 Gerrit-PatchSet: 1 Gerrit-Owner: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Dec 2019 07:03:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch"
by Kane Chen (Code Review) 05 Dec '19

05 Dec '19

Hello Subrata Banik, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/37088 to review the following change. Change subject: Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" ...................................................................... Revert "mb/google/hatch: Enable PchPmSlpS0Vm075VSupport for hatch" This reverts commit 0bc35af93326ec3232ec73c9b1334241b85f0252. Reason for revert: This change breaks runtime s0ix. Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/37088/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index a2831e1..7382209 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,8 +58,6 @@ register "PmTimerDisabled" = "1" - register "PchPmSlpS0Vm075VSupport" = "1" - # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | -- To view, visit https://review.coreboot.org/c/coreboot/+/37088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida80f55b56de7129ed629eb29bd14f2ef300126f Gerrit-Change-Number: 37088 Gerrit-PatchSet: 1 Gerrit-Owner: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newchange

3 12

Change in coreboot[4.11_branch]: mainboard/facebook/watson: Reclaim unused flash space
by Werner Zeh (Code Review) 05 Dec '19

05 Dec '19

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37474 ) Change subject: mainboard/facebook/watson: Reclaim unused flash space ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I5f407c11031822d58f11f1a4684845d57653b190 Gerrit-Change-Number: 37474 Gerrit-PatchSet: 1 Gerrit-Owner: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Dec 2019 05:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: [BACKPORT] arch/x86: SMBIOS: Improve core count reporting
by Werner Zeh (Code Review) 05 Dec '19

05 Dec '19

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37089 ) Change subject: [BACKPORT] arch/x86: SMBIOS: Improve core count reporting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Id4ba9e3079f92ffe38f9104ffcfafe62582dd259 Gerrit-Change-Number: 37089 Gerrit-PatchSet: 1 Gerrit-Owner: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Dec 2019 05:31:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[4.11_branch]: soc/intel/broadwell_de: Re-read SPD on CRC error
by Werner Zeh (Code Review) 05 Dec '19

05 Dec '19

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37303 ) Change subject: soc/intel/broadwell_de: Re-read SPD on CRC error ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37303 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: I650c8cd80f75b603db332024748a91af6171f096 Gerrit-Change-Number: 37303 Gerrit-PatchSet: 3 Gerrit-Owner: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Dec 2019 05:30:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add Jasperlake Device IDs
by Ronak Kanabar (Code Review) 05 Dec '19

05 Dec '19

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37434 ) Change subject: soc/intel/common: Add Jasperlake Device IDs ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/37434/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/37434/5//COMMIT_MSG@7 PS5, Line 7: Jasperlake > The typo was reintroduced. […] Jasperlake is whole name that why I changed it back. and made "L" small -- To view, visit https://review.coreboot.org/c/coreboot/+/37434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2c9ec1ee4236184b986d99250f263172c80f7117 Gerrit-Change-Number: 37434 Gerrit-PatchSet: 5 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 05 Dec 2019 04:58:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: comment

1 0

Change in em100[master]: WIP: code coverage
by Stefan Reinauer (Code Review) 05 Dec '19

05 Dec '19

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37123 ) Change subject: WIP: code coverage ...................................................................... WIP: code coverage Change-Id: I8752482bb89587bc448fe1c966bca40d8d1bdbb0 Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M .gitignore M Makefile 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/em100 refs/changes/23/37123/1 diff --git a/.gitignore b/.gitignore index c89766e..c111945 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,5 @@ /EM100Pro.msi .dependencies *.o +*.gcda +*.gcno diff --git a/Makefile b/Makefile index 481dc02..ccb73c6 100644 --- a/Makefile +++ b/Makefile @@ -32,6 +32,8 @@ CFLAGS += -DXZ_DEC_X86 -DXZ_DEC_POWERPC -DXZ_DEC_IA64 -DXZ_DEC_ARM -DXZ_DEC_ARMTHUMB -DXZ_DEC_SPARC -DXZ_USE_CRC64 -DXZ_DEC_ANY_CHECK -Ixz # Remove after fixing CFLAGS += -Wno-sign-compare -Wno-discarded-qualifiers +# Code Coverage +CFLAGS += -fprofile-arcs -ftest-coverage LDFLAGS ?= LDFLAGS += $(shell $(PKG_CONFIG) --libs libusb-1.0) -- To view, visit https://review.coreboot.org/c/em100/+/37123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: master Gerrit-Change-Id: I8752482bb89587bc448fe1c966bca40d8d1bdbb0 Gerrit-Change-Number: 37123 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newchange

1 2

Change in coreboot[4.11_branch]: drivers/ipmi: Add IPMI Read FRU function
by Johnny Lin (Code Review) 05 Dec '19

05 Dec '19

Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37444 ) Change subject: drivers/ipmi: Add IPMI Read FRU function ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/37444/5/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c: https://review.coreboot.org/c/coreboot/+/37444/5/src/drivers/ipmi/ipmi_fru.… PS5, Line 63: } else > else is not generally useful after a break or return Done -- To view, visit https://review.coreboot.org/c/coreboot/+/37444 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: 4.11_branch Gerrit-Change-Id: Id6353f5ce3f7ddd3bb161b91364b3cf276d020b8 Gerrit-Change-Number: 37444 Gerrit-PatchSet: 6 Gerrit-Owner: Johnny Lin Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jingle Hsu Gerrit-Reviewer: Johnny Lin Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Morgan Jang Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 05 Dec 2019 02:22:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019