coreboot-gerrit December 2019

coreboot-gerrit@coreboot.org

1 participants
1761 discussions

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by Idwer Vollering (Code Review) 14 Dec '19

14 Dec '19

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37727 to look at the new patch set (#6). Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... asus/f2a85-m: switch away from ROMCC_BOOTBLOCK Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> --- M src/mainboard/asus/f2a85-m/Kconfig M src/mainboard/asus/f2a85-m/Makefile.inc A src/mainboard/asus/f2a85-m/bootblock.c M src/mainboard/asus/f2a85-m/romstage.c 4 files changed, 76 insertions(+), 69 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37727/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 6 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by HAOUAS Elyes (Code Review) 14 Dec '19

14 Dec '19

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 ) Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... Patch Set 5: (2 comments) https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m… File src/mainboard/asus/f2a85-m/bootblock.c: https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m… PS4, Line 19: include <console/console.h> remove? would you check the others includes https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m… PS4, Line 32: define MMIO_NON_POSTED_START 0xfed00000 : #define MMIO_NON_POSTED_END 0xfedfffff remove ? -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 5 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2019 18:10:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by build bot (Jenkins) (Code Review) 14 Dec '19

14 Dec '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 ) Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/37727/5/src/mainboard/asus/f2a85-m… File src/mainboard/asus/f2a85-m/bootblock.c: https://review.coreboot.org/c/coreboot/+/37727/5/src/mainboard/asus/f2a85-m… PS5, Line 34: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 5 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2019 18:09:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by Idwer Vollering (Code Review) 14 Dec '19

14 Dec '19

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37727 to look at the new patch set (#5). Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... asus/f2a85-m: switch away from ROMCC_BOOTBLOCK Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Signed-off-by: Idwer Vollering <vidwer(a)gmail.com> --- M src/mainboard/asus/f2a85-m/Kconfig M src/mainboard/asus/f2a85-m/Makefile.inc A src/mainboard/asus/f2a85-m/bootblock.c M src/mainboard/asus/f2a85-m/romstage.c 4 files changed, 78 insertions(+), 69 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/37727/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 5 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: my broken build of coreboot
by Name of user not set (Code Review) 14 Dec '19

14 Dec '19

Name of user not set #1002723 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37661 ) Change subject: my broken build of coreboot ...................................................................... my broken build of coreboot Change-Id: I5586d07b0e5c3c26f4f4d478ec567067476e3c87 --- A src/mainboard/dell/Kconfig A src/mainboard/dell/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Kconfig A src/mainboard/dell/dell_system_vostro_3360/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Makefile.inc A src/mainboard/dell/dell_system_vostro_3360/acpi/ec.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/superio.asl A src/mainboard/dell/dell_system_vostro_3360/acpi_tables.c A src/mainboard/dell/dell_system_vostro_3360/board_info.txt A src/mainboard/dell/dell_system_vostro_3360/devicetree.cb A src/mainboard/dell/dell_system_vostro_3360/dsdt.asl A src/mainboard/dell/dell_system_vostro_3360/gma-mainboard.ads A src/mainboard/dell/dell_system_vostro_3360/gpio.c A src/mainboard/dell/dell_system_vostro_3360/hda_verb.c A src/mainboard/dell/dell_system_vostro_3360/mainboard.c A src/mainboard/dell/dell_system_vostro_3360/romstage.c A util/autoport/logs/acpidump.log A util/autoport/logs/codec_0 A util/autoport/logs/codec_3 A util/autoport/logs/cpuinfo.log A util/autoport/logs/dmidecode.log A util/autoport/logs/ectool.log A util/autoport/logs/input_bustypes.log A util/autoport/logs/inteltool.log A util/autoport/logs/ioports.log A util/autoport/logs/lspci.log A util/autoport/logs/pin_hwC0D0 A util/autoport/logs/pin_hwC0D3 A util/autoport/logs/superiotool.log 30 files changed, 30,191 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/37661/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/37661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5586d07b0e5c3c26f4f4d478ec567067476e3c87 Gerrit-Change-Number: 37661 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002723 Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by Idwer Vollering (Code Review) 14 Dec '19

14 Dec '19

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 ) Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/37727/3/src/mainboard/asus/f2a85-m… File src/mainboard/asus/f2a85-m/romstage.c: https://review.coreboot.org/c/coreboot/+/37727/3/src/mainboard/asus/f2a85-m… PS3, Line 79: superio_init_m(); > 48mhzout and superio_init moved to bootblock, remove functions in this file. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2019 18:05:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: Make X86 stages select ARCH_X86
by Angel Pons (Code Review) 14 Dec '19

14 Dec '19

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31316 ) Change subject: arch/x86: Make X86 stages select ARCH_X86 ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic77b696f493d7648f317f0ba0a27fdee5212961e Gerrit-Change-Number: 31316 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Huang Jin <huang.jin(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: York Yang <yyang024(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Sat, 14 Dec 2019 18:04:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lvds option added
by Name of user not set (Code Review) 14 Dec '19

14 Dec '19

Name of user not set #1002723 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37731 ) Change subject: lvds option added ...................................................................... lvds option added Change-Id: I3d3f03fa6ac9ef5d156cbc94373e94534273f3a2 --- M 3rdparty/vboot A src/mainboard/dell/Kconfig A src/mainboard/dell/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Kconfig A src/mainboard/dell/dell_system_vostro_3360/Kconfig.name A src/mainboard/dell/dell_system_vostro_3360/Makefile.inc A src/mainboard/dell/dell_system_vostro_3360/acpi/ec.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl A src/mainboard/dell/dell_system_vostro_3360/acpi/superio.asl A src/mainboard/dell/dell_system_vostro_3360/acpi_tables.c A src/mainboard/dell/dell_system_vostro_3360/board_info.txt A src/mainboard/dell/dell_system_vostro_3360/devicetree.cb A src/mainboard/dell/dell_system_vostro_3360/dsdt.asl A src/mainboard/dell/dell_system_vostro_3360/gma-mainboard.ads A src/mainboard/dell/dell_system_vostro_3360/gpio.c A src/mainboard/dell/dell_system_vostro_3360/hda_verb.c A src/mainboard/dell/dell_system_vostro_3360/mainboard.c A src/mainboard/dell/dell_system_vostro_3360/romstage.c A util/autoport/logs/acpidump.log A util/autoport/logs/codec_0 A util/autoport/logs/codec_3 A util/autoport/logs/cpuinfo.log A util/autoport/logs/dmidecode.log A util/autoport/logs/ectool.log A util/autoport/logs/input_bustypes.log A util/autoport/logs/inteltool.log A util/autoport/logs/ioports.log A util/autoport/logs/lspci.log A util/autoport/logs/pin_hwC0D0 A util/autoport/logs/pin_hwC0D3 A util/autoport/logs/superiotool.log 31 files changed, 30,234 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/37731/1 -- To view, visit https://review.coreboot.org/c/coreboot/+/37731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d3f03fa6ac9ef5d156cbc94373e94534273f3a2 Gerrit-Change-Number: 37731 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002723 Gerrit-MessageType: newchange

2 1

Change in coreboot[master]: fix that was adviced by Nico Huber
by Name of user not set (Code Review) 14 Dec '19

14 Dec '19

Name of user not set #1002723 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37718 ) Change subject: fix that was adviced by Nico Huber ...................................................................... fix that was adviced by Nico Huber Change-Id: I1e3fc617b915c20fe0cb7cf9e8121bc32b6b574f --- M src/mainboard/dell/dell_system_vostro_3360/Makefile.inc M src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl M src/mainboard/dell/dell_system_vostro_3360/dsdt.asl M src/mainboard/dell/dell_system_vostro_3360/mainboard.c M src/mainboard/dell/dell_system_vostro_3360/romstage.c 5 files changed, 56 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37718/1 diff --git a/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc b/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc index ebe01ae..05fafb8 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc +++ b/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc @@ -1,2 +1,4 @@ romstage-y += gpio.c +bootblock-y += gpio.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads + diff --git a/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl b/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl index 0222986..a03e76c 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl +++ b/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + Method(_WAK,1) { Return(Package(){0,0}) diff --git a/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl b/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl index c7b42e0..6fdaad0 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl +++ b/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB #define ACPI_VIDEO_DEVICE \_SB.PCI0.GFX0 @@ -15,10 +32,10 @@ /* Some generic macros */ #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> - #include <southbridge/intel/bd82x6x/acpi/platform.asl> + #include <southbridge/intel/common/acpi/platform.asl> /* global NVS and variables. */ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> - #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + #include <southbridge/intel/common/acpi/sleepstates.asl> Device (\_SB.PCI0) { diff --git a/src/mainboard/dell/dell_system_vostro_3360/mainboard.c b/src/mainboard/dell/dell_system_vostro_3360/mainboard.c index 1f96d9e..1136015 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/mainboard.c +++ b/src/mainboard/dell/dell_system_vostro_3360/mainboard.c @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <device/device.h> #include <drivers/intel/gma/int15.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/dell/dell_system_vostro_3360/romstage.c b/src/mainboard/dell/dell_system_vostro_3360/romstage.c index a090ab6..0496764 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/romstage.c +++ b/src/mainboard/dell/dell_system_vostro_3360/romstage.c @@ -30,16 +30,12 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h> -void pch_enable_lpc(void) +void mainboard_pch_lpc_setup(void) { pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 1, 0 }, @@ -57,14 +53,6 @@ { 0, 1, 6 }, }; -void mainboard_early_init(int s3resume) -{ -} - -void mainboard_config_superio(void) -{ -} - /* FIXME: Put proper SPD map here. */ void mainboard_get_spd(spd_raw_data *spd, bool id_only) { -- To view, visit https://review.coreboot.org/c/coreboot/+/37718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e3fc617b915c20fe0cb7cf9e8121bc32b6b574f Gerrit-Change-Number: 37718 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002723 Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK
by build bot (Jenkins) (Code Review) 14 Dec '19

14 Dec '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37727 ) Change subject: asus/f2a85-m: switch away from ROMCC_BOOTBLOCK ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m… File src/mainboard/asus/f2a85-m/bootblock.c: https://review.coreboot.org/c/coreboot/+/37727/4/src/mainboard/asus/f2a85-m… PS4, Line 34: #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/37727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1d7127e2f9bd5bd9677feb2b0e686a854c4e3885 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 4 Gerrit-Owner: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Dec 2019 17:14:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2019