coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: security/tpm/tss/tcg-2.0/tss_marshaling.c: Avoid static analysis error
by build bot (Jenkins) (Code Review) 07 Aug '18

07 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27931 ) Change subject: security/tpm/tss/tcg-2.0/tss_marshaling.c: Avoid static analysis error ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27931/1/src/security/tpm/tss/tcg-2.0/tss_ma… File src/security/tpm/tss/tcg-2.0/tss_marshaling.c: https://review.coreboot.org/#/c/27931/1/src/security/tpm/tss/tcg-2.0/tss_ma… PS1, Line 558: printk(BIOS_INFO, "Final tpm_unmarshal_response status 0x%x\n", Prefer using '"%s...", __func__' to using 'tpm_unmarshal_response', this function's name, in a string -- To view, visit https://review.coreboot.org/27931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7575bc75104fd97f138224aa57561e68f6548e58 Gerrit-Change-Number: 27931 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 16:25:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm/tss/tcg-2.0/tss_marshaling.c: Avoid static analysis error
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27931 Change subject: security/tpm/tss/tcg-2.0/tss_marshaling.c: Avoid static analysis error ...................................................................... security/tpm/tss/tcg-2.0/tss_marshaling.c: Avoid static analysis error In procedure tpm_unmarshal_response(), variable "rc" is used early to decide if it should return NULL. However, from that point on, the variable is only |=, but not read. Thus it's causing a static analysis error. Add a printk line using variable "rc" to avoid static analysis error. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: I7575bc75104fd97f138224aa57561e68f6548e58 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/security/tpm/tss/tcg-2.0/tss_marshaling.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/27931/1 diff --git a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c index 86f2231..bd46a7c 100644 --- a/src/security/tpm/tss/tcg-2.0/tss_marshaling.c +++ b/src/security/tpm/tss/tcg-2.0/tss_marshaling.c @@ -554,6 +554,9 @@ command, ibuf_remaining(ib)); return NULL; } + if (rc) + printk(BIOS_INFO, "Final tpm_unmarshal_response status 0x%x\n", + rc); /* The entire message have been parsed. */ return tpm2_resp; -- To view, visit https://review.coreboot.org/27931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7575bc75104fd97f138224aa57561e68f6548e58 Gerrit-Change-Number: 27931 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: cpu/amd: Rename MCA status register
by Martin Roth (Code Review) 07 Aug '18

07 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27922 ) Change subject: cpu/amd: Rename MCA status register ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97d2631a186965bb8b18f544ed9648b3a71f5fb0 Gerrit-Change-Number: 27922 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 16:24:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP
by Martin Roth (Code Review) 07 Aug '18

07 Aug '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27930 ) Change subject: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea1b8359b80d167e69745358f543f025713294ba Gerrit-Change-Number: 27930 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 16:10:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP
by Raul Rangel (Code Review) 07 Aug '18

07 Aug '18

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/27930 Change subject: mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP ...................................................................... mainboard/google/kahlee: Set SYSTEM_TYPE_LAPTOP This configures the ACPI FADT perferred power management profile to PM_MOBILE instead of PM_DESKTOP. I'm not sure what impact this actually has. I just noticed the other boards have it set. BUG=b:110971913 TEST=Made sure SYSTEM_TYPE_LAPTOP shows up in coreboot.config Change-Id: Iea1b8359b80d167e69745358f543f025713294ba Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/27930/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 5565d57..fbd1fb0 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -43,6 +43,7 @@ select PCIEXP_COMMON_CLOCK select PCIEXP_L1_SUB_STATE select HAVE_EM100_SUPPORT + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_KAHLEE -- To view, visit https://review.coreboot.org/27930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iea1b8359b80d167e69745358f543f025713294ba Gerrit-Change-Number: 27930 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>

1 0

Change in coreboot[master]: lib/edid.c: Avoid static analysis error for unused value
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded a new patch set (#2). ( https://review.coreboot.org/27929 ) Change subject: lib/edid.c: Avoid static analysis error for unused value ...................................................................... lib/edid.c: Avoid static analysis error for unused value Within procedure cea_hdmi_block, the variable "b" is used as an index into a buffer of EDID bytes. Each time it's used, it's incremented, but the last increment is not used and is causing a static analysis error. Add a printk at the end, using variable "b", to avoid the static analysis error. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/lib/edid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27929/2 -- To view, visit https://review.coreboot.org/27929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989 Gerrit-Change-Number: 27929 Gerrit-PatchSet: 2 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: lib/edid.c: Avoid static analysis error for unused value
by build bot (Jenkins) (Code Review) 07 Aug '18

07 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27929 ) Change subject: lib/edid.c: Avoid static analysis error for unused value ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27929/1/src/lib/edid.c File src/lib/edid.c: https://review.coreboot.org/#/c/27929/1/src/lib/edid.c@820 PS1, Line 820: printk(BIOS_SPEW, "Next EDID byte %d\n", (9 +b)); need consistent spacing around '+' (ctx:WxV) -- To view, visit https://review.coreboot.org/27929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989 Gerrit-Change-Number: 27929 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 15:43:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: lib/edid.c: Avoid static analysis error for unused value
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27929 Change subject: lib/edid.c: Avoid static analysis error for unused value ...................................................................... lib/edid.c: Avoid static analysis error for unused value Within procedure cea_hdmi_block, the variable "b" is used as an index into a buffer of EDID bytes. Each time it's used, it's incremented, but the last increment is not used and is causing a static analysis error. Add a printk at the end, using variable "b", to avoid the static analysis error. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/lib/edid.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/27929/1 diff --git a/src/lib/edid.c b/src/lib/edid.c index 7ad4136..747526e 100644 --- a/src/lib/edid.c +++ b/src/lib/edid.c @@ -817,7 +817,7 @@ * (optionally: 3D_Detail_X and reserved) */ } - + printk(BIOS_SPEW, "Next EDID byte %d\n", (9 +b)); } } } -- To view, visit https://review.coreboot.org/27929 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd0b4a21bf82fcc46a627bc75564a850b7374989 Gerrit-Change-Number: 27929 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: device/pci_device.c: Remove unused variable attr setting
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27928 Change subject: device/pci_device.c: Remove unused variable attr setting ...................................................................... device/pci_device.c: Remove unused variable attr setting In procedure pci_get_resource, when setting an IO mapped base address, variable attr is &= with PCI_BASE_ADDRESS_IO_ATTR_MASK. However, in this particular code flow variable attr is not used later. Remove the line. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/device/pci_device.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/27928/1 diff --git a/src/device/pci_device.c b/src/device/pci_device.c index 5938389..b4a8a5c 100644 --- a/src/device/pci_device.c +++ b/src/device/pci_device.c @@ -249,7 +249,6 @@ resource->flags = 0; } else if (attr & PCI_BASE_ADDRESS_SPACE_IO) { /* An I/O mapped base address. */ - attr &= PCI_BASE_ADDRESS_IO_ATTR_MASK; resource->flags |= IORESOURCE_IO; /* I don't want to deal with 32bit I/O resources. */ resource->limit = 0xffff; -- To view, visit https://review.coreboot.org/27928 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69 Gerrit-Change-Number: 27928 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: security/vboot: Split fwid.region build target
by Raul Rangel (Code Review) 07 Aug '18

07 Aug '18

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/27884 ) Change subject: security/vboot: Split fwid.region build target ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc: https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc@232 PS1, Line 232: file > Uhhh... […] I used the built in file function: https://www.gnu.org/software/make/manual/html_node/File-Function.html#index… -- To view, visit https://review.coreboot.org/27884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0 Gerrit-Change-Number: 27884 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 14:19:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018