coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: Added multiboot support to cbfstool and made changes to behaviour for...
by build bot (Jenkins) (Code Review) 08 Aug '18

08 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27957 ) Change subject: Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload ...................................................................... Patch Set 1: (10 comments) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c File util/cbfstool/cbfs-mkpayload.c: https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c@551 PS1, Line 551: " 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c@551 PS1, Line 551: " 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr); space required after that ',' (ctx:VxV) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c File util/cbfstool/cbfs-payload-linux.c: https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 246: if ( hdr->boot_sector_magic != 0xAA55 ) { space prohibited after that open parenthesis '(' https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 246: if ( hdr->boot_sector_magic != 0xAA55 ) { space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 250: if ( (hdr->header_magic[0] != 'H')|| spaces required around that '||' (ctx:VxE) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 250: if ( (hdr->header_magic[0] != 'H')|| space prohibited after that open parenthesis '(' https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 251: (hdr->header_magic[1] != 'd')|| spaces required around that '||' (ctx:VxE) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 252: (hdr->header_magic[2] != 'r')|| spaces required around that '||' (ctx:VxE) https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@… PS1, Line 253: (hdr->header_magic[3] != 'S')){ space required before the open brace '{' https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c: https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfstool.c@767 PS1, Line 767: ERROR("Not a supported payload type (ELF / FV / bzImage / Multiboot).\n"); line over 80 characters -- To view, visit https://review.coreboot.org/27957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaeb808e8750ad81bdf8c4daedb0d91e961eebb70 Gerrit-Change-Number: 27957 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Aug 2018 16:46:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: Added multiboot support to cbfstool and made changes to behaviour for...
by Michał Żygowski (Code Review) 08 Aug '18

08 Aug '18

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/27957 Change subject: Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload ...................................................................... Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload * modified messaging and logic with respect to different payload types: - tries multiboot if neither ELF nor UEFI - then tries bzImage * added check for Linux header in bzImage * change ERROR level message if stage file not in ELF format (reduced to INFO) Note: multiboot support limited to obtaining load location and entry point Change-Id: Iaeb808e8750ad81bdf8c4daedb0d91e961eebb70 Signed-off-by: Paul Roberts <paul.c.roberts(a)ntlworld.com> --- M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/cbfs-payload-linux.c M util/cbfstool/cbfstool.c M util/cbfstool/common.h 4 files changed, 123 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/27957/1 diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index d6c10ad..8df52d9 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -454,3 +454,104 @@ return 0; } + +#define MULTIBOOT_MAGIC 0x1BADB002 + +struct multiboot_header { + uint32_t magic; + uint32_t flags; + uint32_t checksum; + uint32_t header_addr; + uint32_t load_addr; + uint32_t load_end_addr; + uint32_t bss_end_addr; + uint32_t entry_addr; +}; + +static int find_multiboot_header(const struct buffer *input, + struct multiboot_header *mboot_hdr) +{ + int i; + + for (i = 0; i < 8192; i += sizeof(uint32_t)) { + uint32_t sum; + struct buffer in; + + buffer_clone(&in, input); + buffer_seek(&in, i); + + mboot_hdr->magic = xdr_le.get32(&in); + + if (mboot_hdr->magic != MULTIBOOT_MAGIC) + continue; + + mboot_hdr->flags = xdr_le.get32(&in); + mboot_hdr->checksum = xdr_le.get32(&in); + + sum = mboot_hdr->magic + mboot_hdr->flags + mboot_hdr->checksum; + + if (sum != 0) { + WARN("Multiboot header found @ %d. Checksum invalid\n", + i); + continue; + } + + mboot_hdr->header_addr = xdr_le.get32(&in); + mboot_hdr->load_addr = xdr_le.get32(&in); + mboot_hdr->load_end_addr = xdr_le.get32(&in); + mboot_hdr->bss_end_addr = xdr_le.get32(&in); + mboot_hdr->entry_addr = xdr_le.get32(&in); + + return i; + } + + return -1; +} + +int parse_multiboot_to_payload(const struct buffer *input, + struct buffer *output, enum comp_algo algo) +{ + int header_offset; + struct multiboot_header mboot_hdr; + uint32_t end_addr; + + + header_offset = find_multiboot_header(input, &mboot_hdr); + + if (header_offset < 0) { + WARN("No valid multiboot header found.\n"); + return -1; + } + + /* No runtime boot information supported. */ + if (mboot_hdr.flags & ((1 << 2) | (1 << 1))) { + WARN("No multiboot runtime boot information supported: %x.\n", + mboot_hdr.flags); + return -1; + } + + if (!(mboot_hdr.flags & (1 << 16))) { + WARN("No multiboot load information available: %x.\n", + mboot_hdr.flags); + return -1; + } + + end_addr = mboot_hdr.load_end_addr; + if (!end_addr) + end_addr = mboot_hdr.load_addr + input->size; + + /* Support full file load only. */ + if (header_offset + mboot_hdr.load_addr != mboot_hdr.header_addr || + end_addr - mboot_hdr.load_addr != input->size) { + WARN("Multiboot payload loading only supports full file.\n"); + return -1; + } + + INFO("Compatible Multiboot payload found. load address:" + " 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr); + return parse_flat_binary_to_payload(input, + output, + mboot_hdr.load_addr, + mboot_hdr.entry_addr, + algo); +} diff --git a/util/cbfstool/cbfs-payload-linux.c b/util/cbfstool/cbfs-payload-linux.c index 6b4bf27..8183925 100644 --- a/util/cbfstool/cbfs-payload-linux.c +++ b/util/cbfstool/cbfs-payload-linux.c @@ -242,6 +242,19 @@ params.loader_type = 0xff; /* Unregistered Linux loader */ + /* Check for signatures and determine version */ + if ( hdr->boot_sector_magic != 0xAA55 ) { + WARN("bzImage missing 55AA signature\n"); + return -1; + } + if ( (hdr->header_magic[0] != 'H')|| + (hdr->header_magic[1] != 'd')|| + (hdr->header_magic[2] != 'r')|| + (hdr->header_magic[3] != 'S')){ + WARN("bzImage missing HdrS signature\n"); + return -1; + } + if (cmdline != NULL) { if (hdr->protocol_version < 0x202) { params.cl_magic = CL_MAGIC_VALUE; diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c index f8b1f65..6fbe2fc 100644 --- a/util/cbfstool/cbfstool.c +++ b/util/cbfstool/cbfstool.c @@ -752,14 +752,19 @@ if (ret != 0) ret = parse_fv_to_payload(buffer, &output, param.compression); - /* If it's neither ELF nor UEFI Fv, try bzImage */ + /* If it's neither ELF nor UEFI Fv, try multiboot */ + if (ret != 0) + ret = parse_multiboot_to_payload(buffer, &output, + param.compression); + + /* If it's neither ELF, UEFI Fv, nor multiboot try bzImage*/ if (ret != 0) ret = parse_bzImage_to_payload(buffer, &output, param.initrd, param.cmdline, param.compression); /* Not a supported payload type */ if (ret != 0) { - ERROR("Not a supported payload type (ELF / FV).\n"); + ERROR("Not a supported payload type (ELF / FV / bzImage / Multiboot).\n"); buffer_delete(buffer); return -1; } diff --git a/util/cbfstool/common.h b/util/cbfstool/common.h index baefc1c..ab2e441 100644 --- a/util/cbfstool/common.h +++ b/util/cbfstool/common.h @@ -198,6 +198,8 @@ uint32_t loadaddress, uint32_t entrypoint, enum comp_algo algo); +int parse_multiboot_to_payload(const struct buffer *input, + struct buffer *output, enum comp_algo algo); /* cbfs-mkstage.c */ int parse_elf_to_stage(const struct buffer *input, struct buffer *output, enum comp_algo algo, uint32_t *location, -- To view, visit https://review.coreboot.org/27957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaeb808e8750ad81bdf8c4daedb0d91e961eebb70 Gerrit-Change-Number: 27957 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Avoid static analysis error for unused value
by Richard Spiegel (Code Review) 08 Aug '18

08 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27956 Change subject: cpu/x86/mp_init.c: Avoid static analysis error for unused value ...................................................................... cpu/x86/mp_init.c: Avoid static analysis error for unused value Within procedure save_bsp_msrs, the structure pointer "msr_entry" is updated every time procedure save_msr() is called. However, after the last call of save_msr(), "msr_entry" is not used, thus causing a static analysis error. Add a "(void)msr_entry;" at the end to avoid the static analysis error. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: If0fb336fbf49eec3da255fadbe38b3a38768d0cf Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/cpu/x86/mp_init.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/27956/1 diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index d124721..4d8b028 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -296,6 +296,7 @@ msr_entry = save_msr(MTRR_DEF_TYPE_MSR, msr_entry); fixed_mtrrs_hide_amd_rwdram(); + (void)msr_entry; return msr_count; } -- To view, visit https://review.coreboot.org/27956 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0fb336fbf49eec3da255fadbe38b3a38768d0cf Gerrit-Change-Number: 27956 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: soc/cavium/cn81xx: Minor fixes
by Patrick Rudolph (Code Review) 08 Aug '18

08 Aug '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27955 Change subject: soc/cavium/cn81xx: Minor fixes ...................................................................... soc/cavium/cn81xx: Minor fixes * Move cbmem.c to cn81xx folder * Store CBMEM below 4 GiB * Make sure CBMEM doesn't overlap with ATF scratchpad * Fix ATF scratchpad not marked as reserved due to wrong calculation * The scratchpad is the last 1 MiB at the end of DRAM. Tested on Cavium CN81xx EVB: The ATF scratchpad is now marked reserved and the configuration tables are located below 4 GiB. Linux still boots. Change-Id: Ibbc8b586f04bd6867c045f5546b32a77c057ac74 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/soc/cavium/cn81xx/Makefile.inc R src/soc/cavium/cn81xx/cbmem.c M src/soc/cavium/cn81xx/soc.c M src/soc/cavium/common/Makefile.inc 4 files changed, 8 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/27955/1 diff --git a/src/soc/cavium/cn81xx/Makefile.inc b/src/soc/cavium/cn81xx/Makefile.inc index 845ac34..2179bc7 100644 --- a/src/soc/cavium/cn81xx/Makefile.inc +++ b/src/soc/cavium/cn81xx/Makefile.inc @@ -39,16 +39,11 @@ romstage-y += spi.c romstage-y += uart.c romstage-$(CONFIG_DRIVERS_UART) += uart.c -romstage-< += cpu.c +romstage-y += cbmem.c romstage-y += sdram.c romstage-y += mmu.c -romstage-y += ../common/cbmem.c -# BDK coreboot interface -romstage-y += ../common/bdk-coreboot.c - - ################################################################################ # ramstage @@ -64,12 +59,10 @@ ramstage-y += cpu.c ramstage-y += cpu_secondary.S ramstage-y += ecam0.c +ramstage-y += cbmem.c ramstage-$(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE) += bl31_plat_params.c -# BDK coreboot interface -ramstage-y += ../common/bdk-coreboot.c - BL31_MAKEARGS += PLAT=t81 M0_CROSS_COMPILE="$(CROSS_COMPILE_arm)" ENABLE_SPE_FOR_LOWER_ELS=0 CPPFLAGS_common += -Isrc/soc/cavium/cn81xx/include diff --git a/src/soc/cavium/common/cbmem.c b/src/soc/cavium/cn81xx/cbmem.c similarity index 82% rename from src/soc/cavium/common/cbmem.c rename to src/soc/cavium/cn81xx/cbmem.c index 401f8b2..397fd26 100644 --- a/src/soc/cavium/common/cbmem.c +++ b/src/soc/cavium/cn81xx/cbmem.c @@ -21,6 +21,7 @@ void *cbmem_top(void) { - return (void *)min((uintptr_t)_dram + sdram_size_mb() * MiB, - MAX_DRAM_ADDRESS); + /* Make sure not to overlap with reserved ATF scratchpad */ + return (void *)min((uintptr_t)_dram + (sdram_size_mb() - 1) * MiB, + 4ULL * GiB); } diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 9dbbcbf..7b57484 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -309,7 +309,8 @@ BM_MEM_RESERVED); /* Scratchpad for ATF SATA quirks */ - bootmem_add_range(sdram_size_mb() * KiB, 1 * MiB, BM_MEM_RESERVED); + bootmem_add_range((sdram_size_mb() - 1) * MiB, 1 * MiB, + BM_MEM_RESERVED); } static void soc_read_resources(device_t dev) diff --git a/src/soc/cavium/common/Makefile.inc b/src/soc/cavium/common/Makefile.inc index 7af8bf5..ada8286 100644 --- a/src/soc/cavium/common/Makefile.inc +++ b/src/soc/cavium/common/Makefile.inc @@ -22,13 +22,12 @@ ################################################################################ # romstage -romstage-y += cbmem.c romstage-y += bdk-coreboot.c ################################################################################ # ramstage -ramstage-y += cbmem.c +ramstage-y += bdk-coreboot.c CPPFLAGS_common += -Isrc/soc/cavium/common/include -- To view, visit https://review.coreboot.org/27955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibbc8b586f04bd6867c045f5546b32a77c057ac74 Gerrit-Change-Number: 27955 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: google/bobba: Add Raydium touch screen support
by Pan Sheng-Liang (Code Review) 08 Aug '18

08 Aug '18

Hello Sheng-Liang Pan, I'd like you to do a code review. Please visit https://review.coreboot.org/27954 to review the following change. Change subject: google/bobba: Add Raydium touch screen support ...................................................................... google/bobba: Add Raydium touch screen support Current coreboot does not create ACPI device for OS to recognize Raydium touchscreen. List the touch screen in the devicetree so that the correct ACPI device are created. BUG=b:none BRANCH=master TEST=emerge-octopus coreboot Change-Id: Ic61a69e19e97520da0702dfe6cb7496563fc34f4 Signed-off-by: Pan Sheng-Liang <sheng-liang.pan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/octopus/variants/bobba/overridetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/27954/1 diff --git a/src/mainboard/google/octopus/variants/bobba/overridetree.cb b/src/mainboard/google/octopus/variants/bobba/overridetree.cb index 466d19b..a0972cc 100644 --- a/src/mainboard/google/octopus/variants/bobba/overridetree.cb +++ b/src/mainboard/google/octopus/variants/bobba/overridetree.cb @@ -43,6 +43,18 @@ register "has_power_resource" = "1" device i2c 10 on end end + chip drivers/i2c/generic + register "hid" = ""RAYD0001"" + register "desc" = ""Raydium Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)" + register "reset_delay_ms" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)" + register "enable_delay_ms" = "50" + register "has_power_resource" = "1" + device i2c 39 on end + end end # - I2C 7 end end -- To view, visit https://review.coreboot.org/27954 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic61a69e19e97520da0702dfe6cb7496563fc34f4 Gerrit-Change-Number: 27954 Gerrit-PatchSet: 1 Gerrit-Owner: Pan Sheng-Liang <sl.pan.quantw(a)gmail.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: util/lint: Set "acknowledgement" correct
by Elyes HAOUAS (Code Review) 08 Aug '18

08 Aug '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27953 Change subject: util/lint: Set "acknowledgement" correct ...................................................................... util/lint: Set "acknowledgement" correct "acknowledgement" is not commonly used but correct. Change-Id: I0aa469d77904d65288f5b7133bec10be3688a596 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M util/lint/spelling.txt 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/27953/1 diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 400ef35..9c2aeba 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -41,7 +41,6 @@ acitions||actions acitve||active acknowldegement||acknowledgment -acknowledgement||acknowledgment ackowledge||acknowledge ackowledged||acknowledged acording||according -- To view, visit https://review.coreboot.org/27953 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0aa469d77904d65288f5b7133bec10be3688a596 Gerrit-Change-Number: 27953 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: [WIP]mb/opencellular/satima: Add new port
by build bot (Jenkins) (Code Review) 08 Aug '18

08 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 ) Change subject: [WIP]mb/opencellular/satima: Add new port ...................................................................... Patch Set 15: (174 comments) https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/cn81xx-linux.dtsi: https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/death.c: https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 31: } while(1); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/mainboard.h: https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/sff8104-linux.dts: https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/15/src/mainboard/opencellular/satima/… PS15, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ -- To view, visit https://review.coreboot.org/27425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f972d59ac2243823a77f614c4f92c1666185705 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 15 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 08 Aug 2018 02:43:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/spi/spi_flash.c: Check input paarameter
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27952 Change subject: drivers/spi/spi_flash.c: Check input paarameter ...................................................................... drivers/spi/spi_flash.c: Check input paarameter In procedure spi_flash_cmd_erase(), parameter "len" is not validated and could lead to the return of an invalid (not-initialized) value. Validate the parameter early on. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: I0b5129a15c9e0ea45f4dba4ab0729196cb64699b Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/drivers/spi/spi_flash.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/27952/1 diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index 9cb1085..01ff7b2 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -206,6 +206,10 @@ printk(BIOS_WARNING, "SF: Erase offset/length not multiple of erase size\n"); return -1; } + if (len == 0) { + printk(BIOS_WARNING, "Erase length cannot be 0\n"); + return -1; + } cmd[0] = flash->erase_cmd; start = offset; -- To view, visit https://review.coreboot.org/27952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0b5129a15c9e0ea45f4dba4ab0729196cb64699b Gerrit-Change-Number: 27952 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: cpu/x86/mp_init.c: Fix error treatment
by Richard Spiegel (Code Review) 07 Aug '18

07 Aug '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27951 Change subject: cpu/x86/mp_init.c: Fix error treatment ...................................................................... cpu/x86/mp_init.c: Fix error treatment In procedure allocate_cpu_devices(), if structure pointer new is null skip using the the pointer. Add a "continue;" to skip using the pointer. BUG=b:112253891 TEST=Build and boot grunt. Change-Id: I7011fbfa0725f22a6dfbca6752e668eddac3463c Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/cpu/x86/mp_init.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/27951/1 diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index d124721..ff02b16 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -404,6 +404,7 @@ if (new == NULL) { printk(BIOS_CRIT, "Could not allocate CPU device\n"); max_cpus--; + continue; } new->name = processor_name; cpus[i].dev = new; -- To view, visit https://review.coreboot.org/27951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7011fbfa0725f22a6dfbca6752e668eddac3463c Gerrit-Change-Number: 27951 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

Change in coreboot[master]: arm64: Turn architectural register accessors into inline functions
by build bot (Jenkins) (Code Review) 07 Aug '18

07 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27881 ) Change subject: arm64: Turn architectural register accessors into inline functions ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/27881/4/src/arch/arm64/include/armv8/arch/l… File src/arch/arm64/include/armv8/arch/lib_helpers.h: https://review.coreboot.org/#/c/27881/4/src/arch/arm64/include/armv8/arch/l… PS4, Line 162: #define MAKE_REGISTER_ACCESSORS_EL123(reg) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/27881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c41cc3ce49ee26bf12cd34e3d0509d8e61ffc63 Gerrit-Change-Number: 27881 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 22:21:03 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018