coreboot-gerrit August 2018

coreboot-gerrit@coreboot.org

1 participants
1120 discussions

Change in coreboot[master]: security/vboot: Split fwid.region build target
by Julius Werner (Code Review) 07 Aug '18

07 Aug '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27884 ) Change subject: security/vboot: Split fwid.region build target ...................................................................... Patch Set 1: Code-Review+2 (2 comments) https://review.coreboot.org/#/c/27884/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27884/1//COMMIT_MSG@11 PS1, Line 11: objects are not invalidated when bumping the fwid. > You assessment is correct, the target will only get created once and never touched again. […] Okay, sorry, I think I overlooked the last line in here yesterday. So you want to replace the file and keep .config the same. Yeah, that should work. https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc File src/security/vboot/Makefile.inc: https://review.coreboot.org/#/c/27884/1/src/security/vboot/Makefile.inc@232 PS1, Line 232: file > I used the built in file function: https://www.gnu.org/software/make/manual/html_node/File-Function. […] Oh, right, carry on then. -- To view, visit https://review.coreboot.org/27884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I955106efd648a75a1311f24ede46bd238d1517e0 Gerrit-Change-Number: 27884 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 18:46:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/amd: Misc. formatting improvements
by Marshall Dawson (Code Review) 07 Aug '18

07 Aug '18

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/27935 Change subject: cpu/amd: Misc. formatting improvements ...................................................................... cpu/amd: Misc. formatting improvements Remove for() braces from around single lines. Remove extra blank lines. Change-Id: I329ac03365e51799581c56eed27ee54de6826f14 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/cpu/amd/agesa/family12/model_12_init.c M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c 7 files changed, 5 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/27935/1 diff --git a/src/cpu/amd/agesa/family12/model_12_init.c b/src/cpu/amd/agesa/family12/model_12_init.c index afdfb3b..93aecad 100644 --- a/src/cpu/amd/agesa/family12/model_12_init.c +++ b/src/cpu/amd/agesa/family12/model_12_init.c @@ -54,9 +54,8 @@ /* zero the machine check error status registers */ msr.lo = 0; msr.hi = 0; - for (i = 0; i < 5; i++) { + for (i = 0; i < 5; i++) wrmsr(MC0_STATUS + (i * 4), msr); - } enable_cache(); diff --git a/src/cpu/amd/agesa/family14/model_14_init.c b/src/cpu/amd/agesa/family14/model_14_init.c index 257f81f..ffb856a 100644 --- a/src/cpu/amd/agesa/family14/model_14_init.c +++ b/src/cpu/amd/agesa/family14/model_14_init.c @@ -77,9 +77,8 @@ /* zero the machine check error status registers */ msr.lo = 0; msr.hi = 0; - for (i = 0; i < 6; i++) { + for (i = 0; i < 6; i++) wrmsr(MC0_STATUS + (i * 4), msr); - } /* Enable the local CPU APICs */ setup_lapic(); diff --git a/src/cpu/amd/agesa/family15tn/model_15_init.c b/src/cpu/amd/agesa/family15tn/model_15_init.c index 1e0375f..8ae184e 100644 --- a/src/cpu/amd/agesa/family15tn/model_15_init.c +++ b/src/cpu/amd/agesa/family15tn/model_15_init.c @@ -74,9 +74,8 @@ /* zero the machine check error status registers */ msr.lo = 0; msr.hi = 0; - for (i = 0; i < 6; i++) { + for (i = 0; i < 6; i++) wrmsr(MC0_STATUS + (i * 4), msr); - } /* Enable the local CPU APICs */ setup_lapic(); diff --git a/src/cpu/amd/agesa/family16kb/model_16_init.c b/src/cpu/amd/agesa/family16kb/model_16_init.c index 9909793..92c7bca 100644 --- a/src/cpu/amd/agesa/family16kb/model_16_init.c +++ b/src/cpu/amd/agesa/family16kb/model_16_init.c @@ -72,9 +72,8 @@ /* zero the machine check error status registers */ msr.lo = 0; msr.hi = 0; - for (i = 0; i < 6; i++) { + for (i = 0; i < 6; i++) wrmsr(MC0_STATUS + (i * 4), msr); - } /* Enable the local CPU APICs */ setup_lapic(); @@ -99,7 +98,6 @@ msr.hi &= ~(1 << (46 - 32)); wrmsr(NB_CFG_MSR, msr); - /* Write protect SMM space with SMMLOCK. */ msr = rdmsr(HWCR_MSR); msr.lo |= (1 << 0); diff --git a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c index 61eb813..74d4673 100644 --- a/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c +++ b/src/cpu/amd/family_10h-family_15h/model_10xxx_init.c @@ -111,9 +111,8 @@ /* zero the machine check error status registers */ msr.lo = 0; msr.hi = 0; - for (i = 0; i < 5; i++) { + for (i = 0; i < 5; i++) wrmsr(MC0_STATUS + (i * 4), msr); - } enable_cache(); diff --git a/src/cpu/amd/pi/00660F01/model_15_init.c b/src/cpu/amd/pi/00660F01/model_15_init.c index 24c2aea..0540a72 100644 --- a/src/cpu/amd/pi/00660F01/model_15_init.c +++ b/src/cpu/amd/pi/00660F01/model_15_init.c @@ -86,7 +86,6 @@ for (i = 0; i < 6; i++) wrmsr(MC0_STATUS + (i * 4), msr); - /* Enable the local CPU APICs */ setup_lapic(); diff --git a/src/cpu/amd/pi/00730F01/model_16_init.c b/src/cpu/amd/pi/00730F01/model_16_init.c index b9e0185..3ae841d 100644 --- a/src/cpu/amd/pi/00730F01/model_16_init.c +++ b/src/cpu/amd/pi/00730F01/model_16_init.c @@ -71,7 +71,6 @@ for (i = 0; i < 6; i++) wrmsr(MC0_STATUS + (i * 4), msr); - /* Enable the local CPU APICs */ setup_lapic(); @@ -95,7 +94,6 @@ msr.hi &= ~(1 << (46 - 32)); wrmsr(NB_CFG_MSR, msr); - /* Write protect SMM space with SMMLOCK. */ msr = rdmsr(HWCR_MSR); msr.lo |= (1 << 0); -- To view, visit https://review.coreboot.org/27935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I329ac03365e51799581c56eed27ee54de6826f14 Gerrit-Change-Number: 27935 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

Change in coreboot[master]: amd/stoneyridge: Dump MCA registers
by Marshall Dawson (Code Review) 07 Aug '18

07 Aug '18

Hello Marshall Dawson, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27926 to look at the new patch set (#2). Change subject: amd/stoneyridge: Dump MCA registers ...................................................................... amd/stoneyridge: Dump MCA registers Add a function to provide a rudimentary dump of the Machine Check Architecture registers. These values survive a warm reset. Change-Id: Ib6875cabe3041e65c811d8b2232f7ac6bedd1a02 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/stoneyridge/cpu.c 1 file changed, 47 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27926/2 -- To view, visit https://review.coreboot.org/27926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib6875cabe3041e65c811d8b2232f7ac6bedd1a02 Gerrit-Change-Number: 27926 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshall.dawson(a)scarletltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/amd: Correct number of MCA banks cleared
by Marshall Dawson (Code Review) 07 Aug '18

07 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27923 to look at the new patch set (#2). Change subject: cpu/amd: Correct number of MCA banks cleared ...................................................................... cpu/amd: Correct number of MCA banks cleared Use the value discovered in the MCG_CAP[Count] for the number of MCA status registers to clear. The generations should have the following number of banks: * Family 10h: 6 banks * Family 12h: 6 * Family 14h: 6 * Family 15h: 7 * Family 16h: 6 Change-Id: I0fc6d127a200b10fd484e051d84353cc61b27a41 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/cpu/amd/agesa/family12/model_12_init.c M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/family_10h-family_15h/model_10xxx_init.c M src/cpu/amd/pi/00630F01/model_15_init.c M src/cpu/amd/pi/00660F01/model_15_init.c M src/cpu/amd/pi/00730F01/model_16_init.c M src/include/cpu/amd/amdfam15.h M src/include/cpu/amd/amdfam16.h M src/northbridge/amd/amdmct/amddefs.h M src/soc/amd/stoneyridge/cpu.c 12 files changed, 45 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/27923/2 -- To view, visit https://review.coreboot.org/27923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0fc6d127a200b10fd484e051d84353cc61b27a41 Gerrit-Change-Number: 27923 Gerrit-PatchSet: 2 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Check for NULL pointer
by Philipp Deppenwiese (Code Review) 07 Aug '18

07 Aug '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/27933 ) Change subject: security/tpm: Check for NULL pointer ...................................................................... security/tpm: Check for NULL pointer Change bce49c2 (security/tpm: Improve TCPA log generation) missed checking for NULL pointer before accessing the tcpa_table returned by tcpa_log_init. This change fixes the boot hang observed on octopus by ensuring pointer is checked for NULL before using it. BUG=b:111403731 TEST=Verified that octopus boots up fine. Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2 Signed-off-by: Furquan Shaikh <furquan(a)google.com> Reviewed-on: https://review.coreboot.org/27933 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Justin TerAvest <teravest(a)chromium.org> Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> --- M src/security/tpm/tspi/log.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Justin TerAvest: Looks good to me, approved diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 0a6655a..17f6f1f 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -57,6 +57,10 @@ struct tcpa_entry *tce; tclt = tcpa_log_init(); + + if (!tclt) + return; + if (tclt->num_entries == tclt->max_entries) { printk(BIOS_WARNING, "ERROR: TCPA log table is full\n"); return; -- To view, visit https://review.coreboot.org/27933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2 Gerrit-Change-Number: 27933 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions
by Elyes HAOUAS (Code Review) 07 Aug '18

07 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27934 to look at the new patch set (#3). Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions ...................................................................... mb/biostar/am1ml: Use common pnp_{enter,exit} functions Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/biostar/am1ml/romstage.c M src/superio/ite/common/ite.h 2 files changed, 29 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27934/3 -- To view, visit https://review.coreboot.org/27934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Gerrit-Change-Number: 27934 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions
by Elyes HAOUAS (Code Review) 07 Aug '18

07 Aug '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27934 to look at the new patch set (#2). Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions ...................................................................... mb/biostar/am1ml: Use common pnp_{enter,exit} functions Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/biostar/am1ml/romstage.c M src/superio/ite/common/ite.h 2 files changed, 29 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27934/2 -- To view, visit https://review.coreboot.org/27934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Gerrit-Change-Number: 27934 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions
by build bot (Jenkins) (Code Review) 07 Aug '18

07 Aug '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27934 ) Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions ...................................................................... Patch Set 1: (65 comments) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… File src/mainboard/biostar/am1ml/romstage.c: https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 40: ite_sio_write(dev, 0xf1 , 0x40 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 40: ite_sio_write(dev, 0xf1 , 0x40 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 41: ite_sio_write(dev, 0xf4 , 0x80 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 41: ite_sio_write(dev, 0xf4 , 0x80 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 42: ite_sio_write(dev, 0xf5 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 42: ite_sio_write(dev, 0xf5 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 43: ite_sio_write(dev, 0xf6 , 0xf0 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 43: ite_sio_write(dev, 0xf6 , 0xf0 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 44: ite_sio_write(dev, 0xf9 , 0x48 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 44: ite_sio_write(dev, 0xf9 , 0x48 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 45: ite_sio_write(dev, 0xfa , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 45: ite_sio_write(dev, 0xfa , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 46: ite_sio_write(dev, 0xfb , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 46: ite_sio_write(dev, 0xfb , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 53: ite_sio_write (dev, 0x25 , 0x80 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 53: ite_sio_write (dev, 0x25 , 0x80 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 53: ite_sio_write (dev, 0x25 , 0x80 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 54: ite_sio_write (dev, 0x26 , 0x07 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 54: ite_sio_write (dev, 0x26 , 0x07 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 54: ite_sio_write (dev, 0x26 , 0x07 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 55: ite_sio_write (dev, 0x28 , 0x81 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 55: ite_sio_write (dev, 0x28 , 0x81 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 55: ite_sio_write (dev, 0x28 , 0x81 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 56: ite_sio_write (dev, 0x2c , 0x06 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 56: ite_sio_write (dev, 0x2c , 0x06 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 56: ite_sio_write (dev, 0x2c , 0x06 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 57: ite_sio_write (dev, 0x72 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 57: ite_sio_write (dev, 0x72 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 57: ite_sio_write (dev, 0x72 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 58: ite_sio_write (dev, 0x73 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 58: ite_sio_write (dev, 0x73 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 58: ite_sio_write (dev, 0x73 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 59: ite_sio_write (dev, 0xb3 , 0x01 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 59: ite_sio_write (dev, 0xb3 , 0x01 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 59: ite_sio_write (dev, 0xb3 , 0x01 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 60: ite_sio_write (dev, 0xb8 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 60: ite_sio_write (dev, 0xb8 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 60: ite_sio_write (dev, 0xb8 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 61: ite_sio_write (dev, 0xc0 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 61: ite_sio_write (dev, 0xc0 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 61: ite_sio_write (dev, 0xc0 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 62: ite_sio_write (dev, 0xc3 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 62: ite_sio_write (dev, 0xc3 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 62: ite_sio_write (dev, 0xc3 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 63: ite_sio_write (dev, 0xc8 , 0x00 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 63: ite_sio_write (dev, 0xc8 , 0x00 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 63: ite_sio_write (dev, 0xc8 , 0x00 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 64: ite_sio_write (dev, 0xc9 , 0x07 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 64: ite_sio_write (dev, 0xc9 , 0x07 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 64: ite_sio_write (dev, 0xc9 , 0x07 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 65: ite_sio_write (dev, 0xcb , 0x01 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 65: ite_sio_write (dev, 0xcb , 0x01 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 65: ite_sio_write (dev, 0xcb , 0x01 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 66: ite_sio_write (dev, 0xf0 , 0x10 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 66: ite_sio_write (dev, 0xf0 , 0x10 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 66: ite_sio_write (dev, 0xf0 , 0x10 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 67: ite_sio_write (dev, 0xf4 , 0x27 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 67: ite_sio_write (dev, 0xf4 , 0x27 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 67: ite_sio_write (dev, 0xf4 , 0x27 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 68: ite_sio_write (dev, 0xf8 , 0x20 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 68: ite_sio_write (dev, 0xf8 , 0x20 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 68: ite_sio_write (dev, 0xf8 , 0x20 ); space prohibited before that close parenthesis ')' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 69: ite_sio_write (dev, 0xf9 , 0x01 ); space prohibited between function name and open parenthesis '(' https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 69: ite_sio_write (dev, 0xf9 , 0x01 ); space prohibited before that ',' (ctx:WxW) https://review.coreboot.org/#/c/27934/1/src/mainboard/biostar/am1ml/romstag… PS1, Line 69: ite_sio_write (dev, 0xf9 , 0x01 ); space prohibited before that close parenthesis ')' -- To view, visit https://review.coreboot.org/27934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Gerrit-Change-Number: 27934 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 07 Aug 2018 17:14:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/biostar/am1ml: Use common pnp_{enter, exit} functions
by Elyes HAOUAS (Code Review) 07 Aug '18

07 Aug '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/27934 Change subject: mb/biostar/am1ml: Use common pnp_{enter,exit} functions ...................................................................... mb/biostar/am1ml: Use common pnp_{enter,exit} functions Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/biostar/am1ml/romstage.c 1 file changed, 28 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/27934/1 diff --git a/src/mainboard/biostar/am1ml/romstage.c b/src/mainboard/biostar/am1ml/romstage.c index 7caa4dc..2512e51 100644 --- a/src/mainboard/biostar/am1ml/romstage.c +++ b/src/mainboard/biostar/am1ml/romstage.c @@ -34,62 +34,40 @@ #define MMIO_NON_POSTED_END 0xfedfffff #define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x)) - -static void it_sio_write(pnp_devfn_t dev, u8 reg, u8 value) -{ - pnp_set_logical_device(dev); - pnp_write_config(dev, reg, value); -} - -static void ite_enter_conf(pnp_devfn_t dev) -{ - u16 port = dev >> 8; - - outb(0x87, port); - outb(0x01, port); - outb(0x55, port); - outb((port == 0x4e) ? 0xaa : 0x55, port); -} - -static void ite_exit_conf(pnp_devfn_t dev) -{ - it_sio_write(dev, ITE_CONFIG_REG_CC, 0x02); -} - static void ite_evc_conf(pnp_devfn_t dev) { - ite_enter_conf(dev); - it_sio_write(dev, 0xf1 , 0x40 ); - it_sio_write(dev, 0xf4 , 0x80 ); - it_sio_write(dev, 0xf5 , 0x00 ); - it_sio_write(dev, 0xf6 , 0xf0 ); - it_sio_write(dev, 0xf9 , 0x48 ); - it_sio_write(dev, 0xfa , 0x00 ); - it_sio_write(dev, 0xfb , 0x00 ); - ite_exit_conf(dev); + pnp_enter_conf_state(dev); + ite_sio_write(dev, 0xf1 , 0x40 ); + ite_sio_write(dev, 0xf4 , 0x80 ); + ite_sio_write(dev, 0xf5 , 0x00 ); + ite_sio_write(dev, 0xf6 , 0xf0 ); + ite_sio_write(dev, 0xf9 , 0x48 ); + ite_sio_write(dev, 0xfa , 0x00 ); + ite_sio_write(dev, 0xfb , 0x00 ); + pnp_exit_conf_state(dev); } static void ite_gpio_conf(pnp_devfn_t dev) { - ite_enter_conf (dev); - it_sio_write (dev, 0x25 , 0x80 ); - it_sio_write (dev, 0x26 , 0x07 ); - it_sio_write (dev, 0x28 , 0x81 ); - it_sio_write (dev, 0x2c , 0x06 ); - it_sio_write (dev, 0x72 , 0x00 ); - it_sio_write (dev, 0x73 , 0x00 ); - it_sio_write (dev, 0xb3 , 0x01 ); - it_sio_write (dev, 0xb8 , 0x00 ); - it_sio_write (dev, 0xc0 , 0x00 ); - it_sio_write (dev, 0xc3 , 0x00 ); - it_sio_write (dev, 0xc8 , 0x00 ); - it_sio_write (dev, 0xc9 , 0x07 ); - it_sio_write (dev, 0xcb , 0x01 ); - it_sio_write (dev, 0xf0 , 0x10 ); - it_sio_write (dev, 0xf4 , 0x27 ); - it_sio_write (dev, 0xf8 , 0x20 ); - it_sio_write (dev, 0xf9 , 0x01 ); - ite_exit_conf (dev); + pnp_enter_conf_state(dev); + ite_sio_write (dev, 0x25 , 0x80 ); + ite_sio_write (dev, 0x26 , 0x07 ); + ite_sio_write (dev, 0x28 , 0x81 ); + ite_sio_write (dev, 0x2c , 0x06 ); + ite_sio_write (dev, 0x72 , 0x00 ); + ite_sio_write (dev, 0x73 , 0x00 ); + ite_sio_write (dev, 0xb3 , 0x01 ); + ite_sio_write (dev, 0xb8 , 0x00 ); + ite_sio_write (dev, 0xc0 , 0x00 ); + ite_sio_write (dev, 0xc3 , 0x00 ); + ite_sio_write (dev, 0xc8 , 0x00 ); + ite_sio_write (dev, 0xc9 , 0x07 ); + ite_sio_write (dev, 0xcb , 0x01 ); + ite_sio_write (dev, 0xf0 , 0x10 ); + ite_sio_write (dev, 0xf4 , 0x27 ); + ite_sio_write (dev, 0xf8 , 0x20 ); + ite_sio_write (dev, 0xf9 , 0x01 ); + pnp_exit_conf_state(dev); } void board_BeforeAgesa(struct sysinfo *cb) -- To view, visit https://review.coreboot.org/27934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73b8811767da1b0356cffb6a26553400b2f10841 Gerrit-Change-Number: 27934 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: security/tpm: Check for NULL pointer
by Furquan Shaikh (Code Review) 07 Aug '18

07 Aug '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27933 Change subject: security/tpm: Check for NULL pointer ...................................................................... security/tpm: Check for NULL pointer Change bce49c2 missed checking for NULL pointer before accessing the tcpa_table returned by tcpa_log_init. This change fixes the boot hang observed on octopus by ensuring pointer is checked for NULL before using it. BUG=b:111403731 TEST=Verified that octopus boots up fine. Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/security/tpm/tspi/log.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/27933/1 diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 0a6655a..17f6f1f 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -57,6 +57,10 @@ struct tcpa_entry *tce; tclt = tcpa_log_init(); + + if (!tclt) + return; + if (tclt->num_entries == tclt->max_entries) { printk(BIOS_WARNING, "ERROR: TCPA log table is full\n"); return; -- To view, visit https://review.coreboot.org/27933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2e46197065f8db1dc028a85551546263e60d46b2 Gerrit-Change-Number: 27933 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2018