Matt Delco has posted comments on this change. ( https://review.coreboot.org/27347 )
Change subject: google: Use proper ACPI ID for Semtech chips: STH
......................................................................
Patch Set 2: Code-Review+1
The change looks more standards-compliant to me.
--
To view, visit https://review.coreboot.org/27347
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85cd567a923cccd2504f351aae276b5f0d9db4de
Gerrit-Change-Number: 27347
Gerrit-PatchSet: 2
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Matt Delco <delco(a)google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 03 Jul 2018 21:50:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello Seunghwan Kim, build bot (Jenkins), Matt Delco, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27347
to look at the new patch set (#2).
Change subject: google: Use proper ACPI ID for Semtech chips: STH
......................................................................
google: Use proper ACPI ID for Semtech chips: STH
Change-Id: I85cd567a923cccd2504f351aae276b5f0d9db4de
Signed-off-by: Gwendal Grignou <gwendal(a)chromium.org>
---
M src/drivers/i2c/sx9310/sx9310.c
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
M src/mainboard/google/zoombini/variants/meowth/devicetree.cb
3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/27347/2
--
To view, visit https://review.coreboot.org/27347
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85cd567a923cccd2504f351aae276b5f0d9db4de
Gerrit-Change-Number: 27347
Gerrit-PatchSet: 2
Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Matt Delco <delco(a)chromium.org>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/27344 )
Change subject: mb/ibase/mb899: Remove unneeded includes
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/27344
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee237206f309409be64307d2daee044da52a05e1
Gerrit-Change-Number: 27344
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 03 Jul 2018 16:47:35 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Martin Roth has posted comments on this change. ( https://review.coreboot.org/27327 )
Change subject: google/grunt: Update Raydium TS device ACPI nodes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/27327
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff3acf4199d23b29dff209ec1c03a731679c6cbe
Gerrit-Change-Number: 27327
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Tue, 03 Jul 2018 14:18:54 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27331 )
Change subject: src: Get rid of non-local header treated as local
......................................................................
Patch Set 1:
No Builds Executed
--
To view, visit https://review.coreboot.org/27331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c5edadfd035c9af08af9ee326a5a2dc8b840faa
Gerrit-Change-Number: 27331
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 03 Jul 2018 13:02:35 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No