coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: nocturne: Fix casing for register definition
by Patrick Georgi (Code Review) 02 Jul '18

02 Jul '18

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27264 ) Change subject: nocturne: Fix casing for register definition ...................................................................... nocturne: Fix casing for register definition Use lower case for hex values. BUG=b:74363445 TEST=compile Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127 Signed-off-by: Gwendal Grignou <gwendal(a)chromium.org> Reviewed-on: https://review.coreboot.org/27264 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/poppy/variants/nocturne/devicetree.cb 1 file changed, 14 insertions(+), 14 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb index 91c0b44..09b7ef9 100644 --- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb @@ -305,15 +305,15 @@ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)" register "speed" = "I2C_SPEED_FAST_PLUS" register "uid" = "0" - register "reg_prox_ctrl0" = "0x1A" + register "reg_prox_ctrl0" = "0x1a" register "reg_prox_ctrl1" = "0x00" register "reg_prox_ctrl2" = "0x84" - register "reg_prox_ctrl3" = "0x0E" + register "reg_prox_ctrl3" = "0x0e" register "reg_prox_ctrl4" = "0x07" - register "reg_prox_ctrl5" = "0xC6" + register "reg_prox_ctrl5" = "0xc6" register "reg_prox_ctrl6" = "0x20" - register "reg_prox_ctrl7" = "0x0D" - register "reg_prox_ctrl8" = "0x8D" + register "reg_prox_ctrl7" = "0x0d" + register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" register "reg_prox_ctrl10" = "0x11" register "reg_prox_ctrl11" = "0x00" @@ -326,8 +326,8 @@ register "reg_prox_ctrl18" = "0x00" register "reg_prox_ctrl19" = "0x00" register "reg_sar_ctrl0" = "0x50" - register "reg_sar_ctrl1" = "0x8A" - register "reg_sar_ctrl2" = "0x3C" + register "reg_sar_ctrl1" = "0x8a" + register "reg_sar_ctrl2" = "0x3c" device i2c 28 on end end end # I2C #1 @@ -346,15 +346,15 @@ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D10_IRQ)" register "speed" = "I2C_SPEED_FAST_PLUS" register "uid" = "1" - register "reg_prox_ctrl0" = "0x1A" + register "reg_prox_ctrl0" = "0x1a" register "reg_prox_ctrl1" = "0x00" register "reg_prox_ctrl2" = "0x84" - register "reg_prox_ctrl3" = "0x0E" + register "reg_prox_ctrl3" = "0x0e" register "reg_prox_ctrl4" = "0x07" - register "reg_prox_ctrl5" = "0xC6" + register "reg_prox_ctrl5" = "0xc6" register "reg_prox_ctrl6" = "0x20" - register "reg_prox_ctrl7" = "0x0D" - register "reg_prox_ctrl8" = "0x8D" + register "reg_prox_ctrl7" = "0x0d" + register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl9" = "0x43" register "reg_prox_ctrl10" = "0x11" register "reg_prox_ctrl11" = "0x00" @@ -367,8 +367,8 @@ register "reg_prox_ctrl18" = "0x00" register "reg_prox_ctrl19" = "0x00" register "reg_sar_ctrl0" = "0x50" - register "reg_sar_ctrl1" = "0x8A" - register "reg_sar_ctrl2" = "0x3C" + register "reg_sar_ctrl1" = "0x8a" + register "reg_sar_ctrl2" = "0x3c" device i2c 28 on end end end # I2C #5 -- To view, visit https://review.coreboot.org/27264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I24afea58b1a791fac3c87ad397a696f7f6e0d127 Gerrit-Change-Number: 27264 Gerrit-PatchSet: 2 Gerrit-Owner: Gwendal Grignou <gwendal(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: ec/google/chromeec: Remove keyboard initialization
by build bot (Jenkins) (Code Review) 02 Jul '18

02 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27293 ) Change subject: ec/google/chromeec: Remove keyboard initialization ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29696/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75641/ : SUCCESS -- To view, visit https://review.coreboot.org/27293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0b56abe0a5990e527277eaf3397e00dccda3e50 Gerrit-Change-Number: 27293 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Jul 2018 06:01:57 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/*: Remove selection of DRIVERS_PS2_KEYBOARD
by build bot (Jenkins) (Code Review) 02 Jul '18

02 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27291 ) Change subject: mb/google/*: Remove selection of DRIVERS_PS2_KEYBOARD ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75639/ : SUCCESS -- To view, visit https://review.coreboot.org/27291 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f49b060eb005c0f2b86f9d68d6758954eeb3cf0 Gerrit-Change-Number: 27291 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Jul 2018 06:01:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/intel/glkrvp: Get rid of DRIVERS_PS2_KEYBOARD selection
by build bot (Jenkins) (Code Review) 02 Jul '18

02 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27292 ) Change subject: mb/intel/glkrvp: Get rid of DRIVERS_PS2_KEYBOARD selection ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/75640/ : SUCCESS -- To view, visit https://review.coreboot.org/27292 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9af48e648231c18f98d0cc1ddd178b8d00082b0a Gerrit-Change-Number: 27292 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Jul 2018 05:58:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/intel/dg41wv: Expose some SIO devices via ACPI
by build bot (Jenkins) (Code Review) 01 Jul '18

01 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27120 ) Change subject: mb/intel/dg41wv: Expose some SIO devices via ACPI ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29694/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75637/ : SUCCESS -- To view, visit https://review.coreboot.org/27120 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia658c117434c3fae45bbbe6c472ca58ba4f1a117 Gerrit-Change-Number: 27120 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Jul 2018 13:10:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/intel/dg43gt: Expose some SIO devices via ACPI
by build bot (Jenkins) (Code Review) 01 Jul '18

01 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27298 ) Change subject: mb/intel/dg43gt: Expose some SIO devices via ACPI ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/29695/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/75638/ : SUCCESS -- To view, visit https://review.coreboot.org/27298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0df578b98c5b346caa6f6df5fdabda28788e6b66 Gerrit-Change-Number: 27298 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Jul 2018 12:59:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/intel/dg43gt: Expose some SIO devices via ACPI
by Arthur Heymans (Code Review) 01 Jul '18

01 Jul '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/27298 Change subject: mb/intel/dg43gt: Expose some SIO devices via ACPI ...................................................................... mb/intel/dg43gt: Expose some SIO devices via ACPI Change-Id: I0df578b98c5b346caa6f6df5fdabda28788e6b66 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/intel/dg43gt/acpi/superio.asl 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/27298/1 diff --git a/src/mainboard/intel/dg43gt/acpi/superio.asl b/src/mainboard/intel/dg43gt/acpi/superio.asl index 2997587..2fc3d8e 100644 --- a/src/mainboard/intel/dg43gt/acpi/superio.asl +++ b/src/mainboard/intel/dg43gt/acpi/superio.asl @@ -1 +1,27 @@ -/* dummy */ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#undef SUPERIO_DEV +#undef SUPERIO_PNP_BASE +#undef W83627DHG_SHOW_UARTA +#undef W83627DHG_SHOW_UARTB +#undef W83627DHG_SHOW_KBC +#undef W83627DHG_SHOW_PS2M +#undef W83627DHG_SHOW_HWMON +#define SUPERIO_DEV SIO0 +#define SUPERIO_PNP_BASE 0x2e +#define W83627DHG_SHOW_UARTA +#define W83627DHG_SHOW_KBC +#define W83627DHG_SHOW_PS2M +#define W83627DHG_SHOW_HWMON +#include <superio/winbond/w83627dhg/acpi/superio.asl> -- To view, visit https://review.coreboot.org/27298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0df578b98c5b346caa6f6df5fdabda28788e6b66 Gerrit-Change-Number: 27298 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018