coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: riscv: temporarily block multiple-threads
by build bot (Jenkins) (Code Review) 04 Jul '18

04 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27348 ) Change subject: riscv: temporarily block multiple-threads ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/#/c/27348/4/src/arch/riscv/include/smp.h File src/arch/riscv/include/smp.h: https://review.coreboot.org/#/c/27348/4/src/arch/riscv/include/smp.h@42 PS4, Line 42: * // `SMP_SYNC` is not required，when other hart no need to wait for the single-threaded work trailing whitespace https://review.coreboot.org/#/c/27348/4/src/arch/riscv/include/smp.h@42 PS4, Line 42: * // `SMP_SYNC` is not required，when other hart no need to wait for the single-threaded work line over 80 characters -- To view, visit https://review.coreboot.org/27348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf58db6cddd44cfc17f5dfb3a5ccc0e12a49536 Gerrit-Change-Number: 27348 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward (1001664) Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 14:23:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/intel/d945gclf/romstage.c: Remove unneeded includes
by Elyes HAOUAS (Code Review) 04 Jul '18

04 Jul '18

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27345 to look at the new patch set (#2). Change subject: mb/intel/d945gclf/romstage.c: Remove unneeded includes ...................................................................... mb/intel/d945gclf/romstage.c: Remove unneeded includes Change-Id: I3bdb93e51cabbfc14fe992ccdb6556e344e03c2f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/d945gclf/romstage.c 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/27345/2 -- To view, visit https://review.coreboot.org/27345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3bdb93e51cabbfc14fe992ccdb6556e344e03c2f Gerrit-Change-Number: 27345 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/ibase/mb899: Remove unneeded includes
by Elyes HAOUAS (Code Review) 04 Jul '18

04 Jul '18

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27344 to look at the new patch set (#4). Change subject: mb/ibase/mb899: Remove unneeded includes ...................................................................... mb/ibase/mb899: Remove unneeded includes Change-Id: Iee237206f309409be64307d2daee044da52a05e1 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/ibase/mb899/mainboard.c M src/mainboard/ibase/mb899/romstage.c 2 files changed, 8 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/27344/4 -- To view, visit https://review.coreboot.org/27344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iee237206f309409be64307d2daee044da52a05e1 Gerrit-Change-Number: 27344 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: riscv: temporarily block multiple-threads
by Jonathan Neuschäfer (Code Review) 04 Jul '18

04 Jul '18

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/27348 ) Change subject: riscv: temporarily block multiple-threads ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/27348/2/src/arch/riscv/include/smp.h File src/arch/riscv/include/smp.h: https://review.coreboot.org/#/c/27348/2/src/arch/riscv/include/smp.h@2 PS2, Line 2: * Copyright (c) 2013, The Regents of the University of California (Regents). Unless this code is copied from UCB code, please use your own copyright line. https://review.coreboot.org/#/c/27348/2/src/arch/riscv/include/smp.h@44 PS2, Line 44: * ... multi-threaded work ... This approach is more readable. Thanks. -- To view, visit https://review.coreboot.org/27348 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedf58db6cddd44cfc17f5dfb3a5ccc0e12a49536 Gerrit-Change-Number: 27348 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward (1001664) Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 12:45:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/ibase/mb899: Remove unneeded includes
by Arthur Heymans (Code Review) 04 Jul '18

04 Jul '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27344 ) Change subject: mb/ibase/mb899: Remove unneeded includes ...................................................................... Patch Set 3: Code-Review-2 (1 comment) https://review.coreboot.org/#/c/27344/3/src/mainboard/ibase/mb899/romstage.c File src/mainboard/ibase/mb899/romstage.c: https://review.coreboot.org/#/c/27344/3/src/mainboard/ibase/mb899/romstage.… PS3, Line 39: pci_write_config8 comes from arch/io.h -- To view, visit https://review.coreboot.org/27344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee237206f309409be64307d2daee044da52a05e1 Gerrit-Change-Number: 27344 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 11:23:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/intel/d945gclf/romstage.c: Remove unneeded includes
by Arthur Heymans (Code Review) 04 Jul '18

04 Jul '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27345 ) Change subject: mb/intel/d945gclf/romstage.c: Remove unneeded includes ...................................................................... Patch Set 1: Code-Review-2 (1 comment) https://review.coreboot.org/#/c/27345/1/src/mainboard/intel/d945gclf/romsta… File src/mainboard/intel/d945gclf/romstage.c: https://review.coreboot.org/#/c/27345/1/src/mainboard/intel/d945gclf/romsta… PS1, Line 37: pci_write_config8 this comes from arch/io.h -- To view, visit https://review.coreboot.org/27345 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bdb93e51cabbfc14fe992ccdb6556e344e03c2f Gerrit-Change-Number: 27345 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 11:12:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium: Enable DRAM test
by build bot (Jenkins) (Code Review) 04 Jul '18

04 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27103 ) Change subject: soc/cavium: Enable DRAM test ...................................................................... Patch Set 2: (2 comments) https://review.coreboot.org/#/c/27103/2/src/soc/cavium/cn81xx/sdram.c File src/soc/cavium/cn81xx/sdram.c: https://review.coreboot.org/#/c/27103/2/src/soc/cavium/cn81xx/sdram.c@87 PS2, Line 87: if (0 != bdk_numa_master()) Comparisons should place the constant on the right side of the test https://review.coreboot.org/#/c/27103/2/src/soc/cavium/cn81xx/sdram.c@91 PS2, Line 91: if (0 == bdk_numa_master()) Comparisons should place the constant on the right side of the test -- To view, visit https://review.coreboot.org/27103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a375f3d4c5cea7c3c0cd4592287f3f85dc7d3cf Gerrit-Change-Number: 27103 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 10:32:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/cavium: Apply additional devicetree fixups
by build bot (Jenkins) (Code Review) 04 Jul '18

04 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 ) Change subject: soc/cavium: Apply additional devicetree fixups ...................................................................... Patch Set 35: (4 comments) https://review.coreboot.org/#/c/25382/35/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25382/35/src/soc/cavium/cn81xx/soc.c@83 PS35, Line 83: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'? https://review.coreboot.org/#/c/25382/35/src/soc/cavium/cn81xx/soc.c@141 PS35, Line 141: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters https://review.coreboot.org/#/c/25382/35/src/soc/cavium/cn81xx/soc.c@173 PS35, Line 173: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/25382/35/src/soc/cavium/cn81xx/soc.c@269 PS35, Line 269: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters -- To view, visit https://review.coreboot.org/25382 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e8eefd913915a879dad28dfb7801a2018ed2985 Gerrit-Change-Number: 25382 Gerrit-PatchSet: 35 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 10:26:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF
by build bot (Jenkins) (Code Review) 04 Jul '18

04 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25751 ) Change subject: [HACK]cavium/arm-trusted-firmware: Use 9elements ATF ...................................................................... Patch Set 24: (2 comments) https://review.coreboot.org/#/c/25751/24/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c: https://review.coreboot.org/#/c/25751/24/src/soc/cavium/cn81xx/soc.c@73 PS24, Line 73: void *ptr = cbfs_boot_map_with_leak("sff8104-linux.dtb", CBFS_TYPE_RAW, &size); line over 80 characters https://review.coreboot.org/#/c/25751/24/src/soc/cavium/common/include/soc/… File src/soc/cavium/common/include/soc/bl31_plat_params.h: https://review.coreboot.org/#/c/25751/24/src/soc/cavium/common/include/soc/… PS24, Line 21: #include <soc/cavium/common/arm-trusted-firmware/plat/cavium/common/include/plat_params.h> line over 80 characters -- To view, visit https://review.coreboot.org/25751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e9eb429d11150d43aa070d1bd6a11ea71951ce3 Gerrit-Change-Number: 25751 Gerrit-PatchSet: 24 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 04 Jul 2018 10:21:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/atlas: MIPI camera ASL files for Atlas
by Ping-chung Chen (Code Review) 04 Jul '18

04 Jul '18

Hello Rajmohan Mani, JasonX Z Chen, Andy Yeh, Hyungwoo Yang, Rizwan Qureshi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27350 to look at the new patch set (#5). Change subject: mb/google/atlas: MIPI camera ASL files for Atlas ...................................................................... mb/google/atlas: MIPI camera ASL files for Atlas Atlas has one sensor, create a single endpoint to CIO2. create power resource for enabling/disabling camera. BUG=b:111141128 Branch=None TEST=Testing (WIP) on Atlas board Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Signed-off-by: Ping-Chung Chen <ping-chung.chen(a)intel.com> Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M src/mainboard/google/poppy/Kconfig M src/mainboard/google/poppy/variants/atlas/devicetree.cb A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/camera.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_endpoints.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/ipu_mainboard.asl A src/mainboard/google/poppy/variants/atlas/include/variant/acpi/mipi_camera.asl M src/mainboard/google/poppy/variants/atlas/include/variant/gpio.h 7 files changed, 233 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/27350/5 -- To view, visit https://review.coreboot.org/27350 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide0e923bbc34f869dd0227c0a29977645bc5d58d Gerrit-Change-Number: 27350 Gerrit-PatchSet: 5 Gerrit-Owner: Ping-chung Chen <ping-chung.chen(a)intel.com> Gerrit-Reviewer: Andy Yeh <andy.yeh(a)intel.com> Gerrit-Reviewer: Hyungwoo Yang <hyungwoo.yang(a)intel.com> Gerrit-Reviewer: JasonX Z Chen <jasonx.z.chen(a)intel.com> Gerrit-Reviewer: Rajmohan Mani <rajmohan.mani(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
77
78
79
80
81
82
83
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018