coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: mb/google/parrot/smihandler: Use new PMBASE API
by Patrick Rudolph (Code Review) 28 Jul '18

28 Jul '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27679 to look at the new patch set (#2). Change subject: mb/google/parrot/smihandler: Use new PMBASE API ...................................................................... mb/google/parrot/smihandler: Use new PMBASE API Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 3 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/27679/2 -- To view, visit https://review.coreboot.org/27679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e Gerrit-Change-Number: 27679 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/samsung/lumpy/smihandler: Use new PMBASE API
by Patrick Rudolph (Code Review) 28 Jul '18

28 Jul '18

Patrick Rudolph has abandoned this change. ( https://review.coreboot.org/27680 ) Change subject: mb/samsung/lumpy/smihandler: Use new PMBASE API ...................................................................... Abandoned duplicate -- To view, visit https://review.coreboot.org/27680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I82287e52cf637381becfd27301d562e7829bb665 Gerrit-Change-Number: 27680 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/samsung/lumpy/smihandler: Use new PMBASE API
by Patrick Rudolph (Code Review) 28 Jul '18

28 Jul '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27680 Change subject: mb/samsung/lumpy/smihandler: Use new PMBASE API ...................................................................... mb/samsung/lumpy/smihandler: Use new PMBASE API Change-Id: I82287e52cf637381becfd27301d562e7829bb665 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/samsung/lumpy/smihandler.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/27680/1 diff --git a/src/mainboard/samsung/lumpy/smihandler.c b/src/mainboard/samsung/lumpy/smihandler.c index 9690aee..f2c2dc3 100644 --- a/src/mainboard/samsung/lumpy/smihandler.c +++ b/src/mainboard/samsung/lumpy/smihandler.c @@ -19,6 +19,7 @@ #include <southbridge/intel/bd82x6x/nvs.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/me.h> +#include <southbridge/intel/common/pmbase.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <cpu/intel/model_206ax/model_206ax.h> #include <ec/smsc/mec1308/ec.h> @@ -27,7 +28,6 @@ static u8 mainboard_smi_ec(void) { u8 cmd; - u32 pm1_cnt; cmd = read_ec_command_byte(EC_GET_SMI_CAUSE); @@ -36,9 +36,7 @@ printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n"); /* Go to S5 */ - pm1_cnt = inl(smm_get_pmbase() + PM1_CNT); - pm1_cnt |= (0xf << 10); - outl(pm1_cnt, smm_get_pmbase() + PM1_CNT); + write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); break; } -- To view, visit https://review.coreboot.org/27680 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I82287e52cf637381becfd27301d562e7829bb665 Gerrit-Change-Number: 27680 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mb/google/parrot/smihandler: Use new PMBASE API
by Patrick Rudolph (Code Review) 28 Jul '18

28 Jul '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27679 Change subject: mb/google/parrot/smihandler: Use new PMBASE API ...................................................................... mb/google/parrot/smihandler: Use new PMBASE API Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/mainboard/google/parrot/smihandler.c 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/27679/1 diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index 7681065..c8f4063 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -20,6 +20,7 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/common/pmutil.h> +#include <southbridge/intel/common/pmbase.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <cpu/intel/model_206ax/model_206ax.h> #include <elog.h> @@ -54,9 +55,7 @@ elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED); #endif /* Go to S5 */ - pm1_cnt = inl(smm_get_pmbase() + PM1_CNT); - pm1_cnt |= (0xf << 10); - outl(pm1_cnt, smm_get_pmbase() + PM1_CNT); + write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); break; } @@ -65,8 +64,6 @@ void mainboard_smi_gpi(u32 gpi_sts) { - u32 pm1_cnt; - printk(BIOS_DEBUG, "mainboard_smi_gpi: %x\n", gpi_sts); if (gpi_sts & (1 << EC_SMI_GPI)) { /* Process all pending events from EC */ @@ -79,9 +76,7 @@ elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_LID_CLOSED); #endif /* Go to S5 */ - pm1_cnt = inl(smm_get_pmbase() + PM1_CNT); - pm1_cnt |= (0xf << 10); - outl(pm1_cnt, smm_get_pmbase() + PM1_CNT); + write_pmbase32(PM1_CNT, read_pmbase32(PM1_CNT) | (0xf << 10)); } } -- To view, visit https://review.coreboot.org/27679 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie95d9c04375e0125bae9bc01ae5caef423faf33e Gerrit-Change-Number: 27679 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: sb/intel/common: Improve TCO code
by Patrick Rudolph (Code Review) 28 Jul '18

28 Jul '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27678 Change subject: sb/intel/common: Improve TCO code ...................................................................... sb/intel/common: Improve TCO code * Use register access like on soc/intel * Fix comment spelling * Report unhandled TCO bits in SMM (was dead code) Change-Id: I5f0b439325227f3fb9f409a56f66256b5a9587d0 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/southbridge/intel/common/pmutil.c M src/southbridge/intel/common/pmutil.h M src/southbridge/intel/common/smihandler.c 3 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27678/1 diff --git a/src/southbridge/intel/common/pmutil.c b/src/southbridge/intel/common/pmutil.c index ac72eba..06659fa 100644 --- a/src/southbridge/intel/common/pmutil.c +++ b/src/southbridge/intel/common/pmutil.c @@ -163,18 +163,22 @@ */ u32 reset_tco_status(void) { - u32 reg32; + u16 tco1_sts; + u16 tco2_sts; - reg32 = read_pmbase32(TCO1_STS); + tco1_sts = read_pmbase16(TCO1_STS); + write_pmbas16(TCO1_STS, tco1_sts); + /* - * set status bits are cleared by writing 1 to them, but don't + * Status bits are cleared by writing 1 to them, but don't * clear BOOT_STS before SECOND_TO_STS. */ - write_pmbase32(TCO1_STS, reg32 & ~BOOT_STS); - if (reg32 & BOOT_STS) - write_pmbase32(TCO1_STS, BOOT_STS); + tco2_sts = read_pmbase16(TCO2_STS); + write_pmbas16(TCO2_STS, tco2_sts & ~BOOT_STS); + if (tco2_sts & BOOT_STS) + write_pmbas16(TCO2_STS, BOOT_STS); - return reg32; + return (tco2_sts << 16) | tco1_sts; } diff --git a/src/southbridge/intel/common/pmutil.h b/src/southbridge/intel/common/pmutil.h index 273e0f8..47fa103 100644 --- a/src/southbridge/intel/common/pmutil.h +++ b/src/southbridge/intel/common/pmutil.h @@ -96,8 +96,8 @@ #define C3_RES 0x54 #define TCO1_STS 0x64 #define DMISCI_STS (1 << 9) -#define BOOT_STS (1 << 18) #define TCO2_STS 0x66 +#define BOOT_STS (1 << 2) #define TCO1_CNT 0x68 #define TCO_LOCK (1 << 12) #define TCO2_CNT 0x6a diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index fb2fe59..9dfbaa9 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -417,16 +417,15 @@ * resolute answer would be to power down the * box. */ - printk(BIOS_DEBUG, "Switching back to RO\n"); + printk(BIOS_DEBUG, "Switching BIOS_CNTL back to RO\n"); pci_write_config32(PCI_DEV(0, 0x1f, 0), 0xdc, (bios_cntl & ~1)); } /* No else for now? */ } else if (tco_sts & (1 << 3)) { /* TIMEOUT */ /* Handle TCO timeout */ printk(BIOS_DEBUG, "TCO Timeout.\n"); - } else if (!tco_sts) { + } else dump_tco_status(tco_sts); - } } static void southbridge_smi_periodic(void) -- To view, visit https://review.coreboot.org/27678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5f0b439325227f3fb9f409a56f66256b5a9587d0 Gerrit-Change-Number: 27678 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nami: Enable Slow Slew rate
by TH Lin (Code Review) 28 Jul '18

28 Jul '18

Hello Arthur Heymans, Kane Chen, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27677 to look at the new patch set (#2). Change subject: mb/google/poppy/variant/nami: Enable Slow Slew rate ...................................................................... mb/google/poppy/variant/nami: Enable Slow Slew rate Send VR mailbox command for IA/GT/SA rails BUG=b:111912585 BRANCH=nami TEST=emerge-nami coreboot chromeos-bootimage Change-Id: Iaf3c7ed97696b1d13eb9a2c82e0a8ae09620ede5 Signed-off-by: T.H. Lin <t.h_lin(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27677/2 -- To view, visit https://review.coreboot.org/27677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iaf3c7ed97696b1d13eb9a2c82e0a8ae09620ede5 Gerrit-Change-Number: 27677 Gerrit-PatchSet: 2 Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nami: Enable Slow Slew rate
by TH Lin (Code Review) 28 Jul '18

28 Jul '18

TH Lin has uploaded this change for review. ( https://review.coreboot.org/27677 Change subject: mb/google/poppy/variant/nami: Enable Slow Slew rate ...................................................................... mb/google/poppy/variant/nami: Enable Slow Slew rate Send VR mailbox command for IA/GT/SA rails BUG=None BRANCH=nami TEST=emerge-nami coreboot chromeos-bootimage Change-Id: Iaf3c7ed97696b1d13eb9a2c82e0a8ae09620ede5 Signed-off-by: T.H. Lin <t.h_lin(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/mainboard.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/27677/1 diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 8080c94..b260cd2 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -83,6 +83,13 @@ /* Disable unused port USB port */ cfg->usb2_ports[5].enable = 0; break; + case SKU_0_AKALI: + case SKU_1_AKALI: + case SKU_0_AKALI360: + case SKU_1_AKALI360: + /*send VR mailbox command for IA/GT/SA rails*/ + cfg->IslVrCmd = 2; + break; default: break; } -- To view, visit https://review.coreboot.org/27677 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf3c7ed97696b1d13eb9a2c82e0a8ae09620ede5 Gerrit-Change-Number: 27677 Gerrit-PatchSet: 1 Gerrit-Owner: TH Lin <t.h_lin(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: mainboard/google/kahlee: Pad SPD serial Number with spaces
by Kevin Chiu (Code Review) 28 Jul '18

28 Jul '18

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/27676 ) Change subject: mainboard/google/kahlee: Pad SPD serial Number with spaces ...................................................................... Patch Set 1: Code-Review+2 thanks Martin, I try my EVT hynix DRAM board and it can get SPD info. -- To view, visit https://review.coreboot.org/27676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e831873acab2f6fc7d76e85647198d3b7af4b12 Gerrit-Change-Number: 27676 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Jul 2018 06:17:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/kahlee: Pad SPD serial Number with spaces
by Daniel Kurtz (Code Review) 28 Jul '18

28 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27676 ) Change subject: mainboard/google/kahlee: Pad SPD serial Number with spaces ...................................................................... Patch Set 1: Sounds like the tools should be fixed as well. -- To view, visit https://review.coreboot.org/27676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e831873acab2f6fc7d76e85647198d3b7af4b12 Gerrit-Change-Number: 27676 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Jul 2018 05:55:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Pad SPD serial Number with spaces
by Daniel Kurtz (Code Review) 28 Jul '18

28 Jul '18

Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/27676 ) Change subject: mainboard/google/kahlee: Pad SPD serial Number with spaces ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e831873acab2f6fc7d76e85647198d3b7af4b12 Gerrit-Change-Number: 27676 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 28 Jul 2018 05:54:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018