Felix Held has posted comments on this change. ( https://review.coreboot.org/27664 )
Change subject: sb/intel/gpio: Cache gpiobase in ramstage and romstage
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/27664
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26d56a9ff1a8d6e64c164f36e23b846b8b459380
Gerrit-Change-Number: 27664
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 27 Jul 2018 13:07:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27664
to look at the new patch set (#2).
Change subject: sb/intel/gpio: Cache gpiobase in ramstage and romstage
......................................................................
sb/intel/gpio: Cache gpiobase in ramstage and romstage
Implement caching like it's done with pmbase.
Change-Id: I26d56a9ff1a8d6e64c164f36e23b846b8b459380
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
---
M src/southbridge/intel/common/gpio.c
M src/southbridge/intel/common/gpio.h
2 files changed, 22 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/27664/2
--
To view, visit https://review.coreboot.org/27664
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26d56a9ff1a8d6e64c164f36e23b846b8b459380
Gerrit-Change-Number: 27664
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Piotr Król, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/27663
to look at the new patch set (#2).
Change subject: mb/pcengines/apu2/mainboard.c: enable power on after fail
......................................................................
mb/pcengines/apu2/mainboard.c: enable power on after fail
Due to vendor's requirements, board should power on after power failure.
Change-Id: I7b35db16e2090484e58d1307dc29049a1325c65f
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/mainboard/pcengines/apu2/mainboard.c
1 file changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/27663/2
--
To view, visit https://review.coreboot.org/27663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7b35db16e2090484e58d1307dc29049a1325c65f
Gerrit-Change-Number: 27663
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/27663
Change subject: mb/pcengines/apu2/mainboard.c: enable power on after fail
......................................................................
mb/pcengines/apu2/mainboard.c: enable power on after fail
Due to vendor's requirements, board should power on after power failure.
Change-Id: I7b35db16e2090484e58d1307dc29049a1325c65f
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M src/mainboard/pcengines/apu2/mainboard.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/27663/1
diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c
index 8f2d622..25daf3c 100644
--- a/src/mainboard/pcengines/apu2/mainboard.c
+++ b/src/mainboard/pcengines/apu2/mainboard.c
@@ -31,6 +31,7 @@
#define SPD_SIZE 128
#define PM_RTC_CONTROL 0x56
+#define PM_RTC_SHADOW 0x5B
#define PM_S_STATE_CONTROL 0xBA
@@ -174,6 +175,11 @@
//
pm_write16 ( PM_S_STATE_CONTROL, pm_read16( PM_S_STATE_CONTROL ) | (1 << 14));
+ //
+ // Enable power on after power fail
+ //
+ pm_write8 ( PM_RTC_SHADOW, pm_read8( PM_RTC_SHADOW ) | (1 << 0));
+
/* Initialize the PIRQ data structures for consumption */
pirq_setup();
}
--
To view, visit https://review.coreboot.org/27663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b35db16e2090484e58d1307dc29049a1325c65f
Gerrit-Change-Number: 27663
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/27632 )
Change subject: cbfstool: fix implicit declaration of strcasecmp
......................................................................
cbfstool: fix implicit declaration of strcasecmp
Change-Id: Iefeb47bca3676a1f807b7a66b74a07491e351362
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-on: https://review.coreboot.org/27632
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Julius Werner <jwerner(a)chromium.org>
---
M util/cbfstool/cbfscomptool.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Julius Werner: Looks good to me, approved
diff --git a/util/cbfstool/cbfscomptool.c b/util/cbfstool/cbfscomptool.c
index c32be64..028893c 100644
--- a/util/cbfstool/cbfscomptool.c
+++ b/util/cbfstool/cbfscomptool.c
@@ -16,6 +16,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <time.h>
#include "common.h"
--
To view, visit https://review.coreboot.org/27632
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefeb47bca3676a1f807b7a66b74a07491e351362
Gerrit-Change-Number: 27632
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Assignee: Idwer Vollering <vidwer(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com>
John Su has uploaded this change for review. ( https://review.coreboot.org/27662
Change subject: mb/google/poppy/variants/nami: Fix fan is always ON
......................................................................
mb/google/poppy/variants/nami: Fix fan is always ON
Add the new setting for fan performance state.
BUG=b:111860513, b:11865138
TEST=Fan do not run below trip point
Change-Id: I894460b8b418217e2477608094c37018437cbb78
Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/27662/1
diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
index a83fe17..03567fc 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
@@ -65,7 +65,8 @@
Package () {69, 0xFFFFFFFF, 5800, 180, 1800},
Package () {56, 0xFFFFFFFF, 5000, 145, 1450},
Package () {46, 0xFFFFFFFF, 4900, 115, 1150},
- Package () {36, 0xFFFFFFFF, 3900, 90, 900}
+ Package () {36, 0xFFFFFFFF, 3900, 90, 900},
+ Package () { 0, 0xFFFFFFFF, 0, 0, 0}
})
Name (DART, Package () {
--
To view, visit https://review.coreboot.org/27662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I894460b8b418217e2477608094c37018437cbb78
Gerrit-Change-Number: 27662
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>