coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default
by Furquan Shaikh (Code Review) 27 Jul '18

27 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27661 ) Change subject: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c Gerrit-Change-Number: 27661 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Jul 2018 07:11:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default
by Seunghwan Kim (Code Review) 27 Jul '18

27 Jul '18

Seunghwan Kim has posted comments on this change. ( https://review.coreboot.org/27661 ) Change subject: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/27661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c Gerrit-Change-Number: 27661 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Jul 2018 06:48:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default
by Seunghwan Kim (Code Review) 27 Jul '18

27 Jul '18

Seunghwan Kim has removed a vote on this change. Change subject: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default ...................................................................... Removed Code-Review+1 by Seunghwan Kim <sh_.kim(a)samsung.com> -- To view, visit https://review.coreboot.org/27661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c Gerrit-Change-Number: 27661 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default
by Seunghwan Kim (Code Review) 27 Jul '18

27 Jul '18

Seunghwan Kim has posted comments on this change. ( https://review.coreboot.org/27661 ) Change subject: mb/google/poppy/variants/nautilus: Set GPP_D21 to high as default ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/27661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62e77196c2116924f437f61368f0ae7efd0e144c Gerrit-Change-Number: 27661 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Jul 2018 06:47:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variant/nami: Overwrite AC/DC loadlines
by build bot (Jenkins) (Code Review) 27 Jul '18

27 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27644 ) Change subject: mb/google/poppy/variant/nami: Overwrite AC/DC loadlines ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/27644/5/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nami/mainboard.c: https://review.coreboot.org/#/c/27644/5/src/mainboard/google/poppy/variants… PS5, Line 261: /* So far, we only have settings for Akali and Nami defult */ 'defult' may be misspelled - perhaps 'default'? -- To view, visit https://review.coreboot.org/27644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0068c5334c257b9f4c32b6088becbfe8391a864 Gerrit-Change-Number: 27644 Gerrit-PatchSet: 5 Gerrit-Owner: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai(a)intel.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: TH Lin <t.h_lin(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 27 Jul 2018 06:20:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/atlas: Add new Nanya memory option
by Tim Chen (Code Review) 27 Jul '18

27 Jul '18

Hello Tim Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/27660 to review the following change. Change subject: mb/google/poppy/variants/atlas: Add new Nanya memory option ...................................................................... mb/google/poppy/variants/atlas: Add new Nanya memory option - add Nanya NT6CL256T32CM-H1 to memory strapping table BUG=b:111906760 BRANCH=none TEST=none Change-Id: I1432b9ab84f01a7fee1bc562aa40c714ddbf639e Signed-off-by: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/atlas/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/27660/1 diff --git a/src/mainboard/google/poppy/variants/atlas/Makefile.inc b/src/mainboard/google/poppy/variants/atlas/Makefile.inc index a3fb5dc..ad40bb0 100644 --- a/src/mainboard/google/poppy/variants/atlas/Makefile.inc +++ b/src/mainboard/google/poppy/variants/atlas/Makefile.inc @@ -11,6 +11,7 @@ SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107 # 0b1001 SPD_SOURCES += samsung_dimm_K4E6E304EC-EGCF # 0b1010 SPD_SOURCES += samsung_dimm_K4EBE304EC-EGCF # 0b1011 +SPD_SOURCES += nayna_dimm_NT6CL256T32CM-H1 # 0b1100 bootblock-y += gpio.c -- To view, visit https://review.coreboot.org/27660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1432b9ab84f01a7fee1bc562aa40c714ddbf639e Gerrit-Change-Number: 27660 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Chen <Tim-Chen(a)quantatw.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com>

1 0

Change in coreboot[master]: google/caroline: Change debounce time for jack insertion and ejection
by Matt DeVillier (Code Review) 27 Jul '18

27 Jul '18

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/27659 Change subject: google/caroline: Change debounce time for jack insertion and ejection ...................................................................... google/caroline: Change debounce time for jack insertion and ejection Adapted from chromium commit 7633daa [caroline: Change debounce time for jack insertion and ejection] We are using max debounce time. During this time line, MICBIAS will be zero because of jack chasis. At the moment we got 0 button(PLAY/PAUSE) We need to reduce this time within 100ms for caroline device. BUG=b:79559096 TEST=see there is no more irq before jack insertion/ejection irq complete Original-Change-Id: Ib6abdb4ff041823ca89f74cf59e2bfa644bb0d6a Original-Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> Original-Reviewed-on: https://chromium-review.googlesource.com/1143109 Original-Reviewed-by: Aaron Durbin <adurbin(a)chromium.org> Original-Tested-by: Wonjoon Lee <woojoo.lee(a)samsung.com> Change-Id: I8f605989d6ffc8a75127ed6722e7a37db95029ed Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/variants/caroline/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/27659/1 diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb index a040714..0c3c861 100644 --- a/src/mainboard/google/glados/variants/caroline/devicetree.cb +++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb @@ -244,8 +244,8 @@ register "sar_compare_time" = "0" # 500ns register "sar_sampling_time" = "0" # 2us register "short_key_debounce" = "2" # 100ms - register "jack_insert_debounce" = "7" # 512ms - register "jack_eject_debounce" = "7" # 512ms + register "jack_insert_debounce" = "4" # 64ms + register "jack_eject_debounce" = "4" # 64ms device i2c 1a on end end chip drivers/i2c/generic -- To view, visit https://review.coreboot.org/27659 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f605989d6ffc8a75127ed6722e7a37db95029ed Gerrit-Change-Number: 27659 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Update PMC base address for CNP H and LP
by build bot (Jenkins) (Code Review) 27 Jul '18

27 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27523 ) Change subject: soc/intel/cannonlake: Update PMC base address for CNP H and LP ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27523/2/src/soc/intel/cannonlake/bootblock/… File src/soc/intel/cannonlake/bootblock/pch.c: https://review.coreboot.org/#/c/27523/2/src/soc/intel/cannonlake/bootblock/… PS2, Line 37: #define PCR_PSF3_TO_SHDW_PMC_REG_BASE_CNP_H 0x0980 please, no space before tabs -- To view, visit https://review.coreboot.org/27523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I833395260e8fb631823bd03192a092df323250fa Gerrit-Change-Number: 27523 Gerrit-PatchSet: 2 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kin Wai Ng <kin.wai.ng(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Jul 2018 04:02:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Fix Micron MT40A512M16LY-075:E POST CRC error
by Kevin Chiu (Code Review) 27 Jul '18

27 Jul '18

Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/27657 ) Change subject: mainboard/google/kahlee: Fix Micron MT40A512M16LY-075:E POST CRC error ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/27657/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/27657/1//COMMIT_MSG@7 PS1, Line 7: mainboard/go > mainboard/google/kahlee would probably be better here Done. thanks. -- To view, visit https://review.coreboot.org/27657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85c82fd9294f9146fc23e649436cbcc337c4c961 Gerrit-Change-Number: 27657 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Jul 2018 03:03:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mainboard/google/kahlee: Fix Micron MT40A512M16LY-075:E POST CRC error
by Kevin Chiu (Code Review) 27 Jul '18

27 Jul '18

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27657 to look at the new patch set (#2). Change subject: mainboard/google/kahlee: Fix Micron MT40A512M16LY-075:E POST CRC error ...................................................................... mainboard/google/kahlee: Fix Micron MT40A512M16LY-075:E POST CRC error Fix Micron MT40A512M16LY-075:E DRAM SPD CRC error in AGESA MemSPDChecking: ERROR Event: 04011200 Data: 0, 0, 0, 0 BUG=b:111901461 BRANCH=master TEST=emerge-grunt coreboot Change-Id: I85c82fd9294f9146fc23e649436cbcc337c4c961 Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16LY-075-E.spd.hex 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/27657/2 -- To view, visit https://review.coreboot.org/27657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I85c82fd9294f9146fc23e649436cbcc337c4c961 Gerrit-Change-Number: 27657 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018