coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable ec host event wake
by Nick Vaccaro (Code Review) 26 Jul '18

26 Jul '18

Hello Aseda Aboagye, Caveh Jalali, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27649 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nocturne: enable ec host event wake ...................................................................... mb/google/poppy/variants/nocturne: enable ec host event wake Enable nocturne to wake from lid attach/detach events. BUG=b:111803637 BRANCH=none TEST="emerge-nocturne coreboot chromeos-bootimage", verify EC has commit a5abbbb4eb9b15a72624dddbfd727d0b324c3f36, and verify nocturne wakes from suspend on a lid attach/detach event. Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/27649/2 -- To view, visit https://review.coreboot.org/27649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb Gerrit-Change-Number: 27649 Gerrit-PatchSet: 2 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable ec host event wake
by Furquan Shaikh (Code Review) 26 Jul '18

26 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27649 ) Change subject: mb/google/poppy/variants/nocturne: enable ec host event wake ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h: https://review.coreboot.org/#/c/27649/1/src/mainboard/google/poppy/variants… PS1, Line 36: EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ You also need to add EC_HOST_EVENT_MODE_CHANGE to SCI list. -- To view, visit https://review.coreboot.org/27649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb Gerrit-Change-Number: 27649 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Thu, 26 Jul 2018 18:16:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nocturne: enable ec host event wake
by Nick Vaccaro (Code Review) 26 Jul '18

26 Jul '18

Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/27649 Change subject: mb/google/poppy/variants/nocturne: enable ec host event wake ...................................................................... mb/google/poppy/variants/nocturne: enable ec host event wake Enable nocturne to wake from lid attach/detach events. BUG=b:111803637 BRANCH=none TEST="emerge-nocturne coreboot chromeos-bootimage", verify EC has commit a5abbbb4eb9b15a72624dddbfd727d0b324c3f36, and verify nocturne wakes from suspend on a lid attach/detach event. Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/27649/1 diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h index 3e692f6..58263ae 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h @@ -47,7 +47,8 @@ /* EC can wake from S3 with lid, power button or mode change event */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) #define MAINBOARD_EC_S0IX_WAKE_EVENTS (MAINBOARD_EC_S3_WAKE_EVENTS) -- To view, visit https://review.coreboot.org/27649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I22b957d741426ca8b49d1819cf39c940f55198eb Gerrit-Change-Number: 27649 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>

1 0

Change in coreboot[master]: superio/ite/it8720f: fix power control init
by Felix Held (Code Review) 26 Jul '18

26 Jul '18

Felix Held has uploaded this change for review. ( https://review.coreboot.org/27648 Change subject: superio/ite/it8720f: fix power control init ...................................................................... superio/ite/it8720f: fix power control init Change-Id: I3c26a2837e451dbfd3cee82e9beedc0f4a90af03 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/superio/ite/it8720f/it8720f.h M src/superio/ite/it8720f/superio.c 2 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/27648/1 diff --git a/src/superio/ite/it8720f/it8720f.h b/src/superio/ite/it8720f/it8720f.h index f8b7efb..093e895 100644 --- a/src/superio/ite/it8720f/it8720f.h +++ b/src/superio/ite/it8720f/it8720f.h @@ -30,4 +30,8 @@ #define IT8720F_GPIO 0x07 /* GPIO (including SPI flash interface) */ #define IT8720F_CIR 0x0a /* Consumer IR */ +/* Registers in LDNs */ +#define IT8720F_EC_PCR1 0xf2 +#define IT8720F_EC_PCR2 0xf4 + #endif /* SUPERIO_ITE_IT8720F_H */ diff --git a/src/superio/ite/it8720f/superio.c b/src/superio/ite/it8720f/superio.c index 142686e..b3e5222 100644 --- a/src/superio/ite/it8720f/superio.c +++ b/src/superio/ite/it8720f/superio.c @@ -33,17 +33,27 @@ static void power_control_init(struct device *dev) { int power_on = MAINBOARD_POWER_OFF; - u8 addr, value; + u8 value; get_option(&power_on, "power_on_after_fail"); - if (power_on == MAINBOARD_POWER_OFF) - return; + pnp_enter_conf_mode(dev); pnp_set_logical_device(dev); - addr = power_on == MAINBOARD_POWER_KEEP ? 0xf2 : 0xf4; - value = pnp_read_config(dev, addr); - value |= BIT(5); - pnp_write_config(dev, addr, value); + + value = pnp_read_config(dev, IT8720F_EC_PCR1); + if (power_on == MAINBOARD_POWER_KEEP) + value |= (1<<5); + else + value &= ~(1<<5); + pnp_write_config(dev, IT8720F_EC_PCR1, value); + + value = pnp_read_config(dev, IT8720F_EC_PCR2); + if (power_on == MAINBOARD_POWER_ON) + value |= (1<<5); + else + value &= ~(1<<5); + pnp_write_config(dev, IT8720F_EC_PCR2, value); + pnp_exit_conf_mode(dev); } -- To view, visit https://review.coreboot.org/27648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3c26a2837e451dbfd3cee82e9beedc0f4a90af03 Gerrit-Change-Number: 27648 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>

1 0

Change in coreboot[master]: chromeec: Sync ec_commands.h with CrOS upstream.
by Furquan Shaikh (Code Review) 26 Jul '18

26 Jul '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27620 ) Change subject: chromeec: Sync ec_commands.h with CrOS upstream. ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3daa09ffd83c089b6874e0ea9aab8aa60016775 Gerrit-Change-Number: 27620 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 17:30:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP]mb/opencellular/satima: Add new port
by build bot (Jenkins) (Code Review) 26 Jul '18

26 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27425 ) Change subject: [WIP]mb/opencellular/satima: Add new port ...................................................................... Patch Set 14: (174 comments) https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/cn81xx-linux.dtsi: https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string "cavium,thunder-81xx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 46: compatible = "cavium,thunder-81xx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 52: compatible = "arm,psci-0.2"; DT compatible string "arm,psci-0.2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 52: compatible = "arm,psci-0.2"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 79: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 88: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 96: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "cavium,thunder" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string "arm,armv8" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 104: compatible = "cavium,thunder", "arm,armv8"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 113: compatible = "cache"; DT compatible string "cache" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 118: compatible = "arm,armv8-timer"; DT compatible string "arm,armv8-timer" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 118: compatible = "arm,armv8-timer"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "cavium,thunder-pmu" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string "arm,armv8-pmuv3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 126: compatible = "cavium,thunder-pmu", "arm,armv8-pmuv3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 131: compatible = "regulator-fixed"; DT compatible string "regulator-fixed" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 141: compatible = "arm,gic-v3"; DT compatible string "arm,gic-v3" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 141: compatible = "arm,gic-v3"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 153: compatible = "arm,gic-v3-its"; DT compatible string "arm,gic-v3-its" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 153: compatible = "arm,gic-v3-its"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 161: compatible = "simple-bus"; DT compatible string "simple-bus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 168: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 175: compatible = "fixed-clock"; DT compatible string "fixed-clock" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 182: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 191: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 200: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,pl011" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string "arm,primecell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 209: compatible = "arm,pl011", "arm,primecell"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string "arm,sbsa-gwdt" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 218: compatible = "arm,sbsa-gwdt"; DT compatible string vendor "arm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 219: reg = <0x8440 0xa0000 0x0 0x1000>, <0x8440 0xb0000 0x0 0x1000>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 224: compatible = "cfi-flash"; DT compatible string "cfi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 232: compatible = "cavium,smmu-v2"; DT compatible string "cavium,smmu-v2" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 232: compatible = "cavium,smmu-v2"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 235: interrupts = <0 68 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 236: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 237: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 238: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 239: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 240: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 241: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 242: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 243: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 244: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 245: <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>, <0 69 4>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 255: compatible = "pci-host-ecam-generic"; DT compatible string "pci-host-ecam-generic" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 265: reg = <0x8480 0x00000000 0 0x02000000>; /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 266: ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x080 0x00000000>, /* mem ranges */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 267: <0x03000000 0x8100 0x00000000 0x8100 0x00000000 0x80 0x00000000>, /* SATA */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 268: <0x03000000 0x8680 0x00000000 0x8680 0x00000000 0x160 0x28000000>, /* UARTs */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 269: <0x03000000 0x87e0 0x2c000000 0x87e0 0x2c000000 0x000 0x94000000>, /* PEMs */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 270: <0x03000000 0x8400 0x00000000 0x8400 0x00000000 0x010 0x00000000>, /* RNM */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 271: <0x03000000 0x8430 0x00000000 0x8430 0x00000000 0x02 0x00000000>, /* NIC0*/ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 272: <0x03000000 0x87e0 0xc6000000 0x87e0 0xc6000000 0x01f 0x3a000000>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "pci-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string "cavium,thunder-8890-mrml-bridge" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 275: compatible = "pci-bridge", "cavium,thunder-8890-mrml-bridge"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 278: ranges = <0x03000000 0x87e0 0x00000000 0x03000000 0x87e0 0x00000000 0x10 0x00000000>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string "cavium,thunder-8890-mdio-nexus" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 284: compatible = "cavium,thunder-8890-mdio-nexus"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 287: reg = <0x0b00 0 0 0 0>; /* DEVFN = 0x0b (1:3) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 288: assigned-addresses = <0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 289: ranges = <0x87e0 0x05000000 0x03000000 0x87e0 0x05000000 0x0 0x800000>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 291: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 291: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 294: reg = <0x87e0 0x05003800 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string "cavium,thunder-8890-mdio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 297: compatible = "cavium,thunder-8890-mdio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 297: compatible = "cavium,thunder-8890-mdio"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 300: reg = <0x87e0 0x05003880 0x0 0x30>; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string "cavium,thunder-8890-mmc" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 305: compatible = "cavium,thunder-8890-mmc"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 306: reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 315: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 316: reg = <0x4800 0 0 0 0>; /* DEVFN = 0x48 (9:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string "cavium,thunder-8890-twsi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 325: compatible = "cavium,thunder-8890-twsi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 326: reg = <0x4900 0 0 0 0>; /* DEVFN = 0x49 (9:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 335: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 336: reg = <0x9000 0 0 0 0>; /* DEVFN = 0x90 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 341: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 342: reg = <0x8000 0 0 0 0>; /* DEVFN = 0x80 (16:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string "cavium,thunder-8890-bgx" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 347: compatible = "cavium,thunder-8890-bgx"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 348: reg = <0x8100 0 0 0 0>; /* DEVFN = 0x81 (16:1) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string "cavium,thunder-8190-spi" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 353: compatible = "cavium,thunder-8190-spi"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 354: reg = <0x3800 0x0 0x0 0x0 0x0>; /* DEVFN = 0x38 (7:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string "cavium,thunder-8890-gpio" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 362: compatible = "cavium,thunder-8890-gpio"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 364: reg = <0x3000 0 0 0 0>; /* DEVFN = 0x30 (6:0) */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string "cavium,cn8130-nand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 371: compatible = "cavium,cn8130-nand"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 392: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 401: reg = <0x8800 0x1f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 402: <0x87e0 0xc0000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 403: ranges = <0x01000000 0x00 0x00000000 0x8830 0x00000000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 404: <0x03000000 0x00 0x10000000 0x8810 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 405: <0x43000000 0x10 0x00000000 0x8820 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 406: <0x03000000 0x87e0 0xc0000000 0x87e0 0xc0000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 417: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 426: reg = <0x8840 0x57000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 427: <0x87e0 0xc1000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 428: ranges = <0x01000000 0x00 0x00010000 0x8870 0x00010000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 429: <0x03000000 0x00 0x10000000 0x8850 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 430: <0x43000000 0x10 0x00000000 0x8860 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 431: <0x03000000 0x87e0 0xc1000000 0x87e0 0xc1000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string "cavium,pci-host-thunder-pem" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 442: compatible = "cavium,pci-host-thunder-pem"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 451: reg = <0x8880 0x8f000000 0x0 0x39000000>, /* Configuration space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 452: <0x87e0 0xc2000000 0x0 0x01000000>; /* PEM space */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 453: ranges = <0x01000000 0x00 0x00020000 0x88b0 0x00020000 0x00 0x00010000>, /* I/O */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 454: <0x03000000 0x00 0x10000000 0x8890 0x10000000 0x0f 0xf0000000>, /* mem64 */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 455: <0x43000000 0x10 0x00000000 0x88a0 0x00000000 0x10 0x00000000>, /* mem64-pref */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 456: <0x03000000 0x87e0 0xc2000000 0x87e0 0xc2000000 0x00 0x01000000>; /* mem64 PEM */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string "cavium,thunder-8190-tdm" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 469: compatible = "cavium,thunder-8190-tdm"; DT compatible string vendor "cavium" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/death.c: https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 31: } while(1); space required before the open parenthesis '(' https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/mainboard.h: https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 18: #define SATIMA_GPIO_SPI_MUX 24 please, no space before tabs https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… File src/mainboard/opencellular/satima/sff8104-linux.dts: https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "marvell,88e1510" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "marvell" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 53: compatible = "marvell,88e1510", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "vitesse,vsc8574" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string vendor "vitesse" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; DT compatible string "ethernet-phy-ieee802.3-c22" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 59: compatible = "vitesse,vsc8574", "ethernet-phy-ieee802.3-c22"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "aquantia,aqr105" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string vendor "aquantia" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; DT compatible string "ethernet-phy-ieee802.3-c45" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 66: compatible = "aquantia,aqr105", "ethernet-phy-ieee802.3-c45"; line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 98: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 108: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 117: compatible = "mmc-slot"; DT compatible string "mmc-slot" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 128: /* There is no card detection available; polling must be used. */ line over 80 characters https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "micron,n25q128a13" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "micron" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "spi-flash" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string "jedec,spi-nor" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 142: compatible = "micron,n25q128a13", "spi-flash", "jedec,spi-nor"; DT compatible string vendor "jedec" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "spinand,mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string vendor "spinand" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/vendor-prefixes.txt https://review.coreboot.org/#/c/27425/14/src/mainboard/opencellular/satima/… PS14, Line 149: compatible = "spinand,mt29f", "mt29f"; DT compatible string "mt29f" appears un-documented -- check util/lint/checkpatch.pl/Documentation/devicetree/bindings/ -- To view, visit https://review.coreboot.org/27425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f972d59ac2243823a77f614c4f92c1666185705 Gerrit-Change-Number: 27425 Gerrit-PatchSet: 14 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 16:22:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: 3rdparty/blobs: Update submodule pointer to include latest BL31
by Patrick Rudolph (Code Review) 26 Jul '18

26 Jul '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/27647 Change subject: 3rdparty/blobs: Update submodule pointer to include latest BL31 ...................................................................... 3rdparty/blobs: Update submodule pointer to include latest BL31 * Include Cavium's CN81xx BL31.elf Change-Id: Ie8f3b2e8db0692e95caee245733054e4e20f61ea Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/27647/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index 3854ad2..372012e 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 3854ad29e7b767001d4f6dd93eba0d79aedda9c3 +Subproject commit 372012e8e1d0d01f3e77ff73b118665b41ff68b6 -- To view, visit https://review.coreboot.org/27647 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie8f3b2e8db0692e95caee245733054e4e20f61ea Gerrit-Change-Number: 27647 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Change in coreboot[master]: riscv: add support move bootblock to CAR/SRAM before exection
by build bot (Jenkins) (Code Review) 26 Jul '18

26 Jul '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27645 ) Change subject: riscv: add support move bootblock to CAR/SRAM before exection ...................................................................... Patch Set 3: (4 comments) https://review.coreboot.org/#/c/27645/3/src/arch/riscv/bootblock.S File src/arch/riscv/bootblock.S: https://review.coreboot.org/#/c/27645/3/src/arch/riscv/bootblock.S@47 PS3, Line 47: trailing whitespace https://review.coreboot.org/#/c/27645/3/src/arch/riscv/bootblock.S@51 PS3, Line 51: trailing whitespace https://review.coreboot.org/#/c/27645/3/src/arch/riscv/bootblock.S@57 PS3, Line 57: trailing whitespace https://review.coreboot.org/#/c/27645/3/src/arch/riscv/bootblock.S@131 PS3, Line 131: #endif adding a line without newline at end of file -- To view, visit https://review.coreboot.org/27645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1f53a7dbd7db9643bd9aeea6567cd4fae0f310e Gerrit-Change-Number: 27645 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shawn Chang <citypw(a)gmail.com> Gerrit-Reviewer: Xiang Wang <wxjstz(a)126.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 16:17:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: chromeec: Sync ec_commands.h with CrOS upstream.
by Jonathan Brandmeyer (Code Review) 26 Jul '18

26 Jul '18

Hello build bot (Jenkins), Raul Rangel, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/27620 to look at the new patch set (#3). Change subject: chromeec: Sync ec_commands.h with CrOS upstream. ...................................................................... chromeec: Sync ec_commands.h with CrOS upstream. Update ec_commands.h to be a verbatim copy of upstream, except retain the complete copyright notice found in coreboot's copy. Upstream refers to a file not present in coreboot. Change-Id: Ic3daa09ffd83c089b6874e0ea9aab8aa60016775 Signed-off-by: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec_commands.h 2 files changed, 650 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/27620/3 -- To view, visit https://review.coreboot.org/27620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic3daa09ffd83c089b6874e0ea9aab8aa60016775 Gerrit-Change-Number: 27620 Gerrit-PatchSet: 3 Gerrit-Owner: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: chromeec: Sync ec_commands.h with CrOS upstream.
by Jonathan Brandmeyer (Code Review) 26 Jul '18

26 Jul '18

Jonathan Brandmeyer has posted comments on this change. ( https://review.coreboot.org/27620 ) Change subject: chromeec: Sync ec_commands.h with CrOS upstream. ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/27620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3daa09ffd83c089b6874e0ea9aab8aa60016775 Gerrit-Change-Number: 27620 Gerrit-PatchSet: 2 Gerrit-Owner: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Jonathan Brandmeyer <jbrandmeyer(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 15:31:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018