coreboot-gerrit July 2018

coreboot-gerrit@coreboot.org

1 participants
877 discussions

Change in coreboot[master]: Documentation/writing_docs: Document the need for recommonmark
by Philipp Deppenwiese (Code Review) 26 Jul '18

26 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27631 ) Change subject: Documentation/writing_docs: Document the need for recommonmark ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/27631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9513ab4bdc753e0350754d9869239ea833893af9 Gerrit-Change-Number: 27631 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 07:30:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Documenation/conf.py: Make sure release is a string
by Philipp Deppenwiese (Code Review) 26 Jul '18

26 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27630 ) Change subject: Documenation/conf.py: Make sure release is a string ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b455c56e8195f0ecfbe5e360ac161c176f00115 Gerrit-Change-Number: 27630 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 07:29:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util: Add util_readme script
by Philipp Deppenwiese (Code Review) 26 Jul '18

26 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27564 ) Change subject: util: Add util_readme script ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/27564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I015ae6816ea74cacb7f0332fda2c3ebef205c1e2 Gerrit-Change-Number: 27564 Gerrit-PatchSet: 5 Gerrit-Owner: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 07:29:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util: Add description.md to each util
by Philipp Deppenwiese (Code Review) 26 Jul '18

26 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27563 ) Change subject: util: Add description.md to each util ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/27563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f91e85d1034736289aedf27de00df00db3ff19c Gerrit-Change-Number: 27563 Gerrit-PatchSet: 3 Gerrit-Owner: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 07:28:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/cavium/bootblock: Get rid of register X1
by Philipp Deppenwiese (Code Review) 26 Jul '18

26 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/23792 ) Change subject: soc/cavium/bootblock: Get rid of register X1 ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/23792 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9324ea9de24ba4baaef9dde890c443dd0f921ad9 Gerrit-Change-Number: 23792 Gerrit-PatchSet: 11 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 07:21:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/i2c/da7219: Allow disabling micbias-pulse feature
by Akshu Agrawal (Code Review) 26 Jul '18

26 Jul '18

Akshu Agrawal has posted comments on this change. ( https://review.coreboot.org/27613 ) Change subject: drivers/i2c/da7219: Allow disabling micbias-pulse feature ...................................................................... Patch Set 1: Code-Review+1 Most of the platform do need to give micbias pulse level as it is used to specify higher voltage of 2.8V or 2.9V in MICBIAS_CTRL Verified it, Not getting "Invalid micbias pulse level" after the patch -- To view, visit https://review.coreboot.org/27613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie99a8962e78c68b3f6927d0de34168f265d4efa9 Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)chromium.org> Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 06:43:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/arm64: Add Kconfig to include BL31 as blob
by Philipp Deppenwiese (Code Review) 25 Jul '18

25 Jul '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/27559 ) Change subject: arch/arm64: Add Kconfig to include BL31 as blob ...................................................................... arch/arm64: Add Kconfig to include BL31 as blob Add Kconfig options to not build the Arm Trusted Firmware, but use a precompiled binary instead. To be used on platforms that do not have upstream Arm Trusted Firmware support and useful for development purposes. It is recommended to use upstream Arm Trusted Firmware where possible. Change-Id: I17954247029df627a3f4db8b73993bd549e55967 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/27559 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M src/arch/arm64/Kconfig M src/arch/arm64/Makefile.inc 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Julius Werner: Looks good to me, approved diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index cae558b..71c9f04 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -31,6 +31,14 @@ default n depends on ARCH_RAMSTAGE_ARM64 +config ARM64_BL31_EXTERNAL_FILE + string "Path to external BL31.ELF (leave empty to build from source)" + depends on ARM64_USE_ARM_TRUSTED_FIRMWARE + help + The blob to use instead of building the Arm Trusted Firmware + from tree. It is discouraged as compatibility with out-of-tree + blobs may break anytime. + config ARM64_USE_SECURE_OS bool default n diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.inc index 3c3cd20..e2c44eb4 100644 --- a/src/arch/arm64/Makefile.inc +++ b/src/arch/arm64/Makefile.inc @@ -156,6 +156,8 @@ ifeq ($(CONFIG_ARM64_USE_ARM_TRUSTED_FIRMWARE),y) +ifeq ($(CONFIG_ARM64_BL31_EXTERNAL_FILE),"") + BL31_SOURCE := $(top)/3rdparty/arm-trusted-firmware BL31_BUILD := $(abspath $(obj)/3rdparty/arm-trusted-firmware) BL31_TARGET := $(BL31_BUILD)/bl31/bl31.elf @@ -205,6 +207,13 @@ .PHONY: $(BL31) +else + +BL31 := $(call strip_quotes,$(CONFIG_ARM64_BL31_EXTERNAL_FILE)) + +endif # CONFIG_ARM64_BUILD_ARM_TRUSTED_FIRMWARE + + BL31_CBFS := $(CONFIG_CBFS_PREFIX)/bl31 $(BL31_CBFS)-file := $(BL31) $(BL31_CBFS)-type := payload -- To view, visit https://review.coreboot.org/27559 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I17954247029df627a3f4db8b73993bd549e55967 Gerrit-Change-Number: 27559 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arch/arm64: Add Kconfig to include BL31 as blob
by Philipp Deppenwiese (Code Review) 25 Jul '18

25 Jul '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27559 ) Change subject: arch/arm64: Add Kconfig to include BL31 as blob ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/27559 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17954247029df627a3f4db8b73993bd549e55967 Gerrit-Change-Number: 27559 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: T.Michael Turney <tturne(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Jul 2018 00:44:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cbfstool: fix implicit declaration of strcasecmp
by Julius Werner (Code Review) 25 Jul '18

25 Jul '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/27632 ) Change subject: cbfstool: fix implicit declaration of strcasecmp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27632 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefeb47bca3676a1f807b7a66b74a07491e351362 Gerrit-Change-Number: 27632 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Assignee: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Comment-Date: Thu, 26 Jul 2018 00:13:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Use multiple VBIOS images
by Richard Spiegel (Code Review) 25 Jul '18

25 Jul '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/27643 Change subject: soc/amd/stoneyridge: Use multiple VBIOS images ...................................................................... soc/amd/stoneyridge: Use multiple VBIOS images The careena board required a different setting within VBIOS in order to pass eDP eye diagram test, creating the possibility that different boards might need different VBIOS images. Prepare the framework for multiple VBIOS images, use the newer VBIOS for all grunt variants (until a new board needs something different) while maintaining the original one for gardenia. BUG=b:111673328 TEST=Change VBIOS_015_049_000_017.bin name, build grunt, fails. Return original name, build grunt, success. Change-Id: I268cd3dbce6ba1f7bd781d768f470463846a4e10 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M 3rdparty/blobs M src/mainboard/amd/gardenia/Kconfig M src/mainboard/google/kahlee/Kconfig M src/soc/amd/stoneyridge/Kconfig 4 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/27643/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index 3854ad2..4f466ab 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 3854ad29e7b767001d4f6dd93eba0d79aedda9c3 +Subproject commit 4f466ab06f44a1fc3c5ac42fecd8232b7f28b872 diff --git a/src/mainboard/amd/gardenia/Kconfig b/src/mainboard/amd/gardenia/Kconfig index 5d74768..091fad1 100644 --- a/src/mainboard/amd/gardenia/Kconfig +++ b/src/mainboard/amd/gardenia/Kconfig @@ -49,4 +49,8 @@ bool default y +config VGA_BIOS_FILE_BLOB + string + default "soc/amd/stoneyridge/VBIOS.bin" + endif # BOARD_AMD_GARDENIA diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index 11cb891..d00fd92 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -51,6 +51,10 @@ string default google/kahlee +config VGA_BIOS_FILE_BLOB + string + default "mainboard/google/kahlee/VBIOS_015_049_000_017.bin" + config VARIANT_DIR string default "aleena" if BOARD_GOOGLE_ALEENA diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig index 05c3043..363eec4 100644 --- a/src/soc/amd/stoneyridge/Kconfig +++ b/src/soc/amd/stoneyridge/Kconfig @@ -137,7 +137,7 @@ config VGA_BIOS_FILE string - default "3rdparty/blobs/soc/amd/stoneyridge/VBIOS.bin" + default "3rdparty/blobs/$(VGA_BIOS_FILE_BLOB)" config S3_VGA_ROM_RUN bool -- To view, visit https://review.coreboot.org/27643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I268cd3dbce6ba1f7bd781d768f470463846a4e10 Gerrit-Change-Number: 27643 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com>

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
88
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2018