coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
by Furquan Shaikh (Code Review) 14 Nov '18

14 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29631 ) Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://review.coreboot.org/#/c/29631/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29631/3//COMMIT_MSG@14 PS3, Line 14: emerge-nautilus coreboot Can you please ensure that there are no side-effects seen on the 2nd SKU. -- To view, visit https://review.coreboot.org/29631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Ben Chan <benchan(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Nov 2018 02:53:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
by Seunghwan Kim (Code Review) 14 Nov '18

14 Nov '18

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29631 to look at the new patch set (#3). Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ...................................................................... mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only GPP_D0 is NC in 1st SKU board design, so we should control GPP_D0 for only 2nd SKU. BUG=none BRANCH=poppy TEST=emerge-nautilus coreboot Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/Makefile.inc M src/mainboard/google/poppy/variants/nautilus/smihandler.c 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/29631/3 -- To view, visit https://review.coreboot.org/29631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 3 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
by build bot (Jenkins) (Code Review) 14 Nov '18

14 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29631 ) Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/nautilus/smihandler.c: https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants… PS2, Line 29: trailing whitespace https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants… PS2, Line 29: code indent should use tabs where possible https://review.coreboot.org/#/c/29631/2/src/mainboard/google/poppy/variants… PS2, Line 29: please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/29631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Nov 2018 02:45:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
by Seunghwan Kim (Code Review) 14 Nov '18

14 Nov '18

Seunghwan Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/29631 ) Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ...................................................................... mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only GPP_D0 is NC in 1st SKU board design, so we should control GPP_D0 for only 2nd SKU. BUG=none BRANCH=poppy TEST=emerge-nautilus coreboot Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/Makefile.inc M src/mainboard/google/poppy/variants/nautilus/smihandler.c 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/29631/2 -- To view, visit https://review.coreboot.org/29631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 2 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only
by Seunghwan Kim (Code Review) 14 Nov '18

14 Nov '18

Seunghwan Kim has uploaded this change for review. ( https://review.coreboot.org/29631 Change subject: mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only ...................................................................... mb/google/poppy/variants/nautilus: Control GPP_D0 in 2nd SKU only GPP_D0 is NC in 1st SKU board design, so we should control GPP_D0 for only 2nd SKU. BUG=none BRANCH=poppy TEST=emerge-nautilus coreboot Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.com> --- M src/mainboard/google/poppy/variants/nautilus/Makefile.inc M src/mainboard/google/poppy/variants/nautilus/smihandler.c 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/29631/1 diff --git a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc index 130c940..c715206 100644 --- a/src/mainboard/google/poppy/variants/nautilus/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nautilus/Makefile.inc @@ -15,3 +15,4 @@ ramstage-y += sku.c smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c +smm-$(CONFIG_HAVE_SMI_HANDLER) += sku.c diff --git a/src/mainboard/google/poppy/variants/nautilus/smihandler.c b/src/mainboard/google/poppy/variants/nautilus/smihandler.c index e355b01..d581168 100644 --- a/src/mainboard/google/poppy/variants/nautilus/smihandler.c +++ b/src/mainboard/google/poppy/variants/nautilus/smihandler.c @@ -16,13 +16,22 @@ #include <arch/acpi.h> #include <baseboard/variants.h> #include <gpio.h> +#include <variant/sku.h> #define LTE3_PWROFF_L GPP_D0 void variant_smi_sleep(u8 slp_typ) { + uint32_t sku_id = variant_board_sku(); + if (slp_typ == ACPI_S5) { - /* Turn off LTE module */ - gpio_set(LTE3_PWROFF_L, 0); + switch (sku_id) { + case SKU_1_NAUTILUS_LTE: + /* Turn off LTE module */ + gpio_set(LTE3_PWROFF_L, 0); + break; + default: + break; + } } } -- To view, visit https://review.coreboot.org/29631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd85693c9155ed960f0c794d4b83fe8863b77134 Gerrit-Change-Number: 29631 Gerrit-PatchSet: 1 Gerrit-Owner: Seunghwan Kim <sh_.kim(a)samsung.com>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L
by Nick Vaccaro (Code Review) 14 Nov '18

14 Nov '18

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29630 ) Change subject: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Marking as -2 until testing verification is complete. https://review.coreboot.org/#/c/29630/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29630/1//COMMIT_MSG@13 PS1, Line 13: none > Can you please check: […] I've checked entering/exiting S0ix and S3, no issues. I will check Wake from WLAN behaviors in the morning. -- To view, visit https://review.coreboot.org/29630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80 Gerrit-Change-Number: 29630 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 14 Nov 2018 01:15:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneridge: Add DRAM check for s3
by Marshall Dawson (Code Review) 13 Nov '18

13 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29406 to look at the new patch set (#4). Change subject: soc/amd/stoneridge: Add DRAM check for s3 ...................................................................... soc/amd/stoneridge: Add DRAM check for s3 Allocate cbmem space to store DRAM check data during S3. Verify the the data is unchanged during the resume. Due to where the save and verify steps are placed, the test cannot capture 100% of potential memory corruption causes in coreboot. The ranges to verify are determined by the coreboot tables that are constructed at the end of POST. If a failure occurs within RAM available to the OS, the test reports "ERROR" to force suspend_stress_test to stop. Otherwise, the mismatch is reported as "FYI", e.g. in memory owned by coreboot. CAUTION: This test must not be deployed in a shipping system. It disables TSEG, and its protections, in order to allow the performance to be at an acceptable level. TODO: Add the capability of checking DRAM above 4GB. TEST=Suspend/resume grunt. Verify mismatch with induced error. BUG=b:118157730 Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0 Signed-off-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> --- M src/soc/amd/common/block/pi/amd_resume_final.c M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/Makefile.inc M src/soc/amd/stoneyridge/finalize.c M src/soc/amd/stoneyridge/include/soc/iomap.h A src/soc/amd/stoneyridge/include/soc/s3test_util.h A src/soc/amd/stoneyridge/s3test_util.c M src/soc/amd/stoneyridge/smihandler.c 8 files changed, 433 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/29406/4 -- To view, visit https://review.coreboot.org/29406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0 Gerrit-Change-Number: 29406 Gerrit-PatchSet: 4 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L
by Furquan Shaikh (Code Review) 13 Nov '18

13 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29630 ) Change subject: mb/google/poppy/variant/nocturne: config GPP_E1 for WLAN_WAKE_L ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29630/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29630/1//COMMIT_MSG@13 PS1, Line 13: none Can you please check: 1. Suspend/resume to both S0ix and S3 still works fine (no unexpected wakes or suspend failures). 2. Wake from WLAN from both S0ix and S3 still works fine. -- To view, visit https://review.coreboot.org/29630 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80 Gerrit-Change-Number: 29630 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Nov 2018 23:00:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: azalia: Add Azalia Reset macro
by build bot (Jenkins) (Code Review) 13 Nov '18

13 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29554 ) Change subject: azalia: Add Azalia Reset macro ...................................................................... Patch Set 8: (1 comment) https://review.coreboot.org/#/c/29554/8/src/include/device/azalia_device.h File src/include/device/azalia_device.h: https://review.coreboot.org/#/c/29554/8/src/include/device/azalia_device.h@… PS8, Line 50: #define AZALIA_RESET(pin) \ Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/29554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie788b7153e25b764cd1d33753af17d5ed4903c36 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 8 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Nov 2018 22:56:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/amd/stoneridge: Add DRAM check for s3
by build bot (Jenkins) (Code Review) 13 Nov '18

13 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29406 ) Change subject: soc/amd/stoneridge: Add DRAM check for s3 ...................................................................... Patch Set 3: (6 comments) https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… File src/soc/amd/stoneyridge/s3test_util.c: https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 252: wbinvd(); code indent should use tabs where possible https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 252: wbinvd(); please, no space before tabs https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 252: wbinvd(); please, no spaces at the start of a line https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 254: err = 0; code indent should use tabs where possible https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 254: err = 0; please, no space before tabs https://review.coreboot.org/#/c/29406/3/src/soc/amd/stoneyridge/s3test_util… PS3, Line 254: err = 0; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/29406 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I375dd7ea9a3ab8992f1616126bcbd9724e4fc9a0 Gerrit-Change-Number: 29406 Gerrit-PatchSet: 3 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 13 Nov 2018 22:01:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018