coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/google/poppy/variant/atlas: config GPP_F10 to use PLTRST
by Pratikkumar V Prajapati (Code Review) 15 Nov '18

15 Nov '18

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/29540 ) Change subject: mb/google/poppy/variant/atlas: config GPP_F10 to use PLTRST ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc6c42cb4dc6e8eb368d605c83f584f4c69077dc Gerrit-Change-Number: 29540 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: caveh jalali <caveh(a)chromium.org> Gerrit-Comment-Date: Thu, 15 Nov 2018 06:10:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add options for pcie ltr
by Pratikkumar V Prajapati (Code Review) 15 Nov '18

15 Nov '18

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/29642 ) Change subject: soc/intel/cannonlake: Add options for pcie ltr ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29642/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29642/1//COMMIT_MSG@10 PS1, Line 10: mechansism mechanism -- To view, visit https://review.coreboot.org/29642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69b423afa4f81a2d58375734bba07792e08931d5 Gerrit-Change-Number: 29642 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Thu, 15 Nov 2018 05:47:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__...
by Subrata Banik (Code Review) 15 Nov '18

15 Nov '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/29643 Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ...................................................................... soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check soc_pch_pirq_init() function is only getting compiled for RAMSTAGE hence remove unused __SIMPLE_DEVICE__ check. Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/soc/intel/cannonlake/lpc.c M src/soc/intel/icelake/lpc.c 2 files changed, 4 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29643/1 diff --git a/src/soc/intel/cannonlake/lpc.c b/src/soc/intel/cannonlake/lpc.c index 84a2138..83d9cea 100644 --- a/src/soc/intel/cannonlake/lpc.c +++ b/src/soc/intel/cannonlake/lpc.c @@ -145,6 +145,7 @@ void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; const config_t *config = dev->chip_info; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; @@ -158,11 +159,7 @@ pch_interrupt_routing[7] = config->pirqh_routing; itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; diff --git a/src/soc/intel/icelake/lpc.c b/src/soc/intel/icelake/lpc.c index 8859c5d..63677c8 100644 --- a/src/soc/intel/icelake/lpc.c +++ b/src/soc/intel/icelake/lpc.c @@ -143,6 +143,7 @@ void soc_pch_pirq_init(const struct device *dev) { + struct device *irq_dev; const config_t *config = dev->chip_info; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; @@ -156,11 +157,7 @@ pch_interrupt_routing[7] = config->pirqh_routing; itss_irq_init(pch_interrupt_routing); -#if defined(__SIMPLE_DEVICE__) - pci_devfn_t irq_dev; -#else - struct device *irq_dev; -#endif + for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { u8 int_pin = 0, int_line = 0; -- To view, visit https://review.coreboot.org/29643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: soc/intel/cannonlake: Add options for pcie ltr
by Lijian Zhao (Code Review) 15 Nov '18

15 Nov '18

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/29642 Change subject: soc/intel/cannonlake: Add options for pcie ltr ...................................................................... soc/intel/cannonlake: Add options for pcie ltr FSP can support enable/disable Pci express LTR (Latency Tolerance Reporting) mechansism through upd interface. Include that into coreboot side. BUG=N/A TEST=N/A Change-Id: I69b423afa4f81a2d58375734bba07792e08931d5 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/fsp_params.c 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/29642/1 diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h index 015133e..b976cd2 100644 --- a/src/soc/intel/cannonlake/chip.h +++ b/src/soc/intel/cannonlake/chip.h @@ -165,6 +165,8 @@ /* PCIe ClkReq-to-ClkSrc mapping, number of clkreq signal assigned to * clksrc. */ uint8_t PcieClkSrcClkReq[CONFIG_MAX_ROOT_PORTS]; + /* PCIe LTR(Latency Tolerance Reporting) mechanism */ + uint8_t PcieRpLtrEnable[CONFIG_MAX_ROOT_PORTS]; /* eMMC and SD */ uint8_t ScsEmmcHs400Enabled; diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c index 3314f6d..f957459 100644 --- a/src/soc/intel/cannonlake/fsp_params.c +++ b/src/soc/intel/cannonlake/fsp_params.c @@ -171,6 +171,8 @@ sizeof(config->PcieClkSrcUsage)); memcpy(params->PcieClkSrcClkReq, config->PcieClkSrcClkReq, sizeof(config->PcieClkSrcClkReq)); + memcpy(params->PcieRpLtrEnable, config->PcieRpLtrEnable, + sizeof(config->PcieRpLtrEnable)); /* eMMC and SD */ dev = dev_find_slot(0, PCH_DEVFN_EMMC); -- To view, visit https://review.coreboot.org/29642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I69b423afa4f81a2d58375734bba07792e08931d5 Gerrit-Change-Number: 29642 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29641 to look at the new patch set (#6). Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 54 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/6 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29641 to look at the new patch set (#5). Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 53 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/5 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29641 to look at the new patch set (#4). Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 53 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/4 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29641 to look at the new patch set (#3). Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 53 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/3 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Elyes HAOUAS has uploaded a new patch set (#2). ( https://review.coreboot.org/29641 ) Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 54 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/2 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.20
by Elyes HAOUAS (Code Review) 14 Nov '18

14 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29641 ) Change subject: SMBIOS: [test] Upgrade to 3.20 ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 14 Nov 2018 21:14:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018