coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-pane...
by Furquan Shaikh (Code Review) 15 Nov '18

15 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29644 ) Change subject: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-panel tuning ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/29644/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29644/3//COMMIT_MSG@17 PS3, Line 17: Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 You will need a "Signed-off-by" line https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/varian… File src/mainboard/google/octopus/variants/ampton/overridetree.cb: https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/varian… PS3, Line 8: .i2c[0] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 152, : .fall_time_ns = 30, : }, Does i2c0 frequency look fine? https://review.coreboot.org/#/c/29644/3/src/mainboard/google/octopus/varian… PS3, Line 13: .i2c[5] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 104, : .fall_time_ns = 52, : }, Does this look fine? -- To view, visit https://review.coreboot.org/29644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 Gerrit-Change-Number: 29644 Gerrit-PatchSet: 3 Gerrit-Owner: Carl Yang <carl_yang(a)asus.corp-partner.google.com> Gerrit-Reviewer: Carl Yang <carl_yang(a)asus.corp-partner.google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Randy Wang <randy2_wang(a)asus.corp-partner.google.com> Gerrit-CC: YuCheng Hung <yucheng_hung(a)asus.corp-partner.google.com> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:20:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__...
by Furquan Shaikh (Code Review) 15 Nov '18

15 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29643 ) Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:18:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-pane...
by Carl Yang (Code Review) 15 Nov '18

15 Nov '18

Hello Marco Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29644 to look at the new patch set (#3). Change subject: mainboard/google/octopus/variants/ampton: I2C touchpad and touch-panel tuning ...................................................................... mainboard/google/octopus/variants/ampton: I2C touchpad and touch-panel tuning The touchpad and touch-panel CLK frequency should be small than 400 kHz which described in spec. Overwrite i2c speed parameters by overridetree.cb BUG=b:119540449 BRANCH=master TEST=emerge-octopus coreboot chromeos-bootimage flash bios and check the touchpad i2c frequency meets the spec. Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 --- M src/mainboard/google/octopus/variants/ampton/overridetree.cb 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/29644/3 -- To view, visit https://review.coreboot.org/29644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1acd26f95b7e947b7088cb25c1cdb686895cced0 Gerrit-Change-Number: 29644 Gerrit-PatchSet: 3 Gerrit-Owner: Carl Yang <carl_yang(a)asus.corp-partner.google.com> Gerrit-Reviewer: Carl Yang <carl_yang(a)asus.corp-partner.google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Randy Wang <randy2_wang(a)asus.corp-partner.google.com> Gerrit-CC: YuCheng Hung <yucheng_hung(a)asus.corp-partner.google.com>

1 0

Change in coreboot[master]: SMBIOS: Remove duplicated smbios_memory_type enum
by Elyes HAOUAS (Code Review) 15 Nov '18

15 Nov '18

Hello Patrick Rudolph, Richard Spiegel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29638 to look at the new patch set (#4). Change subject: SMBIOS: Remove duplicated smbios_memory_type enum ...................................................................... SMBIOS: Remove duplicated smbios_memory_type enum Change-Id: I49554d13f1b6371b85a58cc1263608ad9e99130e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/include/memory_info.h M src/include/smbios.h M src/mainboard/google/cyan/spd/spd.c M src/soc/intel/skylake/romstage/romstage_fsp20.c 4 files changed, 13 insertions(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/29638/4 -- To view, visit https://review.coreboot.org/29638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I49554d13f1b6371b85a58cc1263608ad9e99130e Gerrit-Change-Number: 29638 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__...
by Elyes HAOUAS (Code Review) 15 Nov '18

15 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29643 ) Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ...................................................................... Patch Set 1: > > Patch Set 1: Code-Review+2 > > cat src/soc/intel/cannonlake/Makefile.inc |grep lpc.c ? Oops ... sorry for the noise -- To view, visit https://review.coreboot.org/29643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:03:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: SMBIOS: Remove duplicated smbios_memory_type enum
by Patrick Rudolph (Code Review) 15 Nov '18

15 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29638 ) Change subject: SMBIOS: Remove duplicated smbios_memory_type enum ...................................................................... Patch Set 3: Code-Review-1 As you already pointed out, not only the name, but the information provided changed. You must make sure all calling functions return the correct information (MT/s vs MHz). Also I doubt that this change has any effect without advertising smbios 3.2 and it will only confuse developers even more. -- To view, visit https://review.coreboot.org/29638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49554d13f1b6371b85a58cc1263608ad9e99130e Gerrit-Change-Number: 29638 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:01:34 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by build bot (Jenkins) (Code Review) 15 Nov '18

15 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29641 ) Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/29641/7/src/include/smbios.h File src/include/smbios.h: https://review.coreboot.org/#/c/29641/7/src/include/smbios.h@352 PS7, Line 352: SMBIOS_STATE_WARMING =0x04, spaces required around that '=' (ctx:WxV) -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:00:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__...
by Elyes HAOUAS (Code Review) 15 Nov '18

15 Nov '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/29643 ) Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ...................................................................... Patch Set 1: > Patch Set 1: Code-Review+2 cat src/soc/intel/cannonlake/Makefile.inc |grep lpc.c ? -- To view, visit https://review.coreboot.org/29643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 15 Nov 2018 07:00:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__...
by Patrick Rudolph (Code Review) 15 Nov '18

15 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29643 ) Change subject: soc/intel/{cannonlake, icelake}: Remove unnecessary __SIMPLE_DEVICE__ check ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29643 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854 Gerrit-Change-Number: 29643 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 15 Nov 2018 06:56:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: SMBIOS: [test] Upgrade to 3.2.0
by Elyes HAOUAS (Code Review) 15 Nov '18

15 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29641 to look at the new patch set (#7). Change subject: SMBIOS: [test] Upgrade to 3.2.0 ...................................................................... SMBIOS: [test] Upgrade to 3.2.0 Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/smbios.c M src/include/smbios.h M src/mainboard/samsung/lumpy/mainboard.c 3 files changed, 96 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/29641/7 -- To view, visit https://review.coreboot.org/29641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8bccedd277beb755b643a663f3278af25f8fbf96 Gerrit-Change-Number: 29641 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018