coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: soc/intel/denverton_ns/Kconfig: Remove unused HSUART_FUNC
by Arthur Heymans (Code Review) 12 Nov '18

12 Nov '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29598 ) Change subject: soc/intel/denverton_ns/Kconfig: Remove unused HSUART_FUNC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ec6f0687083c17314588c85af289b4b27c5441c Gerrit-Change-Number: 29598 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 12 Nov 2018 16:06:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/{broadwell, skylake}: Remove unused SERIAL_CPU_INIT
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29600 Change subject: soc/intel/{broadwell,skylake}: Remove unused SERIAL_CPU_INIT ...................................................................... soc/intel/{broadwell,skylake}: Remove unused SERIAL_CPU_INIT Change-Id: I2296ab3c53a82ee990649e35e1370e1dd304e392 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/broadwell/Kconfig M src/soc/intel/skylake/Kconfig 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/29600/1 diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 066f1be..18ec51f 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -80,10 +80,6 @@ hex default 0xf0000000 -config SERIAL_CPU_INIT - bool - default n - config SMM_TSEG_SIZE hex default 0x800000 diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig index 2db8217..ad5a754 100644 --- a/src/soc/intel/skylake/Kconfig +++ b/src/soc/intel/skylake/Kconfig @@ -168,10 +168,6 @@ help This option allows you to select MMIO Base Address of sideband bus. -config SERIAL_CPU_INIT - bool - default n - config SERIRQ_CONTINUOUS_MODE bool default n -- To view, visit https://review.coreboot.org/29600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2296ab3c53a82ee990649e35e1370e1dd304e392 Gerrit-Change-Number: 29600 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: sb/amd/{agesa, pi}/hudson/Kconfig: Remove unused HUDSON_FWM
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29599 Change subject: sb/amd/{agesa,pi}/hudson/Kconfig: Remove unused HUDSON_FWM ...................................................................... sb/amd/{agesa,pi}/hudson/Kconfig: Remove unused HUDSON_FWM Change-Id: Ib621fe01a1d1d026153124a9d46f26e31df6d818 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/southbridge/amd/agesa/hudson/Kconfig M src/southbridge/amd/pi/hudson/Kconfig 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/29599/1 diff --git a/src/southbridge/amd/agesa/hudson/Kconfig b/src/southbridge/amd/agesa/hudson/Kconfig index 4f769fb..77de418 100644 --- a/src/southbridge/amd/agesa/hudson/Kconfig +++ b/src/southbridge/amd/agesa/hudson/Kconfig @@ -94,11 +94,6 @@ default "3rdparty/blobs/southbridge/amd/yangtze/gec.bin" if SOUTHBRIDGE_AMD_AGESA_YANGTZE depends on HUDSON_GEC_FWM -config HUDSON_FWM - bool - default y if HUDSON_XHCI_FWM || HUDSON_IMC_FWM || HUDSON_GEC_FWM - default n - config HUDSON_SATA_MODE int "SATA Mode" default 0 diff --git a/src/southbridge/amd/pi/hudson/Kconfig b/src/southbridge/amd/pi/hudson/Kconfig index 9d803be..960cfa4 100644 --- a/src/southbridge/amd/pi/hudson/Kconfig +++ b/src/southbridge/amd/pi/hudson/Kconfig @@ -96,11 +96,6 @@ string "GEC firmware path and filename" depends on HUDSON_GEC_FWM -config HUDSON_FWM - bool - default y if HUDSON_XHCI_FWM || HUDSON_IMC_FWM || HUDSON_GEC_FWM || HUDSON_PSP - default n - config AMD_PUBKEY_FILE depends on HUDSON_PSP string "AMD public Key" -- To view, visit https://review.coreboot.org/29599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib621fe01a1d1d026153124a9d46f26e31df6d818 Gerrit-Change-Number: 29599 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/intel/denverton_ns/Kconfig: Remove unused HSUART_FUNC
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29598 Change subject: soc/intel/denverton_ns/Kconfig: Remove unused HSUART_FUNC ...................................................................... soc/intel/denverton_ns/Kconfig: Remove unused HSUART_FUNC Change-Id: I1ec6f0687083c17314588c85af289b4b27c5441c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/denverton_ns/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/29598/1 diff --git a/src/soc/intel/denverton_ns/Kconfig b/src/soc/intel/denverton_ns/Kconfig index 736d567..fd31e51 100644 --- a/src/soc/intel/denverton_ns/Kconfig +++ b/src/soc/intel/denverton_ns/Kconfig @@ -146,10 +146,6 @@ hex default 0x1a -config HSUART_FUNC - hex - default 0x0 - choice prompt "UART mode selection" default NON_LEGACY_UART_MODE -- To view, visit https://review.coreboot.org/29598 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1ec6f0687083c17314588c85af289b4b27c5441c Gerrit-Change-Number: 29598 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/amd/amdfam10/Kconfig: Remove unused symbols
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29597 Change subject: nb/amd/amdfam10/Kconfig: Remove unused symbols ...................................................................... nb/amd/amdfam10/Kconfig: Remove unused symbols Change-Id: I7019d70b7e6f8ae041a12d6bab83127e9e70868c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/amd/amdfam10/Kconfig 1 file changed, 0 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/29597/1 diff --git a/src/northbridge/amd/amdfam10/Kconfig b/src/northbridge/amd/amdfam10/Kconfig index 19fd293..4342c3a 100644 --- a/src/northbridge/amd/amdfam10/Kconfig +++ b/src/northbridge/amd/amdfam10/Kconfig @@ -63,10 +63,6 @@ config HT_CHAIN_DISTRIBUTE def_bool n -config DIMM_FBDIMM - bool - default n - config DIMM_DDR2 bool default n @@ -83,12 +79,6 @@ bool default n -if DIMM_FBDIMM - config DIMM_SUPPORT - hex - default 0x0110 -endif - config S3_DATA_SIZE int default 32768 @@ -99,28 +89,6 @@ default 0x0 depends on (HAVE_ACPI_RESUME) -if DIMM_DDR2 - if DIMM_REGISTERED - config DIMM_SUPPORT - hex - default 0x0104 - endif - - if !DIMM_REGISTERED - config DIMM_SUPPORT - hex - default 0x0004 - endif -endif - -if DIMM_DDR3 - if DIMM_REGISTERED - config DIMM_SUPPORT - hex - default 0x0005 - endif -endif - config SVI_HIGH_FREQ bool default n -- To view, visit https://review.coreboot.org/29597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7019d70b7e6f8ae041a12d6bab83127e9e70868c Gerrit-Change-Number: 29597 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: LinuxBoot: refactor payload
by Marcello Sylvester Bauer (Code Review) 12 Nov '18

12 Nov '18

Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29581 to look at the new patch set (#6). Change subject: LinuxBoot: refactor payload ...................................................................... LinuxBoot: refactor payload Clean and refactor the structure of the LinuxBoot payload integration. Change-Id: I41d0275a5f7efb920e881f43b0acda29f41ee221 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M payloads/external/LinuxBoot/Kconfig M payloads/external/LinuxBoot/Makefile M payloads/external/LinuxBoot/arm64/kernel_fdt_lzma.its A payloads/external/LinuxBoot/targets/linux.mk M payloads/external/LinuxBoot/targets/u-root.mk M payloads/external/Makefile.inc 6 files changed, 201 insertions(+), 98 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/29581/6 -- To view, visit https://review.coreboot.org/29581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41d0275a5f7efb920e881f43b0acda29f41ee221 Gerrit-Change-Number: 29581 Gerrit-PatchSet: 6 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Marcello Sylvester Bauer <info(a)marcellobauer.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets
by build bot (Jenkins) (Code Review) 12 Nov '18

12 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18224 ) Change subject: util/bucts: Add tool to manipulate BUC.TS bit on Intel targets ...................................................................... Patch Set 6: (12 comments) https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c File util/bucts/bucts.c: https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@265 PS6, Line 265: ? "set, changing top swap not possible" : "unset, changing top swap is possible"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@266 PS6, Line 266: printf("Top Swap : %s\n", ts ? "Enabled" : "Disabled"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@269 PS6, Line 269: printf("Ranges swapped : 0x%llx-0x%08llx <-> 0x%08llx-0x%08llx", line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@292 PS6, Line 292: printf("BIOS Interface Lock-Down set, Changing Top Swap not possible.\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@345 PS6, Line 345: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@349 PS6, Line 349: printf("Print and Set are mutually exclusive!\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@357 PS6, Line 357: printf("Invalid setting: multiple set/unset arguments\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@361 PS6, Line 361: printf("Print and Set are mutually exclusive!\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@369 PS6, Line 369: printf("Print and Set are mutually exclusive!\n"); line over 80 characters https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@378 PS6, Line 378: default: Possible switch case/default not preceded by break or fallthrough comment https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@392 PS6, Line 392: if ((io_fd = open("/dev/io", O_RDWR)) < 0) { do not use assignment in if condition https://review.coreboot.org/#/c/18224/6/util/bucts/bucts.c@402 PS6, Line 402: if ((fd_mem = open(MEM_DEV, O_RDWR | O_SYNC)) == -1) { do not use assignment in if condition -- To view, visit https://review.coreboot.org/18224 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12cc2e91396f096fc979e23848e1929cb6c44fc5 Gerrit-Change-Number: 18224 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 12 Nov 2018 15:11:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: adjust fmap
by Marcello Sylvester Bauer (Code Review) 12 Nov '18

12 Nov '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/29596 Change subject: mb/cavium/cn8100_sff_evb: adjust fmap ...................................................................... mb/cavium/cn8100_sff_evb: adjust fmap Adjust the default fmap description file. Change-Id: I46165eb27314a500187bcd24e3e201cf6a3175e7 Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M src/mainboard/cavium/cn8100_sff_evb/Kconfig M src/mainboard/cavium/cn8100_sff_evb/board.fmd 2 files changed, 8 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/29596/1 diff --git a/src/mainboard/cavium/cn8100_sff_evb/Kconfig b/src/mainboard/cavium/cn8100_sff_evb/Kconfig index c67c362..b95ddf6 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/Kconfig +++ b/src/mainboard/cavium/cn8100_sff_evb/Kconfig @@ -17,7 +17,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y - select BOARD_ROMSIZE_KB_16384 + select BOARD_ROMSIZE_KB_8192 select COMMON_CBFS_SPI_WRAPPER select RTC select SOC_CAVIUM_CN81XX diff --git a/src/mainboard/cavium/cn8100_sff_evb/board.fmd b/src/mainboard/cavium/cn8100_sff_evb/board.fmd index 1998727..34f3161 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/board.fmd +++ b/src/mainboard/cavium/cn8100_sff_evb/board.fmd @@ -1,24 +1,15 @@ FLASH@0x0 8M { - WP_RO@0x0 0x400000 { - RO_SECTION@0x0 0x200000 { + WP_RO@0x0 0x800000 { + RO_SECTION@0x0 0x7fc000 { + # 0 - 0x10000 is free for firmware usage. + # bootblock starts at 0x20000 + FMAP@0x0 0x1000 # bootblock includes trusted/non-trusted CLIB, CSIB, # and BL1FWs packaged in # src/soc/cavium/common/Makefile.inc. BOOTBLOCK@0x10000 0x70000 - FMAP@0x90000 0x1000 - COREBOOT(CBFS)@0x100000 0x100000 + COREBOOT(CBFS)@0x80000 0x77c000 } + RO_VPD@0x7fc000 0x4000 } - RW_SECTION_A@0x400000 0xe8000 { - VBLOCK_A@0x0 0x2000 - FW_MAIN_A(CBFS)@0x2000 0xe5f00 - RW_FWID_A@0xe7f00 0x100 - } - RW_UNUSED@0x4e8000 0x8000 - RW_ELOG@0x5d8000 0x1000 - RW_SHARED@0x5e0000 0x10000 { - SHARED_DATA@0x0 0x10000 - } - RW_NVRAM@0x5f0000 0x10000 - CONSOLE@0x700000 0x100000 } -- To view, visit https://review.coreboot.org/29596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I46165eb27314a500187bcd24e3e201cf6a3175e7 Gerrit-Change-Number: 29596 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer <info(a)marcellobauer.com>

1 0

Change in coreboot[master]: security/tpm: Fix TCPA log feature
by build bot (Jenkins) (Code Review) 12 Nov '18

12 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29563 ) Change subject: security/tpm: Fix TCPA log feature ...................................................................... Patch Set 13: (2 comments) https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h File src/include/memlayout.h: https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h@168 PS13, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop https://review.coreboot.org/#/c/29563/13/src/include/memlayout.h@168 PS13, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/29563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 13 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph (1001864) Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 12:42:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/*/*/Kconfig: Use CONFIG_VARIANT_DIR for devicetree
by Peter Lemenkov (Code Review) 12 Nov '18

12 Nov '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29595 Change subject: mb/*/*/Kconfig: Use CONFIG_VARIANT_DIR for devicetree ...................................................................... mb/*/*/Kconfig: Use CONFIG_VARIANT_DIR for devicetree Change-Id: Ic9620cfa1630c7c085b6c244ca80dc023a181e30 Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/asrock/g41c-gs/Kconfig M src/mainboard/asus/p5qc/Kconfig M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t530/Kconfig M src/mainboard/opencellular/rotundu/Kconfig M src/mainboard/purism/librem_bdw/Kconfig M src/mainboard/purism/librem_skl/Kconfig M src/mainboard/roda/rv11/Kconfig 8 files changed, 8 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/29595/1 diff --git a/src/mainboard/asrock/g41c-gs/Kconfig b/src/mainboard/asrock/g41c-gs/Kconfig index c0a63be..e7cbf7a 100644 --- a/src/mainboard/asrock/g41c-gs/Kconfig +++ b/src/mainboard/asrock/g41c-gs/Kconfig @@ -62,11 +62,7 @@ config DEVICETREE string - default "variants/g41c-gs-r2/devicetree.cb" if BOARD_ASROCK_G41C_GS_R2_0 - default "variants/g41c-gs/devicetree.cb" if BOARD_ASROCK_G41C_GS - default "variants/g41m-gs/devicetree.cb" if BOARD_ASROCK_G41M_GS - default "variants/g41m-s3/devicetree.cb" if BOARD_ASROCK_G41M_S3 - default "variants/g41m-vs3-r2/devicetree.cb" if BOARD_ASROCK_G41M_VS3_R2_0 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAX_CPUS int diff --git a/src/mainboard/asus/p5qc/Kconfig b/src/mainboard/asus/p5qc/Kconfig index 75c7c7c..c3b287c 100644 --- a/src/mainboard/asus/p5qc/Kconfig +++ b/src/mainboard/asus/p5qc/Kconfig @@ -46,8 +46,7 @@ config DEVICETREE string - default "variants/p5qc/devicetree.cb" if BOARD_ASUS_P5QC - default "variants/p5q_pro/devicetree.cb" if BOARD_ASUS_P5Q_PRO + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAX_CPUS int diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index 79455e2..6bc5884 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -37,8 +37,7 @@ config DEVICETREE string - default "variants/t520/devicetree.cb" if BOARD_LENOVO_T520 - default "variants/w520/devicetree.cb" if BOARD_LENOVO_W520 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index d107504..61752d8 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -39,8 +39,7 @@ config DEVICETREE string - default "variants/t530/devicetree.cb" if BOARD_LENOVO_T530 - default "variants/w530/devicetree.cb" if BOARD_LENOVO_W530 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAINBOARD_PART_NUMBER string diff --git a/src/mainboard/opencellular/rotundu/Kconfig b/src/mainboard/opencellular/rotundu/Kconfig index edacf0d..b1fb040 100644 --- a/src/mainboard/opencellular/rotundu/Kconfig +++ b/src/mainboard/opencellular/rotundu/Kconfig @@ -59,8 +59,7 @@ config DEVICETREE string - default "variants/rotundu/devicetree.cb" if BOARD_OPENCELLULAR_ROTUNDU - default "variants/supabrckv1/devicetree.cb" if BOARD_OPENCELLULAR_SUPABRCKV1 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAINBOARD_DIR string diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig index fd78087..f9016b9 100644 --- a/src/mainboard/purism/librem_bdw/Kconfig +++ b/src/mainboard/purism/librem_bdw/Kconfig @@ -17,8 +17,7 @@ config DEVICETREE string - default "variants/librem13v1/devicetree.cb" if BOARD_PURISM_LIBREM13_V1 - default "variants/librem15v2/devicetree.cb" if BOARD_PURISM_LIBREM15_V2 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config DRIVERS_PS2_KEYBOARD def_bool y diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig index be4b7a3..d757d1a 100644 --- a/src/mainboard/purism/librem_skl/Kconfig +++ b/src/mainboard/purism/librem_skl/Kconfig @@ -47,8 +47,7 @@ config DEVICETREE string - default "variants/librem13v2/devicetree.cb" if BOARD_PURISM_LIBREM13_V2 - default "variants/librem15v3/devicetree.cb" if BOARD_PURISM_LIBREM15_V3 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAX_CPUS int diff --git a/src/mainboard/roda/rv11/Kconfig b/src/mainboard/roda/rv11/Kconfig index 9e81841..de7a0dc 100644 --- a/src/mainboard/roda/rv11/Kconfig +++ b/src/mainboard/roda/rv11/Kconfig @@ -27,8 +27,7 @@ config DEVICETREE string - default "variants/rv11/devicetree.cb" if BOARD_RODA_RV11 - default "variants/rw11/devicetree.cb" if BOARD_RODA_RW11 + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" config MAINBOARD_PART_NUMBER string -- To view, visit https://review.coreboot.org/29595 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9620cfa1630c7c085b6c244ca80dc023a181e30 Gerrit-Change-Number: 29595 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018