coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file"
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/29583 ) Change subject: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file" ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/29583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79e9b95059f16c53767c89cfaef1e89182be9c62 Gerrit-Change-Number: 29583 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 09:07:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: arch/x86/Kconfig: Remove unused ARCH_POSTCAR_X86_{32, 64}
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/29587 ) Change subject: arch/x86/Kconfig: Remove unused ARCH_POSTCAR_X86_{32,64} ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/29587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I4bef4b147083191da6a36ee15b832d75d8215372 Gerrit-Change-Number: 29587 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/mainboard: Remove unused "HW_MEM_HOLE_SIZE_AUTO_INC"
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29589 Change subject: src/mainboard: Remove unused "HW_MEM_HOLE_SIZE_AUTO_INC" ...................................................................... src/mainboard: Remove unused "HW_MEM_HOLE_SIZE_AUTO_INC" Change-Id: I10e89de270a20dbd28647e8b0f8a2425c515b350 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/advansus/a785e-i/Kconfig M src/mainboard/amd/bimini_fam10/Kconfig M src/mainboard/amd/inagua/Kconfig M src/mainboard/amd/olivehill/Kconfig M src/mainboard/amd/parmer/Kconfig M src/mainboard/amd/persimmon/Kconfig M src/mainboard/amd/south_station/Kconfig M src/mainboard/amd/thatcher/Kconfig M src/mainboard/amd/torpedo/Kconfig M src/mainboard/amd/union_station/Kconfig M src/mainboard/asrock/e350m1/Kconfig M src/mainboard/asrock/imb-a180/Kconfig M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/asus/f2a85-m/Kconfig M src/mainboard/asus/m5a88-v/Kconfig M src/mainboard/avalue/eax-785e/Kconfig M src/mainboard/bap/ode_e20XX/Kconfig M src/mainboard/biostar/a68n_5200/Kconfig M src/mainboard/biostar/am1ml/Kconfig M src/mainboard/elmex/pcm205400/Kconfig M src/mainboard/gizmosphere/gizmo/Kconfig M src/mainboard/gizmosphere/gizmo2/Kconfig M src/mainboard/hp/abm/Kconfig M src/mainboard/hp/pavilion_m6_1035dx/Kconfig M src/mainboard/jetway/nf81-t56n-lf/Kconfig M src/mainboard/lenovo/g505s/Kconfig M src/mainboard/lippert/frontrunner-af/Kconfig M src/mainboard/lippert/toucan-af/Kconfig M src/mainboard/msi/ms7721/Kconfig M src/mainboard/pcengines/apu1/Kconfig M src/northbridge/amd/agesa/family12/Kconfig M src/northbridge/amd/agesa/family14/Kconfig M src/northbridge/amd/agesa/family15tn/Kconfig M src/northbridge/amd/agesa/family16kb/Kconfig M src/northbridge/amd/amdfam10/Kconfig M src/northbridge/amd/pi/00630F01/Kconfig M src/northbridge/amd/pi/00660F01/Kconfig M src/northbridge/amd/pi/00730F01/Kconfig M src/northbridge/amd/pi/Kconfig 39 files changed, 0 insertions(+), 156 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/29589/1 diff --git a/src/mainboard/advansus/a785e-i/Kconfig b/src/mainboard/advansus/a785e-i/Kconfig index 2becdf0..3e16a1d 100644 --- a/src/mainboard/advansus/a785e-i/Kconfig +++ b/src/mainboard/advansus/a785e-i/Kconfig @@ -46,10 +46,6 @@ int default 1 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HT_CHAIN_END_UNITID_BASE hex default 0x1 diff --git a/src/mainboard/amd/bimini_fam10/Kconfig b/src/mainboard/amd/bimini_fam10/Kconfig index f30c972..84d3d5e 100644 --- a/src/mainboard/amd/bimini_fam10/Kconfig +++ b/src/mainboard/amd/bimini_fam10/Kconfig @@ -45,10 +45,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HT_CHAIN_END_UNITID_BASE hex default 0x1 diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig index 89bb516..996846b 100644 --- a/src/mainboard/amd/inagua/Kconfig +++ b/src/mainboard/amd/inagua/Kconfig @@ -45,10 +45,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/olivehill/Kconfig b/src/mainboard/amd/olivehill/Kconfig index 2f3b849..4db1dd6 100644 --- a/src/mainboard/amd/olivehill/Kconfig +++ b/src/mainboard/amd/olivehill/Kconfig @@ -44,10 +44,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/parmer/Kconfig b/src/mainboard/amd/parmer/Kconfig index db942a2..6701741 100644 --- a/src/mainboard/amd/parmer/Kconfig +++ b/src/mainboard/amd/parmer/Kconfig @@ -44,10 +44,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index b365eba..f14f810 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -45,10 +45,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index c48e5eb..d4326ae 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -44,10 +44,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/thatcher/Kconfig b/src/mainboard/amd/thatcher/Kconfig index 2ce919a..08e3246 100644 --- a/src/mainboard/amd/thatcher/Kconfig +++ b/src/mainboard/amd/thatcher/Kconfig @@ -45,10 +45,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/amd/torpedo/Kconfig b/src/mainboard/amd/torpedo/Kconfig index 5c85c4b..134e745 100644 --- a/src/mainboard/amd/torpedo/Kconfig +++ b/src/mainboard/amd/torpedo/Kconfig @@ -45,10 +45,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HT_CHAIN_END_UNITID_BASE hex default 0x1 diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index 726e28e..94036a3 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -43,10 +43,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/asrock/e350m1/Kconfig b/src/mainboard/asrock/e350m1/Kconfig index 1c53212..4602883 100644 --- a/src/mainboard/asrock/e350m1/Kconfig +++ b/src/mainboard/asrock/e350m1/Kconfig @@ -46,10 +46,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/asrock/imb-a180/Kconfig b/src/mainboard/asrock/imb-a180/Kconfig index e666549..18e8f4a 100644 --- a/src/mainboard/asrock/imb-a180/Kconfig +++ b/src/mainboard/asrock/imb-a180/Kconfig @@ -45,10 +45,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index 56d5d0c..d50edbe 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -34,10 +34,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 9 diff --git a/src/mainboard/asus/f2a85-m/Kconfig b/src/mainboard/asus/f2a85-m/Kconfig index 3a3348d..9c03c30 100644 --- a/src/mainboard/asus/f2a85-m/Kconfig +++ b/src/mainboard/asus/f2a85-m/Kconfig @@ -74,10 +74,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HUDSON_XHCI_FWM bool default n diff --git a/src/mainboard/asus/m5a88-v/Kconfig b/src/mainboard/asus/m5a88-v/Kconfig index 9bb8965..a86c366 100644 --- a/src/mainboard/asus/m5a88-v/Kconfig +++ b/src/mainboard/asus/m5a88-v/Kconfig @@ -45,10 +45,6 @@ int default 1 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HT_CHAIN_END_UNITID_BASE hex default 0x1 diff --git a/src/mainboard/avalue/eax-785e/Kconfig b/src/mainboard/avalue/eax-785e/Kconfig index 3e835da..b090757 100644 --- a/src/mainboard/avalue/eax-785e/Kconfig +++ b/src/mainboard/avalue/eax-785e/Kconfig @@ -46,10 +46,6 @@ int default 1 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HT_CHAIN_END_UNITID_BASE hex default 0x1 diff --git a/src/mainboard/bap/ode_e20XX/Kconfig b/src/mainboard/bap/ode_e20XX/Kconfig index 6631ac8..b2a7927 100644 --- a/src/mainboard/bap/ode_e20XX/Kconfig +++ b/src/mainboard/bap/ode_e20XX/Kconfig @@ -45,10 +45,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/biostar/a68n_5200/Kconfig b/src/mainboard/biostar/a68n_5200/Kconfig index 183f0f5..d81a64f 100644 --- a/src/mainboard/biostar/a68n_5200/Kconfig +++ b/src/mainboard/biostar/a68n_5200/Kconfig @@ -46,10 +46,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/biostar/am1ml/Kconfig b/src/mainboard/biostar/am1ml/Kconfig index 513975d..a981787 100644 --- a/src/mainboard/biostar/am1ml/Kconfig +++ b/src/mainboard/biostar/am1ml/Kconfig @@ -47,10 +47,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 10 diff --git a/src/mainboard/elmex/pcm205400/Kconfig b/src/mainboard/elmex/pcm205400/Kconfig index a901301..7102519 100644 --- a/src/mainboard/elmex/pcm205400/Kconfig +++ b/src/mainboard/elmex/pcm205400/Kconfig @@ -53,10 +53,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/gizmosphere/gizmo/Kconfig b/src/mainboard/gizmosphere/gizmo/Kconfig index 4177b1d..1bbd148 100644 --- a/src/mainboard/gizmosphere/gizmo/Kconfig +++ b/src/mainboard/gizmosphere/gizmo/Kconfig @@ -45,10 +45,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/gizmosphere/gizmo2/Kconfig b/src/mainboard/gizmosphere/gizmo2/Kconfig index e07e584..8ef0897 100644 --- a/src/mainboard/gizmosphere/gizmo2/Kconfig +++ b/src/mainboard/gizmosphere/gizmo2/Kconfig @@ -45,10 +45,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/hp/abm/Kconfig b/src/mainboard/hp/abm/Kconfig index fa6bf3c..546c869 100644 --- a/src/mainboard/hp/abm/Kconfig +++ b/src/mainboard/hp/abm/Kconfig @@ -44,10 +44,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig index 32a33e7..9423388 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/Kconfig +++ b/src/mainboard/hp/pavilion_m6_1035dx/Kconfig @@ -49,10 +49,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig index 14c534b..3f45260 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig +++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig @@ -46,10 +46,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/lenovo/g505s/Kconfig b/src/mainboard/lenovo/g505s/Kconfig index 6b34d42..13f7791 100644 --- a/src/mainboard/lenovo/g505s/Kconfig +++ b/src/mainboard/lenovo/g505s/Kconfig @@ -47,10 +47,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config ONBOARD_VGA_IS_PRIMARY bool default y diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig index 1ec219e..d4617a4 100644 --- a/src/mainboard/lippert/frontrunner-af/Kconfig +++ b/src/mainboard/lippert/frontrunner-af/Kconfig @@ -47,10 +47,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/lippert/toucan-af/Kconfig b/src/mainboard/lippert/toucan-af/Kconfig index 590909b..c99f02e 100644 --- a/src/mainboard/lippert/toucan-af/Kconfig +++ b/src/mainboard/lippert/toucan-af/Kconfig @@ -49,10 +49,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/mainboard/msi/ms7721/Kconfig b/src/mainboard/msi/ms7721/Kconfig index 7a2623b..b9df339 100644 --- a/src/mainboard/msi/ms7721/Kconfig +++ b/src/mainboard/msi/ms7721/Kconfig @@ -48,10 +48,6 @@ int default 4 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HUDSON_XHCI_FWM bool default n diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index f0cc479..5db3e87 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -48,10 +48,6 @@ int default 2 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config IRQ_SLOT_COUNT int default 11 diff --git a/src/northbridge/amd/agesa/family12/Kconfig b/src/northbridge/amd/agesa/family12/Kconfig index f967837..74bc6fc 100644 --- a/src/northbridge/amd/agesa/family12/Kconfig +++ b/src/northbridge/amd/agesa/family12/Kconfig @@ -24,10 +24,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xe0000000 diff --git a/src/northbridge/amd/agesa/family14/Kconfig b/src/northbridge/amd/agesa/family14/Kconfig index 2e295ef..173714f 100644 --- a/src/northbridge/amd/agesa/family14/Kconfig +++ b/src/northbridge/amd/agesa/family14/Kconfig @@ -21,10 +21,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/agesa/family15tn/Kconfig b/src/northbridge/amd/agesa/family15tn/Kconfig index 26a9984..a0841eb 100644 --- a/src/northbridge/amd/agesa/family15tn/Kconfig +++ b/src/northbridge/amd/agesa/family15tn/Kconfig @@ -21,10 +21,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/agesa/family16kb/Kconfig b/src/northbridge/amd/agesa/family16kb/Kconfig index bafbe2d..2be2fd3 100644 --- a/src/northbridge/amd/agesa/family16kb/Kconfig +++ b/src/northbridge/amd/agesa/family16kb/Kconfig @@ -22,10 +22,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/amdfam10/Kconfig b/src/northbridge/amd/amdfam10/Kconfig index 19fd293..b882510 100644 --- a/src/northbridge/amd/amdfam10/Kconfig +++ b/src/northbridge/amd/amdfam10/Kconfig @@ -35,10 +35,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xc0000000 diff --git a/src/northbridge/amd/pi/00630F01/Kconfig b/src/northbridge/amd/pi/00630F01/Kconfig index 3669826..9a529f0 100644 --- a/src/northbridge/amd/pi/00630F01/Kconfig +++ b/src/northbridge/amd/pi/00630F01/Kconfig @@ -21,10 +21,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/pi/00660F01/Kconfig b/src/northbridge/amd/pi/00660F01/Kconfig index fdae80f..c19ad14 100644 --- a/src/northbridge/amd/pi/00660F01/Kconfig +++ b/src/northbridge/amd/pi/00660F01/Kconfig @@ -21,10 +21,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/pi/00730F01/Kconfig b/src/northbridge/amd/pi/00730F01/Kconfig index 47c2323..441d8a1 100644 --- a/src/northbridge/amd/pi/00730F01/Kconfig +++ b/src/northbridge/amd/pi/00730F01/Kconfig @@ -22,10 +22,6 @@ hex default 0x100000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config MMCONF_BASE_ADDRESS hex default 0xF8000000 diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig index a1cb58d..65c6556 100644 --- a/src/northbridge/amd/pi/Kconfig +++ b/src/northbridge/amd/pi/Kconfig @@ -49,10 +49,6 @@ hex default 0x200000 -config HW_MEM_HOLE_SIZE_AUTO_INC - bool - default n - config HEAP_SIZE hex default 0xc0000 -- To view, visit https://review.coreboot.org/29589 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I10e89de270a20dbd28647e8b0f8a2425c515b350 Gerrit-Change-Number: 29589 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file"
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29583 to look at the new patch set (#4). Change subject: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file" ...................................................................... mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file" Change-Id: I79e9b95059f16c53767c89cfaef1e89182be9c62 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/emulation/qemu-i440fx/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/29583/4 -- To view, visit https://review.coreboot.org/29583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79e9b95059f16c53767c89cfaef1e89182be9c62 Gerrit-Change-Number: 29583 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/tpm: Fix TCPA log feature
by build bot (Jenkins) (Code Review) 12 Nov '18

12 Nov '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29563 ) Change subject: security/tpm: Fix TCPA log feature ...................................................................... Patch Set 10: (2 comments) https://review.coreboot.org/#/c/29563/10/src/include/memlayout.h File src/include/memlayout.h: https://review.coreboot.org/#/c/29563/10/src/include/memlayout.h@168 PS10, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ Macros with multiple statements should be enclosed in a do - while loop https://review.coreboot.org/#/c/29563/10/src/include/memlayout.h@168 PS10, Line 168: #define VBOOT2_TPM_LOG(addr, size) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/29563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic93133531b84318f48940d34bded48cbae739c44 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 10 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph (1001864) Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 08:33:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/opencellular/rotundu: Remove unused CACHE_ROM_SIZE_OVERRIDE
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29588 Change subject: mb/opencellular/rotundu: Remove unused CACHE_ROM_SIZE_OVERRIDE ...................................................................... mb/opencellular/rotundu: Remove unused CACHE_ROM_SIZE_OVERRIDE Change-Id: If77c23fc5d440fe9181e4aae72ffff8ddaa716b6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/opencellular/rotundu/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/29588/1 diff --git a/src/mainboard/opencellular/rotundu/Kconfig b/src/mainboard/opencellular/rotundu/Kconfig index edacf0d..34916c3 100644 --- a/src/mainboard/opencellular/rotundu/Kconfig +++ b/src/mainboard/opencellular/rotundu/Kconfig @@ -74,10 +74,6 @@ int default 16 -config CACHE_ROM_SIZE_OVERRIDE - hex - default 0x800000 - config FSP_LOC hex default 0xfffb0000 -- To view, visit https://review.coreboot.org/29588 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If77c23fc5d440fe9181e4aae72ffff8ddaa716b6 Gerrit-Change-Number: 29588 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: arch/x86/Kconfig: Remove unused ARCH_POSTCAR_X86_{32, 64}
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29587 Change subject: arch/x86/Kconfig: Remove unused ARCH_POSTCAR_X86_{32,64} ...................................................................... arch/x86/Kconfig: Remove unused ARCH_POSTCAR_X86_{32,64} Change-Id: I4bef4b147083191da6a36ee15b832d75d8215372 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/arch/x86/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29587/1 diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index 7c8371e..ff26a15 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -35,10 +35,6 @@ bool default n -config ARCH_POSTCAR_X86_32 - bool - default ARCH_ROMSTAGE_X86_32 && POSTCAR_STAGE - config ARCH_RAMSTAGE_X86_32 bool default n @@ -59,10 +55,6 @@ bool default n -config ARCH_POSTCAR_X86_64 - bool - default ARCH_ROMSTAGE_X86_64 && POSTCAR_STAGE - config ARCH_RAMSTAGE_X86_64 bool default n -- To view, visit https://review.coreboot.org/29587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4bef4b147083191da6a36ee15b832d75d8215372 Gerrit-Change-Number: 29587 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file"
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29583 to look at the new patch set (#3). Change subject: mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file" ...................................................................... mb/emulation/qemu-i440fx/Makefile.inc: Fix "No newline at end of file" Change-Id: I79e9b95059f16c53767c89cfaef1e89182be9c62 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/emulation/qemu-i440fx/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/29583/3 -- To view, visit https://review.coreboot.org/29583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79e9b95059f16c53767c89cfaef1e89182be9c62 Gerrit-Change-Number: 29583 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/siemens/mc_apl1/variants/mc_apl*: Remove unused BOARD_SIEMENS_MC_A...
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29586 Change subject: mb/siemens/mc_apl1/variants/mc_apl*: Remove unused BOARD_SIEMENS_MC_APL*_VAR ...................................................................... mb/siemens/mc_apl1/variants/mc_apl*: Remove unused BOARD_SIEMENS_MC_APL*_VAR Change-Id: I6e911556abc7b7ac3573c5807b6453eecaff7e10 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl3/Kconfig M src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/29586/1 diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig index 1ed2609..f325e24 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl1/Kconfig @@ -1,7 +1,7 @@ if BOARD_SIEMENS_MC_APL1 -config BOARD_SIEMENS_MC_APL1_VAR +config BOARD_SPECIFIC_OPTIONS def_bool y select DRIVER_INTEL_I210 select DRIVERS_I2C_RX6110SA diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig index aa90041..0694316 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig @@ -1,7 +1,7 @@ if BOARD_SIEMENS_MC_APL2 -config BOARD_SIEMENS_MC_APL2_VAR +config BOARD_SPECIFIC_OPTIONS def_bool y select DRIVER_INTEL_I210 select DRIVERS_I2C_RX6110SA diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/Kconfig index 3c5a9fa..48ab734 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl3/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl3/Kconfig @@ -1,7 +1,7 @@ if BOARD_SIEMENS_MC_APL3 -config BOARD_SIEMENS_MC_APL3_VAR +config BOARD_SPECIFIC_OPTIONS def_bool y select DRIVER_INTEL_I210 select DRIVERS_I2C_RX6110SA diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig index 3cf7406..f341465 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/Kconfig @@ -1,7 +1,7 @@ if BOARD_SIEMENS_MC_APL4 -config BOARD_SIEMENS_MC_APL4_VAR +config BOARD_SPECIFIC_OPTIONS def_bool y select DRIVER_INTEL_I210 select DRIVERS_I2C_RX6110SA -- To view, visit https://review.coreboot.org/29586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6e911556abc7b7ac3573c5807b6453eecaff7e10 Gerrit-Change-Number: 29586 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/pcengines/apu2: Remove unused APU2_PINMUX_OFF_{C, D}
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29585 Change subject: mb/pcengines/apu2: Remove unused APU2_PINMUX_OFF_{C,D} ...................................................................... mb/pcengines/apu2: Remove unused APU2_PINMUX_OFF_{C,D} Change-Id: Ie5f73453a8cc12be5f18d8e7f0462ce3f38bb9d8 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/pcengines/apu2/Kconfig 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/29585/1 diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index fe74bcc..9b696d8 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -80,9 +80,6 @@ prompt "J19 pins 1-10" default APU2_PINMUX_UART_C -config APU2_PINMUX_OFF_C - bool "disable" - config APU2_PINMUX_GPIO0 bool "GPIO" depends on BOARD_PCENGINES_APU2 || BOARD_PCENGINES_APU3 || \ @@ -97,9 +94,6 @@ prompt "J19 pins 11-20" default APU2_PINMUX_UART_D -config APU2_PINMUX_OFF_D - bool "disable" - config APU2_PINMUX_GPIO1 bool "GPIO" depends on BOARD_PCENGINES_APU2 || BOARD_PCENGINES_APU3 || \ -- To view, visit https://review.coreboot.org/29585 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5f73453a8cc12be5f18d8e7f0462ce3f38bb9d8 Gerrit-Change-Number: 29585 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018