coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: oc/intel/quark/Kconfig: Remove unused MMCOMF_SUPPORT_DEFAULT
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29609 Change subject: oc/intel/quark/Kconfig: Remove unused MMCOMF_SUPPORT_DEFAULT ...................................................................... oc/intel/quark/Kconfig: Remove unused MMCOMF_SUPPORT_DEFAULT Change-Id: I24596b7b4f3e7caef7f42e4317a786caa42c5c2d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/intel/quark/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/29609/1 diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig index 232dc4f..adf545d 100644 --- a/src/soc/intel/quark/Kconfig +++ b/src/soc/intel/quark/Kconfig @@ -41,10 +41,6 @@ select UNCOMPRESSED_RAMSTAGE select USE_MARCH_586 -config MMCOMF_SUPPORT_DEFAULT - bool - default n - ##### # Debug serial output # The following options configure the debug serial port -- To view, visit https://review.coreboot.org/29609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I24596b7b4f3e7caef7f42e4317a786caa42c5c2d Gerrit-Change-Number: 29609 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: src/drivers/vpd: Remove unused VPD_DEBUG
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29608 Change subject: src/drivers/vpd: Remove unused VPD_DEBUG ...................................................................... src/drivers/vpd: Remove unused VPD_DEBUG Change-Id: Iba838309f8055d364c5f846ce29e628067d7b5f5 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/vpd/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/29608/1 diff --git a/src/drivers/vpd/Kconfig b/src/drivers/vpd/Kconfig index 335b907..21e9eaf 100644 --- a/src/drivers/vpd/Kconfig +++ b/src/drivers/vpd/Kconfig @@ -18,11 +18,3 @@ default n help Enable support for flash based vital product data. - -if VPD - -config VPD_DEBUG - bool "Enable VPD debug output" - default n - -endif -- To view, visit https://review.coreboot.org/29608 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iba838309f8055d364c5f846ce29e628067d7b5f5 Gerrit-Change-Number: 29608 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Add Gerrit reviewers config emitter
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29607 Change subject: util/scripts/maintainers.go: Add Gerrit reviewers config emitter ...................................................................... util/scripts/maintainers.go: Add Gerrit reviewers config emitter The gerrit reviewers plugin has a certain configuration format. Teach maintainers to emit it when called with -print-gerrit-rules. Change-Id: I92cfc905e0c1b03b7cf793a4324c392140a22060 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29607/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 6d91b90..1204e95 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -286,10 +286,40 @@ return "^" + regex + "$" } +var is_email *regexp.Regexp + +func extract_maintainer(maintainer string) string { + if is_email == nil { + is_email = regexp.MustCompile("<[^>]*>") + } + + if match := is_email.FindStringSubmatch(maintainer); match != nil { + return match[0][1 : len(match[0])-1] + } + return maintainer +} + +func do_print_gerrit_rules() { + for _, subsystem := range subsystems { + if len(subsystem.paths) == 0 || len(subsystem.maintainer) == 0 { + continue + } + fmt.Println("#", subsystem.name) + for _, path := range subsystem.paths { + fmt.Println("[filter \"file:" + path_to_regexstr(path) + "\"]") + for _, maint := range subsystem.maintainer { + fmt.Println(" reviewer =", extract_maintainer(maint)) + } + } + fmt.Println() + } +} + func main() { var files []string var err error + var print_gerrit_rules = flag.Bool("print-gerrit-rules", false, "emit the MAINTAINERS rules in a format suitable for Gerrit's reviewers plugin") var debug = flag.Bool("debug", false, "emit additional debug output") flag.Parse() @@ -305,6 +335,11 @@ print_maintainers() } + if *print_gerrit_rules { + do_print_gerrit_rules() + return + } + args := flag.Args() if len(args) == 0 { /* get the filenames */ -- To view, visit https://review.coreboot.org/29607 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I92cfc905e0c1b03b7cf793a4324c392140a22060 Gerrit-Change-Number: 29607 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Introduce command line argument handling
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29606 Change subject: util/scripts/maintainers.go: Introduce command line argument handling ...................................................................... util/scripts/maintainers.go: Introduce command line argument handling First new option is -debug. Change-Id: Ia6e9b3675449a0b1e6f5d7526ee999f925eaadb2 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 20 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/29606/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 843a794..6d91b90 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -15,6 +15,7 @@ import ( "bufio" + "flag" "fmt" "log" "os" @@ -287,11 +288,24 @@ func main() { var files []string - var maint bool - var debug bool var err error - args := os.Args[1:] + var debug = flag.Bool("debug", false, "emit additional debug output") + flag.Parse() + + /* get and build subsystem database */ + maintainers, err := get_maintainers() + if err != nil { + log.Fatalf("Oops.") + return + } + build_maintainers(maintainers) + + if *debug { + print_maintainers() + } + + args := flag.Args() if len(args) == 0 { /* get the filenames */ files, err = get_git_files() @@ -299,33 +313,15 @@ log.Fatalf("Oops.") return } - maint = false + for _, file := range files { + find_unmaintained(file) + } } else { files = args - maint = true - } - maintainers, err := get_maintainers() - if err != nil { - log.Fatalf("Oops.") - return - } - - /* build subsystem database */ - build_maintainers(maintainers) - - if debug { - print_maintainers() - } - - if maint { /* Find maintainers for each file */ for _, file := range files { find_maintainer(file) } - } else { - for _, file := range files { - find_unmaintained(file) - } } } -- To view, visit https://review.coreboot.org/29606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6e9b3675449a0b1e6f5d7526ee999f925eaadb2 Gerrit-Change-Number: 29606 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Provide delimiters between maintainers
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29604 to look at the new patch set (#2). Change subject: util/scripts/maintainers.go: Provide delimiters between maintainers ...................................................................... util/scripts/maintainers.go: Provide delimiters between maintainers Help automated tools make sense of the output. Instead of "[name 1 <email> name 2 <email>]", it now prints "name 1 <email>, name 2 <email>". As long as there are no commas in the maintainer names, they can be split easily. Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29604/2 -- To view, visit https://review.coreboot.org/29604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a Gerrit-Change-Number: 29604 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/msi/ms9652_fam10: Remove unused VAR_MTRR_HOLE
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29605 Change subject: mb/msi/ms9652_fam10: Remove unused VAR_MTRR_HOLE ...................................................................... mb/msi/ms9652_fam10: Remove unused VAR_MTRR_HOLE Change-Id: Ibbc010c9550c0a50b1e913e198f9b575107572fb Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/msi/ms9652_fam10/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/29605/1 diff --git a/src/mainboard/msi/ms9652_fam10/Kconfig b/src/mainboard/msi/ms9652_fam10/Kconfig index 3440cad..080fc58 100644 --- a/src/mainboard/msi/ms9652_fam10/Kconfig +++ b/src/mainboard/msi/ms9652_fam10/Kconfig @@ -75,10 +75,6 @@ hex default 0x00 -config VAR_MTRR_HOLE - bool - default n - config APIC_ID_OFFSET hex default 0x00 -- To view, visit https://review.coreboot.org/29605 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibbc010c9550c0a50b1e913e198f9b575107572fb Gerrit-Change-Number: 29605 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Provide delimiters between maintainers
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29604 Change subject: util/scripts/maintainers.go: Provide delimiters between maintainers ...................................................................... util/scripts/maintainers.go: Provide delimiters between maintainers Help automated tools make sense of the output. Instead of "[name 1 <email> name 2 <email>]", it now prints "name 1 <email>, name 2 <email>". As long as there are no commas in the maintainer names, they can be split easily. Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29604/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index f99dc37..901817a 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -19,6 +19,7 @@ "log" "os" "os/exec" + "strings" "github.com/gobwas/glob" ) @@ -172,7 +173,7 @@ success = true fmt.Println(fname, "is in subsystem", subsystem.name) - fmt.Println("Maintainers: ", subsystem.maintainer) + fmt.Println("Maintainers: ", strings.Join(subsystem.maintainer, ", ")) } } if !success { -- To view, visit https://review.coreboot.org/29604 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4a254f566404b081a08923bc7ceb49f02039aa2a Gerrit-Change-Number: 29604 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scrips/maintainers.go: Allow file to appear in multiple components
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29602 Change subject: util/scrips/maintainers.go: Allow file to appear in multiple components ...................................................................... util/scrips/maintainers.go: Allow file to appear in multiple components Without this change, the tool only reports the first hit. We want to see all of them. Change-Id: Ib59b13c50b61c48e3cb200bf57e28c9453590819 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/29602/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 1b8b645..352d0a1 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -206,6 +206,7 @@ } func find_maintainer(fname string) { + success := false for _, subsystem := range subsystems { matched, err := match_file(fname, subsystem.file) if err != nil { @@ -213,16 +214,19 @@ return } if matched && subsystem.name != "THE REST" { + success = true fmt.Println(fname, "is in subsystem", subsystem.name) fmt.Println("Maintainers: ", subsystem.maintainer) - return } } - fmt.Println(fname, "has no subsystem defined in MAINTAINERS") + if !success { + fmt.Println(fname, "has no subsystem defined in MAINTAINERS") + } } func find_unmaintained(fname string) { + success := false for _, subsystem := range subsystems { matched, err := match_file(fname, subsystem.file) if err != nil { @@ -230,12 +234,14 @@ return } if matched && subsystem.name != "THE REST" { + success = true fmt.Println(fname, "is in subsystem", subsystem.name) - return } } - fmt.Println(fname, "has no subsystem defined in MAINTAINERS") + if !success { + fmt.Println(fname, "has no subsystem defined in MAINTAINERS") + } } func main() { -- To view, visit https://review.coreboot.org/29602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib59b13c50b61c48e3cb200bf57e28c9453590819 Gerrit-Change-Number: 29602 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Use a full glob parser
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29603 Change subject: util/scripts/maintainers.go: Use a full glob parser ...................................................................... util/scripts/maintainers.go: Use a full glob parser Instead of checking only for three cases, just use a glob parser. This requires to download the parser first, using: $ go get github.com/gobwas/glob # It's MIT licensed After that, maintainers src/arch/x86/memlayout.h emits: src/arch/x86/memlayout.h is in subsystem X86 ARCHITECTURE Maintainers: [] src/arch/x86/memlayout.h is in subsystem MEMLAYOUT Maintainers: [Julius Werner <jwerner(a)chromium.org>] The latter entry was invisible to the maintainers tool because its path description wasn't in one of the supported formats. Change-Id: I7e5cf4269415269552e35f2c73952ce3dff487e1 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 22 insertions(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/29603/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 352d0a1..f99dc37 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -19,13 +19,15 @@ "log" "os" "os/exec" - "path/filepath" + + "github.com/gobwas/glob" ) type subsystem struct { name string maintainer []string - file []string + paths []string + globs []glob.Glob } var subsystems []subsystem @@ -84,6 +86,14 @@ return maintainers, nil } +func path_to_glob(path string) glob.Glob { + // if prefix, allow all subdirectories + if path[len(path)-1] == '/' { + path += "**" + } + return glob.MustCompile(path) +} + func build_maintainers(maintainers []string) { var current *subsystem for _, line := range maintainers { @@ -119,9 +129,8 @@ case 'F': { // add files - current.file = - append(current.file, - line[3:len(line)]) + current.paths = append(current.paths, line[3:len(line)]) + current.globs = append(current.globs, path_to_glob(line[3:len(line)])) break } case 'W': @@ -142,77 +151,23 @@ for _, subsystem := range subsystems { fmt.Println(subsystem.name) fmt.Println(" ", subsystem.maintainer) - fmt.Println(" ", subsystem.file) + fmt.Println(" ", subsystem.paths) } } -func match_file(fname string, files []string) (bool, error) { - var matched bool - var err error - - for _, file := range files { - /* Direct match */ - matched, err = filepath.Match(file, fname) - if err != nil { - return false, err - } - if matched { - return true, nil - } - - /* There are three cases that match_file can handle: - * - * dirname/filename - * dirname/* - * dirname/ - * - * The first case is an exact match, the second case is a - * direct match of everything in that directory, and the third - * is a direct match of everything in that directory and its - * subdirectories. - * - * The first two cases are handled above, the code below is - * only for that latter case, so if file doesn't end in /, - * skip to the next file. - */ - if file[len(file)-1] != '/' { - continue - } - - /* Remove / because we add it again below */ - file = file[:len(file)-1] - - /* Maximum tree depth, as calculated by - * $(( `git ls-files | tr -d "[a-z][A-Z][0-9]\-\_\." | \ - * sort -u | tail -1 | wc -c` - 1 )) - * 11 - */ - max_depth := 11 - - for i := 0; i < max_depth; i++ { - /* Subdirectory match */ - file += "/*" - - if matched, err = filepath.Match(file, fname); err != nil { - return false, err - } - if matched { - return true, nil - } - +func match_file(fname string, component subsystem) bool { + for _, glob := range component.globs { + if glob.Match(fname) { + return true } } - return false, nil + return false } func find_maintainer(fname string) { success := false for _, subsystem := range subsystems { - matched, err := match_file(fname, subsystem.file) - if err != nil { - log.Fatalf("match_file failed: %v", err) - return - } + matched := match_file(fname, subsystem) if matched && subsystem.name != "THE REST" { success = true fmt.Println(fname, "is in subsystem", @@ -228,11 +183,7 @@ func find_unmaintained(fname string) { success := false for _, subsystem := range subsystems { - matched, err := match_file(fname, subsystem.file) - if err != nil { - log.Fatalf("match_file failed: %v", err) - return - } + matched := match_file(fname, subsystem) if matched && subsystem.name != "THE REST" { success = true fmt.Println(fname, "is in subsystem", -- To view, visit https://review.coreboot.org/29603 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7e5cf4269415269552e35f2c73952ce3dff487e1 Gerrit-Change-Number: 29603 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Stub support for website tag
by Patrick Georgi (Code Review) 12 Nov '18

12 Nov '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29601 Change subject: util/scripts/maintainers.go: Stub support for website tag ...................................................................... util/scripts/maintainers.go: Stub support for website tag ME Cleaner's component has an entry specifying its website, which this parser didn't know how to handle. Avoid the resulting warning. Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/scripts/maintainers.go 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/29601/1 diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 03c7709..1b8b645 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -124,6 +124,10 @@ line[3:len(line)]) break } + case 'W': + { + break + } default: { fmt.Println("No such specifier: ", line) -- To view, visit https://review.coreboot.org/29601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Gerrit-Change-Number: 29601 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018