coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: soc/intel/common: Add option to call EC _PTS/_WAK methods
by Furquan Shaikh (Code Review) 12 Nov '18

12 Nov '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29487 ) Change subject: soc/intel/common: Add option to call EC _PTS/_WAK methods ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/29487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Gerrit-Change-Number: 29487 Gerrit-PatchSet: 5 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 22:15:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/intel/common: Add option to call EC _PTS/_WAK methods
by Duncan Laurie (Code Review) 12 Nov '18

12 Nov '18

Hello Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29487 to look at the new patch set (#5). Change subject: soc/intel/common: Add option to call EC _PTS/_WAK methods ...................................................................... soc/intel/common: Add option to call EC _PTS/_WAK methods Some embedded controllers expect to be sent a command when the OS calls the ACPI \_PTS and \_WAK methods. For example see the code in ec/google/wilco/acpi/platform.asl that tells the EC when the methods have been executed by the OS. Not all ECs may define these methods so this change requires also setting a Kconfig option to enable it. Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/soc/intel/common/Kconfig M src/soc/intel/common/acpi/platform.asl 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29487/5 -- To view, visit https://review.coreboot.org/29487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Gerrit-Change-Number: 29487 Gerrit-PatchSet: 5 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: soc/intel/common: Add option to call EC _PTS/_WAK methods
by Duncan Laurie (Code Review) 12 Nov '18

12 Nov '18

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/29487 ) Change subject: soc/intel/common: Add option to call EC _PTS/_WAK methods ...................................................................... Patch Set 4: This is going to have issues in chromium as well so I just put it behind a kconfig option. -- To view, visit https://review.coreboot.org/29487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Gerrit-Change-Number: 29487 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 21:54:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/sarien: Enable EC _PTS/_WAK methods
by Duncan Laurie (Code Review) 12 Nov '18

12 Nov '18

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/29614 Change subject: mb/google/sarien: Enable EC _PTS/_WAK methods ...................................................................... mb/google/sarien: Enable EC _PTS/_WAK methods Enable the option to have the system level _PTS/_WAK methods call the EC provided methods when they are invoked by the OS. Verified on sarien board by inspecting dsdt.dsl: Method (_PTS, 1, NotSerialized) // _PTS: Prepare To Sleep { DBG0 = 0x96 \_SB.PCI0.LPCB.EC0.PTS (Arg0) } Method (_WAK, 1, NotSerialized) // _WAK: Wake { DBG0 = 0x97 \_SB.PCI0.LPCB.EC0.WAK (Arg0) Return (Package (0x02) { Zero, Zero }) } Change-Id: I52be1c1cd7adae9ad317a51868735eb87a410549 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/mainboard/google/sarien/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/29614/1 diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index e571be2..7494edd 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -15,6 +15,7 @@ select MAINBOARD_HAS_TPM2 select SOC_INTEL_COFFEELAKE select SOC_INTEL_CANNONLAKE_MEMCFG_INIT + select SOC_INTEL_COMMON_ACPI_EC_PTS_WAK select SOC_INTEL_COMMON_BLOCK_SMM_ESPI_ACPI_DIS select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP -- To view, visit https://review.coreboot.org/29614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I52be1c1cd7adae9ad317a51868735eb87a410549 Gerrit-Change-Number: 29614 Gerrit-PatchSet: 1 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org>

1 0

Change in coreboot[master]: soc/intel/common: Add option to call EC _PTS/_WAK methods
by Duncan Laurie (Code Review) 12 Nov '18

12 Nov '18

Hello Philipp Deppenwiese, build bot (Jenkins), Martin Roth, Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/29487 to look at the new patch set (#4). Change subject: soc/intel/common: Add option to call EC _PTS/_WAK methods ...................................................................... soc/intel/common: Add option to call EC _PTS/_WAK methods Some embedded controllers expect to be sent a command when the OS calls the ACPI \_PTS and \_WAK methods. For example see the code in ec/google/wilco/acpi/platform.asl that tells the EC when the methods have been executed by the OS. Not all ECs may define these methods so this change requires also setting a Kconfig option to enable it. Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Signed-off-by: Duncan Laurie <dlaurie(a)google.com> --- M src/soc/intel/common/Kconfig M src/soc/intel/common/acpi/platform.asl 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/29487/4 -- To view, visit https://review.coreboot.org/29487 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10 Gerrit-Change-Number: 29487 Gerrit-PatchSet: 4 Gerrit-Owner: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>

1 0

Change in coreboot[master]: util/scrips/maintainers.go: Allow file to appear in multiple components
by Philipp Deppenwiese (Code Review) 12 Nov '18

12 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29602 ) Change subject: util/scrips/maintainers.go: Allow file to appear in multiple components ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29602 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib59b13c50b61c48e3cb200bf57e28c9453590819 Gerrit-Change-Number: 29602 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Ronald Minnich <rminnich(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 21:14:32 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Stub support for website tag
by Philipp Deppenwiese (Code Review) 12 Nov '18

12 Nov '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29601 ) Change subject: util/scripts/maintainers.go: Stub support for website tag ...................................................................... util/scripts/maintainers.go: Stub support for website tag ME Cleaner's component has an entry specifying its website, which this parser didn't know how to handle. Avoid the resulting warning. While at it, de-C the switch statement and make it work go-style. This also fixes "R" statements being ignored. Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/29601 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M util/scripts/maintainers.go 1 file changed, 7 insertions(+), 32 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 03c7709..a457581 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -95,40 +95,15 @@ current.name = line } else { switch line[0] { - case 'R': - case 'M': - { - /* Add subsystem maintainer */ - current.maintainer = - append(current.maintainer, - line[3:len(line)]) - break - } - case 'S': - { - break - } - case 'L': - { - break - } - case 'T': - { - break - } + case 'R', 'M': + /* Add subsystem maintainer */ + current.maintainer = append(current.maintainer, line[3:len(line)]) case 'F': - { - // add files - current.file = - append(current.file, - line[3:len(line)]) - break - } + // add files + current.file = append(current.file, line[3:len(line)]) + case 'L', 'S', 'T', 'W': // ignore default: - { - fmt.Println("No such specifier: ", line) - break - } + fmt.Println("No such specifier: ", line) } } } -- To view, visit https://review.coreboot.org/29601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Gerrit-Change-Number: 29601 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Ronald Minnich <rminnich(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/scripts/maintainers.go: Stub support for website tag
by Philipp Deppenwiese (Code Review) 12 Nov '18

12 Nov '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29601 ) Change subject: util/scripts/maintainers.go: Stub support for website tag ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29601 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Gerrit-Change-Number: 29601 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Ronald Minnich <rminnich(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 21:13:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: (console, drivers/uart)/Kconfig: Fix dependencies
by Julius Werner (Code Review) 12 Nov '18

12 Nov '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/29572 ) Change subject: (console,drivers/uart)/Kconfig: Fix dependencies ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/29572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 21:05:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_6{9, D}X
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded a new patch set (#2). ( https://review.coreboot.org/29613 ) Change subject: cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_6{9,D}X ...................................................................... cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_6{9,D}X Makefile.inc uses already model_6{9,d}x subdirs. Change-Id: I0bfc179a83fab85e5b924751e026d906d01b3fb6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/socket_mFCPGA478/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29613/2 -- To view, visit https://review.coreboot.org/29613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0bfc179a83fab85e5b924751e026d906d01b3fb6 Gerrit-Change-Number: 29613 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018