coreboot-gerrit November 2018

coreboot-gerrit@coreboot.org

1 participants
1699 discussions

Change in coreboot[master]: cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_69X
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29613 Change subject: cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_69X ...................................................................... cpu/intel/socket_mFCPGA478/Kconfig: Add MODEL_69X Makefile.inc uses already model_69x subdir. Change-Id: I0bfc179a83fab85e5b924751e026d906d01b3fb6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/socket_mFCPGA478/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/29613/1 diff --git a/src/cpu/intel/socket_mFCPGA478/Kconfig b/src/cpu/intel/socket_mFCPGA478/Kconfig index 075abad..69b21ba 100644 --- a/src/cpu/intel/socket_mFCPGA478/Kconfig +++ b/src/cpu/intel/socket_mFCPGA478/Kconfig @@ -5,6 +5,7 @@ config SOCKET_SPECIFIC_OPTIONS # dummy def_bool y + select CPU_INTEL_MODEL_69X select CPU_INTEL_MODEL_6EX select CPU_INTEL_MODEL_6FX select MMX -- To view, visit https://review.coreboot.org/29613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0bfc179a83fab85e5b924751e026d906d01b3fb6 Gerrit-Change-Number: 29613 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/{google/cyan, intel/strago}: Remove unused DYNAMIC_VNN_SUPPORT
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29612 Change subject: mb/{google/cyan,intel/strago}: Remove unused DYNAMIC_VNN_SUPPORT ...................................................................... mb/{google/cyan,intel/strago}: Remove unused DYNAMIC_VNN_SUPPORT Change-Id: I4d0df30255d006c0399dde1b3ba8ee513d98dc0a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/cyan/Kconfig M src/mainboard/intel/strago/Kconfig 2 files changed, 0 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/29612/1 diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 7520410..981ca83 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -30,10 +30,6 @@ help When enabled displays the memory configuration data. -config DYNAMIC_VNN_SUPPORT - bool "Enables support for Dynamic VNN" - default n - config MAINBOARD_DIR string default google/cyan diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index bef0e63..4aa7640 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -21,9 +21,6 @@ select VBOOT_LID_SWITCH select VBOOT_VBNV_CMOS -config DYNAMIC_VNN_SUPPORT - bool "Enables support for Dynamic VNN" - default n config MAINBOARD_DIR string default intel/strago -- To view, visit https://review.coreboot.org/29612 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4d0df30255d006c0399dde1b3ba8ee513d98dc0a Gerrit-Change-Number: 29612 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: amd/{nb/amdfam10, cpu/pi}/Kconfig: Remove unused symbols
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29597 to look at the new patch set (#2). Change subject: amd/{nb/amdfam10,cpu/pi}/Kconfig: Remove unused symbols ...................................................................... amd/{nb/amdfam10,cpu/pi}/Kconfig: Remove unused symbols Change-Id: I7019d70b7e6f8ae041a12d6bab83127e9e70868c Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/pi/00630F01/Kconfig M src/cpu/amd/pi/00660F01/Kconfig M src/cpu/amd/pi/00730F01/Kconfig M src/northbridge/amd/amdfam10/Kconfig 4 files changed, 0 insertions(+), 51 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/29597/2 -- To view, visit https://review.coreboot.org/29597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7019d70b7e6f8ae041a12d6bab83127e9e70868c Gerrit-Change-Number: 29597 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/qualcomm/ipq{40xx, 806x}/Kconfig: Remove unused MBN_ENCAPSULATION
by Julius Werner (Code Review) 12 Nov '18

12 Nov '18

Julius Werner has posted comments on this change. ( https://review.coreboot.org/29610 ) Change subject: soc/qualcomm/ipq{40xx,806x}/Kconfig: Remove unused MBN_ENCAPSULATION ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/29610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cf5cd1d3bed7188590e4f143d8f14dc9e58b183 Gerrit-Change-Number: 29610 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 19:29:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: (console, drivers/uart)/Kconfig: Fix dependencies
by Nico Huber (Code Review) 12 Nov '18

12 Nov '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29572 to look at the new patch set (#2). Change subject: (console,drivers/uart)/Kconfig: Fix dependencies ...................................................................... (console,drivers/uart)/Kconfig: Fix dependencies The dependencies of CONSOLE_SERIAL and DRIVERS_UART were somehow backwards. Fix that. Now, CONSOLE_SERIAL depends on DRIVERS_UART, because it's using its interface. The individual UART drivers select DRIVERS_UART, because they implement the interface and depend on the common UART code. Some guards had to be fixed (using CONSOLE_SERIAL now instead of DRIVERS_UART). Some other guards that were only about compilation of units were removed. We want to build test as much as possible, right? Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M src/console/Kconfig M src/cpu/allwinner/a10/Makefile.inc M src/cpu/ti/am335x/Makefile.inc M src/drivers/uart/Kconfig M src/mainboard/google/gru/bootblock.c M src/mainboard/google/veyron/bootblock.c M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_rialto/bootblock.c M src/soc/broadcom/cygnus/Makefile.inc M src/soc/imgtec/pistachio/Makefile.inc M src/soc/mediatek/mt8173/Makefile.inc M src/soc/mediatek/mt8183/Makefile.inc M src/soc/nvidia/tegra124/Makefile.inc M src/soc/nvidia/tegra210/Makefile.inc M src/soc/qualcomm/ipq40xx/Makefile.inc M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/Makefile.inc M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/sdm845/Makefile.inc M src/soc/rockchip/rk3288/Makefile.inc M src/soc/rockchip/rk3399/Makefile.inc M src/soc/samsung/exynos5250/Makefile.inc 22 files changed, 58 insertions(+), 89 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/29572/2 -- To view, visit https://review.coreboot.org/29572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0ea73a8909f07202b23c88db93df74cf9dc8abf9 Gerrit-Change-Number: 29572 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/intelvbttool: Cleanup and fixes
by Patrick Rudolph (Code Review) 12 Nov '18

12 Nov '18

Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/29099 ) Change subject: util/intelvbttool: Cleanup and fixes ...................................................................... util/intelvbttool: Cleanup and fixes * Clear remalloced memory * Fix check for invalid VBT offset in header * Fix VBIOS checksum generation * Fix VBIOS size field * Align VBIOS size to multiple of 512 * Reassign pointers after use of remalloc * Don't leak on error path Current version is enough to allow the proprietary Windows Intel GMA driver to find the VBT in the legacy VBIOS area and it doesn't BSOD any more. The LVDS screen remains black, due to an unknown issue with the proprietary driver, while the VGA works. Tested with libgfxinit and native graphics init. Change-Id: If07b1bb51d8fb3499d13102f70fedb36c020fb72 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Reviewed-on: https://review.coreboot.org/29099 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/intelvbttool/intelvbttool.c 1 file changed, 51 insertions(+), 52 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved diff --git a/util/intelvbttool/intelvbttool.c b/util/intelvbttool/intelvbttool.c index c8b973e..1444129 100644 --- a/util/intelvbttool/intelvbttool.c +++ b/util/intelvbttool/intelvbttool.c @@ -341,10 +341,12 @@ return NULL; fo->data = realloc(fo->data, size); - if (!fo->data) return NULL; + if (fo->size < size) + memset(&fo->data[fo->size], 0, size - fo->size); + fo->size = size; return fo; @@ -882,7 +884,6 @@ struct fileobject **vbt) { const optionrom_header_t *oh = (const optionrom_header_t *)fo->data; - const struct vbt_header *head; size_t i; *vbt = NULL; @@ -897,24 +898,23 @@ return; } - head = (const struct vbt_header *)fo->data; - if (memcmp(head->signature, "$VBT", 4) == 0) { - parse_vbt(fo, vbt); + struct fileobject *fo_vbt = malloc_fo_sub(fo, oh->vbt_offset); + if (fo_vbt) { + parse_vbt(fo_vbt, vbt); + free_fo(fo_vbt); if (*vbt) return; } - - printwarn("VBT wasn't found at specified offset\n"); + printwarn("VBT wasn't found at specified offset of %04x\n", + oh->vbt_offset); for (i = sizeof(optionrom_header_t); i <= fo->size - sizeof(struct vbt_header); i++) { struct fileobject *fo_vbt = malloc_fo_sub(fo, i); if (!fo_vbt) - continue; + break; - head = (const struct vbt_header *)fo_vbt->data; - if (memcmp(head->signature, "$VBT", 4) == 0) - parse_vbt(fo_vbt, vbt); + parse_vbt(fo_vbt, vbt); free_fo(fo_vbt); @@ -980,32 +980,28 @@ }; } -/* Open a VBIOS file, calculate the checksum and fix it */ -static int fix_vbios_checksum(const char *filename) +/* Fix VBIOS header and PCIR */ +static int fix_vbios_header(struct fileobject *fo) { - struct fileobject *fo = read_file(filename); - if (!fo) { - printerr("%s open failed\n", filename); - return 1; - } - - if (fo->size < sizeof(optionrom_header_t)) + if (!fo || fo->size < sizeof(optionrom_header_t)) return 1; optionrom_header_t *oh = (optionrom_header_t *)fo->data; - if (oh->size * 512 > fo->size) - return 1; - - /* fix checksum */ - oh->checksum = -(checksum_vbios(oh) - oh->checksum); - - if (write_file(filename, fo)) { - printerr("%s write failed\n", filename); - free_fo(fo); - return 1; + /* Fix size alignment */ + if (fo->size % 512) { + print("Aligning size to 512\n"); + fo = remalloc_fo(fo, (fo->size + 511) / 512 * 512); + if (!fo) + return 1; + oh = (optionrom_header_t *)fo->data; } - free_fo(fo); + + /* Fix size field */ + oh->size = fo->size / 512; + + /* Fix checksum field */ + oh->checksum = -(checksum_vbios(oh) - oh->checksum); return 0; } @@ -1042,8 +1038,10 @@ fo = remalloc_fo(fo, fo->size - vbt_size(old_vbt)); if (!fo) { printerr("Failed to allocate memory\n"); + free_fo(old_vbt); return 1; } + oh = (optionrom_header_t *)fo->data; oh->vbt_offset = 0; } else if (vbt_size(old_vbt) < vbt_size(fo_vbt)) { /* In the middle of the file - Remove old VBT */ @@ -1061,7 +1059,7 @@ if (!oh->vbt_offset) { print("increasing VBIOS to append VBT\n"); - if ((fo->size + vbt_size(fo_vbt)) >= 64 * KiB) { + if ((fo->size + vbt_size(fo_vbt)) >= 2 * 64 * KiB) { printerr("VBT won't fit\n"); return 1; } @@ -1072,7 +1070,7 @@ printerr("Failed to allocate memory\n"); return 1; } - oh->size = (fo->size + 512 - 1) / 512; + oh = (optionrom_header_t *)fo->data; } head = (struct vbt_header *)((u8 *)oh + oh->vbt_offset); @@ -1083,7 +1081,7 @@ int main(int argc, char **argv) { - int opt, option_index = 0; + int opt, ret, option_index = 0; size_t has_input = 0, has_output = 0; size_t dump = 0, in_legacy = 0; @@ -1180,40 +1178,41 @@ if (!dump) print_vbt(vbt); + ret = 0; if (dump) { dump_vbt(vbt); } else if (out_vbt) { - if (write_file(out_vbt, vbt)) + if (write_file(out_vbt, vbt)) { printerr("Failed to write VBT\n"); - else + ret = 1; + } else { print("VBT written to %s\n", out_vbt); + } } else if (patch_oprom) { fo = read_file(patch_oprom); if (!fo) { printerr("Failed to read input file\n"); - return 1; + ret = 1; } - if (!is_valid_vbios(fo)) { + if (ret != 1 && !is_valid_vbios(fo)) { printerr("Invalid input file\n"); - free_fo(fo); - return 1; + ret = 1; } - if (patch_vbios(fo, vbt)) { + if (ret != 1 && patch_vbios(fo, vbt)) { printerr("Failed to patch VBIOS\n"); - free_fo(fo); - return 1; + ret = 1; } - if (write_file(patch_oprom, fo)) { + if (ret != 1 && fix_vbios_header(fo)) { + printerr("Failed to fix VBIOS header\n"); + ret = 1; + } + if (ret != 1 && write_file(patch_oprom, fo)) { printerr("Failed to write VBIOS\n"); - free_fo(fo); - return 1; + ret = 1; } free_fo(fo); - if (fix_vbios_checksum(patch_oprom)) { - printerr("Failed to fix checksum\n"); - return 1; - } - print("VBIOS %s successfully patched\n", patch_oprom); + if (ret != 1) + print("VBIOS %s successfully patched\n", patch_oprom); } /* cleanup */ @@ -1228,5 +1227,5 @@ free_fo(vbt); - return 0; + return ret; } -- To view, visit https://review.coreboot.org/29099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If07b1bb51d8fb3499d13102f70fedb36c020fb72 Gerrit-Change-Number: 29099 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: util/intelvbttool: Cleanup and fixes
by Patrick Rudolph (Code Review) 12 Nov '18

12 Nov '18

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29099 ) Change subject: util/intelvbttool: Cleanup and fixes ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/29099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If07b1bb51d8fb3499d13102f70fedb36c020fb72 Gerrit-Change-Number: 29099 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 12 Nov 2018 18:40:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/emulation/qemu-i440fx|q35: Fix stack size
by Patrick Rudolph (Code Review) 12 Nov '18

12 Nov '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/29611 Change subject: mb/emulation/qemu-i440fx|q35: Fix stack size ...................................................................... mb/emulation/qemu-i440fx|q35: Fix stack size Current implementation works by luck as DCACHE area is actually RAM and stack can grow and use that RAM outside of the area. * Set DCACHE_BSP_STACK_SIZE to 0x4000. * Add an assert to make sure it is set to a sane value on all platforms. Change-Id: I71f9d74d89e4129cdc4a850acc4fc1ac90e5f628 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/arch/x86/car.ld M src/mainboard/emulation/qemu-i440fx/Kconfig M src/mainboard/emulation/qemu-q35/Kconfig 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/29611/1 diff --git a/src/arch/x86/car.ld b/src/arch/x86/car.ld index 33fb5c9..4472b42 100644 --- a/src/arch/x86/car.ld +++ b/src/arch/x86/car.ld @@ -113,3 +113,6 @@ #if IS_ENABLED(CONFIG_PAGING_IN_CACHE_AS_RAM) _bogus2 = ASSERT(_pagetables == ALIGN(_pagetables, 4096), "_pagetables aren't 4KiB aligned"); #endif +#if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK) +_bogus3 = ASSERT(CONFIG_DCACHE_BSP_STACK_SIZE > 0x0, "BSP stack size is to small"); +#endif \ No newline at end of file diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 2435729..4454e67 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -41,4 +41,8 @@ hex default 0x4000 +config DCACHE_BSP_STACK_SIZE + hex + default 0x4000 + endif # BOARD_EMULATION_QEMU_X86_I440FX diff --git a/src/mainboard/emulation/qemu-q35/Kconfig b/src/mainboard/emulation/qemu-q35/Kconfig index 4394530..3be034a 100644 --- a/src/mainboard/emulation/qemu-q35/Kconfig +++ b/src/mainboard/emulation/qemu-q35/Kconfig @@ -49,4 +49,8 @@ hex default 0x4000 +config DCACHE_BSP_STACK_SIZE + hex + default 0x4000 + endif # BOARD_EMULATION_QEMU_X86_Q35 -- To view, visit https://review.coreboot.org/29611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I71f9d74d89e4129cdc4a850acc4fc1ac90e5f628 Gerrit-Change-Number: 29611 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: soc/intel: Clean mess around UART_DEBUG
by Aaron Durbin (Code Review) 12 Nov '18

12 Nov '18

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/29573 ) Change subject: soc/intel: Clean mess around UART_DEBUG ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/29573/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29573/1//COMMIT_MSG@10 PS1, Line 10: Based on Kconfig prompts the SoC code performed pad configu- : rations! Which chipset? And what exactly were the bad configurations? https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kco… File src/soc/intel/common/block/uart/Kconfig: https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kco… PS1, Line 20: bool We have 2 different builds with chromium. 1 with serial console and 1 w/o. By not making this option visible we can't select it with a local .config file. -- To view, visit https://review.coreboot.org/29573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe2ed3cab0bb04bb23989c22da45299f088c758b Gerrit-Change-Number: 29573 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)gmail.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 18:23:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: soc/qualcomm/ipq{40xx, 806x}/Kconfig: Remove unused MBN_ENCAPSULATION
by Elyes HAOUAS (Code Review) 12 Nov '18

12 Nov '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29610 Change subject: soc/qualcomm/ipq{40xx,806x}/Kconfig: Remove unused MBN_ENCAPSULATION ...................................................................... soc/qualcomm/ipq{40xx,806x}/Kconfig: Remove unused MBN_ENCAPSULATION Change-Id: I4cf5cd1d3bed7188590e4f143d8f14dc9e58b183 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/ipq40xx/Kconfig M src/soc/qualcomm/ipq806x/Kconfig 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/29610/1 diff --git a/src/soc/qualcomm/ipq40xx/Kconfig b/src/soc/qualcomm/ipq40xx/Kconfig index b0d3f07..2cfcd2d 100644 --- a/src/soc/qualcomm/ipq40xx/Kconfig +++ b/src/soc/qualcomm/ipq40xx/Kconfig @@ -24,11 +24,6 @@ help Is the SoC a QFN part (as opposed to a BGA part) -config MBN_ENCAPSULATION - depends on USE_BLOBS - bool "bootblock encapsulation for ipq40xx" - default y - config CDT_MBN string "CDT binary blob" default "cdt-AP.DK01.1-C1.bin" diff --git a/src/soc/qualcomm/ipq806x/Kconfig b/src/soc/qualcomm/ipq806x/Kconfig index 54300eb..a6262d0 100644 --- a/src/soc/qualcomm/ipq806x/Kconfig +++ b/src/soc/qualcomm/ipq806x/Kconfig @@ -17,11 +17,6 @@ select VBOOT_SEPARATE_VERSTAGE select VBOOT_RETURN_FROM_VERSTAGE -config MBN_ENCAPSULATION - depends on USE_BLOBS - bool "bootblock encapsulation for ipq8064" - default y - config SBL_BLOB depends on USE_BLOBS string "file name of the Qualcomm SBL blob" -- To view, visit https://review.coreboot.org/29610 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4cf5cd1d3bed7188590e4f143d8f14dc9e58b183 Gerrit-Change-Number: 29610 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2018