coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: amd/stoneyridge: Convert hex definitions to lower case
by Richard Spiegel (Code Review) 11 Oct '18

11 Oct '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29009 ) Change subject: amd/stoneyridge: Convert hex definitions to lower case ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge… File src/soc/amd/stoneyridge/southbridge.c: https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge… PS1, Line 593: cfg5 |= (0x2 << … [View More]

1 0

Change in coreboot[master]: amd/stoneyridge: Remove hudson register definitions
by Richard Spiegel (Code Review) 11 Oct '18

11 Oct '18

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29008 ) Change subject: amd/stoneyridge: Remove hudson register definitions ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29008/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29008/1//COMMIT_MSG@7 PS1, Line 7: amd/stoneyridge Only one file is changed, and it's a header file. So at a minimum: amd/stoneyridge/… [View More]

1 0

Change in coreboot[master]: Enable Serial Debug for UEFI payload Debug build
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29004 ) Change subject: Enable Serial Debug for UEFI payload Debug build ...................................................................... Patch Set 3: Code-Review-2 Let's commit upstream to TianoCore -- To view, visit https://review.coreboot.org/29004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-… [View More]

1 0

Change in coreboot[master]: payloads/tianocore: rebase patches to UDK2018 release
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27615 ) Change subject: payloads/tianocore: rebase patches to UDK2018 release ...................................................................... Patch Set 1: Code-Review-2 @Piotr Let's commit upstream to TianoCore -- To view, visit https://review.coreboot.org/27615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: … [View More]

1 0

Change in coreboot[master]: Documentation: Improve message printed by livesphinx target
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28992 ) Change subject: Documentation: Improve message printed by livesphinx target ...................................................................... Documentation: Improve message printed by livesphinx target Printing "Autobuild finished" after the autobuild server exits (which normally doesn't happen) is not very useful. Change-Id: I909d7ab5f399993dbb1916e66ba94c48d7bc53bf Signed-off-by: … [View More]

1 0

Change in coreboot[master]: Documentation: Add and link the arch directory
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28991 ) Change subject: Documentation: Add and link the arch directory ...................................................................... Documentation: Add and link the arch directory Fixes: b159d5ba8f ("riscv: add documentation for stages and payloads") Change-Id: I5ca8ed094c9b6d115da707375205872e782a66b2 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Reviewed-on: https://… [View More]

1 0

Change in coreboot[master]: Documentation/releases: Improve readability
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28990 ) Change subject: Documentation/releases: Improve readability ...................................................................... Documentation/releases: Improve readability A colon usually indicates that something related follows. But in Documentation/releases/index.md, nothing followed. Fix this by swapping two lines. Change-Id: I3e2750c208a2b725145b94615f64381ac763f0dc Signed-off-by: … [View More]

1 0

Change in coreboot[master]: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep...
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/27614 ) Change subject: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table ...................................................................... payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table Mentioned patch could not be applied in coreboot-sdk:1.52. With this fix patch apply correctly. Change-Id: … [View More]I130856520f91bcfbd9a62741b1d5abb6495a6eac Signed-off-by: Piotr Król <piotr.krol(a)3mdeb.com> Reviewed-on: https://review.coreboot.org/27614 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> --- M payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved diff --git a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch index e75052b..da8fc7f 100644 --- a/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch +++ b/payloads/external/tianocore/patches/06_CorebootPayloadPkg_keep_cb_table.patch @@ -1,13 +1,16 @@ -From ef89b11ce6f93c96fbd1753a8006dd9c3da212e0 Mon Sep 17 00:00:00 2001 +From 336ce69129206ea6cb5bea2a99c5f00e77850518 Mon Sep 17 00:00:00 2001 From: ReddestDream <reddestdream(a)gmail.com> Date: Wed, 3 May 2017 00:13:28 -0400 Subject: [PATCH] CbSupportPei: prevent lower coreboot table from being overwritten Exclude the bottom 4kb from being included in System Memory HoB +--- + CorebootModulePkg/CbSupportPei/CbSupportPei.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CorebootModulePkg/CbSupportPei/CbSupportPei.c b/CorebootModulePkg/CbSupportPei/CbSupportPei.c -index 262e6b9..d3c5723 100755 +index 831de89b21d1..e84b9b55288a 100755 --- a/CorebootModulePkg/CbSupportPei/CbSupportPei.c +++ b/CorebootModulePkg/CbSupportPei/CbSupportPei.c @@ -261,8 +261,9 @@ CbPeiEntryPoint ( @@ -20,7 +23,8 @@ + (EFI_PHYSICAL_ADDRESS)(0 + 0x1000), + (UINT64)(0xA0000 - 0x1000) ); + + +-- +2.17.0 - --- -2.14.0 -- To view, visit https://review.coreboot.org/27614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I130856520f91bcfbd9a62741b1d5abb6495a6eac Gerrit-Change-Number: 27614 Gerrit-PatchSet: 2 Gerrit-Owner: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Krystian Hebel (1002088) Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> [View Less]

1 0

Change in coreboot[master]: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep...
by Philipp Deppenwiese (Code Review) 11 Oct '18

11 Oct '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/27614 ) Change subject: payloads/tianocore: Fix not applying patch 06_CorebootPayloadPkg_keep_cb_table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/27614 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-… [View More]

1 0

Change in coreboot[master]: mb/google/octopus: I2C clock tuning for meep
by Wisley Chen (Code Review) 11 Oct '18

11 Oct '18

Wisley Chen has uploaded this change for review. ( https://review.coreboot.org/29021 Change subject: mb/google/octopus: I2C clock tuning for meep ...................................................................... mb/google/octopus: I2C clock tuning for meep Tune I2C params for I2C buses 0, 5, 6, and 7 to ensure that the frequency does not exceed 400KHz. BUG=b:117298114 TEST=emerge-octopus coreboot chromeos-bootimage and measured frequency under 400 KHz Change-Id: … [View More]Id608aae7edf54a24f364606dd7952521d1d67c1a Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/mainboard/google/octopus/variants/meep/overridetree.cb 1 file changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/29021/1 diff --git a/src/mainboard/google/octopus/variants/meep/overridetree.cb b/src/mainboard/google/octopus/variants/meep/overridetree.cb index 42bd83b..691fa9e 100644 --- a/src/mainboard/google/octopus/variants/meep/overridetree.cb +++ b/src/mainboard/google/octopus/variants/meep/overridetree.cb @@ -1,5 +1,46 @@ chip soc/intel/apollolake + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| I2C0 | Digitizer | + #| I2C5 | Audio | + #| I2C6 | Trackpad | + #| I2C7 | Touchscreen | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 120, + .fall_time_ns = 30, + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 104, + .fall_time_ns = 52, + }, + .i2c[6] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 66, + .fall_time_ns = 90, + .data_hold_time_ns = 350, + }, + .i2c[7] = { + .speed = I2C_SPEED_FAST, + .rise_time_ns = 44, + .fall_time_ns = 90, + }, + }" + device domain 0 on device pci 16.0 on chip drivers/i2c/hid -- To view, visit https://review.coreboot.org/29021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id608aae7edf54a24f364606dd7952521d1d67c1a Gerrit-Change-Number: 29021 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018