Angel Pons has posted comments on this change. ( https://review.coreboot.org/28993 )
Change subject: arch/x86/exception: Improve the readability of a comment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/28993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic61c665f7e2daefb50b478a1710ea66c8a88235a
Gerrit-Change-Number: 28993
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 19:52:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Angel Pons has posted comments on this change. ( https://review.coreboot.org/28971 )
Change subject: src/superio/smsc/smscsuperio/superio.c: Add SCH5504
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+1
>
> looks good to me; I'd like to wait with +2ing this until there is a patch adding mainboard with this superio in the review system though
I plan on supporting a Dell Optiplex GX520 with this thing, I hope I can port it soon...
--
To view, visit https://review.coreboot.org/28971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c433fa04c01ba6315bcdca699030dfce18a169a
Gerrit-Change-Number: 28971
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 18:46:12 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29004
to look at the new patch set (#3).
Change subject: Enable Serial Debug for UEFI payload Debug build
......................................................................
Enable Serial Debug for UEFI payload Debug build
Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
---
R payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch
1 file changed, 35 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29004/3
--
To view, visit https://review.coreboot.org/29004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Gerrit-Change-Number: 29004
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Wonkyu Kim has uploaded a new patch set (#2). ( https://review.coreboot.org/29004 )
Change subject: Enable Serial Debug for UEFI payload Debug build
......................................................................
Enable Serial Debug for UEFI payload Debug build
Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Signed-off-by: Wonkyu Kim <wonkyu.kim(a)intel.com>
---
R payloads/external/tianocore/patches/05_CorebootPayloadPkg-don-t-use-serial-output-for-Relea.patch
1 file changed, 33 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/29004/2
--
To view, visit https://review.coreboot.org/29004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Gerrit-Change-Number: 29004
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>