coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: arch/x86/exception: Improve the readability of a comment
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28993 Change subject: arch/x86/exception: Improve the readability of a comment ...................................................................... arch/x86/exception: Improve the readability of a comment Add punctuation and fix a typo. Change-Id: Ic61c665f7e2daefb50b478a1710ea66c8a88235a Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/x86/exception.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/28993/1 diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index a281c54..0f42fdf 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -554,8 +554,8 @@ /* Even though the vecX symbols are interrupt entry points just treat them like data to more easily get the pointer values in C. Because IDT entries - format splits the offset field up one can't use the linker to resolve - parts of a relecation on x86 ABI an array of pointers is used to gather + format splits the offset field up, one can't use the linker to resolve + parts of a relocation on x86 ABI. An array of pointers is used to gather the symbols. The IDT is initialized at runtime when exception_init() is called. */ extern u8 vec0[], vec1[], vec2[], vec3[], vec4[], vec5[], vec6[], vec7[]; -- To view, visit https://review.coreboot.org/28993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic61c665f7e2daefb50b478a1710ea66c8a88235a Gerrit-Change-Number: 28993 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Documentation: Improve message printed by livesphinx target
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28992 Change subject: Documentation: Improve message printed by livesphinx target ...................................................................... Documentation: Improve message printed by livesphinx target Printing "Autobuild finished" after the autobuild server exits (which normally doesn't happen) is not very useful. Change-Id: I909d7ab5f399993dbb1916e66ba94c48d7bc53bf Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/Makefile.sphinx 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/28992/1 diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx index 5236f3e..caa8190 100644 --- a/Documentation/Makefile.sphinx +++ b/Documentation/Makefile.sphinx @@ -57,9 +57,10 @@ .PHONY: livehtml livehtml: - $(SPHINXAUTOBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR) + @echo "Starting sphinx-autobuild. The HTML pages are in $(BUILDDIR)." + @echo "Press Ctrl-C to stop." @echo - @echo "Autobuild finished. The HTML pages are in $(BUILDDIR)." + $(SPHINXAUTOBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR) .PHONY: dirhtml dirhtml: -- To view, visit https://review.coreboot.org/28992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I909d7ab5f399993dbb1916e66ba94c48d7bc53bf Gerrit-Change-Number: 28992 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Documentation: Add and link the arch directory
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28991 Change subject: Documentation: Add and link the arch directory ...................................................................... Documentation: Add and link the arch directory Fixes: b159d5ba8f ("riscv: add documentation for stages and payloads") Change-Id: I5ca8ed094c9b6d115da707375205872e782a66b2 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- A Documentation/arch/index.md M Documentation/index.md 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/28991/1 diff --git a/Documentation/arch/index.md b/Documentation/arch/index.md new file mode 100644 index 0000000..c3b080e --- /dev/null +++ b/Documentation/arch/index.md @@ -0,0 +1,8 @@ +# Architecture-specific documentation + +This section contains documentation about coreboot on specific CPU +architectures. + +## RISC-V + +- [RISC-V documentation](riscv/index.md) diff --git a/Documentation/index.md b/Documentation/index.md index e69f2ea..4b3324c 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -15,6 +15,7 @@ * [ABI data consumption](abi-data-consumption.md) * [GPIO toggling in ACPI AML](acpi/gpio.md) * [Native Graphics Initialization with libgfxinit](gfx/libgfxinit.md) +* [Architecture-specific documentation](arch/index.md) * [Northbridge-specific documentation](northbridge/index.md) * [System on Chip-specific documentation](soc/index.md) * [Mainboard-specific documentation](mainboard/index.md) -- To view, visit https://review.coreboot.org/28991 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5ca8ed094c9b6d115da707375205872e782a66b2 Gerrit-Change-Number: 28991 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: Documentation/releases: Improve readability
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28990 Change subject: Documentation/releases: Improve readability ...................................................................... Documentation/releases: Improve readability A colon usually indicates that something related follows. But in Documentation/releases/index.md, nothing followed. Fix this by swapping two lines. Change-Id: I3e2750c208a2b725145b94615f64381ac763f0dc Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M Documentation/releases/index.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/28990/1 diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index 09082a1..602a63a 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -12,6 +12,6 @@ Upcoming release ---------------- -* [4.9 - November 2018](coreboot-4.9-relnotes.md) Please add to the release notes as changes are added: +* [4.9 - November 2018](coreboot-4.9-relnotes.md) -- To view, visit https://review.coreboot.org/28990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3e2750c208a2b725145b94615f64381ac763f0dc Gerrit-Change-Number: 28990 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: mb/lenovo/t530: Fix double indentation in Kconfig.name
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28989 Change subject: mb/lenovo/t530: Fix double indentation in Kconfig.name ...................................................................... mb/lenovo/t530: Fix double indentation in Kconfig.name There is no need to indent these lines with two tabs. Change-Id: I2164f4e3ea48db8dc5242a55b0452782dae19a4b Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/mainboard/lenovo/t530/Kconfig.name 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/28989/1 diff --git a/src/mainboard/lenovo/t530/Kconfig.name b/src/mainboard/lenovo/t530/Kconfig.name index 9bcd2c5..446a225 100644 --- a/src/mainboard/lenovo/t530/Kconfig.name +++ b/src/mainboard/lenovo/t530/Kconfig.name @@ -1,7 +1,7 @@ config BOARD_LENOVO_T530 - bool "ThinkPad T530" - select BOARD_LENOVO_BASEBOARD_T530 + bool "ThinkPad T530" + select BOARD_LENOVO_BASEBOARD_T530 config BOARD_LENOVO_W530 - bool "ThinkPad W530" - select BOARD_LENOVO_BASEBOARD_T530 + bool "ThinkPad W530" + select BOARD_LENOVO_BASEBOARD_T530 -- To view, visit https://review.coreboot.org/28989 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2164f4e3ea48db8dc5242a55b0452782dae19a4b Gerrit-Change-Number: 28989 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: mb/*/*: Clean up FADT checksum assignment
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28988 Change subject: mb/*/*: Clean up FADT checksum assignment ...................................................................... mb/*/*: Clean up FADT checksum assignment The assignment of header->checksum was in some cases done twice, or unnecessarily split into two lines. Change-Id: Ib0c0890d7589e6a24b11e9bda10e6969c7d73c56 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/mainboard/adi/rcc-dff/fadt.c M src/mainboard/aopen/dxplplusu/fadt.c M src/mainboard/emulation/qemu-q35/acpi_tables.c M src/mainboard/esd/atom15/fadt.c M src/mainboard/facebook/watson/fadt.c M src/mainboard/google/auron/fadt.c M src/mainboard/google/beltino/fadt.c M src/mainboard/google/cyan/fadt.c M src/mainboard/google/jecht/fadt.c M src/mainboard/google/rambi/fadt.c M src/mainboard/google/slippy/fadt.c M src/mainboard/intel/baskingridge/fadt.c M src/mainboard/intel/bayleybay_fsp/fadt.c M src/mainboard/intel/camelbackmountain_fsp/fadt.c M src/mainboard/intel/littleplains/fadt.c M src/mainboard/intel/minnowmax/fadt.c M src/mainboard/intel/mohonpeak/fadt.c M src/mainboard/intel/strago/fadt.c M src/mainboard/intel/wtm2/fadt.c M src/mainboard/lenovo/t400/fadt.c M src/mainboard/lenovo/x200/fadt.c M src/mainboard/ocp/monolake/fadt.c M src/mainboard/ocp/wedge100s/fadt.c M src/mainboard/opencellular/rotundu/fadt.c M src/mainboard/roda/rk9/fadt.c M src/mainboard/siemens/mc_bdx1/fadt.c M src/mainboard/siemens/mc_tcu3/fadt.c 27 files changed, 26 insertions(+), 70 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/28988/1 diff --git a/src/mainboard/adi/rcc-dff/fadt.c b/src/mainboard/adi/rcc-dff/fadt.c index 83adf85..cc88e58 100644 --- a/src/mainboard/adi/rcc-dff/fadt.c +++ b/src/mainboard/adi/rcc-dff/fadt.c @@ -30,9 +30,7 @@ #if PLATFORM_HAS_FADT_CUSTOMIZATIONS - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); #endif } diff --git a/src/mainboard/aopen/dxplplusu/fadt.c b/src/mainboard/aopen/dxplplusu/fadt.c index 9e44b85..b78a3ed 100644 --- a/src/mainboard/aopen/dxplplusu/fadt.c +++ b/src/mainboard/aopen/dxplplusu/fadt.c @@ -157,6 +157,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/emulation/qemu-q35/acpi_tables.c b/src/mainboard/emulation/qemu-q35/acpi_tables.c index 83d25d7..5a36cb1 100644 --- a/src/mainboard/emulation/qemu-q35/acpi_tables.c +++ b/src/mainboard/emulation/qemu-q35/acpi_tables.c @@ -170,8 +170,7 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } unsigned long acpi_fill_madt(unsigned long current) diff --git a/src/mainboard/esd/atom15/fadt.c b/src/mainboard/esd/atom15/fadt.c index 36e4655..49e0d30 100644 --- a/src/mainboard/esd/atom15/fadt.c +++ b/src/mainboard/esd/atom15/fadt.c @@ -25,8 +25,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); - + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/facebook/watson/fadt.c b/src/mainboard/facebook/watson/fadt.c index a762227..5af6056 100644 --- a/src/mainboard/facebook/watson/fadt.c +++ b/src/mainboard/facebook/watson/fadt.c @@ -23,6 +23,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c index c96ae68..9ee5c95 100644 --- a/src/mainboard/google/auron/fadt.c +++ b/src/mainboard/google/auron/fadt.c @@ -42,6 +42,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/google/beltino/fadt.c b/src/mainboard/google/beltino/fadt.c index 806902d..5c2cafd 100644 --- a/src/mainboard/google/beltino/fadt.c +++ b/src/mainboard/google/beltino/fadt.c @@ -147,6 +147,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c index 29e2d2a..7455d4b 100644 --- a/src/mainboard/google/cyan/fadt.c +++ b/src/mainboard/google/cyan/fadt.c @@ -42,6 +42,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c index c96ae68..9ee5c95 100644 --- a/src/mainboard/google/jecht/fadt.c +++ b/src/mainboard/google/jecht/fadt.c @@ -42,6 +42,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c index 4aa4ec6..d02609b 100644 --- a/src/mainboard/google/rambi/fadt.c +++ b/src/mainboard/google/rambi/fadt.c @@ -41,6 +41,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/google/slippy/fadt.c b/src/mainboard/google/slippy/fadt.c index 8a04591..52a099f 100644 --- a/src/mainboard/google/slippy/fadt.c +++ b/src/mainboard/google/slippy/fadt.c @@ -147,6 +147,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/intel/baskingridge/fadt.c b/src/mainboard/intel/baskingridge/fadt.c index e32e9f2..54e95f8 100644 --- a/src/mainboard/intel/baskingridge/fadt.c +++ b/src/mainboard/intel/baskingridge/fadt.c @@ -147,6 +147,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/intel/bayleybay_fsp/fadt.c b/src/mainboard/intel/bayleybay_fsp/fadt.c index 8e8de51..8fee54b 100644 --- a/src/mainboard/intel/bayleybay_fsp/fadt.c +++ b/src/mainboard/intel/bayleybay_fsp/fadt.c @@ -25,7 +25,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/intel/camelbackmountain_fsp/fadt.c b/src/mainboard/intel/camelbackmountain_fsp/fadt.c index b274531..5af6056 100644 --- a/src/mainboard/intel/camelbackmountain_fsp/fadt.c +++ b/src/mainboard/intel/camelbackmountain_fsp/fadt.c @@ -23,7 +23,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/intel/littleplains/fadt.c b/src/mainboard/intel/littleplains/fadt.c index 83adf85..3d8db00 100644 --- a/src/mainboard/intel/littleplains/fadt.c +++ b/src/mainboard/intel/littleplains/fadt.c @@ -30,9 +30,6 @@ #if PLATFORM_HAS_FADT_CUSTOMIZATIONS - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); #endif - } diff --git a/src/mainboard/intel/minnowmax/fadt.c b/src/mainboard/intel/minnowmax/fadt.c index cd8eefd..4194bfc 100644 --- a/src/mainboard/intel/minnowmax/fadt.c +++ b/src/mainboard/intel/minnowmax/fadt.c @@ -25,8 +25,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); - + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/intel/mohonpeak/fadt.c b/src/mainboard/intel/mohonpeak/fadt.c index 83adf85..3d8db00 100644 --- a/src/mainboard/intel/mohonpeak/fadt.c +++ b/src/mainboard/intel/mohonpeak/fadt.c @@ -30,9 +30,6 @@ #if PLATFORM_HAS_FADT_CUSTOMIZATIONS - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); #endif - } diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c index af222b5..e0e7d44 100644 --- a/src/mainboard/intel/strago/fadt.c +++ b/src/mainboard/intel/strago/fadt.c @@ -42,6 +42,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c index d474fc4..6f1553c 100644 --- a/src/mainboard/intel/wtm2/fadt.c +++ b/src/mainboard/intel/wtm2/fadt.c @@ -41,6 +41,5 @@ acpi_fill_in_fadt(fadt); - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/lenovo/t400/fadt.c b/src/mainboard/lenovo/t400/fadt.c index fe988d6..5596115 100644 --- a/src/mainboard/lenovo/t400/fadt.c +++ b/src/mainboard/lenovo/t400/fadt.c @@ -148,6 +148,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/lenovo/x200/fadt.c b/src/mainboard/lenovo/x200/fadt.c index fe988d6..5596115 100644 --- a/src/mainboard/lenovo/x200/fadt.c +++ b/src/mainboard/lenovo/x200/fadt.c @@ -148,6 +148,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/ocp/monolake/fadt.c b/src/mainboard/ocp/monolake/fadt.c index b274531..5af6056 100644 --- a/src/mainboard/ocp/monolake/fadt.c +++ b/src/mainboard/ocp/monolake/fadt.c @@ -23,7 +23,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/ocp/wedge100s/fadt.c b/src/mainboard/ocp/wedge100s/fadt.c index b274531..5af6056 100644 --- a/src/mainboard/ocp/wedge100s/fadt.c +++ b/src/mainboard/ocp/wedge100s/fadt.c @@ -23,7 +23,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/opencellular/rotundu/fadt.c b/src/mainboard/opencellular/rotundu/fadt.c index cd8eefd..4194bfc 100644 --- a/src/mainboard/opencellular/rotundu/fadt.c +++ b/src/mainboard/opencellular/rotundu/fadt.c @@ -25,8 +25,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); - + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/roda/rk9/fadt.c b/src/mainboard/roda/rk9/fadt.c index fe988d6..5596115 100644 --- a/src/mainboard/roda/rk9/fadt.c +++ b/src/mainboard/roda/rk9/fadt.c @@ -148,6 +148,5 @@ fadt->x_gpe1_blk.addrl = 0x0; fadt->x_gpe1_blk.addrh = 0x0; - header->checksum = - acpi_checksum((void *) fadt, header->length); + header->checksum = acpi_checksum((void *) fadt, header->length); } diff --git a/src/mainboard/siemens/mc_bdx1/fadt.c b/src/mainboard/siemens/mc_bdx1/fadt.c index b274531..5af6056 100644 --- a/src/mainboard/siemens/mc_bdx1/fadt.c +++ b/src/mainboard/siemens/mc_bdx1/fadt.c @@ -23,7 +23,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } diff --git a/src/mainboard/siemens/mc_tcu3/fadt.c b/src/mainboard/siemens/mc_tcu3/fadt.c index 8e8de51..8fee54b 100644 --- a/src/mainboard/siemens/mc_tcu3/fadt.c +++ b/src/mainboard/siemens/mc_tcu3/fadt.c @@ -25,7 +25,5 @@ /* Platform specific customizations go here */ - header->checksum = 0; - header->checksum = - acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); + header->checksum = acpi_checksum((void *) fadt, sizeof(acpi_fadt_t)); } -- To view, visit https://review.coreboot.org/28988 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib0c0890d7589e6a24b11e9bda10e6969c7d73c56 Gerrit-Change-Number: 28988 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: arch/riscv: Don't set FPU state to "dirty"
by Jonathan Neuschäfer (Code Review) 10 Oct '18

10 Oct '18

Jonathan Neuschäfer has uploaded this change for review. ( https://review.coreboot.org/28987 Change subject: arch/riscv: Don't set FPU state to "dirty" ...................................................................... arch/riscv: Don't set FPU state to "dirty" Quoting from the RISC-V Privileged Architecture manual version 1.10, chapter 3.1.11: The FS and XS fields use the same status encoding as shown in Table 3.3, with the four possible status values being Off, Initial, Clean, and Dirty. Status FS Meaning XS Meaning 0 Off All off 1 Initial None dirty of clean, some on 2 Clean None dirty, some clean 3 Dirty Some dirty Change-Id: If0225044ed52215ce64ea979d120014e02d4ce37 Signed-off-by: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> --- M src/arch/riscv/virtual_memory.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/28987/1 diff --git a/src/arch/riscv/virtual_memory.c b/src/arch/riscv/virtual_memory.c index d9bae2a..506a047 100644 --- a/src/arch/riscv/virtual_memory.c +++ b/src/arch/riscv/virtual_memory.c @@ -40,11 +40,6 @@ void mstatus_init(void) { - uintptr_t ms = 0; - - ms = INSERT_FIELD(ms, MSTATUS_FS, 3); - write_csr(mstatus, ms); - // clear any pending timer interrupts. clear_csr(mip, MIP_STIP | MIP_SSIP); -- To view, visit https://review.coreboot.org/28987 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If0225044ed52215ce64ea979d120014e02d4ce37 Gerrit-Change-Number: 28987 Gerrit-PatchSet: 1 Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net>

1 0

Change in coreboot[master]: util/superiotool/smsc.c: Add SCH5504 register dump
by Felix Held (Code Review) 10 Oct '18

10 Oct '18

Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/28958 ) Change subject: util/superiotool/smsc.c: Add SCH5504 register dump ...................................................................... util/superiotool/smsc.c: Add SCH5504 register dump There is no datasheet available for this SuperIO, but dumping all possible registers on a Dell Optiplex GX520 resulted in data that was similar to other supported chips. Data also matches what is set in the BIOS, e.g. the parallel and serial ports' addresses. Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/28958 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M util/superiotool/smsc.c 1 file changed, 26 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index 820bc16..2fe940c 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -715,7 +715,32 @@ {0x30,0x60,0x61,0x62,0x63,0xf0,0xf1,0xf2,EOT}, {0x00,0x00,0x00,0x00,0x00,NANA,RSVD,0x04,EOT}}, {EOT}}}, - {0x79, "SCH5504", { /* From sensors-detect (no datasheet) */ + {0x79, "SCH5504", { /* No datasheet, reverse-engineered */ + {NOLDN, NULL, /* FIXME: Is this correct? */ + {0x02,0x03,0x21,0x22,0x23,0x24,0x26,0x27, + 0x28,0x2a,0x2b,0x2c,0x2d,0x2e,0x2f,EOT}, + {0x00,RSVD,MISC,0x00,0x00,0x04,MISC,0x00, + RSVD,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x0, "Floppy", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,0xf2,0xf4, + 0xf5,EOT}, + {0x00,0x03,0xf0,0x06,0x02,0x0e,0x00,0xff,0x00, + 0x00,EOT}}, + {0x3, "Parallel port", + {0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x04,0x3c,0x00,EOT}}, + {0x4, "COM1", + {0x30,0x60,0x61,0x70,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x5, "COM2", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x02,0x03,EOT}}, + {0x7, "Keyboard", + {0x30,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0xa, "Runtime registers", /* FIXME: Is this correct? */ + {0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, + {0x00,0x00,0x00,0x00,0x00,RSVD,EOT}}, {EOT}}}, {0x7a, "LPC47N217", { /* Found in Toshiba Satellite A80-117. */ {NOLDN, NULL, -- To view, visit https://review.coreboot.org/28958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I768e4b5ec1e73c53e1a2355e0a0657b7a5ccbb89 Gerrit-Change-Number: 28958 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src/superio/smsc/smscsuperio/superio.c: Add SCH5504
by Felix Held (Code Review) 10 Oct '18

10 Oct '18

Felix Held has posted comments on this change. ( https://review.coreboot.org/28971 ) Change subject: src/superio/smsc/smscsuperio/superio.c: Add SCH5504 ...................................................................... Patch Set 1: Code-Review+1 looks good to me; I'd like to wait with +2ing this until there is a patch adding mainboard with this superio in the review system though -- To view, visit https://review.coreboot.org/28971 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c433fa04c01ba6315bcdca699030dfce18a169a Gerrit-Change-Number: 28971 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Oct 2018 11:17:15 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Only expose two UARTs
by Patrick Rudolph (Code Review) 10 Oct '18

10 Oct '18

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/28986 Change subject: mb/cavium/cn8100_sff_evb: Only expose two UARTs ...................................................................... mb/cavium/cn8100_sff_evb: Only expose two UARTs Only two UARTs are connected to the FTDI UART USB chip. Change-Id: Id5ae7266ce44c9f64c7f7aeaf23c49122041f47a Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/mainboard/cavium/cn8100_sff_evb/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/28986/1 diff --git a/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb b/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb index 3398e9a..00be155 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb +++ b/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb @@ -93,11 +93,11 @@ end chip soc/cavium/common/pci register "secure" = "1" - device pci 08.2 on end # UUA2 + device pci 08.2 off end # UUA2 end chip soc/cavium/common/pci register "secure" = "1" - device pci 08.3 on end # UUA3 + device pci 08.3 off end # UUA3 end chip soc/cavium/common/pci register "secure" = "1" -- To view, visit https://review.coreboot.org/28986 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id5ae7266ce44c9f64c7f7aeaf23c49122041f47a Gerrit-Change-Number: 28986 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018