Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/28986 )
Change subject: mb/cavium/cn8100_sff_evb: Only expose two UARTs
......................................................................
mb/cavium/cn8100_sff_evb: Only expose two UARTs
Only two UARTs are connected to the FTDI UART USB chip.
Change-Id: Id5ae7266ce44c9f64c7f7aeaf23c49122041f47a
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Reviewed-on: https://review.coreboot.org/28986
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
---
M src/mainboard/cavium/cn8100_sff_evb/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Philipp Deppenwiese: Looks good to me, approved
diff --git a/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb b/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb
index 3398e9a..00be155 100644
--- a/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb
+++ b/src/mainboard/cavium/cn8100_sff_evb/devicetree.cb
@@ -93,11 +93,11 @@
end
chip soc/cavium/common/pci
register "secure" = "1"
- device pci 08.2 on end # UUA2
+ device pci 08.2 off end # UUA2
end
chip soc/cavium/common/pci
register "secure" = "1"
- device pci 08.3 on end # UUA3
+ device pci 08.3 off end # UUA3
end
chip soc/cavium/common/pci
register "secure" = "1"
--
To view, visit https://review.coreboot.org/28986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5ae7266ce44c9f64c7f7aeaf23c49122041f47a
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/28986 )
Change subject: mb/cavium/cn8100_sff_evb: Only expose two UARTs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/28986
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5ae7266ce44c9f64c7f7aeaf23c49122041f47a
Gerrit-Change-Number: 28986
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus(a)9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:58:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29017 )
Change subject: libpayload: arm64: Conform to new coreboot lib_helpers.h and assume EL2
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29017/1/payloads/libpayload/include/arm64/a…
File payloads/libpayload/include/arm64/arch/lib_helpers.h:
https://review.coreboot.org/#/c/29017/1/payloads/libpayload/include/arm64/a…
PS1, Line 54: #define MAKE_REGISTER_ACCESSORS_EL12(reg) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/29017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9dfa48411f3805747613f03611f8a134a51cc46
Gerrit-Change-Number: 29017
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No