Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29009 )
Change subject: amd/stoneyridge: Convert hex definitions to lower case
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge…
File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/29009/1/src/soc/amd/stoneyridge/southbridge…
PS1, Line 593: cfg5 |= (0x2 << CG1PLL_SS_AMOUNT_NFRAC_SLIP_SHIFT) & CG1PLL_SS_AMOUNT_NFRAC_SLIP_MA
> This line is probably also over 80 characters. If you fix the others, please fix this one too.
I saw you fixed on a separate patch.
--
To view, visit https://review.coreboot.org/29009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4531e6dad0362be73499647d9fc93c168b6f163e
Gerrit-Change-Number: 29009
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 02:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29013 )
Change subject: amd/stoneyridge: Rearrange southbridge.h
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG@6
PS1, Line 6:
: amd/stoneyridge
soc/amd/stoneyridge/include/soc:
https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc…
File src/soc/amd/stoneyridge/include/soc/southbridge.h:
https://review.coreboot.org/#/c/29013/1/src/soc/amd/stoneyridge/include/soc…
PS1, Line 166: #define DEBUG_PORT_MASK (BIT(16) | BIT(17) | (BIT(18))
> Macros with complex values should be enclosed in parentheses
I have seen this kind of problem before. It's encased in parenthesis, but Jenkins believe it's not.
--
To view, visit https://review.coreboot.org/29013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe
Gerrit-Change-Number: 29013
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:56:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/29004 )
Change subject: Enable Serial Debug for UEFI payload Debug build
......................................................................
Patch Set 3: -Code-Review
--
To view, visit https://review.coreboot.org/29004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I29953250ca278d5b1977be3763359df5110f67c7
Gerrit-Change-Number: 29004
Gerrit-PatchSet: 3
Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:49:52 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes