coreboot-gerrit October 2018

coreboot-gerrit@coreboot.org

1 participants
1285 discussions

Change in coreboot[master]: amd/stoneyridge: Remove hudson register definitions
by Marshall Dawson (Code Review) 11 Oct '18

11 Oct '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/29008 ) Change subject: amd/stoneyridge: Remove hudson register definitions ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/29008/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/29008/1//COMMIT_MSG@7 PS1, Line 7: amd/stoneyridge > Only one file is changed, and it's a header file. So at a minimum: […] I'll demur. … [View More]

1 0

Change in coreboot[master]: cpu/intel/fsp_model_206ax: [For Test] Use IA32_MCG_CAP to read num_banks
by Elyes HAOUAS (Code Review) 11 Oct '18

11 Oct '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/29034 Change subject: cpu/intel/fsp_model_206ax: [For Test] Use IA32_MCG_CAP to read num_banks ...................................................................... cpu/intel/fsp_model_206ax: [For Test] Use IA32_MCG_CAP to read num_banks Change-Id: I3f3428ae2b7747d93487de9b49c8c4f651ef093b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/intel/fsp_model_206ax/model_206ax_init.c 1 file changed,… [View More]

1 0

Change in coreboot[master]: [Lenovo] Remove some unused includes
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29033 to look at the new patch set (#2). Change subject: [Lenovo] Remove some unused includes ...................................................................... [Lenovo] Remove some unused includes Tried to build all affected mainboards - still compiles fine. Change-Id: I385cac1a75cee13453b831bd75b3ecc7a6d229fa Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M … [View More]

1 0

Change in coreboot[master]: [Lenovo] Remove some unused includes
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29033 Change subject: [Lenovo] Remove some unused includes ...................................................................... [Lenovo] Remove some unused includes Tried to build all affected mainboards - still compiles fine. Change-Id: I385cac1a75cee13453b831bd75b3ecc7a6d229fa Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/lenovo/t420s/smihandler.c M src/mainboard/lenovo/… [View More]t430/smihandler.c M src/mainboard/lenovo/t430s/smihandler.c M src/mainboard/lenovo/t530/smihandler.c M src/mainboard/lenovo/x220/smihandler.c 5 files changed, 8 insertions(+), 28 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/29033/1 diff --git a/src/mainboard/lenovo/t420s/smihandler.c b/src/mainboard/lenovo/t420s/smihandler.c index c34cb5b..578aee8 100644 --- a/src/mainboard/lenovo/t420s/smihandler.c +++ b/src/mainboard/lenovo/t420s/smihandler.c @@ -20,13 +20,8 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> -#include <southbridge/intel/bd82x6x/nvs.h> -#include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/common/pmutil.h> -#include <northbridge/intel/sandybridge/sandybridge.h> -#include <cpu/intel/model_206ax/model_206ax.h> +#include <southbridge/intel/bd82x6x/pch.h> #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13 @@ -111,7 +106,7 @@ if (slp_typ == 3) { u8 ec_wake = ec_read(0x32); - /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ + /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ if (ec_wake & 0x14) { /* Redirect EC WAKE GPE to SCI. */ gpi_route_interrupt(GPE_EC_WAKE, GPI_IS_SCI); diff --git a/src/mainboard/lenovo/t430/smihandler.c b/src/mainboard/lenovo/t430/smihandler.c index 120d9a0..286f07a 100644 --- a/src/mainboard/lenovo/t430/smihandler.c +++ b/src/mainboard/lenovo/t430/smihandler.c @@ -20,7 +20,6 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/pmutil.h> @@ -77,7 +76,7 @@ h8_usb_always_on(); u8 ec_wake = ec_read(0x32); - /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ + /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ if (ec_wake & 0x14) { /* Redirect EC WAKE GPE to SCI. */ gpi_route_interrupt(GPE_EC_WAKE, GPI_IS_SCI); diff --git a/src/mainboard/lenovo/t430s/smihandler.c b/src/mainboard/lenovo/t430s/smihandler.c index 1313eac..79679dc 100644 --- a/src/mainboard/lenovo/t430s/smihandler.c +++ b/src/mainboard/lenovo/t430s/smihandler.c @@ -20,12 +20,8 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <southbridge/intel/bd82x6x/nvs.h> -#include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/common/pmutil.h> -#include <northbridge/intel/sandybridge/sandybridge.h> -#include <cpu/intel/model_206ax/model_206ax.h> +#include <southbridge/intel/bd82x6x/pch.h> #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13 diff --git a/src/mainboard/lenovo/t530/smihandler.c b/src/mainboard/lenovo/t530/smihandler.c index 0491392..c967e40 100644 --- a/src/mainboard/lenovo/t530/smihandler.c +++ b/src/mainboard/lenovo/t530/smihandler.c @@ -20,13 +20,8 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> -#include <southbridge/intel/bd82x6x/nvs.h> -#include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/common/pmutil.h> -#include <northbridge/intel/sandybridge/sandybridge.h> -#include <cpu/intel/model_206ax/model_206ax.h> +#include <southbridge/intel/bd82x6x/pch.h> #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13 @@ -111,7 +106,7 @@ if (slp_typ == 3) { u8 ec_wake = ec_read(0x32); - /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ + /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ if (ec_wake & 0x14) { /* Redirect EC WAKE GPE to SCI. */ gpi_route_interrupt(GPE_EC_WAKE, GPI_IS_SCI); diff --git a/src/mainboard/lenovo/x220/smihandler.c b/src/mainboard/lenovo/x220/smihandler.c index 0491392..c967e40 100644 --- a/src/mainboard/lenovo/x220/smihandler.c +++ b/src/mainboard/lenovo/x220/smihandler.c @@ -20,13 +20,8 @@ #include <cpu/x86/smm.h> #include <ec/acpi/ec.h> #include <ec/lenovo/h8/h8.h> -#include <delay.h> -#include <southbridge/intel/bd82x6x/nvs.h> -#include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/bd82x6x/me.h> #include <southbridge/intel/common/pmutil.h> -#include <northbridge/intel/sandybridge/sandybridge.h> -#include <cpu/intel/model_206ax/model_206ax.h> +#include <southbridge/intel/bd82x6x/pch.h> #define GPE_EC_SCI 1 #define GPE_EC_WAKE 13 @@ -111,7 +106,7 @@ if (slp_typ == 3) { u8 ec_wake = ec_read(0x32); - /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ + /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ if (ec_wake & 0x14) { /* Redirect EC WAKE GPE to SCI. */ gpi_route_interrupt(GPE_EC_WAKE, GPI_IS_SCI); -- To view, visit https://review.coreboot.org/29033 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I385cac1a75cee13453b831bd75b3ecc7a6d229fa Gerrit-Change-Number: 29033 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> [View Less]

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29032 to look at the new patch set (#3). Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On ...................................................................... mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On Port commit f1395d82: "ec/lenovo/h8: Add USB Always On" to the Thinkpad x1_carbon_gen1 board as well, as it seems to work fine on all … [View More]

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Hello Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/29032 to look at the new patch set (#2). Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On ...................................................................... mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On Port commit f1395d82: "ec/lenovo/h8: Add USB Always On" to the Thinkpad x1_carbon_gen1 board as well, as it seems to work fine on all … [View More]

1 0

Change in coreboot[master]: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Hello Patrick Rudolph, I'd like you to do a code review. Please visit https://review.coreboot.org/29032 to review the following change. Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On ...................................................................... mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On Port commit f1395d82: "ec/lenovo/h8: Add USB Always On" to the Thinkpad x1_carbon_gen1 board as well, as it seems to work fine on all generations. See also commit … [View More]7ffb329f278d6b027bb3b3660b69e87f1ddd69d8 Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25 Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com> --- M src/mainboard/lenovo/x1_carbon_gen1/cmos.default M src/mainboard/lenovo/x1_carbon_gen1/cmos.layout M src/mainboard/lenovo/x1_carbon_gen1/smihandler.c 3 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/29032/1 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default index 3044c6c..bcabae5 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default @@ -13,3 +13,4 @@ sticky_fn=Disable trackpoint=Enable backlight=Both +usb_always_on=Disable \ No newline at end of file diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout index ad5a489..bb25261 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout @@ -67,7 +67,7 @@ 416 1 e 1 trackpoint 417 1 e 1 fn_ctrl_swap 418 1 e 1 sticky_fn -#419 2 r 0 unused +419 2 e 12 usb_always_on 421 1 e 9 sata_mode 422 2 e 10 backlight @@ -126,6 +126,9 @@ 11 4 160M 11 5 192M 11 6 224M +12 0 Disable +12 1 AC and battery +12 2 AC only # ----------------------------------------------------------------- checksums diff --git a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c index 2425927..a69b78f 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c +++ b/src/mainboard/lenovo/x1_carbon_gen1/smihandler.c @@ -72,6 +72,8 @@ void mainboard_smi_sleep(u8 slp_typ) { + h8_usb_always_on(); + if (slp_typ == 3) { u8 ec_wake = ec_read(0x32); /* If EC wake events are enabled, enable wake on EC WAKE GPE. */ -- To view, visit https://review.coreboot.org/29032 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25 Gerrit-Change-Number: 29032 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> [View Less]

1 0

Change in coreboot[master]: [lenovo t430] Set USB always on when calling SMI sleep
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/29031 ) Change subject: [lenovo t430] Set USB always on when calling SMI sleep ...................................................................... Patch Set 1: Sorry for calling you directly but I'd like to clarify this one - I feel that there is no need to hide usb_always_on within the if(){} block. -- To view, visit https://review.coreboot.org/29031 To unsubscribe, or for help writing mail filters, … [View More]

1 0

Change in coreboot[master]: [lenovo t430] Set USB always on when calling SMI sleep
by Peter Lemenkov (Code Review) 11 Oct '18

11 Oct '18

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29031 Change subject: [lenovo t430] Set USB always on when calling SMI sleep ...................................................................... [lenovo t430] Set USB always on when calling SMI sleep Looks like we must do it in the same way as in l520, t420, t420s, t430s, t520, t530, x201, x220, x230 models. No idea why t430 should be handled differently. Change-Id: … [View More]

1 0

Change in coreboot[master]: 3rdparty/blobs: Update to include QuarkFsp
by Patrick Georgi (Code Review) 11 Oct '18

11 Oct '18

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/29030 Change subject: 3rdparty/blobs: Update to include QuarkFsp ...................................................................... 3rdparty/blobs: Update to include QuarkFsp Change-Id: I0032e86755750755e7ae6e2a53863e1600f96a5b Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2018