Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29031 )
Change subject: [lenovo t430] Set USB always on when calling SMI sleep
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/29031
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4851022267caca267b667b4e3c327838e0a0b66
Gerrit-Change-Number: 29031
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:44:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29032 )
Change subject: mb/lenovo/x1_carbon_gen1/cmos: Port USB Always On
......................................................................
Patch Set 3:
I don't see a reason to run this code in SMM.
According to the datasheet it could be set at any time and it survives even reboots, as long as a battery is pluged in.
--
To view, visit https://review.coreboot.org/29032
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9070b659b0c9ad5dde4200ec2845c6fa2b78b25
Gerrit-Change-Number: 29032
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:43:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29016 )
Change subject: amd/stoneyridge: Fix PmControl register size in SMI handler
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29016/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29016/1//COMMIT_MSG@7
PS1, Line 7: amd/stoneyridge
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so
--
To view, visit https://review.coreboot.org/29016
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib900468cc1c790fa7d57bb6faa91aee012173f7a
Gerrit-Change-Number: 29016
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:07:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29013 )
Change subject: amd/stoneyridge: Rearrange southbridge.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29013/1//COMMIT_MSG@6
PS1, Line 6:
: amd/stoneyridge
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so
--
To view, visit https://review.coreboot.org/29013
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6ef21431db0e758eba0ea043b54c036ec6235fe
Gerrit-Change-Number: 29013
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29012 )
Change subject: amd/stoneyridge: Remove dead GPIO definitions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29012/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29012/1//COMMIT_MSG@7
PS1, Line 7: amd/stoneyridge
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so
--
To view, visit https://review.coreboot.org/29012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I94c9c33f73c1a2d9308408e3e9ca526e876d6135
Gerrit-Change-Number: 29012
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:05:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29011 )
Change subject: amd/stoneyridge: Clarify XHCI_PM register definitions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29011/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29011/1//COMMIT_MSG@7
PS1, Line 7: amd/stoneyridge:
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so
--
To view, visit https://review.coreboot.org/29011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b44ffd7c0244b0408c3823d634a9b8d5038462f
Gerrit-Change-Number: 29011
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:04:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Martin Roth has posted comments on this change. ( https://review.coreboot.org/29010 )
Change subject: amd/stoneyridge: Fix SPI_CMD_TRIGGER coding style
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29010/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29010/1//COMMIT_MSG@7
PS1, Line 7: md/stoneyridg
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Personally, I go with 'soc/amd/stoneyridge', but amd/stoneyridge is enough to identify it, so I'm ok with it.
--
To view, visit https://review.coreboot.org/29010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed02494ba69237c38af61317e435d9575cefe1c
Gerrit-Change-Number: 29010
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29010 )
Change subject: amd/stoneyridge: Fix SPI_CMD_TRIGGER coding style
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29010/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29010/1//COMMIT_MSG@7
PS1, Line 7: md/stoneyridg
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so
--
To view, visit https://review.coreboot.org/29010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ed02494ba69237c38af61317e435d9575cefe1c
Gerrit-Change-Number: 29010
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:04:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Marc Jones has posted comments on this change. ( https://review.coreboot.org/29028 )
Change subject: mainboard/google/kahlee: Set PSPP setting to BalanceLow
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/29028
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeae52b262b12622a6753432e3fc40bf5f0fd8e0
Gerrit-Change-Number: 29028
Gerrit-PatchSet: 1
Gerrit-Owner: Akshu Agrawal <akshu.agrawal(a)amd.com>
Gerrit-Reviewer: Akshu Agrawal <akshu.agrawal(a)amd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:04:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29008 )
Change subject: amd/stoneyridge: Remove hudson register definitions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
> Patch Set 1:
>
> (1 comment)
https://review.coreboot.org/#/c/29008/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29008/1//COMMIT_MSG@7
PS1, Line 7: amd/stoneyridge
> I'll demur. You're nearly the only person who does that. Look through the git log and you'll see. […]
Ok, if you say so.
--
To view, visit https://review.coreboot.org/29008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6484bb2ca80b65318565dfee1a3368b121aea9de
Gerrit-Change-Number: 29008
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes