coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: soc/intel/cannonlake: Fill the SMI usage
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21543 ) Change subject: soc/intel/cannonlake: Fill the SMI usage ...................................................................... Patch Set 17: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61150/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16316/ : SUCCESS -- To view, visit https://review.coreboot.org/21543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aab141c528709b30804d327804c4031c59fcfff Gerrit-Change-Number: 21543 Gerrit-PatchSet: 17 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:45:12 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/fsp: Update CannonLake FSP header
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21705 ) Change subject: intel/fsp: Update CannonLake FSP header ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61149/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16315/ : SUCCESS -- To view, visit https://review.coreboot.org/21705 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8db8403b0f909f32049329f867c28c68e3b830 Gerrit-Change-Number: 21705 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:32:08 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Add smi support in board
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21542 ) Change subject: mainboard/intel/cannonlake_rvp: Add smi support in board ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61148/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16314/ : SUCCESS -- To view, visit https://review.coreboot.org/21542 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f363e20a6eb92b3c05e16715aa052a8da18b509 Gerrit-Change-Number: 21542 Gerrit-PatchSet: 9 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:30:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [wip]soc/intel/cannonlake: Fill the SMI usage
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21543 ) Change subject: [wip]soc/intel/cannonlake: Fill the SMI usage ...................................................................... Patch Set 16: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61147/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16313/ : SUCCESS -- To view, visit https://review.coreboot.org/21543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aab141c528709b30804d327804c4031c59fcfff Gerrit-Change-Number: 21543 Gerrit-PatchSet: 16 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:29:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: intel/fsp: Update CannonLake FSP header
by Lijian Zhao (Code Review) 26 Sep '17

26 Sep '17

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/21705 Change subject: intel/fsp: Update CannonLake FSP header ...................................................................... intel/fsp: Update CannonLake FSP header Updated FSP header file to latest version 7.0.14.11 Change-Id: Iac8db8403b0f909f32049329f867c28c68e3b830 Signed-off-by: Lijian Zhao <lijian.zhao(a)intel.com> --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h 3 files changed, 220 insertions(+), 195 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/21705/1 diff --git a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h index 0e2bd99..fe9933f 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h +++ b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h @@ -41,8 +41,7 @@ #include <MemInfoHob.h> /// -/// The ChipsetInit Info structure provides the information of ME ChipsetInit CRC and BIOS -/// ChipsetInit CRC. +/// The ChipsetInit Info structure provides the information of ME ChipsetInit CRC and BIOS ChipsetInit CRC. /// typedef struct { UINT8 Revision; ///< Chipset Init Info Revision @@ -202,9 +201,10 @@ /** Offset 0x00AA - Platform Debug Consent To 'opt-in' for debug, please select 'Enabled' with the desired debug probe type. Enabling this BIOS option may alter the default value of other debug-related BIOS - options. Note: DCI OOB (aka BSSB) uses CCA probe - 0:Disabled, 1:Enabled (DCI OOB+DbC), 2:Enabled (DCI OOB), 3:Enabled (USB3 DbC), - 4:Enabled (XDP/MIPI60) + options. Note: DCI OOB (aka BSSB) uses CCA probe; [DCI OOB+DbC] and [USB2 DbC] + have the same setting + 0:Disabled, 1:Enabled (DCI OOB+[DbC]), 2:Enabled (DCI OOB), 3:Enabled (USB3 DbC), + 4:Enabled (XDP/MIPI60), 5:Enabled (USB2 DbC) **/ UINT8 PlatformDebugConsent; @@ -272,7 +272,7 @@ /** Offset 0x00BC - SA GV System Agent dynamic frequency support and when enabled memory will be training at two different frequencies. Only effects ULX/ULT CPUs. 0=Disabled, 1=FixedLow, - 2=FixedHigh, and 3=Enabled. + 2=FixedMid, 3=FixedHigh, and 4=Enabled. 0:Disabled, 1:FixedLow, 2:FixedMid, 3:FixedHigh, 4:Enabled **/ UINT8 SaGv; @@ -326,25 +326,25 @@ **/ UINT8 ScramblerSupport; -/** Offset 0x00C8 - MMA Test Content Pointer - Pointer to MMA Test Content in Memory +/** Offset 0x00C8 - EV Loader Test Content Pointer + Pointer to EV Loader Test Content in Memory **/ - UINT32 MmaTestContentPtr; + UINT32 EvTestContentPtr; -/** Offset 0x00CC - MMA Test Content Size - Size of MMA Test Content in Memory +/** Offset 0x00CC - EV Loader Test Content Size + Size of EV Loader Test Content in Memory **/ - UINT32 MmaTestContentSize; + UINT32 EvTestContentSize; -/** Offset 0x00D0 - MMA Test Config Pointer - Pointer to MMA Test Config in Memory +/** Offset 0x00D0 - EV Loader Test Config Pointer + Pointer to EV Loader Test Config in Memory **/ - UINT32 MmaTestConfigPtr; + UINT32 EvTestConfigPtr; -/** Offset 0x00D4 - MMA Test Config Size - Size of MMA Test Config in Memory +/** Offset 0x00D4 - EV Loader Test Config Size + Size of EV Loader Test Config in Memory **/ - UINT32 MmaTestConfigSize; + UINT32 EvTestConfigSize; /** Offset 0x00D8 - SPD Profile Selected Select DIMM timing profile. Options are 0=Default profile, 1=Custom profile, 2=XMP @@ -354,8 +354,8 @@ UINT8 SpdProfileSelected; /** Offset 0x00D9 - Memory Reference Clock - Automatic, 100MHz, 133MHz. - 0:Auto, 1:133MHz, 2:100MHz + 100MHz, 133MHz. + 0:133MHz, 1:100MHz **/ UINT8 RefClk; @@ -702,7 +702,7 @@ UINT8 DmiGen3EndPointHint[8]; /** Offset 0x0140 - DMI Gen3 RxCTLEp per-Bundle control - Range: 0-15, 12 is default for each bundle, must be specified based upon platform design + Range: 0-15, 0 is default for each bundle, must be specified based upon platform design **/ UINT8 DmiGen3RxCtlePeaking[4]; @@ -713,45 +713,45 @@ /** Offset 0x0148 - PEG Gen3 RxCTLEp per-Bundle control Range: 0-15, 12 is default for each bundle, must be specified based upon platform design **/ - UINT8 PegGen3RxCtlePeaking[8]; + UINT8 PegGen3RxCtlePeaking[10]; -/** Offset 0x0150 - Memory data pointer for saved preset search results +/** Offset 0x0152 - Memory data pointer for saved preset search results The reference code will store the Gen3 Preset Search results in the SaDataHob's PegData structure (SA_PEG_DATA) and platform code can save/restore this data to skip preset search in the following boots. Range: 0-0xFFFFFFFF, default is 0 **/ UINT32 PegDataPtr; -/** Offset 0x0154 - PEG PERST# GPIO information +/** Offset 0x0156 - PEG PERST# GPIO information The reference code will use the information in this structure in order to reset PCIe Gen3 devices during equalization, if necessary **/ UINT8 PegGpioData[28]; -/** Offset 0x0170 - PCIe Hot Plug Enable/Disable per port +/** Offset 0x0172 - PCIe Hot Plug Enable/Disable per port 0(Default): Disable, 1: Enable **/ UINT8 PegRootPortHPE[4]; -/** Offset 0x0174 - DeEmphasis control for DMI +/** Offset 0x0176 - DeEmphasis control for DMI DeEmphasis control for DMI. 0=-6dB, 1(Default)=-3.5 dB 0: -6dB, 1: -3.5dB **/ UINT8 DmiDeEmphasis; -/** Offset 0x0175 - Selection of the primary display device +/** Offset 0x0177 - Selection of the primary display device 0=iGFX, 1=PEG, 2=PCIe Graphics on PCH, 3(Default)=AUTO, 4=Switchable Graphics 0:iGFX, 1:PEG, 2:PCIe Graphics on PCH, 3:AUTO, 4:Switchable Graphics **/ UINT8 PrimaryDisplay; -/** Offset 0x0176 - Selection of iGFX GTT Memory size +/** Offset 0x0178 - Selection of iGFX GTT Memory size 1=2MB, 2=4MB, 3=8MB, Default is 3 1:2MB, 2:4MB, 3:8MB **/ UINT16 GttSize; -/** Offset 0x0178 - Temporary MMIO address for GMADR +/** Offset 0x017A - Temporary MMIO address for GMADR The reference code will use this as Temporary MMIO address space to access GMADR Registers.Platform should provide conflict free Temporary MMIO Range: GmAdr to (GmAdr + ApertureSize). Default is (PciExpressBaseAddress - ApertureSize) to (PciExpressBaseAddress @@ -759,7 +759,7 @@ **/ UINT32 GmAdr; -/** Offset 0x017C - Temporary MMIO address for GTTMMADR +/** Offset 0x017E - Temporary MMIO address for GTTMMADR The reference code will use this as Temporary MMIO address space to access GTTMMADR Registers.Platform should provide conflict free Temporary MMIO Range: GttMmAdr to (GttMmAdr + 2MB MMIO + 6MB Reserved + GttSize). Default is (GmAdr - (2MB MMIO @@ -767,112 +767,111 @@ **/ UINT32 GttMmAdr; -/** Offset 0x0180 - Selection of PSMI Region size +/** Offset 0x0182 - Selection of PSMI Region size 0=32MB, 1=288MB, 2=544MB, 3=800MB, 4=1024MB Default is 0 0:32MB, 1:288MB, 2:544MB, 3:800MB, 4:1024MB **/ UINT8 PsmiRegionSize; -/** Offset 0x0181 - Switchable Graphics GPIO information for PEG 0 +/** Offset 0x0183 - Switchable Graphics GPIO information for PEG 0 Switchable Graphics GPIO information for PEG 0, for Reset, power and wake GPIOs **/ UINT8 SaRtd3Pcie0Gpio[24]; -/** Offset 0x0199 - Switchable Graphics GPIO information for PEG 1 +/** Offset 0x019B - Switchable Graphics GPIO information for PEG 1 Switchable Graphics GPIO information for PEG 1, for Reset, power and wake GPIOs **/ UINT8 SaRtd3Pcie1Gpio[24]; -/** Offset 0x01B1 - Switchable Graphics GPIO information for PEG 2 +/** Offset 0x01B3 - Switchable Graphics GPIO information for PEG 2 Switchable Graphics GPIO information for PEG 2, for Reset, power and wake GPIOs **/ UINT8 SaRtd3Pcie2Gpio[24]; -/** Offset 0x01C9 - Switchable Graphics GPIO information for PEG 3 +/** Offset 0x01CB - Switchable Graphics GPIO information for PEG 3 Switchable Graphics GPIO information for PEG 3, for Reset, power and wake GPIOs **/ UINT8 SaRtd3Pcie3Gpio[24]; -/** Offset 0x01E1 - Enable/Disable MRC TXT dependency - When enabled MRC execution will wait for TXT initialization to be done first. Disabled(0x0) - (Default): MRC will not wait for TXT initialization, Enabled(0x1): MRC will wait for TXT - initialization $EN_DIS +/** Offset 0x01E3 - Enable/Disable MRC TXT dependency + When enabled MRC execution will wait for TXT initialization to be done first. Disabled(0x0)(Default): + MRC will not wait for TXT initialization, Enabled(0x1): MRC will wait for TXT initialization + $EN_DIS **/ UINT8 TxtImplemented; -/** Offset 0x01E2 - Enable/Disable SA OcSupport +/** Offset 0x01E4 - Enable/Disable SA OcSupport Enable: Enable SA OcSupport, Disable(Default): Disable SA OcSupport $EN_DIS **/ UINT8 SaOcSupport; -/** Offset 0x01E3 - GT slice Voltage Mode +/** Offset 0x01E5 - GT slice Voltage Mode 0(Default): Adaptive, 1: Override 0: Adaptive, 1: Override **/ UINT8 GtVoltageMode; -/** Offset 0x01E4 - Maximum GTs turbo ratio override +/** Offset 0x01E6 - Maximum GTs turbo ratio override 0(Default)=Minimal/Auto, 60=Maximum **/ UINT8 GtMaxOcRatio; -/** Offset 0x01E5 - The voltage offset applied to GT slice +/** Offset 0x01E7 - The voltage offset applied to GT slice 0(Default)=Minimal, 1000=Maximum **/ UINT16 GtVoltageOffset; -/** Offset 0x01E7 - The GT slice voltage override which is applied to the entire range of GT - frequencies +/** Offset 0x01E9 - The GT slice voltage override which is applied to the entire range of GT frequencies 0(Default)=Minimal, 2000=Maximum **/ UINT16 GtVoltageOverride; -/** Offset 0x01E9 - adaptive voltage applied during turbo frequencies +/** Offset 0x01EB - adaptive voltage applied during turbo frequencies 0(Default)=Minimal, 2000=Maximum **/ UINT16 GtExtraTurboVoltage; -/** Offset 0x01EB - voltage offset applied to the SA +/** Offset 0x01ED - voltage offset applied to the SA 0(Default)=Minimal, 1000=Maximum **/ UINT16 SaVoltageOffset; -/** Offset 0x01ED - PCIe root port Function number for Switchable Graphics dGPU +/** Offset 0x01EF - PCIe root port Function number for Switchable Graphics dGPU Root port Index number to indicate which PCIe root port has dGPU **/ UINT8 RootPortIndex; -/** Offset 0x01EE - Realtime Memory Timing +/** Offset 0x01F0 - Realtime Memory Timing 0(Default): Disabled, 1: Enabled. When enabled, it will allow the system to perform realtime memory timing changes after MRC_DONE. 0: Disabled, 1: Enabled **/ UINT8 RealtimeMemoryTiming; -/** Offset 0x01EF - Enable/Disable SA IPU +/** Offset 0x01F1 - Enable/Disable SA IPU Enable(Default): Enable SA IPU, Disable: Disable SA IPU $EN_DIS **/ UINT8 SaIpuEnable; -/** Offset 0x01F0 - IPU IMR Configuration +/** Offset 0x01F2 - IPU IMR Configuration 0:IPU Camera, 1:IPU Gen Default is 0 0:IPU Camera, 1:IPU Gen **/ UINT8 SaIpuImrConfiguration; -/** Offset 0x01F1 - Selection of PSMI Support On/Off +/** Offset 0x01F3 - Selection of PSMI Support On/Off 0(Default) = FALSE, 1 = TRUE. When TRUE, it will allow the PSMI Support $EN_DIS **/ UINT8 GtPsmiSupport; -/** Offset 0x01F2 - SaPreMemProductionRsvd +/** Offset 0x01F4 - SaPreMemProductionRsvd Reserved for SA Pre-Mem Production $EN_DIS **/ - UINT8 SaPreMemProductionRsvd[14]; + UINT8 SaPreMemProductionRsvd[12]; /** Offset 0x0200 - BIST on Reset Enable or Disable BIST on Reset; 0: Disable; 1: Enable. @@ -1063,8 +1062,8 @@ UINT8 BiosGuardToolsInterface; /** Offset 0x0225 - EnableSgx - Enable/Disable. 0: Disable, Enable/Disable SGX feature, 1: enable - $EN_DIS + Enable/Disable. 0: Disable, Enable/Disable SGX feature, 1: enable, 2: Software Control + 0: Disable, 1: Enable, 2: Software Control **/ UINT8 EnableSgx; @@ -1079,7 +1078,7 @@ UINT8 UnusedUpdSpace6; /** Offset 0x0228 - PrmrrSize - Enable/Disable. 0: Disable, define default value of PrmrrSize , 1: enable + 0=Invalid, 32MB=0x2000000, 64MB=0x4000000, 128MB=0x8000000, 256MB=0x10000000 **/ UINT32 PrmrrSize; @@ -2233,9 +2232,25 @@ **/ UINT8 CleanMemory; -/** Offset 0x050D +/** Offset 0x050D - LpDdrDqDqsReTraining + Enables/Disable LpDdrDqDqsReTraining + $EN_DIS **/ - UINT8 ReservedFspmUpd[19]; + UINT8 LpDdrDqDqsReTraining; + +/** Offset 0x050E - Post Code Output Port + This option configures Post Code Output Port +**/ + UINT16 PostCodeOutputPort; + +/** Offset 0x0510 - RMTLoopCount + Specifies the Loop Count to be used during Rank Margin Tool Testing. 0 - AUTO +**/ + UINT8 RMTLoopCount; + +/** Offset 0x0511 +**/ + UINT8 ReservedFspmUpd[15]; } FSP_M_CONFIG; /** Fsp M Test Configuration @@ -2489,11 +2504,17 @@ **/ UINT8 PanelPowerEnable; -/** Offset 0x0583 - SaPreMemTestRsvd +/** Offset 0x0583 - BdatTestType + Indicates the type of Memory Training data to populate into the BDAT ACPI table. + 0:Rank Marign Tool, 1:Margin2D +**/ + UINT8 BdatTestType; + +/** Offset 0x0584 - SaPreMemTestRsvd Reserved for SA Pre-Mem Test $EN_DIS **/ - UINT8 SaPreMemTestRsvd[13]; + UINT8 SaPreMemTestRsvd[12]; /** Offset 0x0590 - TotalFlashSize Enable/Disable. 0: Disable, define default value of TotalFlashSize , 1: enable @@ -2544,8 +2565,8 @@ UINT8 BypassPhySyncReset; /** Offset 0x059D - Force ME DID Init Status - Test, 0: disable, 1: Success, 2: No Memory in Channels, 3: Memory Init Error, 4: - Memory not preserved across reset, Set ME DID init stat value + Test, 0: disable, 1: Success, 2: No Memory in Channels, 3: Memory Init Error, Set + ME DID init stat value $EN_DIS **/ UINT8 DidInitStat; diff --git a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h index ab48513..ac660eb 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h +++ b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h @@ -437,11 +437,25 @@ **/ UINT8 SataRstLegacyOrom; -/** Offset 0x011B - PchPostMemRsvd +/** Offset 0x011B - Trace Hub Memory Base + If Trace Hub is enabled and trace to memory is desired, BootLoader needs to allocate + trace hub memory as reserved and uncacheable, set the base to ensure Trace Hub + memory is configured properly. +**/ + UINT32 TraceHubMemBase; + +/** Offset 0x011F - PMC Debug Message Enable + When Enabled, PMC HW will send debug messages to trace hub; When Disabled, PMC HW + will never send debug meesages to trace hub. Noted: When Enabled, may not enter S0ix + $EN_DIS +**/ + UINT8 PmcDbgMsgEn; + +/** Offset 0x0120 - PchPostMemRsvd Reserved for PCH Post-Mem $EN_DIS **/ - UINT8 PchPostMemRsvd[42]; + UINT8 PchPostMemRsvd[37]; /** Offset 0x0145 - Enable Ufs Controller Enable/disable Ufs 2.0 Controller. @@ -458,13 +472,7 @@ /** Offset 0x0147 **/ - UINT8 UnusedUpdSpace3; - -/** Offset 0x0148 - CNVi BT Interface - This option configures BT device interface to either USB or UART - 0:UART, 1:USB -**/ - UINT8 PchCnviBtInterface; + UINT8 UnusedUpdSpace3[2]; /** Offset 0x0149 - PCH USB OverCurrent mapping enable 1: Will program USB OC pin mapping in xHCI controller memory, 0: Will clear OC pin @@ -473,11 +481,9 @@ **/ UINT8 PchUsbOverCurrentEnable; -/** Offset 0x014A - CNVi BT Uart Type - This is a test option which allows configuration of UART type for BT communication - 0:Serial IO Uart0, 1:ISH Uart0, 2:Uart over external pads +/** Offset 0x014A **/ - UINT8 PchCnviBtUartType; + UINT8 UnusedUpdSpace4; /** Offset 0x014B - CNVi MfUart1 Type This option configures Uart type which connects to MfUart1 @@ -500,7 +506,7 @@ /** Offset 0x014E **/ - UINT8 UnusedUpdSpace4; + UINT8 UnusedUpdSpace5; /** Offset 0x014F - PCHHOT# pin Enable PCHHOT# pin assertion when temperature is higher than PchHotLevel. 0: disable, 1: enable @@ -590,7 +596,7 @@ /** Offset 0x015F **/ - UINT8 UnusedUpdSpace5[4]; + UINT8 UnusedUpdSpace6[4]; /** Offset 0x0163 - PCH PCIe root port connection type 0: built-in device, 1:slot @@ -627,7 +633,7 @@ /** Offset 0x01FB **/ - UINT8 UnusedUpdSpace6[5]; + UINT8 UnusedUpdSpace7[5]; /** Offset 0x0200 - Enable/Disable SA CRID Enable: SA CRID, Disable (Default): SA CRID @@ -636,8 +642,8 @@ UINT8 CridEnable; /** Offset 0x0201 - DMI ASPM - 0=Disable, 2(Default)=L1 - 0:Disable, 2:L1 + 0=Disable, 3(Default)=L0sL1 + 0:Disable, 3:L0sL1 **/ UINT8 DmiAspm; @@ -683,7 +689,7 @@ /** Offset 0x0219 **/ - UINT8 UnusedUpdSpace7; + UINT8 UnusedUpdSpace8; /** Offset 0x021A - Enable or disable GNA device 0=Disable, 1(Default)=Enable @@ -760,7 +766,13 @@ Reserved for SA Post-Mem Production $EN_DIS **/ - UINT8 SaPostMemProductionRsvd[70]; + UINT8 SaPostMemProductionRsvd[46]; + +/** Offset 0x025F - PCIE RP Disable Gen2PLL Shutdown and L1 Clock Gating Enable + PCIE RP Disable Gen2PLL Shutdown and L1 Clock Gating Enable Workaround needed for + Alpine ridge +**/ + UINT8 PcieRootPortGen2PllL1CgDisable[24]; /** Offset 0x0277 - Advanced Encryption Standard (AES) feature Enable or Disable Advanced Encryption Standard (AES) feature; 0: Disable; 1: Enable @@ -876,7 +888,7 @@ /** Offset 0x02BB **/ - UINT8 UnusedUpdSpace8[10]; + UINT8 UnusedUpdSpace9[10]; /** Offset 0x02C5 - DcLoadline PCODE MMIO Mailbox: DcLoadline in 1/100 mOhms (ie. 1250 = 12.50 mOhm); Range is @@ -931,11 +943,10 @@ **/ UINT8 SendVrMbxCmd; -/** Offset 0x0304 - Enable or Disable VMX - Enable or Disable VMX; 0: Disable; 1: Enable. - $EN_DIS +/** Offset 0x0304 - Reserved + Reserved **/ - UINT8 VmxEnable; + UINT8 Reserved2; /** Offset 0x0305 - Enable or Disable TXT Enable or Disable TXT; 0: Disable; 1: Enable. @@ -945,7 +956,7 @@ /** Offset 0x0306 **/ - UINT8 UnusedUpdSpace9[6]; + UINT8 UnusedUpdSpace10[6]; /** Offset 0x030C - Skip Multi-Processor Initialization When this is skipped, boot loader must initialize processors before SilicionInit @@ -1012,7 +1023,7 @@ /** Offset 0x032B **/ - UINT8 UnusedUpdSpace10[27]; + UINT8 UnusedUpdSpace11[27]; /** Offset 0x0346 - Enable DMI ASPM ASPM on PCH side of the DMI Link. @@ -1055,7 +1066,7 @@ /** Offset 0x0367 **/ - UINT8 UnusedUpdSpace11; + UINT8 UnusedUpdSpace12; /** Offset 0x0368 - VC Type Virtual Channel Type Select: 0: VC0, 1: VC1. @@ -1094,34 +1105,9 @@ **/ UINT8 PchHdaIDispCodecDisconnect; -/** Offset 0x036E - DSP DMIC Select (PCH_HDAUDIO_DMIC_TYPE enum) - 0: Disable; 1: 2ch array; 2: 4ch array; 3: 1ch array. - 0: Disable, 1: 2ch array, 2: 4ch array, 3: 1ch array +/** Offset 0x036E **/ - UINT8 PchHdaDspEndpointDmic; - -/** Offset 0x036F - DSP Bluetooth enablement - 0: Disable; 1: Enable. - $EN_DIS -**/ - UINT8 PchHdaDspEndpointBluetooth; - -/** Offset 0x0370 - DSP I2S enablement - 0: Disable; 1: Enable. - $EN_DIS -**/ - UINT8 PchHdaDspEndpointI2s; - -/** Offset 0x0371 - Bitmask of supported DSP features - [BIT0] - WoV; [BIT1] - BT Sideband; [BIT2] - Codec VAD; [BIT5] - BT Intel HFP; [BIT6] - - BT Intel A2DP; [BIT7] - DSP based speech pre-processing disabled; [BIT8] - 0: - Intel WoV, 1: Windows Voice Activation. -**/ - UINT32 PchHdaDspFeatureMask; - -/** Offset 0x0375 -**/ - UINT8 UnusedUpdSpace12[8]; + UINT8 UnusedUpdSpace13[15]; /** Offset 0x037D - Enable PCH Io Apic Entry 24-119 0: Disable; 1: Enable. @@ -1136,7 +1122,7 @@ /** Offset 0x037F **/ - UINT8 UnusedUpdSpace13; + UINT8 UnusedUpdSpace14; /** Offset 0x0380 - Enable PCH ISH SPI GPIO pins assigned 0: Disable; 1: Enable. @@ -1236,7 +1222,7 @@ /** Offset 0x0390 **/ - UINT8 UnusedUpdSpace14[3]; + UINT8 UnusedUpdSpace15[3]; /** Offset 0x0393 - Enable LOCKDOWN BIOS LOCK Enable the BIOS Lock feature and set EISS bit (D31:F5:RegDCh[5]) for the BIOS region @@ -1363,7 +1349,7 @@ /** Offset 0x05BE **/ - UINT8 UnusedUpdSpace15[10]; + UINT8 UnusedUpdSpace16[10]; /** Offset 0x05C8 - PCIE RP Aspm The ASPM configuration of the root port (see: PCH_PCIE_ASPM_CONTROL). Default is @@ -1422,7 +1408,7 @@ /** Offset 0x0664 **/ - UINT8 UnusedUpdSpace16; + UINT8 UnusedUpdSpace17; /** Offset 0x0665 - PCIE Compliance Test Mode Compliance Test Mode shall be enabled when using Compliance Load Board. @@ -1439,7 +1425,7 @@ /** Offset 0x0667 **/ - UINT8 UnusedUpdSpace17[2]; + UINT8 UnusedUpdSpace18[2]; /** Offset 0x0669 - PCH Pm PME_B0_S5_DIS When cleared (default), wake events from PME_B0_STS are allowed in S5 if PME_B0_EN = 1. @@ -1465,7 +1451,7 @@ /** Offset 0x066F **/ - UINT8 UnusedUpdSpace18; + UINT8 UnusedUpdSpace19; /** Offset 0x0670 - PCH Pm Wol Enable Override Corresponds to the WOL Enable Override bit in the General PM Configuration B (GEN_PMCON_B) register. @@ -1554,7 +1540,7 @@ /** Offset 0x067D **/ - UINT8 UnusedUpdSpace19[3]; + UINT8 UnusedUpdSpace20[3]; /** Offset 0x0680 - PCH Pm Lpc Clock Run This member describes whether or not the LPC ClockRun feature of PCH should be enabled. @@ -1587,7 +1573,7 @@ /** Offset 0x0685 **/ - UINT8 UnusedUpdSpace20; + UINT8 UnusedUpdSpace21; /** Offset 0x0686 - PCH Pm Disable Native Power Button Power button native mode disable. @@ -1627,7 +1613,7 @@ /** Offset 0x068C **/ - UINT8 UnusedUpdSpace21; + UINT8 UnusedUpdSpace22; /** Offset 0x068D - PCH Sata Pwr Opt Enable SATA Power Optimizer on PCH side. @@ -1806,9 +1792,17 @@ **/ UINT8 PchScsEmmcHs400DriverStrength; -/** Offset 0x06FA +/** Offset 0x06FA - PCH SerialIo I2C Pads Termination + 0x1: None, 0x13: 1kOhm weak pull-up, 0x15: 5kOhm weak pull-up, 0x19: 20kOhm weak + pull-up - Enable/disable SerialIo I2C0,I2C1,I2C2,I2C3,I2C4,I2C5 pads termination + respectively. One byte for each controller, byte0 for I2C0, byte1 for I2C1, and so on. + 0x1:None, 0x13:1kOhm WPU, 0x15:5kOhm WPU, 0x19:20kOhm WPU **/ - UINT8 UnusedUpdSpace22[7]; + UINT8 PchSerialIoI2cPadsTermination[6]; + +/** Offset 0x0700 +**/ + UINT8 UnusedUpdSpace23; /** Offset 0x0701 - PcdSerialIoUart0PinMuxing Select SerialIo Uart0 pin muxing. Setting applicable only if SerialIO UART0 is enabled. @@ -1818,7 +1812,7 @@ /** Offset 0x0702 **/ - UINT8 UnusedUpdSpace23[1]; + UINT8 UnusedUpdSpace24[1]; /** Offset 0x0703 - Enables UART hardware flow control, CTS and RTS lines Enables UART hardware flow control, CTS and RTS linesh. @@ -2075,9 +2069,15 @@ **/ UINT8 SataRstOptaneMemory; -/** Offset 0x0751 +/** Offset 0x0751 - PCH Sata Rst CPU Attached Storage + CPU Attached Storage + $EN_DIS **/ - UINT8 UnusedUpdSpace24[3]; + UINT8 SataRstCpuAttachedStorage; + +/** Offset 0x0752 +**/ + UINT8 UnusedUpdSpace25[2]; /** Offset 0x0754 - Pch PCIE device override table pointer The PCIe device table is being used to override PCIe device ASPM settings. This @@ -2171,14 +2171,23 @@ UINT8 MeUnconfigOnRtcClear; /** Offset 0x07A9 - Enable PS_ON. - When FALSE, PS_ON is to be disabled. + PS_ON is a new C10 state from the CPU on desktop SKUs that enables a lower power + target that will be required by the California Energy Commission (CEC). When FALSE, + PS_ON is to be disabled. $EN_DIS **/ UINT8 PsOnEnable; -/** Offset 0x07AA +/** Offset 0x07AA - Pmc Cpu C10 Gate Pin Enable + Enable/Disable platform support for CPU_C10_GATE# pin to control gating of CPU VccIO + and VccSTG rails instead of SLP_S0# pin. + $EN_DIS **/ - UINT8 ReservedFspsUpd[3]; + UINT8 PmcCpuC10GatePinEnable; + +/** Offset 0x07AB +**/ + UINT8 ReservedFspsUpd[2]; } FSP_S_CONFIG; /** Fsp S Test Configuration @@ -2742,10 +2751,9 @@ **/ UINT16 PsysPmax; -/** Offset 0x0858 - Interrupt Response Time Limit of C-State LatencyContol0 - Interrupt Response Time Limit of C-State LatencyContol0. Range of value 0 to 0x3FF +/** Offset 0x0858 **/ - UINT16 CstateLatencyControl0Irtl; + UINT8 Reserved0[2]; /** Offset 0x085A - Interrupt Response Time Limit of C-State LatencyContol1 Interrupt Response Time Limit of C-State LatencyContol1.Range of value 0 to 0x3FF @@ -3059,35 +3067,29 @@ **/ UINT8 PchPmDisableEnergyReport; -/** Offset 0x0A5F - PCH Pm Pmc Read Disable - When set to true, this bit disallows host reads to PMC XRAM. - $EN_DIS -**/ - UINT8 PchPmPmcReadDisable; - -/** Offset 0x0A60 - PCH Sata Test Mode +/** Offset 0x0A5F - PCH Sata Test Mode Allow entrance to the PCH SATA test modes. $EN_DIS **/ UINT8 SataTestMode; -/** Offset 0x0A61 - PCH USB OverCurrent mapping lock enable +/** Offset 0x0A60 - PCH USB OverCurrent mapping lock enable If this policy option is enabled then BIOS will program OCCFDONE bit in xHCI meaning that OC mapping data will be consumed by xHCI and OC mapping registers will be locked. $EN_DIS **/ UINT8 PchXhciOcLock; -/** Offset 0x0A62 - PCH USB Access Control setting +/** Offset 0x0A61 - PCH USB Access Control setting This policy option controls setting the Access Control (ACCTRL) bit in XHCC1 which will lock write access to registers controlled by its functionality. $EN_DIS **/ UINT8 PchXhciAcLock; -/** Offset 0x0A63 +/** Offset 0x0A62 **/ - UINT8 UnusedUpdSpace25[15]; + UINT8 UnusedUpdSpace26[16]; /** Offset 0x0A72 - Skip POSTBOOT SAI This skip the Post Boot Sai programming. 0: Set Post Boot Sai; 1: Skip Post Boot Sai. @@ -3095,9 +3097,15 @@ **/ UINT8 SkipPostBootSai; -/** Offset 0x0A73 +/** Offset 0x0A73 - Mctp Broadcast Cycle + Test, Determine if MCTP Broadcast is enabled 0: Disable; 1: Enable. + $EN_DIS **/ - UINT8 ReservedFspsTestUpd[13]; + UINT8 MctpBroadcastCycle; + +/** Offset 0x0A74 +**/ + UINT8 ReservedFspsTestUpd[12]; } FSP_S_TEST_CONFIG; /** Fsp S Restricted Configuration @@ -3110,7 +3118,7 @@ /** Offset 0x0A84 **/ - UINT8 UnusedUpdSpace26; + UINT8 UnusedUpdSpace27; /** Offset 0x0A85 - Enable or disable GNA Error Check Disable Bit 0=Disable, 1(Default)=Enable @@ -3378,7 +3386,7 @@ /** Offset 0x0ACB **/ - UINT8 UnusedUpdSpace27[49]; + UINT8 UnusedUpdSpace28[49]; /** Offset 0x0AFC - SaPostMemRestrictedRsvd Reserved for SA Post-Mem Restricted @@ -3490,7 +3498,7 @@ /** Offset 0x0B5E **/ - UINT8 UnusedUpdSpace28; + UINT8 UnusedUpdSpace29; /** Offset 0x0B5F - Pch Tc Lock Down Pch Tc Lock Down. @@ -3518,7 +3526,7 @@ /** Offset 0x0B63 **/ - UINT8 UnusedUpdSpace29; + UINT8 UnusedUpdSpace30; /** Offset 0x0B64 - Configuration Lockdown (BCLD) 0: POR (Enable), 1: Enable, 2: Disable. @@ -3532,11 +3540,9 @@ **/ UINT8 PchHdaTestLowFreqLinkClkSrc; -/** Offset 0x0B66 - I2s Configuration - 0: Disabled, 1: Realtek ALC298, 2: Realtek ALC286S, 3: Analog Devices, 4: I2S_24b_48kHz_Master, - 5: I2S_24b_48kHz_Slave, 6: PCM_16b_8kHz_Master, 7: PCM_16b_8kHz_Slave. +/** Offset 0x0B66 **/ - UINT32 PchHdaTestI2sConfiguration; + UINT8 UnusedUpdSpace31[4]; /** Offset 0x0B6A - PCH Lan Test WOL Fast Support Enables bit B_PCH_ACPI_GPE0_EN_127_96_PME_B0 during PchLanSxCallback in PchLanSxSmm. @@ -3578,7 +3584,7 @@ /** Offset 0x0BE4 **/ - UINT8 UnusedUpdSpace30[72]; + UINT8 UnusedUpdSpace32[72]; /** Offset 0x0C2C - PCH Pcie bem PCH Pcie bem. @@ -3808,7 +3814,7 @@ /** Offset 0x0C6F **/ - UINT8 UnusedUpdSpace31[2]; + UINT8 UnusedUpdSpace33[2]; /** Offset 0x0C71 - This locks down Enables the thermal sensor 0: Disabled, 1: Enabled. @@ -3830,7 +3836,7 @@ /** Offset 0x0C74 **/ - UINT8 UnusedUpdSpace32[10]; + UINT8 UnusedUpdSpace34[10]; /** Offset 0x0C7E - USB EP Type Lock Policy USB EP Type Lock Policy. @@ -3849,7 +3855,7 @@ /** Offset 0x0C8A **/ - UINT8 UnusedUpdSpace33[4]; + UINT8 UnusedUpdSpace35[4]; /** Offset 0x0C8E - Xhci Controller Enable 0: Disable; 1: Enable. @@ -3858,7 +3864,7 @@ /** Offset 0x0C8F **/ - UINT8 UnusedUpdSpace34; + UINT8 UnusedUpdSpace36; /** Offset 0x0C90 - Unlock to enable NOA for SV usage 1: Unlock to enable NOA usage. 0: Set Xhci OC registers, Set Xhci OCCDone bit, XHCI @@ -3885,22 +3891,16 @@ /** Offset 0x0C94 **/ - UINT8 UnusedUpdSpace35[2]; + UINT8 UnusedUpdSpace37[2]; /** Offset 0x0C96 - Restricted Flash Lock Down Restricted Flash Lock Down. **/ UINT8 PchTestFlashLockDown; -/** Offset 0x0C97 - Restricted Mctp Broad cast Cycle - Determine if MCTP Broadcast is enabled. 0: PLATFORM_POR, 1: FORCE_ENABLE, 2: FORCE_DISABLE. - 0: PLATFORM_POR, 1: FORCE_ENABLE, 2: FORCE_DISABLE +/** Offset 0x0C97 **/ - UINT8 PchTestMctpBroadcastCycle; - -/** Offset 0x0C98 -**/ - UINT8 UnusedUpdSpace36; + UINT8 UnusedUpdSpace38[2]; /** Offset 0x0C99 - PCH PMC ER Debug mode Disable/Enable Energy Reporting Debug Mode. @@ -3908,15 +3908,9 @@ **/ UINT8 TestPchPmErDebugMode; -/** Offset 0x0C9A - PCH ACPI Timer Disable - 0: False, Acpi Timer is enabled; 1: True, Acpi Timer is disabled - $EN_DIS +/** Offset 0x0C9A **/ - UINT8 TestAcpiTmrDisable; - -/** Offset 0x0C9B -**/ - UINT8 UnusedUpdSpace37; + UINT8 UnusedUpdSpace39[2]; /** Offset 0x0C9C - USB2/TS LDO Dynamic Shutdown Enable/Disable USB2/TS LDO Dynamic Shutdown @@ -3974,25 +3968,42 @@ **/ UINT8 PcieAllowL0sWithGen3; -/** Offset 0x0CA5 - PchSiliconRestrictedRsvd - Reserved for CPU Post-Mem Restricted +/** Offset 0x0CA5 - CNVi BT Interface + This option configures BT device interface to either USB or UART + 0:UART, 1:USB +**/ + UINT8 TestCnviBtInterface; + +/** Offset 0x0CA6 - CNVi BT Uart Type + This is a test option which allows configuration of UART type for BT communication + 0:Serial IO Uart0, 1:ISH Uart0, 2:Uart over external pads +**/ + UINT8 TestCnviBtUartType; + +/** Offset 0x0CA7 - Enable/Disable DMI L1 entry disable mode + Enable/Disable DMI L1 entry disable mode. +**/ + UINT8 PcieRpTestDmiL1Edm[24]; + +/** Offset 0x0CBF - PchSiliconRestrictedRsvd + Reserved for PCH Post-Mem Restricted $EN_DIS **/ - UINT8 PchSiliconRestrictedRsvd[5]; + UINT8 PchSiliconRestrictedRsvd[3]; -/** Offset 0x0CAA - Si Config SvPolicyEnable. +/** Offset 0x0CC2 - Si Config SvPolicyEnable. Platform specific common policies that used by several silicon components. SvPolicyEnable. $EN_DIS **/ UINT8 SiSvPolicyEnable; -/** Offset 0x0CAB - Si Config HsleWorkaround +/** Offset 0x0CC3 - Si Config HsleWorkaround Enable/Disable HSLE model specific workarounds $EN_DIS **/ UINT8 HsleWorkaround; -/** Offset 0x0CAC +/** Offset 0x0CC4 **/ UINT8 ReservedFspsRestrictedUpd[4]; } FSP_S_RESTRICTED_CONFIG; @@ -4017,7 +4028,7 @@ **/ FSP_S_RESTRICTED_CONFIG FspsRestrictedConfig; -/** Offset 0x0CB0 +/** Offset 0x0CC8 **/ UINT16 UpdTerminator; } FSPS_UPD; diff --git a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h index 7927e23..24f0883 100644 --- a/src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h +++ b/src/vendorcode/intel/fsp/fsp2_0/cannonlake/MemInfoHob.h @@ -260,13 +260,6 @@ UINT32 GdxcMotBase; UINT32 GdxcMotSize; #endif //CPU_CFL -// -// CPU:RestrictedBegin -// - UINT32 SharedMailboxBase; -// -// CPU:RestrictedEnd -// } MEMORY_PLATFORM_DATA; typedef struct { -- To view, visit https://review.coreboot.org/21705 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iac8db8403b0f909f32049329f867c28c68e3b830 Gerrit-Change-Number: 21705 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com>

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Add smi support in board
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21542 ) Change subject: mainboard/intel/cannonlake_rvp: Add smi support in board ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61146/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16312/ : SUCCESS -- To view, visit https://review.coreboot.org/21542 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f363e20a6eb92b3c05e16715aa052a8da18b509 Gerrit-Change-Number: 21542 Gerrit-PatchSet: 8 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:23:32 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fill the SMI usage
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21543 ) Change subject: soc/intel/cannonlake: Fill the SMI usage ...................................................................... Patch Set 15: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61145/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16311/ : SUCCESS -- To view, visit https://review.coreboot.org/21543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aab141c528709b30804d327804c4031c59fcfff Gerrit-Change-Number: 21543 Gerrit-PatchSet: 15 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:21:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fill the SMI usage
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21543 ) Change subject: soc/intel/cannonlake: Fill the SMI usage ...................................................................... Patch Set 14: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61144/ : ABORTED -- To view, visit https://review.coreboot.org/21543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aab141c528709b30804d327804c4031c59fcfff Gerrit-Change-Number: 21543 Gerrit-PatchSet: 14 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:16:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Fill the SMI usage
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21543 ) Change subject: soc/intel/cannonlake: Fill the SMI usage ...................................................................... Patch Set 13: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61143/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16310/ : SUCCESS -- To view, visit https://review.coreboot.org/21543 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aab141c528709b30804d327804c4031c59fcfff Gerrit-Change-Number: 21543 Gerrit-PatchSet: 13 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:15:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/cyan: fix variant memory/silicon init params overrride
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21704 ) Change subject: google/cyan: fix variant memory/silicon init params overrride ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61142/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16309/ : SUCCESS -- To view, visit https://review.coreboot.org/21704 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1c76cb5838ef1e65e72c7341d951f9baf2ddd41b Gerrit-Change-Number: 21704 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:05:23 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017