coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21309 ) Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14940/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59663/ : SUCCESS -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 3 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 02:39:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by Wisley Chen (Code Review) 01 Sep '17

01 Sep '17

Hello build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21309 to look at the new patch set (#3). Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... mainboard/google/soraka: Remove wacom digitizer We have no wacom digitizer on I2C#3, so remove it. TEST=build and boot on soraka. Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 2 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21309/3 -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 3 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mb/hp: Enable ExpressCard hotplug in all Elitebooks
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21310 ) Change subject: mb/hp: Enable ExpressCard hotplug in all Elitebooks ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14939/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59662/ : SUCCESS -- To view, visit https://review.coreboot.org/21310 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic53e36a7192b9bfa8ff9fca57f4556e972e2611b Gerrit-Change-Number: 21310 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 02:32:49 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21309 ) Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/59661/ : SUCCESS -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 02:26:43 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by Furquan Shaikh (Code Review) 01 Sep '17

01 Sep '17

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21309 ) Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... Patch Set 1: (4 comments) Thanks for picking this up. I was planning to get it done this week. :) https://review.coreboot.org/#/c/21309/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/21309/1//COMMIT_MSG@14 PS1, Line 14: signed Uppercase s. "Signed-off-by" https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants… File src/mainboard/google/poppy/variants/soraka/devicetree.cb: https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants… PS1, Line 207: # Pen : register "i2c_voltage[3]" = "I2C_VOLTAGE_1V8" Remove this. https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants… PS1, Line 246: PchSerialIoPci PchSerialIoDisabled https://review.coreboot.org/#/c/21309/1/src/mainboard/google/poppy/variants… PS1, Line 301: on off -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 02:23:44 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: mb/hp: Enable ExpressCard hotplug in all Elitebooks
by Iru Cai (Code Review) 01 Sep '17

01 Sep '17

Iru Cai has uploaded this change for review. ( https://review.coreboot.org/21310 Change subject: mb/hp: Enable ExpressCard hotplug in all Elitebooks ...................................................................... mb/hp: Enable ExpressCard hotplug in all Elitebooks The MPC.HPCE bit of the ExpressCard root port is not set in vendor firmware, so autoport didn't generate the right pcie_hotplug_map to support ExpressCard hotplug. Also add comments for each PCIe root port. Change-Id: Ic53e36a7192b9bfa8ff9fca57f4556e972e2611b Signed-off-by: Iru Cai <mytbk920423(a)gmail.com> --- M src/mainboard/hp/2570p/devicetree.cb M src/mainboard/hp/2760p/devicetree.cb M src/mainboard/hp/8460p/devicetree.cb M src/mainboard/hp/8470p/devicetree.cb 4 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/21310/1 diff --git a/src/mainboard/hp/2570p/devicetree.cb b/src/mainboard/hp/2570p/devicetree.cb index 6dcfb61..753d286 100644 --- a/src/mainboard/hp/2570p/devicetree.cb +++ b/src/mainboard/hp/2570p/devicetree.cb @@ -56,7 +56,7 @@ register "gen4_dec" = "0x000402e9" register "gpi6_routing" = "2" register "p_cnt_throttling_supported" = "1" - register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x33" @@ -89,13 +89,13 @@ device pci 1c.0 on # PCIe Port #1 subsystemid 0x103c 0x17df end - device pci 1c.1 on # PCIe Port #2 + device pci 1c.1 on # PCIe Port #2, ExpressCard subsystemid 0x103c 0x17df end - device pci 1c.2 on # PCIe Port #3 + device pci 1c.2 on # PCIe Port #3, SD/MMC subsystemid 0x103c 0x17df end - device pci 1c.3 on # PCIe Port #4 + device pci 1c.3 on # PCIe Port #4, WLAN subsystemid 0x103c 0x17df end device pci 1c.4 off # PCIe Port #5 diff --git a/src/mainboard/hp/2760p/devicetree.cb b/src/mainboard/hp/2760p/devicetree.cb index 5728ad9..e63b69c 100644 --- a/src/mainboard/hp/2760p/devicetree.cb +++ b/src/mainboard/hp/2760p/devicetree.cb @@ -65,7 +65,7 @@ register "gen4_dec" = "0x007c0281" register "gpi6_routing" = "2" register "p_cnt_throttling_supported" = "1" - register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x21" @@ -94,10 +94,10 @@ device pci 1c.0 on # PCIe Port #1 subsystemid 0x103c 0x162a end - device pci 1c.1 on # PCIe Port #2 + device pci 1c.1 on # PCIe Port #2, ExpressCard subsystemid 0x103c 0x162a end - device pci 1c.2 on # PCIe Port #3 + device pci 1c.2 on # PCIe Port #3, SD/MMC subsystemid 0x103c 0x162a end device pci 1c.3 on # WLAN diff --git a/src/mainboard/hp/8460p/devicetree.cb b/src/mainboard/hp/8460p/devicetree.cb index 4b1df4a..866f57e 100644 --- a/src/mainboard/hp/8460p/devicetree.cb +++ b/src/mainboard/hp/8460p/devicetree.cb @@ -64,7 +64,7 @@ register "gen4_dec" = "0x000402e9" register "gpi6_routing" = "2" register "p_cnt_throttling_supported" = "1" - register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x3b" @@ -94,13 +94,13 @@ device pci 1c.0 on # PCIe Port #1 subsystemid 0x103c 0x161c end - device pci 1c.1 on # PCIe Port #2 + device pci 1c.1 on # PCIe Port #2, ExpressCard subsystemid 0x103c 0x161c end - device pci 1c.2 on # PCIe Port #3 + device pci 1c.2 on # PCIe Port #3, SD/MMC subsystemid 0x103c 0x161c end - device pci 1c.3 on # PCIe Port #4 + device pci 1c.3 on # PCIe Port #4, WLAN subsystemid 0x103c 0x161c end device pci 1c.4 off # PCIe Port #5 @@ -109,7 +109,7 @@ end device pci 1c.6 off # PCIe Port #7 end - device pci 1c.7 on # PCIe Port #8 + device pci 1c.7 on # PCIe Port #8, NEC USB 3.0 Host Controller subsystemid 0x103c 0x161c end device pci 1d.0 on # USB2 EHCI #1 diff --git a/src/mainboard/hp/8470p/devicetree.cb b/src/mainboard/hp/8470p/devicetree.cb index 6baccca..b7254bb 100644 --- a/src/mainboard/hp/8470p/devicetree.cb +++ b/src/mainboard/hp/8470p/devicetree.cb @@ -65,7 +65,7 @@ register "gen4_dec" = "0x000402e9" register "gpi6_routing" = "2" register "p_cnt_throttling_supported" = "1" - register "pcie_hotplug_map" = "{ 0, 0, 1, 0, 0, 0, 0, 0 }" + register "pcie_hotplug_map" = "{ 0, 1, 1, 0, 0, 0, 0, 0 }" register "pcie_port_coalesce" = "1" register "sata_interface_speed_support" = "0x3" register "sata_port_map" = "0x3b" @@ -101,13 +101,13 @@ device pci 1c.0 on # PCIe Port #1 subsystemid 0x103c 0x179b end - device pci 1c.1 on # PCIe Port #2 + device pci 1c.1 on # PCIe Port #2, ExpressCard subsystemid 0x103c 0x179b end - device pci 1c.2 on # PCIe Port #3 + device pci 1c.2 on # PCIe Port #3, SD/MMC subsystemid 0x103c 0x179b end - device pci 1c.3 on # PCIe Port #4 + device pci 1c.3 on # PCIe Port #4, WLAN subsystemid 0x103c 0x179b end device pci 1c.4 off # PCIe Port #5 -- To view, visit https://review.coreboot.org/21310 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic53e36a7192b9bfa8ff9fca57f4556e972e2611b Gerrit-Change-Number: 21310 Gerrit-PatchSet: 1 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com>

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by Wisley Chen (Code Review) 01 Sep '17

01 Sep '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21309 to look at the new patch set (#2). Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... mainboard/google/soraka: Remove wacom digitizer We have no wacom digitizer on I2C#3, so remove it. TEST=build and boot on soraka. Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21309/2 -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 2 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21309 ) Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59660/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/14938/ : SUCCESS -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 01:59:53 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/google/soraka: Remove wacom digitizer
by Wisley Chen (Code Review) 01 Sep '17

01 Sep '17

Wisley Chen has uploaded this change for review. ( https://review.coreboot.org/21309 Change subject: mainboard/google/soraka: Remove wacom digitizer ...................................................................... mainboard/google/soraka: Remove wacom digitizer We have no wacom digitizer on I2C#3, so remove it. TEST=build and boot on soraka. Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 signed-off-by: Wisley Chen <wisley.chen(a)quantatw.com> --- M src/mainboard/google/poppy/variants/soraka/devicetree.cb 1 file changed, 1 insertion(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/21309/1 diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb index b39092b..0c87611 100644 --- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb +++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb @@ -298,15 +298,7 @@ end end # I2C #1 device pci 15.2 on end # I2C #2 - device pci 15.3 on - chip drivers/i2c/hid - register "generic.hid" = ""WCOM50C1"" - register "generic.desc" = ""WCOM Digitizer"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D1_IRQ)" - register "hid_desc_reg_offset" = "0x1" - device i2c 0x9 on end - end - end # I2C #3 + device pci 15.3 on end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 device pci 16.2 off end # Management Engine IDE-R -- To view, visit https://review.coreboot.org/21309 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3f5a1b9ece6fc9a9443477c7a7aa77dbcdf6a703 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 1 Gerrit-Owner: Wisley Chen <wisley.chen(a)quantatw.com>

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 10: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14937/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59659/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 10 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 01:27:38 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017