coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14961/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59686/ : SUCCESS -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 14:32:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21315 ) Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14963/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59689/ : SUCCESS -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 14:30:33 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: optimize some code and data type
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21288 ) Change subject: ifdtool: optimize some code and data type ...................................................................... Patch Set 13: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14962/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59690/ : SUCCESS -- To view, visit https://review.coreboot.org/21288 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d05418c8b32fa31dcd038a3e56f9aefe13fa9c4 Gerrit-Change-Number: 21288 Gerrit-PatchSet: 13 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Ronald G. Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 14:28:37 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/*/*/romstage.c: Clean up targets with i82801gx
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21065 ) Change subject: mb/*/*/romstage.c: Clean up targets with i82801gx ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59688/ : ABORTED -- To view, visit https://review.coreboot.org/21065 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d6a0ff3d391947f611a2f3c65684f4ee57bc263 Gerrit-Change-Number: 21065 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 14:23:55 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21320 ) Change subject: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/14960/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/59687/ : SUCCESS -- To view, visit https://review.coreboot.org/21320 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 14:23:01 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout
by Bill XIE (Code Review) 01 Sep '17

01 Sep '17

Hello Nicola Corna, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21315 to look at the new patch set (#4). Change subject: ifdtool: refactor region_name(s) and new_layout ...................................................................... ifdtool: refactor region_name(s) and new_layout The feature "--newlayout" is designed to use scheme "right-align" to copy every regions since its birstday (change I0e0925a725c40fa44d8c4b6e86552028779d0523), but such scheme may be only valid for the bios region. For example, it will cut off the starting chunk of the me region when attempting to shrink it, according to https://github.com/corna/me_cleaner/issues/58 . In this commit, I add a member "dir" to "struct region_info" (former "struct region_name" to record the alignment direction of the region, and for now, only bios region uses "right-align". (ME region should use "left-align", according to me_cleaner's practice) Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Signed-off-by: Bill XIE <persmule(a)gmail.com> --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 101 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/21315/4 -- To view, visit https://review.coreboot.org/21315 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf Gerrit-Change-Number: 21315 Gerrit-PatchSet: 4 Gerrit-Owner: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)gmail.com> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER
by Arthur Heymans (Code Review) 01 Sep '17

01 Sep '17

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21320 Change subject: nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER ...................................................................... nb/intel/x4x: Select LAPIC_MONOTONIC_TIMER Needed for coreboot spi driver. Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/x4x/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/21320/1 diff --git a/src/northbridge/intel/x4x/Kconfig b/src/northbridge/intel/x4x/Kconfig index 5517d97..9239637 100644 --- a/src/northbridge/intel/x4x/Kconfig +++ b/src/northbridge/intel/x4x/Kconfig @@ -22,6 +22,7 @@ config NORTHBRIDGE_SPECIFIC_OPTIONS # dummy def_bool y select HAVE_DEBUG_RAM_SETUP + select LAPIC_MONOTONIC_TIMER select VGA select INTEL_GMA_ACPI select RELOCATABLE_RAMSTAGE -- To view, visit https://review.coreboot.org/21320 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I01059c8cbdc6a002dfd75b6da3a629811b137702 Gerrit-Change-Number: 21320 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Change in coreboot[master]: sb/intel/common/spi.c: Port to i82801gx
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21113 ) Change subject: sb/intel/common/spi.c: Port to i82801gx ...................................................................... Patch Set 5: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/59685/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/14959/ : SUCCESS -- To view, visit https://review.coreboot.org/21113 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39199f3279a8b76e290b6693adc50dc2ac0ccf23 Gerrit-Change-Number: 21113 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 13:47:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Override Keyboard Backlight by SKU ID
by build bot (Jenkins) (Code Review) 01 Sep '17

01 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21319 ) Change subject: google/snappy: Override Keyboard Backlight by SKU ID ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/59684/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/14958/ : SUCCESS -- To view, visit https://review.coreboot.org/21319 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c963bfd932df9297ee18a62617e48acead7b68a Gerrit-Change-Number: 21319 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Keith Tzeng <keith.tzeng(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Sep 2017 11:29:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/snappy: Override Keyboard Backlight by SKU ID
by Kevin Chiu (Code Review) 01 Sep '17

01 Sep '17

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/21319 Change subject: google/snappy: Override Keyboard Backlight by SKU ID ...................................................................... google/snappy: Override Keyboard Backlight by SKU ID Since Snappy will have specific SKU to support keyboard backlight. we will need to report whether ACPI device exists or not by SKU ID to prevent keyboard backlight OSD on non supported system. BUG=none BRANCH=reef TEST=emerge-snappy coreboot Change-Id: I7c963bfd932df9297ee18a62617e48acead7b68a Signed-off-by: Kevin Chiu <Kevin.Chiu(a)quantatw.com> --- M src/arch/x86/smbios.c M src/mainboard/google/reef/dsdt.asl A src/mainboard/google/reef/variants/snappy/include/variant/acpi/keyboard_backlight.asl M src/mainboard/google/reef/variants/snappy/include/variant/ec.h M src/vendorcode/google/chromeos/acpi/gnvs.asl M src/vendorcode/google/chromeos/gnvs.h 6 files changed, 65 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/21319/1 diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 89951a1..a46a887 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -372,6 +372,7 @@ { struct smbios_type1 *t = (struct smbios_type1 *)*current; int len = sizeof(struct smbios_type1); + char skuid[7]; memset(t, 0, sizeof(struct smbios_type1)); t->type = SMBIOS_SYSTEM_INFORMATION; @@ -388,6 +389,11 @@ #ifdef CONFIG_MAINBOARD_FAMILY t->family = smbios_add_string(t->eos, smbios_mainboard_family()); #endif + +#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES) + strcpy(skuid, smbios_mainboard_sku()); + vboot_data->skuid = skuid[3] - '0'; +#endif smbios_mainboard_set_uuid(t->uuid); len = t->length + smbios_string_table_len(t->eos); *current += len; diff --git a/src/mainboard/google/reef/dsdt.asl b/src/mainboard/google/reef/dsdt.asl index dc63436..a1f40be 100644 --- a/src/mainboard/google/reef/dsdt.asl +++ b/src/mainboard/google/reef/dsdt.asl @@ -65,4 +65,8 @@ /* Include common dptf ASL files */ #include <soc/intel/common/acpi/dptf/dptf.asl> } + + #ifdef BOARD_EC_ENABLE_KEYBOARD_BACKLIGHT + #include <variant/acpi/keyboard_backlight.asl> + #endif } diff --git a/src/mainboard/google/reef/variants/snappy/include/variant/acpi/keyboard_backlight.asl b/src/mainboard/google/reef/variants/snappy/include/variant/acpi/keyboard_backlight.asl new file mode 100644 index 0000000..706dc8b --- /dev/null +++ b/src/mainboard/google/reef/variants/snappy/include/variant/acpi/keyboard_backlight.asl @@ -0,0 +1,50 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2015 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +Scope (\_SB) +{ + /* + * Chrome EC Keyboard Backlight interface + */ + Device (KBLT) + { + Name (_HID, "GOOG0002") + Name (_UID, 1) + + /* Read current backlight value */ + Method (KBQC, 0, NotSerialized) + { + Return (\_SB.PCI0.LPCB.EC0.KBLV) + } + + /* Write new backlight value */ + Method (KBCM, 1, NotSerialized) + { + Store (Arg0, \_SB.PCI0.LPCB.EC0.KBLV) + } + + Method (_STA) + { + /* SKU2 supports Keyboard Backlight */ + If (LEqual(\SKID,2)) + { + Return (0xF) + } + Else { + Return (0) + } + } + } +} diff --git a/src/mainboard/google/reef/variants/snappy/include/variant/ec.h b/src/mainboard/google/reef/variants/snappy/include/variant/ec.h index 4f5051b..8b0a96d 100644 --- a/src/mainboard/google/reef/variants/snappy/include/variant/ec.h +++ b/src/mainboard/google/reef/variants/snappy/include/variant/ec.h @@ -19,6 +19,6 @@ #include <baseboard/ec.h> /* Enable EC backed Keyboard Backlight in ACPI */ -#define EC_ENABLE_KEYBOARD_BACKLIGHT +#define BOARD_EC_ENABLE_KEYBOARD_BACKLIGHT #endif diff --git a/src/vendorcode/google/chromeos/acpi/gnvs.asl b/src/vendorcode/google/chromeos/acpi/gnvs.asl index 52d3a0d..8901d7e 100644 --- a/src/vendorcode/google/chromeos/acpi/gnvs.asl +++ b/src/vendorcode/google/chromeos/acpi/gnvs.asl @@ -32,4 +32,5 @@ MEHH, 256, // 0xd9e - Management Engine Hash RMOB, 32, // 0xdbe - RAM oops base address RMOL, 32, // 0xdc2 - RAM oops length - // 0xdc6 +SKID, 8, // 0xdc6 - SKU ID + // 0xdc7-0xeff diff --git a/src/vendorcode/google/chromeos/gnvs.h b/src/vendorcode/google/chromeos/gnvs.h index 82cd409..0fe767a 100644 --- a/src/vendorcode/google/chromeos/gnvs.h +++ b/src/vendorcode/google/chromeos/gnvs.h @@ -58,7 +58,8 @@ u32 mehh[8]; // d9e management engine hash u32 ramoops_base; // dbe ramoops base address u32 ramoops_len; // dc2 ramoops length - u8 pad[314]; // dc6-eff + u8 skuid; // dc6 sku id + u8 pad[313]; // dc7-eff } __packed chromeos_acpi_t; extern chromeos_acpi_t *vboot_data; -- To view, visit https://review.coreboot.org/21319 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7c963bfd932df9297ee18a62617e48acead7b68a Gerrit-Change-Number: 21319 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chiu <Kevin.Chiu(a)quantatw.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017