September 2017 - coreboot-gerrit

Change in coreboot[master]: mb/dell: Add Dell Optiplex 790
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21774 ) Change subject: mb/dell: Add Dell Optiplex 790 ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61382/ : SUCCESS -- To view, visit https://review.coreboot.org/21774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f Gerrit-Change-Number: 21774 Gerrit-PatchSet: 3 Gerrit-Owner: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 14:01:47 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mb/dell: Add Dell Optiplex 790
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21774 ) Change subject: mb/dell: Add Dell Optiplex 790 ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61381/ : ABORTED -- To view, visit https://review.coreboot.org/21774 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3d3a13163d5da1368259a7498019d42fb3ed57f Gerrit-Change-Number: 21774 Gerrit-PatchSet: 2 Gerrit-Owner: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Christoph Pomaska <cp_public(a)posteo.de> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 13:56:57 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/*/gma: Port ACPI opregion to older platforms
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21766 ) Change subject: nb/intel/*/gma: Port ACPI opregion to older platforms ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61380/ : SUCCESS -- To view, visit https://review.coreboot.org/21766 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1896411155592b343e48cbd116e2f70fb0dbfafa Gerrit-Change-Number: 21766 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 07:32:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/pineview: Port ACPI opregion to pineview
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21775 ) Change subject: nb/intel/pineview: Port ACPI opregion to pineview ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61379/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16520/ : SUCCESS -- To view, visit https://review.coreboot.org/21775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc9fc52d84dcbb0da577e61467ece8a48752f44b Gerrit-Change-Number: 21775 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 07:20:42 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: nb/intel/*/gma: Port ACPI opregion to older platforms
by Patrick Rudolph (Code Review) Sept. 30, 2017

Sept. 30, 2017

Hello Arthur Heymans, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/21766 to look at the new patch set (#2). Change subject: nb/intel/*/gma: Port ACPI opregion to older platforms ...................................................................... nb/intel/*/gma: Port ACPI opregion to older platforms Port the ACPI opregion implementation that resides in drivers/intel/gma to older platforms. It allows to include a vbt.bin and allows GNU/Linux to load the opregion as ASLS is being set. Windows' Intel will likely ignore it as it relies on legacy VBIOS to be loaded at 0xc0000. Tested successfully on DG43GT (x4x) with vbt.bin, with X200 (gm45) with vendor option rom and D45GCLF (i945) with fake vbt. Change-Id: I1896411155592b343e48cbd116e2f70fb0dbfafa Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/gm45/gma.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/x4x/gma.c 3 files changed, 158 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/21766/2 -- To view, visit https://review.coreboot.org/21766 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1896411155592b343e48cbd116e2f70fb0dbfafa Gerrit-Change-Number: 21766 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/pineview: Port ACPI opregion to pineview
by Patrick Rudolph (Code Review) Sept. 30, 2017

Sept. 30, 2017

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/21775 Change subject: nb/intel/pineview: Port ACPI opregion to pineview ...................................................................... nb/intel/pineview: Port ACPI opregion to pineview Port the ACPI opregion implementation that resides in drivers/intel/gma to older platforms. It allows to include a vbt.bin and allows GNU/Linux to load the opregion as ASLS is being set. Windows' Intel will likely ignore it as it relies on legacy VBIOS to be loaded at 0xc0000. Change-Id: Ifc9fc52d84dcbb0da577e61467ece8a48752f44b Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M src/northbridge/intel/pineview/Kconfig M src/northbridge/intel/pineview/gma.c 2 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/21775/1 diff --git a/src/northbridge/intel/pineview/Kconfig b/src/northbridge/intel/pineview/Kconfig index 1af8d3c..e8ef9d9 100644 --- a/src/northbridge/intel/pineview/Kconfig +++ b/src/northbridge/intel/pineview/Kconfig @@ -28,6 +28,7 @@ select HAVE_VGA_TEXT_FRAMEBUFFER if MAINBOARD_DO_NATIVE_VGA_INIT select INTEL_EDID if MAINBOARD_DO_NATIVE_VGA_INIT select RELOCATABLE_RAMSTAGE + select INTEL_GMA_ACPI config BOOTBLOCK_NORTHBRIDGE_INIT string diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index c92428e..d47fc0e 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -31,6 +31,9 @@ #include "pineview.h" #include <drivers/intel/gma/intel_bios.h> #include <drivers/intel/gma/i915.h> +#include <drivers/intel/gma/opregion.h> +#include <southbridge/intel/i82801gx/nvs.h> +#include <cbmem.h> #include <pc80/vga.h> #include <pc80/vga_io.h> @@ -54,6 +57,19 @@ static struct resource *gtt_res = NULL; static struct resource *mmio_res = NULL; + +uintptr_t gma_get_gnvs_aslb(const void *gnvs) +{ + const global_nvs_t *gnvs_ptr = gnvs; + return (uintptr_t)(gnvs_ptr ? gnvs_ptr->aslb : 0); +} + +void gma_set_gnvs_aslb(void *gnvs, uintptr_t aslb) +{ + global_nvs_t *gnvs_ptr = gnvs; + if (gnvs_ptr) + gnvs_ptr->aslb = aslb; +} static int gtt_setup(u8 *mmiobase) { @@ -278,6 +294,8 @@ /* Linux relies on VBT for panel info. */ generate_fake_intel_oprom(&conf->gfx, dev, "$VBT PINEVIEW"); } + + intel_gma_restore_opregion(); } static void gma_set_subsystem(device_t dev, unsigned vendor, unsigned device) @@ -303,6 +321,37 @@ return &chip->gfx; } +static unsigned long +gma_write_acpi_tables(struct device *const dev, + unsigned long current, + struct acpi_rsdp *const rsdp) +{ + igd_opregion_t *opregion = (igd_opregion_t *)current; + global_nvs_t *gnvs; + + if (intel_gma_init_igd_opregion(opregion) != CB_SUCCESS) + return current; + + current += sizeof(igd_opregion_t); + + /* GNVS has been already set up */ + gnvs = cbmem_find(CBMEM_ID_ACPI_GNVS); + if (gnvs) { + /* IGD OpRegion Base Address */ + gma_set_gnvs_aslb(gnvs, (uintptr_t)opregion); + } else { + printk(BIOS_ERR, "Error: GNVS table not found.\n"); + } + + current = acpi_align_current(current); + return current; +} + +static const char *gma_acpi_name(const struct device *dev) +{ + return "GFX0"; +} + static struct pci_operations gma_pci_ops = { .set_subsystem = gma_set_subsystem, }; @@ -316,6 +365,8 @@ .scan_bus = 0, .enable = 0, .ops_pci = &gma_pci_ops, + .acpi_name = gma_acpi_name, + .write_acpi_tables = gma_write_acpi_tables, }; static const unsigned short pci_device_ids[] = -- To view, visit https://review.coreboot.org/21775 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifc9fc52d84dcbb0da577e61467ece8a48752f44b Gerrit-Change-Number: 21775 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>

1 0

Change in coreboot[master]: ec/lenovo/h8: Add support for bluetooth on wifi
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21578 ) Change subject: ec/lenovo/h8: Add support for bluetooth on wifi ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61378/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16519/ : SUCCESS -- To view, visit https://review.coreboot.org/21578 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23f14c937252a296dc543db49ec9e093e7e24604 Gerrit-Change-Number: 21578 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 07:05:14 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/opregion: Get rid of opregion.c
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21703 ) Change subject: soc/intel/common/opregion: Get rid of opregion.c ...................................................................... Patch Set 3: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/61377/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/16517/ : SUCCESS -- To view, visit https://review.coreboot.org/21703 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f78e9030df12da5369d142dda5c59e576ebcef7 Gerrit-Change-Number: 21703 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 07:04:09 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: ec/lenovo/h8: Add support for bluetooth on wifi
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21578 ) Change subject: ec/lenovo/h8: Add support for bluetooth on wifi ...................................................................... Patch Set 3: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61373/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16516/ : SUCCESS -- To view, visit https://review.coreboot.org/21578 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23f14c937252a296dc543db49ec9e093e7e24604 Gerrit-Change-Number: 21578 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 06:59:24 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: [WIP] drv/intel/gma/opregion: Add common init_idg_opregion()
by build bot (Jenkins) (Code Review) Sept. 30, 2017

Sept. 30, 2017

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20969 ) Change subject: [WIP] drv/intel/gma/opregion: Add common init_idg_opregion() ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61376/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16518/ : SUCCESS -- To view, visit https://review.coreboot.org/20969 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee50ea9900537bd9e3ca5ab0cd3f48d2acec970 Gerrit-Change-Number: 20969 Gerrit-PatchSet: 8 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 06:58:30 +0000 Gerrit-HasComments: No

1 0