coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: vendorcode/amd/pi: Put libagesa build all in libagesa directory
by Jonathan Neuschäfer (Code Review) 26 Sep '17

26 Sep '17

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/21699 ) Change subject: vendorcode/amd/pi: Put libagesa build all in libagesa directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21699 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied69dafffe2eb3354bd430789e098a1cb1d40551 Gerrit-Change-Number: 21699 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 21:07:28 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: src/vendorcode/amd: Use AR variable in Makefiles
by Jonathan Neuschäfer (Code Review) 26 Sep '17

26 Sep '17

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/21700 ) Change subject: src/vendorcode/amd: Use AR variable in Makefiles ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/21700/1/src/vendorcode/amd/agesa/f12/Makefi… File src/vendorcode/amd/agesa/f12/Makefile.inc: https://review.coreboot.org/#/c/21700/1/src/vendorcode/amd/agesa/f12/Makefi… PS1, Line 62: Spurious newline? -- To view, visit https://review.coreboot.org/21700 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5158f1bcc18eb5b15f310d0cf50fb787c12317c8 Gerrit-Change-Number: 21700 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 21:05:52 +0000 Gerrit-HasComments: Yes

1 0

Change in coreboot[master]: soc/intel/cannonlake: Change default UART number to 2
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21544 ) Change subject: soc/intel/cannonlake: Change default UART number to 2 ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61157/ : SUCCESS -- To view, visit https://review.coreboot.org/21544 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e0e8c8ac86e49a245f3d1d4722d40be9c01e25 Gerrit-Change-Number: 21544 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Vaibhav Shankar <vaibhav.shankar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 21:01:16 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/amd: Add required callouts to Stoney BiosCallouts.c
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21708 ) Change subject: mainboard/amd: Add required callouts to Stoney BiosCallouts.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61156/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16322/ : SUCCESS -- To view, visit https://review.coreboot.org/21708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9c2b20e59ede404edb1f700238e425fea35914 Gerrit-Change-Number: 21708 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 20:59:17 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add framework for missing AGESA callouts
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21707 ) Change subject: soc/amd/common: Add framework for missing AGESA callouts ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61155/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16321/ : SUCCESS -- To view, visit https://review.coreboot.org/21707 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a Gerrit-Change-Number: 21707 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 20:56:36 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/amd/common: Add framework for missing AGESA callouts
by Jonathan Neuschäfer (Code Review) 26 Sep '17

26 Sep '17

Jonathan Neuschäfer has posted comments on this change. ( https://review.coreboot.org/21707 ) Change subject: soc/amd/common: Add framework for missing AGESA callouts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/21707 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a Gerrit-Change-Number: 21707 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Comment-Date: Tue, 26 Sep 2017 20:55:27 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/amd: Add required callouts to Stoney BiosCallouts.c
by Martin Roth (Code Review) 26 Sep '17

26 Sep '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21708 Change subject: mainboard/amd: Add required callouts to Stoney BiosCallouts.c ...................................................................... mainboard/amd: Add required callouts to Stoney BiosCallouts.c Hook the new required AGESA callout functions into the callouts tables. BUG=b:66690176 TEST=Build and boot Kahlee - see the functions get called. Change-Id: Ife9c2b20e59ede404edb1f700238e425fea35914 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/amd/gardenia/BiosCallOuts.c M src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c M src/mainboard/google/kahlee/BiosCallOuts.c M src/mainboard/google/kahlee/bootblock/BiosCallOuts.c 4 files changed, 50 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/21708/1 diff --git a/src/mainboard/amd/gardenia/BiosCallOuts.c b/src/mainboard/amd/gardenia/BiosCallOuts.c index 1d06411..c947b0c 100644 --- a/src/mainboard/amd/gardenia/BiosCallOuts.c +++ b/src/mainboard/amd/gardenia/BiosCallOuts.c @@ -84,18 +84,35 @@ } const BIOS_CALLOUT_STRUCT BiosCallouts[] = { + /* Required callouts */ {AGESA_ALLOCATE_BUFFER, agesa_AllocateBuffer }, {AGESA_DEALLOCATE_BUFFER, agesa_DeallocateBuffer }, + {AGESA_DO_RESET, agesa_Reset }, {AGESA_LOCATE_BUFFER, agesa_LocateBuffer }, {AGESA_READ_SPD, agesa_ReadSpd }, - {AGESA_DO_RESET, agesa_Reset }, - {AGESA_READ_SPD_RECOVERY, agesa_NoopUnsupported }, {AGESA_RUNFUNC_ONAP, agesa_RunFuncOnAp }, - {AGESA_GET_IDS_INIT_DATA, agesa_EmptyIdsInitData }, - {AGESA_HOOKBEFORE_DQS_TRAINING, agesa_NoopSuccess }, - {AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopSuccess }, - {AGESA_FCH_OEM_CALLOUT, fch_initenv }, - {AGESA_GNB_GFX_GET_VBIOS_IMAGE, agesa_GfxGetVbiosImage } + {AGESA_RUNFUNC_ON_ALL_APS, agesa_RunFcnOnAllAps }, + {AMD_LATE_RUN_AP_TASK, agesa_LateRunApTask }, + {AGESA_GNB_PCIE_SLOT_RESET, agesa_PcieSlotResetControl }, + {AGESA_WAIT_FOR_ALL_APS, agesa_WaitForAllApsFinished }, + {AGESA_IDLE_AN_AP, agesa_IdleAnAp }, + + /* Optional callouts */ + {AGESA_GET_IDS_INIT_DATA, agesa_EmptyIdsInitData }, + //AgesaHeapRebase - Hook ID? + {AGESA_HOOKBEFORE_DRAM_INIT, agesa_NoopUnsupported }, + {AGESA_HOOKBEFORE_DQS_TRAINING, agesa_NoopUnsupported }, + {AGESA_EXTERNAL_2D_TRAIN_VREF_CHANGE, agesa_NoopUnsupported }, + {AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopUnsupported }, + {AGESA_GNB_GFX_GET_VBIOS_IMAGE, agesa_GfxGetVbiosImage }, + {AGESA_FCH_OEM_CALLOUT, fch_initenv }, + {AGESA_EXTERNAL_VOLTAGE_ADJUST, agesa_NoopUnsupported }, + {AGESA_GNB_PCIE_CLK_REQ, agesa_NoopUnsupported }, + + /* Deprecated */ + {AGESA_HOOKBEFORE_DRAM_INIT_RECOVERY, agesa_NoopUnsupported}, + {AGESA_READ_SPD_RECOVERY, agesa_NoopUnsupported }, + }; const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts); diff --git a/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c b/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c index b0a3e23..1b7a341 100644 --- a/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c +++ b/src/mainboard/amd/gardenia/bootblock/BiosCallOuts.c @@ -64,6 +64,7 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] = { {AGESA_FCH_OEM_CALLOUT, fch_initreset }, + {AGESA_GNB_PCIE_SLOT_RESET, agesa_PcieSlotResetControl } }; const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts); diff --git a/src/mainboard/google/kahlee/BiosCallOuts.c b/src/mainboard/google/kahlee/BiosCallOuts.c index f651876..2e57166 100644 --- a/src/mainboard/google/kahlee/BiosCallOuts.c +++ b/src/mainboard/google/kahlee/BiosCallOuts.c @@ -65,18 +65,35 @@ } const BIOS_CALLOUT_STRUCT BiosCallouts[] = { + /* Required callouts */ {AGESA_ALLOCATE_BUFFER, agesa_AllocateBuffer }, {AGESA_DEALLOCATE_BUFFER, agesa_DeallocateBuffer }, + {AGESA_DO_RESET, agesa_Reset }, {AGESA_LOCATE_BUFFER, agesa_LocateBuffer }, {AGESA_READ_SPD, agesa_ReadSpd }, - {AGESA_DO_RESET, agesa_Reset }, - {AGESA_READ_SPD_RECOVERY, agesa_NoopUnsupported }, {AGESA_RUNFUNC_ONAP, agesa_RunFuncOnAp }, - {AGESA_GET_IDS_INIT_DATA, agesa_EmptyIdsInitData }, - {AGESA_HOOKBEFORE_DQS_TRAINING, agesa_NoopSuccess }, - {AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopSuccess }, - {AGESA_FCH_OEM_CALLOUT, fch_initenv }, - {AGESA_GNB_GFX_GET_VBIOS_IMAGE, agesa_GfxGetVbiosImage } + {AGESA_RUNFUNC_ON_ALL_APS, agesa_RunFcnOnAllAps }, + {AMD_LATE_RUN_AP_TASK, agesa_LateRunApTask }, + {AGESA_GNB_PCIE_SLOT_RESET, agesa_PcieSlotResetControl }, + {AGESA_WAIT_FOR_ALL_APS, agesa_WaitForAllApsFinished }, + {AGESA_IDLE_AN_AP, agesa_IdleAnAp }, + + /* Optional callouts */ + {AGESA_GET_IDS_INIT_DATA, agesa_EmptyIdsInitData }, + //AgesaHeapRebase - Hook ID? + {AGESA_HOOKBEFORE_DRAM_INIT, agesa_NoopUnsupported }, + {AGESA_HOOKBEFORE_DQS_TRAINING, agesa_NoopUnsupported }, + {AGESA_EXTERNAL_2D_TRAIN_VREF_CHANGE, agesa_NoopUnsupported }, + {AGESA_HOOKBEFORE_EXIT_SELF_REF, agesa_NoopUnsupported }, + {AGESA_GNB_GFX_GET_VBIOS_IMAGE, agesa_GfxGetVbiosImage }, + {AGESA_FCH_OEM_CALLOUT, fch_initenv }, + {AGESA_EXTERNAL_VOLTAGE_ADJUST, agesa_NoopUnsupported }, + {AGESA_GNB_PCIE_CLK_REQ, agesa_NoopUnsupported }, + + /* Deprecated */ + {AGESA_HOOKBEFORE_DRAM_INIT_RECOVERY, agesa_NoopUnsupported}, + {AGESA_READ_SPD_RECOVERY, agesa_NoopUnsupported }, + }; const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts); diff --git a/src/mainboard/google/kahlee/bootblock/BiosCallOuts.c b/src/mainboard/google/kahlee/bootblock/BiosCallOuts.c index 162fc50..4dce042 100644 --- a/src/mainboard/google/kahlee/bootblock/BiosCallOuts.c +++ b/src/mainboard/google/kahlee/bootblock/BiosCallOuts.c @@ -40,6 +40,7 @@ const BIOS_CALLOUT_STRUCT BiosCallouts[] = { {AGESA_FCH_OEM_CALLOUT, fch_initreset }, + {AGESA_GNB_PCIE_SLOT_RESET, agesa_PcieSlotResetControl } }; const int BiosCalloutsLen = ARRAY_SIZE(BiosCallouts); -- To view, visit https://review.coreboot.org/21708 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ife9c2b20e59ede404edb1f700238e425fea35914 Gerrit-Change-Number: 21708 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: soc/amd/common: Add framework for missing AGESA callouts
by Martin Roth (Code Review) 26 Sep '17

26 Sep '17

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/21707 Change subject: soc/amd/common: Add framework for missing AGESA callouts ...................................................................... soc/amd/common: Add framework for missing AGESA callouts These are required callout functions that currently are not implemented. agesa_LateRunApTask does not seem to be called, but the others are. BUG=b:66690176 TEST=Build Kahlee. Tested in next commit. Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/soc/amd/common/BiosCallOuts.h M src/soc/amd/common/def_callouts.c 2 files changed, 50 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/21707/1 diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h index 4456466..9f6f8a7 100644 --- a/src/soc/amd/common/BiosCallOuts.h +++ b/src/soc/amd/common/BiosCallOuts.h @@ -53,6 +53,13 @@ AGESA_STATUS agesa_ReadSpd(UINT32 Func, UINTN Data, VOID *ConfigPtr); AGESA_STATUS agesa_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr); +AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr); +AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr); +AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data, + VOID *ConfigPtr); +AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data, + VOID *ConfigPtr); +AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr); AGESA_STATUS GetBiosCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr); diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c index fda0013..4b71d5b 100644 --- a/src/soc/amd/common/def_callouts.c +++ b/src/soc/amd/common/def_callouts.c @@ -144,3 +144,46 @@ #endif return Status; } + +AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr) +{ + printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); + AGESA_STATUS Status = AGESA_UNSUPPORTED; + + return Status; +} + +AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr) +{ + printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); + AGESA_STATUS Status = AGESA_UNSUPPORTED; + + return Status; +} + + +AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data, + VOID *ConfigPtr) +{ + printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); + AGESA_STATUS Status = AGESA_UNSUPPORTED; + + return Status; +} + +AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data, + VOID *ConfigPtr) +{ + printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); + AGESA_STATUS Status = AGESA_UNSUPPORTED; + + return Status; +} + +AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr) +{ + printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__); + AGESA_STATUS Status = AGESA_UNSUPPORTED; + + return Status; +} -- To view, visit https://review.coreboot.org/21707 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a Gerrit-Change-Number: 21707 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: intel/fsp: Update CannonLake FSP header
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21705 ) Change subject: intel/fsp: Update CannonLake FSP header ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61152/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16318/ : SUCCESS -- To view, visit https://review.coreboot.org/21705 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8db8403b0f909f32049329f867c28c68e3b830 Gerrit-Change-Number: 21705 Gerrit-PatchSet: 2 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:51:54 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Add smi support in board
by build bot (Jenkins) (Code Review) 26 Sep '17

26 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21542 ) Change subject: mainboard/intel/cannonlake_rvp: Add smi support in board ...................................................................... Patch Set 10: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61151/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16317/ : SUCCESS -- To view, visit https://review.coreboot.org/21542 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f363e20a6eb92b3c05e16715aa052a8da18b509 Gerrit-Change-Number: 21542 Gerrit-PatchSet: 10 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 26 Sep 2017 19:50:08 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017