coreboot-gerrit December 2016

coreboot-gerrit@coreboot.org

1 participants
1140 discussions

Patch merged into coreboot/master: mainboard/google/reef: clear normal MRC cache on recovery retrain
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit f8bd1dd43cadc01cd93b6f14373d3fd3903d5817 Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Dec 14 15:41:45 2016 -0600 mainboard/google/reef: clear normal MRC cache on recovery retrain For Chrome OS the normal MRC cache should be cleared when a hardware retrain recovery request is observed. The reason is that since there are 2 different MRC cache slots there needs to be a mechanism which allows an end user make a system bootable again if the MRC settings happen to not allow the system to boot any longer. Therefore, one just needs to enter recovery with the hardware retrain flag and the system normal MRC cache slot will be invalidated. BUG=chrome-os-partner:60592 BRANCH=reef Change-Id: I6ad32ed0dd217d66404b77467a88689a06044544 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://review.coreboot.org/17871 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan(a)google.com> See https://review.coreboot.org/17871 for details. -gerrit

1 0

Patch merged into coreboot/master: soc/intel/common: provide option to invalide MRC cache on recovery
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit d09142c136c81e190c78a17eac88153ba9464eff Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Dec 14 15:36:56 2016 -0600 soc/intel/common: provide option to invalide MRC cache on recovery Allow a board/platform to invalidate the normal MRC cache when hardware retraining is requested in recovery mode. A small 4 byte payload is used to update the latest data written. It will of course fail on MRC cache retreival on next usage. BUG=chrome-os-partner:60592 BRANCH=reef Change-Id: Ic88cd66802664813562d003f50d54e4a4ea375ef Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://review.coreboot.org/17870 Tested-by: build bot (Jenkins) Reviewed-by: Duncan Laurie <dlaurie(a)chromium.org> See https://review.coreboot.org/17870 for details. -gerrit

1 0

Patch merged into coreboot/master: ec/google/chromeec: query cbmem for retrain status
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 8f9a5ff8ec338dcaa1c43e4725ce0dbd6a01f37d Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Dec 14 14:46:20 2016 -0600 ec/google/chromeec: query cbmem for retrain status The EC switches, including the hardware retrain flag, are cleared when handing off the vboot state in romstage. However, one may still want to query the state of the hardware retrain flag. Thus, add a method to get the flag from cbmem. BUG=chrome-os-partner:60592 BRANCH=reef Change-Id: Ic76cfb3255a8d3c179d5f8b13fa13c518f79faa2 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://review.coreboot.org/17869 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan(a)google.com> See https://review.coreboot.org/17869 for details. -gerrit

1 0

Patch merged into coreboot/master: lib/cbmem: allow anyone to use cbmem_possibly_online()
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit b2a5f4833d022d16c934f7dad30cdfa8fb28863c Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Dec 14 14:40:43 2016 -0600 lib/cbmem: allow anyone to use cbmem_possibly_online() The cbmem_possibly_online() is a helpful construct. Therefore, push it into cbmem.h so other users can take advantage of it. BUG=chrome-os-partner:60592 BRANCH=reef Change-Id: If5a1c7815ed03874dcf141014b8ffefb82b7cc92 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://review.coreboot.org/17868 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan(a)google.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See https://review.coreboot.org/17868 for details. -gerrit

1 0

Patch merged into coreboot/master: soc/intel/apollolake: don't probe flash manually
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit dfcc60c385c70ca2d003d0f1ff543bbc74e60adc Author: Aaron Durbin <adurbin(a)chromium.org> Date: Wed Dec 14 12:32:35 2016 -0600 soc/intel/apollolake: don't probe flash manually Rely on boot_device_spi_flash() to provide the spi_flash object. There's no need to duplicate the probing logic. BUG=chrome-os-partner:56151 BRANCH=reef Change-Id: I91900a3dfad7ba92cbd3b0ace77b08db04cff0b6 Signed-off-by: Aaron Durbin <adurbin(a)chromium.org> Reviewed-on: https://review.coreboot.org/17867 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh <furquan(a)google.com> See https://review.coreboot.org/17867 for details. -gerrit

1 0

Patch merged into coreboot/master: util/cbfstool: Handle error condition more carefully
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 8099803c4657994de6ef02150c99fd178527c80a Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Dec 14 16:16:47 2016 +0100 util/cbfstool: Handle error condition more carefully Change-Id: I72a7776d530d1cf0b8fa39e558990df3dc7f7805 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Coverity Scan #1295494 Reviewed-on: https://review.coreboot.org/17861 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) See https://review.coreboot.org/17861 for details. -gerrit

1 0

Patch set updated for coreboot: util/broadcom: Add two more NULL checks
by Patrick Georgi 15 Dec '16

15 Dec '16

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17882 -gerrit commit 04e22ae232e1802a27608e5124bcc6e2dc38a789 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Thu Dec 15 15:03:55 2016 +0100 util/broadcom: Add two more NULL checks Change-Id: I088730fd87dd39fa2c36a06c5770fad05a5808b0 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Coverity Scan #1323511, #1323512 --- util/broadcom/secimage/sbi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/util/broadcom/secimage/sbi.c b/util/broadcom/secimage/sbi.c index d972ba4..f156ed5 100644 --- a/util/broadcom/secimage/sbi.c +++ b/util/broadcom/secimage/sbi.c @@ -109,6 +109,16 @@ int CreateSecureBootImage(int ac, char **av) --ac, ++av; } + if (!bl) { + puts("-bl not set"); + return -1; + } + + if (!privkey) { + puts("-hmac not set"); + return -1; + } + if (stat(bl, &file_stat) == -1) { puts("Can't stat bl"); return -1;

1 0

Patch set updated for coreboot: util/cbfstool: Handle error condition more carefully
by Patrick Georgi 15 Dec '16

15 Dec '16

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17861 -gerrit commit 809ab0cb1a78c21c81056e7787feefdd94707ef7 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Dec 14 16:16:47 2016 +0100 util/cbfstool: Handle error condition more carefully Change-Id: I72a7776d530d1cf0b8fa39e558990df3dc7f7805 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Coverity Scan #1295494 --- util/cbfstool/common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c index 3093ba1..5a47c2f 100644 --- a/util/cbfstool/common.c +++ b/util/cbfstool/common.c @@ -71,12 +71,13 @@ int buffer_from_file(struct buffer *buffer, const char *filename) return -1; } buffer->offset = 0; - buffer->size = get_file_size(fp); - if (buffer->size == -1u) { + off_t file_size = get_file_size(fp); + if (file_size < 0) { fprintf(stderr, "could not determine size of %s\n", filename); fclose(fp); return -1; } + buffer->size = file_size; buffer->name = strdup(filename); buffer->data = (char *)malloc(buffer->size); assert(buffer->data);

1 0

Patch set updated for coreboot: util/broadcom: Check for successful file access
by Patrick Georgi 15 Dec '16

15 Dec '16

Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17877 -gerrit commit 907a0f6bdcbb37fb452f35b5b0e7db954da6b427 Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Thu Dec 15 14:53:23 2016 +0100 util/broadcom: Check for successful file access Change-Id: I5c77b3c5ea3fbc249a8c564a521c2c3c45e1c560 Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Coverity Scan #1323510 --- util/broadcom/secimage/io.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/util/broadcom/secimage/io.c b/util/broadcom/secimage/io.c index d71065c..f5be50a 100644 --- a/util/broadcom/secimage/io.c +++ b/util/broadcom/secimage/io.c @@ -73,6 +73,11 @@ int DataRead(char *filename, uint8_t *buf, int *length) return -1; } len = FileSizeGet(file); + if (len < 0) { + printf("Unable to seek in file: %s\n", filename); + fclose(file); + return -1; + } if (len < *length) *length = len; else

1 0

Patch merged into coreboot/master: util/cbfstool: check that buffer_create worked
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 6b2d2db9eb514f6c54cf951fe864e052b680edef Author: Patrick Georgi <pgeorgi(a)chromium.org> Date: Wed Dec 14 16:11:58 2016 +0100 util/cbfstool: check that buffer_create worked We might not care much about this buffer, but we really use it later on... Change-Id: Ia16270f836d05d8b454e77de7b5babeb6bb05d6d Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org> Found-by: Coverity Scan #1294797 Reviewed-on: https://review.coreboot.org/17860 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) See https://review.coreboot.org/17860 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2016