coreboot-gerrit December 2016

coreboot-gerrit@coreboot.org

1 participants
1140 discussions

Patch set updated for coreboot: device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known.
by Philipp Deppenwiese 15 Dec '16

15 Dec '16

Philipp Deppenwiese (zaolin.daisuki(a)googlemail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17895 -gerrit commit 7925bda1ab240f1f9c44f08e3204fa178e4df381 Author: Philipp Deppenwiese <zaolin(a)das-labor.org> Date: Thu Dec 15 23:42:58 2016 +0100 device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known. Normally blobs are placed under the blobs repository of coreboot therefore the path should point to the mainboard blobs directory instead of the root of coreboot. This can be overwritten by a mainboard specific definition. Change-Id: I1791dcd4ddd037b4c95f3424bd629f7f1f3ab51a Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- src/device/Kconfig | 2 +- src/mainboard/amd/inagua/Kconfig | 5 ----- src/mainboard/amd/persimmon/Kconfig | 5 ----- src/mainboard/amd/south_station/Kconfig | 3 --- src/mainboard/amd/torpedo/Kconfig | 5 ----- src/mainboard/amd/union_station/Kconfig | 3 --- src/mainboard/apple/macbookair4_2/Kconfig | 4 ---- src/mainboard/asus/f2a85-m_le/Kconfig | 4 ---- src/mainboard/getac/p470/Kconfig | 4 ++-- src/mainboard/gigabyte/ga-b75m-d3h/Kconfig | 4 ---- src/mainboard/gigabyte/ga-b75m-d3v/Kconfig | 4 ---- src/mainboard/google/auron/Kconfig | 4 ++-- src/mainboard/google/auron_paine/Kconfig | 4 ++-- src/mainboard/google/beltino/Kconfig | 4 ++-- src/mainboard/google/butterfly/Kconfig | 4 ++-- src/mainboard/google/cyan/Kconfig | 8 -------- src/mainboard/google/enguarde/Kconfig | 4 ++-- src/mainboard/google/guado/Kconfig | 4 ++-- src/mainboard/google/jecht/Kconfig | 4 ++-- src/mainboard/google/link/Kconfig | 4 ++-- src/mainboard/google/ninja/Kconfig | 4 ++-- src/mainboard/google/parrot/Kconfig | 4 ++-- src/mainboard/google/rambi/Kconfig | 4 ++-- src/mainboard/google/rikku/Kconfig | 4 ++-- src/mainboard/google/samus/Kconfig | 4 ++-- src/mainboard/google/slippy/Kconfig | 4 ++-- src/mainboard/google/stout/Kconfig | 4 ---- src/mainboard/google/tidus/Kconfig | 4 ++-- src/mainboard/intel/baskingridge/Kconfig | 4 ++-- src/mainboard/intel/cougar_canyon2/Kconfig | 4 ---- src/mainboard/intel/emeraldlake2/Kconfig | 4 ++-- src/mainboard/intel/strago/Kconfig | 8 -------- src/mainboard/intel/wtm2/Kconfig | 4 ++-- src/mainboard/jetway/nf81-t56n-lf/Kconfig | 5 ----- src/mainboard/kontron/ktqm77/Kconfig | 4 ++-- src/mainboard/lenovo/t420/Kconfig | 4 ---- src/mainboard/lenovo/t420s/Kconfig | 4 ---- src/mainboard/lenovo/t430s/Kconfig | 4 ++-- src/mainboard/lenovo/t520/Kconfig | 4 ---- src/mainboard/lenovo/t530/Kconfig | 4 ---- src/mainboard/lenovo/x220/Kconfig | 5 ----- src/mainboard/lenovo/x230/Kconfig | 4 ---- src/mainboard/lippert/frontrunner-af/Kconfig | 5 ----- src/mainboard/lippert/toucan-af/Kconfig | 5 ----- src/mainboard/pcengines/apu1/Kconfig | 5 ----- src/mainboard/samsung/lumpy/Kconfig | 4 ++-- src/mainboard/samsung/stumpy/Kconfig | 4 ++-- src/mainboard/via/pc2500e/Kconfig | 4 ---- src/mainboard/winent/mb6047/Kconfig | 4 ---- src/northbridge/amd/pi/00630F01/Kconfig | 4 ---- src/northbridge/amd/pi/00660F01/Kconfig | 4 ---- src/northbridge/amd/pi/00670F00/Kconfig | 4 ---- src/northbridge/amd/pi/00730F01/Kconfig | 4 ---- src/soc/intel/fsp_baytrail/Kconfig | 4 ---- 54 files changed, 47 insertions(+), 181 deletions(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index d238547..01b246f 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -339,7 +339,7 @@ config VGA_BIOS config VGA_BIOS_FILE string "VGA BIOS path and filename" depends on VGA_BIOS - default "vgabios.bin" + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/pci${VGA_BIOS_ID}.rom" help The path and filename of the file to use as VGA BIOS. diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig index 89bb516..b68bcba 100644 --- a/src/mainboard/amd/inagua/Kconfig +++ b/src/mainboard/amd/inagua/Kconfig @@ -61,11 +61,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVBios.bin" - config VGA_BIOS_ID string "VGA device PCI IDs" depends on VGA_BIOS diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index b365eba..0e28ad0 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -61,11 +61,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index f92d27d..dc192be 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -60,9 +60,6 @@ config ONBOARD_VGA_IS_PRIMARY config VGA_BIOS bool default n -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" config VGA_BIOS_ID string diff --git a/src/mainboard/amd/torpedo/Kconfig b/src/mainboard/amd/torpedo/Kconfig index 5c85c4b..2c80932 100644 --- a/src/mainboard/amd/torpedo/Kconfig +++ b/src/mainboard/amd/torpedo/Kconfig @@ -69,11 +69,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/LlanoGenericVbios.bin" - config VGA_BIOS_ID string "VGA device PCI IDs" depends on VGA_BIOS diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index 83660bb..81a3e5c 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -59,9 +59,6 @@ config ONBOARD_VGA_IS_PRIMARY config VGA_BIOS bool default n -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" config VGA_BIOS_ID string diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 08e7166..42ece41 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -31,10 +31,6 @@ config MAINBOARD_PART_NUMBER string default "MacBookAir4,2" -config VGA_BIOS_FILE - string - default "pci8086,0116.rom" - config VGA_BIOS_ID string default "8086,0116" diff --git a/src/mainboard/asus/f2a85-m_le/Kconfig b/src/mainboard/asus/f2a85-m_le/Kconfig index a81f700..923bee1 100644 --- a/src/mainboard/asus/f2a85-m_le/Kconfig +++ b/src/mainboard/asus/f2a85-m_le/Kconfig @@ -86,8 +86,4 @@ config VGA_BIOS_ID string default "1002,9901" -config VGA_BIOS_FILE - string - default "pci1002,9901.rom" - endif # BOARD_ASUS_F2A85_M_LE diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index ea68bed..985dd3a 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -60,8 +60,8 @@ config MAX_CPUS int default 4 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "getac-pci8086,27a2.rom" + default "8086,27a2" endif # BOARD_GETAC_P470 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index e53b68c..81190f9 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -46,10 +46,6 @@ config VGA_BIOS_ID string default "8086,0162" -config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig index 2be3322..a4db486 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig @@ -46,10 +46,6 @@ config VGA_BIOS_ID string default "8086,0102" -config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 9eda101..4b30afa 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/auron_paine/Kconfig b/src/mainboard/google/auron_paine/Kconfig index 147f37d..7c63ee3 100644 --- a/src/mainboard/google/auron_paine/Kconfig +++ b/src/mainboard/google/auron_paine/Kconfig @@ -45,9 +45,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index c430018..ca663a7 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -61,9 +61,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0406.rom" + default "8086,0406" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 09d2157..fdf2f17 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -36,9 +36,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index d236aa0..8985c15 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -46,14 +46,6 @@ config MAINBOARD_VENDOR default "Google" if !GOP_SUPPORT -config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin" - help - The C0 version of the video bios gets computed from this name - so that they can both be added. Only the correct one for the - system will be run. - config VGA_BIOS_ID string default "8086,22b0" diff --git a/src/mainboard/google/enguarde/Kconfig b/src/mainboard/google/enguarde/Kconfig index c2842bb..c990748 100644 --- a/src/mainboard/google/enguarde/Kconfig +++ b/src/mainboard/google/enguarde/Kconfig @@ -27,9 +27,9 @@ config MAINBOARD_PART_NUMBER string default "Enguarde" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0f31.rom" + default "8086,0f31" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/guado/Kconfig b/src/mainboard/google/guado/Kconfig index ce6ee07..2858363 100644 --- a/src/mainboard/google/guado/Kconfig +++ b/src/mainboard/google/guado/Kconfig @@ -34,9 +34,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 8a30a4d..7676dab 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -31,9 +31,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/link/Kconfig b/src/mainboard/google/link/Kconfig index b521f9c..3a6e356 100644 --- a/src/mainboard/google/link/Kconfig +++ b/src/mainboard/google/link/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config GBB_HWID string diff --git a/src/mainboard/google/ninja/Kconfig b/src/mainboard/google/ninja/Kconfig index 4c28e1a..dc513b7 100644 --- a/src/mainboard/google/ninja/Kconfig +++ b/src/mainboard/google/ninja/Kconfig @@ -29,9 +29,9 @@ config MAINBOARD_PART_NUMBER string default "Ninja" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0f31.rom" + default "8086,0f31" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/parrot/Kconfig b/src/mainboard/google/parrot/Kconfig index 7b6b49b..a9d217e 100644 --- a/src/mainboard/google/parrot/Kconfig +++ b/src/mainboard/google/parrot/Kconfig @@ -36,9 +36,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 94354c9..d7cfccc 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -27,9 +27,9 @@ config MAINBOARD_PART_NUMBER string default "Rambi" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/rikku/Kconfig b/src/mainboard/google/rikku/Kconfig index 8dc1551..87a5c7c 100644 --- a/src/mainboard/google/rikku/Kconfig +++ b/src/mainboard/google/rikku/Kconfig @@ -42,9 +42,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/samus/Kconfig b/src/mainboard/google/samus/Kconfig index 528a5eb..82e06f4 100644 --- a/src/mainboard/google/samus/Kconfig +++ b/src/mainboard/google/samus/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 045d6a8..48d49b8 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -73,9 +73,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0406.rom" + default "8086,0406" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 571cbce..2ba6a6e 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -36,10 +36,6 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE - string - default "pci8086,0156.rom" - config VGA_BIOS_ID string default "8086,0156" diff --git a/src/mainboard/google/tidus/Kconfig b/src/mainboard/google/tidus/Kconfig index 8d9b4860..4c37feb 100644 --- a/src/mainboard/google/tidus/Kconfig +++ b/src/mainboard/google/tidus/Kconfig @@ -34,9 +34,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/intel/baskingridge/Kconfig b/src/mainboard/intel/baskingridge/Kconfig index df5d312..73dba02 100644 --- a/src/mainboard/intel/baskingridge/Kconfig +++ b/src/mainboard/intel/baskingridge/Kconfig @@ -33,9 +33,9 @@ config MAX_CPUS int default 16 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig index 00db10e..ce9eda8 100644 --- a/src/mainboard/intel/cougar_canyon2/Kconfig +++ b/src/mainboard/intel/cougar_canyon2/Kconfig @@ -47,10 +47,6 @@ config VGA_BIOS bool default y -config VGA_BIOS_FILE - string - default "../intel/mainboard/intel/cougar_canyon2/vbios/snm_2170.dat" - config VGA_BIOS_ID string default "8086,0166" diff --git a/src/mainboard/intel/emeraldlake2/Kconfig b/src/mainboard/intel/emeraldlake2/Kconfig index 9ee41e8..e600526 100644 --- a/src/mainboard/intel/emeraldlake2/Kconfig +++ b/src/mainboard/intel/emeraldlake2/Kconfig @@ -32,8 +32,8 @@ config MAX_CPUS int default 16 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" endif # BOARD_INTEL_EMERALDLAKE2 diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 0d59371..415cfa3 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -39,14 +39,6 @@ config MAINBOARD_VENDOR default "Intel" if !GOP_SUPPORT -config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin" - help - The C0 version of the video bios gets computed from this name - so that they can both be added. Only the correct one for the - system will be run. - config VGA_BIOS_ID string default "8086,22b0" diff --git a/src/mainboard/intel/wtm2/Kconfig b/src/mainboard/intel/wtm2/Kconfig index f57cb23..2a26e6c 100644 --- a/src/mainboard/intel/wtm2/Kconfig +++ b/src/mainboard/intel/wtm2/Kconfig @@ -30,9 +30,9 @@ config MAX_CPUS int default 16 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig index 14c534b..81d6f32 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig +++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig @@ -62,11 +62,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9806" # FUSION_G_T56N diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 115a0fa..8bde3e0 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -32,9 +32,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/lenovo/t420/Kconfig b/src/mainboard/lenovo/t420/Kconfig index e2272b1..78906f4 100644 --- a/src/mainboard/lenovo/t420/Kconfig +++ b/src/mainboard/lenovo/t420/Kconfig @@ -56,10 +56,6 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - config VGA_BIOS_ID string default "8086,0126" diff --git a/src/mainboard/lenovo/t420s/Kconfig b/src/mainboard/lenovo/t420s/Kconfig index d278ccb..e0f877e 100644 --- a/src/mainboard/lenovo/t420s/Kconfig +++ b/src/mainboard/lenovo/t420s/Kconfig @@ -55,10 +55,6 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - config VGA_BIOS_ID string default "8086,0126" diff --git a/src/mainboard/lenovo/t430s/Kconfig b/src/mainboard/lenovo/t430s/Kconfig index bb898cf..ca89026 100644 --- a/src/mainboard/lenovo/t430s/Kconfig +++ b/src/mainboard/lenovo/t430s/Kconfig @@ -55,9 +55,9 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index 4ce27f1..0d99536 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -59,10 +59,6 @@ config VGA_BIOS_ID string default "8086,0126" -config VGA_BIOS_FILE - string - default "pci8086,0126.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 76147fc..e4484cc 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -62,10 +62,6 @@ config VGA_BIOS_ID string default "8086,0106" -config VGA_BIOS_FILE - string - default "pci8086,0106.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/x220/Kconfig b/src/mainboard/lenovo/x220/Kconfig index 5367fd1..4e39b90 100644 --- a/src/mainboard/lenovo/x220/Kconfig +++ b/src/mainboard/lenovo/x220/Kconfig @@ -55,11 +55,6 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0116.rom" if BOARD_LENOVO_X220I - default "pci8086,0126.rom" - config VGA_BIOS_ID string default "8086,0116" if BOARD_LENOVO_X220I diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 16e34ff..0e5509b 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -55,10 +55,6 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - config VGA_BIOS_ID string default "8086,0166" diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig index 1ec219e..4385cee 100644 --- a/src/mainboard/lippert/frontrunner-af/Kconfig +++ b/src/mainboard/lippert/frontrunner-af/Kconfig @@ -63,11 +63,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/lippert/toucan-af/Kconfig b/src/mainboard/lippert/toucan-af/Kconfig index 590909b..206fe98 100644 --- a/src/mainboard/lippert/toucan-af/Kconfig +++ b/src/mainboard/lippert/toucan-af/Kconfig @@ -65,11 +65,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index 3099d14..ff3254b 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -63,11 +63,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 7cb00e5..c65fc2d 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -39,9 +39,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_POWER_ON_AFTER_POWER_FAIL bool diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 3777f69..e83b00b 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_POWER_ON_AFTER_POWER_FAIL bool diff --git a/src/mainboard/via/pc2500e/Kconfig b/src/mainboard/via/pc2500e/Kconfig index d5e1133..62f9788 100644 --- a/src/mainboard/via/pc2500e/Kconfig +++ b/src/mainboard/via/pc2500e/Kconfig @@ -24,10 +24,6 @@ config IRQ_SLOT_COUNT int default 10 -config VGA_BIOS_FILE - string - default "M14CRT.ROM" - config VGA_BIOS_ID string default "1106,3344" diff --git a/src/mainboard/winent/mb6047/Kconfig b/src/mainboard/winent/mb6047/Kconfig index 5a3b81d..ca22025 100644 --- a/src/mainboard/winent/mb6047/Kconfig +++ b/src/mainboard/winent/mb6047/Kconfig @@ -58,8 +58,4 @@ config VGA_BIOS_ID string default "126f,0720" -config VGA_BIOS_FILE - string - default "DM22383.ROM" - endif # BOARD_WINENT_MB6047 diff --git a/src/northbridge/amd/pi/00630F01/Kconfig b/src/northbridge/amd/pi/00630F01/Kconfig index 3669826..902bb42 100644 --- a/src/northbridge/amd/pi/00630F01/Kconfig +++ b/src/northbridge/amd/pi/00630F01/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00630F01/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00660F01/Kconfig b/src/northbridge/amd/pi/00660F01/Kconfig index fdae80f..45fd46a 100644 --- a/src/northbridge/amd/pi/00660F01/Kconfig +++ b/src/northbridge/amd/pi/00660F01/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00660F01/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00670F00/Kconfig b/src/northbridge/amd/pi/00670F00/Kconfig index a92658a..8aa2c6f 100644 --- a/src/northbridge/amd/pi/00670F00/Kconfig +++ b/src/northbridge/amd/pi/00670F00/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00670F00/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00730F01/Kconfig b/src/northbridge/amd/pi/00730F01/Kconfig index 47c2323..a77b089 100644 --- a/src/northbridge/amd/pi/00730F01/Kconfig +++ b/src/northbridge/amd/pi/00730F01/Kconfig @@ -41,8 +41,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00730F01/VBIOS.bin" - endif diff --git a/src/soc/intel/fsp_baytrail/Kconfig b/src/soc/intel/fsp_baytrail/Kconfig index 689e625..9655d74 100644 --- a/src/soc/intel/fsp_baytrail/Kconfig +++ b/src/soc/intel/fsp_baytrail/Kconfig @@ -91,10 +91,6 @@ config ENABLE_BUILTIN_COM1 configure the pads and enable it. This serial port can be used for the debug console. -config VGA_BIOS_FILE - string - default "../intel/cpu/baytrail/vbios/Vga.dat" if VGA_BIOS - config FSP_BAYTRAIL_GFX_INIT default n bool

1 0

Patch merged into coreboot/master: mb/roda/rv11: Add new boards Lizard RV11 and RW11
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit bd10516643893f0f0904109519220d65413285b5 Author: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Date: Thu Sep 10 12:20:58 2015 +0200 mb/roda/rv11: Add new boards Lizard RV11 and RW11 The Roda Lizard RV11 is a comparatively lightweight, full-rugged notebook. It's based on a 17W TDP dual core Ivy Bridge CPU. The Lizard RW11 is its bigger brother (45W TDP quad core, more i/o options). The RV11 is the first board to use the native graphics initialization by libgfxinit. Tested so far, are the internal eDP port, DP and VGA. Change-Id: Iea283059ce3402dc36184baf16928b55285a9eeb Signed-off-by: Dennis Wassenberg <dennis.wassenberg(a)secunet.com> Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/17446 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/17446 for details. -gerrit

1 0

Patch set updated for coreboot: drivers/intel/gma: Use scaling to simplify fb config
by Nico Huber 15 Dec '16

15 Dec '16

Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17492 -gerrit commit 09db93e52b78abc78385c1ad75ba1b78180faca9 Author: Nico Huber <nico.huber(a)secunet.com> Date: Tue Nov 8 12:29:50 2016 +0100 drivers/intel/gma: Use scaling to simplify fb config Utilize libgfxinit's support for scaling to simplify the framebuffer configuration. In case of multiple displays of different resolutions, we had configured one framebuffer big enough for their union, each display only showing its respective upper left window. Instead, we use the smallest resolution now and show the whole image on all displays. Change-Id: I70a9d92f88ef891703829945264f94ac7eff09b0 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- src/drivers/intel/gma/hires_fb/gma.adb | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb index 7ebc4f8..87e0900 100644 --- a/src/drivers/intel/gma/hires_fb/gma.adb +++ b/src/drivers/intel/gma/hires_fb/gma.adb @@ -59,9 +59,8 @@ is success : boolean; - stride : Width_Type; - max_h : pos16 := 1; - max_v : pos16 := 1; + min_h : pos16 := pos16'last; + min_v : pos16 := pos16'last; begin lightup_ok := 0; @@ -77,30 +76,24 @@ is for i in Config_Index loop exit when configs (i).Port = Disabled; - max_h := pos16'max (max_h, configs (i).Mode.H_Visible); - max_v := pos16'max (max_v, configs (i).Mode.V_Visible); + min_h := pos16'min (min_h, configs (i).Mode.H_Visible); + min_v := pos16'min (min_v, configs (i).Mode.V_Visible); end loop; - stride := ((Width_Type (max_h) + 63) / 64) * 64; + fb := + (Width => Width_Type (min_h), + Height => Height_Type (min_v), + BPC => 8, + Stride => ((Width_Type (min_h) + 63) / 64) * 64, + Offset => 0); for i in Config_Index loop exit when configs (i).Port = Disabled; - configs (i).Framebuffer := - (Width => Width_Type (configs (i).Mode.H_Visible), - Height => Height_Type (configs (i).Mode.V_Visible), - BPC => 8, - Stride => stride, - Offset => 0); + configs (i).Framebuffer := fb; end loop; HW.GFX.GMA.Dump_Configs (configs); - fb := - (Width => Width_Type (max_h), - Height => Height_Type (max_v), - BPC => 8, - Stride => stride, - Offset => 0); HW.GFX.GMA.Setup_Default_GTT (fb, phys_fb); HW.GFX.Framebuffer_Filler.Fill (linear_fb, fb);

1 0

Patch set updated for coreboot: drivers/intel/gma: Add textmode support with libgfxinit
by Nico Huber 15 Dec '16

15 Dec '16

Nico Huber (nico.h(a)gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17279 -gerrit commit a9e82dd13f7b6f0fd966f21e19c350fffd0bbbcd Author: Nico Huber <nico.huber(a)secunet.com> Date: Mon Nov 7 17:24:47 2016 +0100 drivers/intel/gma: Add textmode support with libgfxinit Add an alternative gfxinit implementation for textmode. The legacy VGA plane and textmode is configured through coreboot provided functions. libgfxinit uses this plane as alternative to the usual high resolution plane. Change-Id: Iad0754c50fc6faec35f49583fe1c7cb50ac6c0c5 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- src/device/Kconfig | 1 + src/drivers/intel/gma/Makefile.inc | 6 +- src/drivers/intel/gma/gma.adb | 117 --------------------------------- src/drivers/intel/gma/hires_fb/gma.adb | 117 +++++++++++++++++++++++++++++++++ src/drivers/intel/gma/text_fb/gma.adb | 75 +++++++++++++++++++++ 5 files changed, 198 insertions(+), 118 deletions(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index d238547..efe1633 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -45,6 +45,7 @@ config MAINBOARD_DO_NATIVE_VGA_INIT config MAINBOARD_HAS_LIBGFXINIT def_bool n select MAINBOARD_HAS_NATIVE_VGA_INIT + select MAINBOARD_HAS_NATIVE_VGA_INIT_TEXTMODECFG help Selected by mainboards that implement support for `libgfxinit`. Usually this requires a list of ports to be probed for displays. diff --git a/src/drivers/intel/gma/Makefile.inc b/src/drivers/intel/gma/Makefile.inc index a4e007c..d4d6c08 100644 --- a/src/drivers/intel/gma/Makefile.inc +++ b/src/drivers/intel/gma/Makefile.inc @@ -40,6 +40,10 @@ CONFIG_GFX_GMA_DEFAULT_MMIO := 0 # dummy, will be overwritten at runtime subdirs-y += ../../../../3rdparty/libgfxinit ramstage-y += gma.ads -ramstage-y += gma.adb +ifeq ($(CONFIG_FRAMEBUFFER_KEEP_VESA_MODE),y) +ramstage-y += hires_fb/gma.adb +else +ramstage-y += text_fb/gma.adb +endif endif # CONFIG_MAINBOARD_USE_LIBGFXINIT diff --git a/src/drivers/intel/gma/gma.adb b/src/drivers/intel/gma/gma.adb deleted file mode 100644 index 7ebc4f8..0000000 --- a/src/drivers/intel/gma/gma.adb +++ /dev/null @@ -1,117 +0,0 @@ -with HW.GFX; -with HW.GFX.Framebuffer_Filler; -with HW.GFX.GMA; - -use HW.GFX; -use HW.GFX.GMA; - -with GMA.Mainboard; - -package body GMA -is - - vbe_valid : boolean := false; - - linear_fb_addr : word64; - - fb : Framebuffer_Type; - - function vbe_mode_info_valid return Interfaces.C.int - is - begin - return (if vbe_valid then 1 else 0); - end vbe_mode_info_valid; - - procedure fill_lb_framebuffer (framebuffer : out lb_framebuffer) - is - use type word32; - begin - framebuffer := - (tag => 0, - size => 0, - physical_address => linear_fb_addr, - x_resolution => word32 (fb.Width), - y_resolution => word32 (fb.Height), - bytes_per_line => 4 * word32 (fb.Stride), - bits_per_pixel => 32, - reserved_mask_pos => 24, - reserved_mask_size => 8, - red_mask_pos => 16, - red_mask_size => 8, - green_mask_pos => 8, - green_mask_size => 8, - blue_mask_pos => 0, - blue_mask_size => 8); - end fill_lb_framebuffer; - - ---------------------------------------------------------------------------- - - procedure gfxinit - (mmio_base : in word64; - linear_fb : in word64; - phys_fb : in word32; - lightup_ok : out Interfaces.C.int) - is - use type pos32; - - ports : Port_List; - configs : Configs_Type; - - success : boolean; - - stride : Width_Type; - max_h : pos16 := 1; - max_v : pos16 := 1; - begin - lightup_ok := 0; - - HW.GFX.GMA.Initialize - (MMIO_Base => mmio_base, - Success => success); - - if success then - ports := Mainboard.ports; - HW.GFX.GMA.Scan_Ports (configs, ports); - - if configs (Primary).Port /= Disabled then - for i in Config_Index loop - exit when configs (i).Port = Disabled; - - max_h := pos16'max (max_h, configs (i).Mode.H_Visible); - max_v := pos16'max (max_v, configs (i).Mode.V_Visible); - end loop; - - stride := ((Width_Type (max_h) + 63) / 64) * 64; - for i in Config_Index loop - exit when configs (i).Port = Disabled; - - configs (i).Framebuffer := - (Width => Width_Type (configs (i).Mode.H_Visible), - Height => Height_Type (configs (i).Mode.V_Visible), - BPC => 8, - Stride => stride, - Offset => 0); - end loop; - - HW.GFX.GMA.Dump_Configs (configs); - - fb := - (Width => Width_Type (max_h), - Height => Height_Type (max_v), - BPC => 8, - Stride => stride, - Offset => 0); - HW.GFX.GMA.Setup_Default_GTT (fb, phys_fb); - HW.GFX.Framebuffer_Filler.Fill (linear_fb, fb); - - HW.GFX.GMA.Update_Outputs (configs); - - linear_fb_addr := linear_fb; - vbe_valid := true; - - lightup_ok := 1; - end if; - end if; - end gfxinit; - -end GMA; diff --git a/src/drivers/intel/gma/hires_fb/gma.adb b/src/drivers/intel/gma/hires_fb/gma.adb new file mode 100644 index 0000000..7ebc4f8 --- /dev/null +++ b/src/drivers/intel/gma/hires_fb/gma.adb @@ -0,0 +1,117 @@ +with HW.GFX; +with HW.GFX.Framebuffer_Filler; +with HW.GFX.GMA; + +use HW.GFX; +use HW.GFX.GMA; + +with GMA.Mainboard; + +package body GMA +is + + vbe_valid : boolean := false; + + linear_fb_addr : word64; + + fb : Framebuffer_Type; + + function vbe_mode_info_valid return Interfaces.C.int + is + begin + return (if vbe_valid then 1 else 0); + end vbe_mode_info_valid; + + procedure fill_lb_framebuffer (framebuffer : out lb_framebuffer) + is + use type word32; + begin + framebuffer := + (tag => 0, + size => 0, + physical_address => linear_fb_addr, + x_resolution => word32 (fb.Width), + y_resolution => word32 (fb.Height), + bytes_per_line => 4 * word32 (fb.Stride), + bits_per_pixel => 32, + reserved_mask_pos => 24, + reserved_mask_size => 8, + red_mask_pos => 16, + red_mask_size => 8, + green_mask_pos => 8, + green_mask_size => 8, + blue_mask_pos => 0, + blue_mask_size => 8); + end fill_lb_framebuffer; + + ---------------------------------------------------------------------------- + + procedure gfxinit + (mmio_base : in word64; + linear_fb : in word64; + phys_fb : in word32; + lightup_ok : out Interfaces.C.int) + is + use type pos32; + + ports : Port_List; + configs : Configs_Type; + + success : boolean; + + stride : Width_Type; + max_h : pos16 := 1; + max_v : pos16 := 1; + begin + lightup_ok := 0; + + HW.GFX.GMA.Initialize + (MMIO_Base => mmio_base, + Success => success); + + if success then + ports := Mainboard.ports; + HW.GFX.GMA.Scan_Ports (configs, ports); + + if configs (Primary).Port /= Disabled then + for i in Config_Index loop + exit when configs (i).Port = Disabled; + + max_h := pos16'max (max_h, configs (i).Mode.H_Visible); + max_v := pos16'max (max_v, configs (i).Mode.V_Visible); + end loop; + + stride := ((Width_Type (max_h) + 63) / 64) * 64; + for i in Config_Index loop + exit when configs (i).Port = Disabled; + + configs (i).Framebuffer := + (Width => Width_Type (configs (i).Mode.H_Visible), + Height => Height_Type (configs (i).Mode.V_Visible), + BPC => 8, + Stride => stride, + Offset => 0); + end loop; + + HW.GFX.GMA.Dump_Configs (configs); + + fb := + (Width => Width_Type (max_h), + Height => Height_Type (max_v), + BPC => 8, + Stride => stride, + Offset => 0); + HW.GFX.GMA.Setup_Default_GTT (fb, phys_fb); + HW.GFX.Framebuffer_Filler.Fill (linear_fb, fb); + + HW.GFX.GMA.Update_Outputs (configs); + + linear_fb_addr := linear_fb; + vbe_valid := true; + + lightup_ok := 1; + end if; + end if; + end gfxinit; + +end GMA; diff --git a/src/drivers/intel/gma/text_fb/gma.adb b/src/drivers/intel/gma/text_fb/gma.adb new file mode 100644 index 0000000..bbb6d74 --- /dev/null +++ b/src/drivers/intel/gma/text_fb/gma.adb @@ -0,0 +1,75 @@ +with HW.GFX; +with HW.GFX.GMA; + +use HW.GFX; +use HW.GFX.GMA; + +with GMA.Mainboard; + +package body GMA +is + + function vbe_mode_info_valid return Interfaces.C.int + is + begin + return 0; + end vbe_mode_info_valid; + + procedure fill_lb_framebuffer (framebuffer : out lb_framebuffer) + is + begin + null; + end fill_lb_framebuffer; + + ---------------------------------------------------------------------------- + + procedure gfxinit + (mmio_base : in word64; + linear_fb : in word64; + phys_fb : in word32; + lightup_ok : out Interfaces.C.int) + is + ports : Port_List; + configs : Configs_Type; + + success : boolean; + + -- from pc80/vga driver + procedure vga_io_init; + pragma Import (C, vga_io_init, "vga_io_init"); + procedure vga_textmode_init; + pragma Import (C, vga_textmode_init, "vga_textmode_init"); + begin + lightup_ok := 0; + + HW.GFX.GMA.Initialize + (MMIO_Base => mmio_base, + Success => success); + + if success then + ports := Mainboard.ports; + HW.GFX.GMA.Scan_Ports + (Configs => configs, + Ports => ports, + Max_Pipe => Primary); + + if configs (Primary).Port /= Disabled then + vga_io_init; + vga_textmode_init; + + configs (Primary).Framebuffer := + (Width => 640, + Height => 400, + BPC => Auto_BPC, -- ignored for VGA plane + Stride => 320, -- ignored + Offset => VGA_PLANE_FRAMEBUFFER_OFFSET); + + HW.GFX.GMA.Dump_Configs (configs); + HW.GFX.GMA.Update_Outputs (configs); + + lightup_ok := 1; + end if; + end if; + end gfxinit; + +end GMA;

1 0

New patch to review for coreboot: device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known.
by Philipp Deppenwiese 15 Dec '16

15 Dec '16

Philipp Deppenwiese (zaolin.daisuki(a)googlemail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17895 -gerrit commit 0995fb186de48af54ce73cd2a35610d7291f99d2 Author: Philipp Deppenwiese <zaolin(a)das-labor.org> Date: Thu Dec 15 23:42:58 2016 +0100 device/Kconfig: Make VGA_BIOS_FILE generic if VGA_BIOS_ID is known. Normally blobs are placed under the blobs repository of coreboot therefore the path should point to the mainboard blobs directory instead of the root of coreboot. This can be overwritten by a mainboard specific definition. Change-Id: I1791dcd4ddd037b4c95f3424bd629f7f1f3ab51a Signed-off-by: Philipp Deppenwiese <zaolin(a)das-labor.org> --- src/device/Kconfig | 2 +- src/mainboard/amd/inagua/Kconfig | 5 ----- src/mainboard/amd/persimmon/Kconfig | 5 ----- src/mainboard/amd/south_station/Kconfig | 3 --- src/mainboard/amd/torpedo/Kconfig | 5 ----- src/mainboard/amd/union_station/Kconfig | 3 --- src/mainboard/apple/macbookair4_2/Kconfig | 4 ---- src/mainboard/asus/f2a85-m_le/Kconfig | 4 ---- src/mainboard/getac/p470/Kconfig | 4 ++-- src/mainboard/gigabyte/ga-b75m-d3h/Kconfig | 4 ---- src/mainboard/gigabyte/ga-b75m-d3v/Kconfig | 4 ---- src/mainboard/google/auron/Kconfig | 4 ++-- src/mainboard/google/auron_paine/Kconfig | 4 ++-- src/mainboard/google/beltino/Kconfig | 4 ++-- src/mainboard/google/butterfly/Kconfig | 4 ++-- src/mainboard/google/cyan/Kconfig | 8 -------- src/mainboard/google/enguarde/Kconfig | 4 ++-- src/mainboard/google/jecht/Kconfig | 4 ++-- src/mainboard/google/ninja/Kconfig | 4 ++-- src/mainboard/google/rambi/Kconfig | 4 ++-- src/mainboard/google/samus/Kconfig | 4 ++-- src/mainboard/google/stout/Kconfig | 4 ---- src/mainboard/intel/cougar_canyon2/Kconfig | 4 ---- src/mainboard/intel/strago/Kconfig | 8 -------- src/mainboard/jetway/nf81-t56n-lf/Kconfig | 5 ----- src/mainboard/kontron/ktqm77/Kconfig | 4 ++-- src/mainboard/lenovo/t530/Kconfig | 4 ---- src/mainboard/lenovo/x230/Kconfig | 4 ---- src/mainboard/lippert/frontrunner-af/Kconfig | 5 ----- src/mainboard/lippert/toucan-af/Kconfig | 5 ----- src/mainboard/pcengines/apu1/Kconfig | 5 ----- src/mainboard/samsung/lumpy/Kconfig | 4 ++-- src/mainboard/samsung/stumpy/Kconfig | 4 ++-- src/mainboard/via/pc2500e/Kconfig | 4 ---- src/mainboard/winent/mb6047/Kconfig | 4 ---- src/northbridge/amd/pi/00630F01/Kconfig | 4 ---- src/northbridge/amd/pi/00660F01/Kconfig | 4 ---- src/northbridge/amd/pi/00670F00/Kconfig | 4 ---- src/northbridge/amd/pi/00730F01/Kconfig | 4 ---- src/soc/intel/fsp_baytrail/Kconfig | 4 ---- 40 files changed, 27 insertions(+), 144 deletions(-) diff --git a/src/device/Kconfig b/src/device/Kconfig index d238547..01b246f 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -339,7 +339,7 @@ config VGA_BIOS config VGA_BIOS_FILE string "VGA BIOS path and filename" depends on VGA_BIOS - default "vgabios.bin" + default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/pci${VGA_BIOS_ID}.rom" help The path and filename of the file to use as VGA BIOS. diff --git a/src/mainboard/amd/inagua/Kconfig b/src/mainboard/amd/inagua/Kconfig index 89bb516..b68bcba 100644 --- a/src/mainboard/amd/inagua/Kconfig +++ b/src/mainboard/amd/inagua/Kconfig @@ -61,11 +61,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVBios.bin" - config VGA_BIOS_ID string "VGA device PCI IDs" depends on VGA_BIOS diff --git a/src/mainboard/amd/persimmon/Kconfig b/src/mainboard/amd/persimmon/Kconfig index b365eba..0e28ad0 100644 --- a/src/mainboard/amd/persimmon/Kconfig +++ b/src/mainboard/amd/persimmon/Kconfig @@ -61,11 +61,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/amd/south_station/Kconfig b/src/mainboard/amd/south_station/Kconfig index f92d27d..dc192be 100644 --- a/src/mainboard/amd/south_station/Kconfig +++ b/src/mainboard/amd/south_station/Kconfig @@ -60,9 +60,6 @@ config ONBOARD_VGA_IS_PRIMARY config VGA_BIOS bool default n -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" config VGA_BIOS_ID string diff --git a/src/mainboard/amd/torpedo/Kconfig b/src/mainboard/amd/torpedo/Kconfig index 5c85c4b..2c80932 100644 --- a/src/mainboard/amd/torpedo/Kconfig +++ b/src/mainboard/amd/torpedo/Kconfig @@ -69,11 +69,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/LlanoGenericVbios.bin" - config VGA_BIOS_ID string "VGA device PCI IDs" depends on VGA_BIOS diff --git a/src/mainboard/amd/union_station/Kconfig b/src/mainboard/amd/union_station/Kconfig index 83660bb..81a3e5c 100644 --- a/src/mainboard/amd/union_station/Kconfig +++ b/src/mainboard/amd/union_station/Kconfig @@ -59,9 +59,6 @@ config ONBOARD_VGA_IS_PRIMARY config VGA_BIOS bool default n -config VGA_BIOS_FILE - string - default "site-local/vgabios.bin" config VGA_BIOS_ID string diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 08e7166..42ece41 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -31,10 +31,6 @@ config MAINBOARD_PART_NUMBER string default "MacBookAir4,2" -config VGA_BIOS_FILE - string - default "pci8086,0116.rom" - config VGA_BIOS_ID string default "8086,0116" diff --git a/src/mainboard/asus/f2a85-m_le/Kconfig b/src/mainboard/asus/f2a85-m_le/Kconfig index a81f700..923bee1 100644 --- a/src/mainboard/asus/f2a85-m_le/Kconfig +++ b/src/mainboard/asus/f2a85-m_le/Kconfig @@ -86,8 +86,4 @@ config VGA_BIOS_ID string default "1002,9901" -config VGA_BIOS_FILE - string - default "pci1002,9901.rom" - endif # BOARD_ASUS_F2A85_M_LE diff --git a/src/mainboard/getac/p470/Kconfig b/src/mainboard/getac/p470/Kconfig index ea68bed..985dd3a 100644 --- a/src/mainboard/getac/p470/Kconfig +++ b/src/mainboard/getac/p470/Kconfig @@ -60,8 +60,8 @@ config MAX_CPUS int default 4 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "getac-pci8086,27a2.rom" + default "8086,27a2" endif # BOARD_GETAC_P470 diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig index e53b68c..81190f9 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3h/Kconfig @@ -46,10 +46,6 @@ config VGA_BIOS_ID string default "8086,0162" -config VGA_BIOS_FILE - string - default "pci8086,0162.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig index 2be3322..a4db486 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig +++ b/src/mainboard/gigabyte/ga-b75m-d3v/Kconfig @@ -46,10 +46,6 @@ config VGA_BIOS_ID string default "8086,0102" -config VGA_BIOS_FILE - string - default "pci8086,0102.rom" - config HAVE_IFD_BIN bool default n diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 9eda101..4b30afa 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/auron_paine/Kconfig b/src/mainboard/google/auron_paine/Kconfig index 147f37d..7c63ee3 100644 --- a/src/mainboard/google/auron_paine/Kconfig +++ b/src/mainboard/google/auron_paine/Kconfig @@ -45,9 +45,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/beltino/Kconfig b/src/mainboard/google/beltino/Kconfig index c430018..ca663a7 100644 --- a/src/mainboard/google/beltino/Kconfig +++ b/src/mainboard/google/beltino/Kconfig @@ -61,9 +61,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0406.rom" + default "8086,0406" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/butterfly/Kconfig b/src/mainboard/google/butterfly/Kconfig index 09d2157..fdf2f17 100644 --- a/src/mainboard/google/butterfly/Kconfig +++ b/src/mainboard/google/butterfly/Kconfig @@ -36,9 +36,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index d236aa0..8985c15 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -46,14 +46,6 @@ config MAINBOARD_VENDOR default "Google" if !GOP_SUPPORT -config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin" - help - The C0 version of the video bios gets computed from this name - so that they can both be added. Only the correct one for the - system will be run. - config VGA_BIOS_ID string default "8086,22b0" diff --git a/src/mainboard/google/enguarde/Kconfig b/src/mainboard/google/enguarde/Kconfig index c2842bb..c990748 100644 --- a/src/mainboard/google/enguarde/Kconfig +++ b/src/mainboard/google/enguarde/Kconfig @@ -27,9 +27,9 @@ config MAINBOARD_PART_NUMBER string default "Enguarde" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0f31.rom" + default "8086,0f31" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/jecht/Kconfig b/src/mainboard/google/jecht/Kconfig index 8a30a4d..7676dab 100644 --- a/src/mainboard/google/jecht/Kconfig +++ b/src/mainboard/google/jecht/Kconfig @@ -31,9 +31,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/ninja/Kconfig b/src/mainboard/google/ninja/Kconfig index 4c28e1a..dc513b7 100644 --- a/src/mainboard/google/ninja/Kconfig +++ b/src/mainboard/google/ninja/Kconfig @@ -29,9 +29,9 @@ config MAINBOARD_PART_NUMBER string default "Ninja" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0f31.rom" + default "8086,0f31" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index 94354c9..d7cfccc 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -27,9 +27,9 @@ config MAINBOARD_PART_NUMBER string default "Rambi" -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/samus/Kconfig b/src/mainboard/google/samus/Kconfig index 528a5eb..82e06f4 100644 --- a/src/mainboard/google/samus/Kconfig +++ b/src/mainboard/google/samus/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config HAVE_IFD_BIN bool diff --git a/src/mainboard/google/stout/Kconfig b/src/mainboard/google/stout/Kconfig index 571cbce..2ba6a6e 100644 --- a/src/mainboard/google/stout/Kconfig +++ b/src/mainboard/google/stout/Kconfig @@ -36,10 +36,6 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE - string - default "pci8086,0156.rom" - config VGA_BIOS_ID string default "8086,0156" diff --git a/src/mainboard/intel/cougar_canyon2/Kconfig b/src/mainboard/intel/cougar_canyon2/Kconfig index 00db10e..ce9eda8 100644 --- a/src/mainboard/intel/cougar_canyon2/Kconfig +++ b/src/mainboard/intel/cougar_canyon2/Kconfig @@ -47,10 +47,6 @@ config VGA_BIOS bool default y -config VGA_BIOS_FILE - string - default "../intel/mainboard/intel/cougar_canyon2/vbios/snm_2170.dat" - config VGA_BIOS_ID string default "8086,0166" diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 0d59371..415cfa3 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -39,14 +39,6 @@ config MAINBOARD_VENDOR default "Intel" if !GOP_SUPPORT -config VGA_BIOS_FILE - string - default "3rdparty/blobs/mainboard/intel/strago/vgabios.bin" - help - The C0 version of the video bios gets computed from this name - so that they can both be added. Only the correct one for the - system will be run. - config VGA_BIOS_ID string default "8086,22b0" diff --git a/src/mainboard/jetway/nf81-t56n-lf/Kconfig b/src/mainboard/jetway/nf81-t56n-lf/Kconfig index 14c534b..81d6f32 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/Kconfig +++ b/src/mainboard/jetway/nf81-t56n-lf/Kconfig @@ -62,11 +62,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9806" # FUSION_G_T56N diff --git a/src/mainboard/kontron/ktqm77/Kconfig b/src/mainboard/kontron/ktqm77/Kconfig index 115a0fa..8bde3e0 100644 --- a/src/mainboard/kontron/ktqm77/Kconfig +++ b/src/mainboard/kontron/ktqm77/Kconfig @@ -32,9 +32,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0166.rom" + default "8086,0166" config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig index 76147fc..e4484cc 100644 --- a/src/mainboard/lenovo/t530/Kconfig +++ b/src/mainboard/lenovo/t530/Kconfig @@ -62,10 +62,6 @@ config VGA_BIOS_ID string default "8086,0106" -config VGA_BIOS_FILE - string - default "pci8086,0106.rom" - config MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID hex default 0x17aa diff --git a/src/mainboard/lenovo/x230/Kconfig b/src/mainboard/lenovo/x230/Kconfig index 16e34ff..0e5509b 100644 --- a/src/mainboard/lenovo/x230/Kconfig +++ b/src/mainboard/lenovo/x230/Kconfig @@ -55,10 +55,6 @@ config DRAM_RESET_GATE_GPIO int default 10 -config VGA_BIOS_FILE - string - default "pci8086,0166.rom" - config VGA_BIOS_ID string default "8086,0166" diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig index 1ec219e..4385cee 100644 --- a/src/mainboard/lippert/frontrunner-af/Kconfig +++ b/src/mainboard/lippert/frontrunner-af/Kconfig @@ -63,11 +63,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/lippert/toucan-af/Kconfig b/src/mainboard/lippert/toucan-af/Kconfig index 590909b..206fe98 100644 --- a/src/mainboard/lippert/toucan-af/Kconfig +++ b/src/mainboard/lippert/toucan-af/Kconfig @@ -65,11 +65,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/pcengines/apu1/Kconfig b/src/mainboard/pcengines/apu1/Kconfig index 3099d14..ff3254b 100644 --- a/src/mainboard/pcengines/apu1/Kconfig +++ b/src/mainboard/pcengines/apu1/Kconfig @@ -63,11 +63,6 @@ config VGA_BIOS bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" diff --git a/src/mainboard/samsung/lumpy/Kconfig b/src/mainboard/samsung/lumpy/Kconfig index 7cb00e5..c65fc2d 100644 --- a/src/mainboard/samsung/lumpy/Kconfig +++ b/src/mainboard/samsung/lumpy/Kconfig @@ -39,9 +39,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_POWER_ON_AFTER_POWER_FAIL bool diff --git a/src/mainboard/samsung/stumpy/Kconfig b/src/mainboard/samsung/stumpy/Kconfig index 3777f69..e83b00b 100644 --- a/src/mainboard/samsung/stumpy/Kconfig +++ b/src/mainboard/samsung/stumpy/Kconfig @@ -37,9 +37,9 @@ config MAX_CPUS int default 8 -config VGA_BIOS_FILE +config VGA_BIOS_ID string - default "pci8086,0106.rom" + default "8086,0106" config MAINBOARD_POWER_ON_AFTER_POWER_FAIL bool diff --git a/src/mainboard/via/pc2500e/Kconfig b/src/mainboard/via/pc2500e/Kconfig index d5e1133..62f9788 100644 --- a/src/mainboard/via/pc2500e/Kconfig +++ b/src/mainboard/via/pc2500e/Kconfig @@ -24,10 +24,6 @@ config IRQ_SLOT_COUNT int default 10 -config VGA_BIOS_FILE - string - default "M14CRT.ROM" - config VGA_BIOS_ID string default "1106,3344" diff --git a/src/mainboard/winent/mb6047/Kconfig b/src/mainboard/winent/mb6047/Kconfig index 5a3b81d..ca22025 100644 --- a/src/mainboard/winent/mb6047/Kconfig +++ b/src/mainboard/winent/mb6047/Kconfig @@ -58,8 +58,4 @@ config VGA_BIOS_ID string default "126f,0720" -config VGA_BIOS_FILE - string - default "DM22383.ROM" - endif # BOARD_WINENT_MB6047 diff --git a/src/northbridge/amd/pi/00630F01/Kconfig b/src/northbridge/amd/pi/00630F01/Kconfig index 3669826..902bb42 100644 --- a/src/northbridge/amd/pi/00630F01/Kconfig +++ b/src/northbridge/amd/pi/00630F01/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00630F01/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00660F01/Kconfig b/src/northbridge/amd/pi/00660F01/Kconfig index fdae80f..45fd46a 100644 --- a/src/northbridge/amd/pi/00660F01/Kconfig +++ b/src/northbridge/amd/pi/00660F01/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00660F01/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00670F00/Kconfig b/src/northbridge/amd/pi/00670F00/Kconfig index a92658a..8aa2c6f 100644 --- a/src/northbridge/amd/pi/00670F00/Kconfig +++ b/src/northbridge/amd/pi/00670F00/Kconfig @@ -40,8 +40,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00670F00/VBIOS.bin" - endif diff --git a/src/northbridge/amd/pi/00730F01/Kconfig b/src/northbridge/amd/pi/00730F01/Kconfig index 47c2323..a77b089 100644 --- a/src/northbridge/amd/pi/00730F01/Kconfig +++ b/src/northbridge/amd/pi/00730F01/Kconfig @@ -41,8 +41,4 @@ config VGA_BIOS_ID The default VGA BIOS PCI vendor/device ID should be set to the result of the map_oprom_vendev() function in northbridge.c. -config VGA_BIOS_FILE - string - default "3rdparty/blobs/northbridge/amd/00730F01/VBIOS.bin" - endif diff --git a/src/soc/intel/fsp_baytrail/Kconfig b/src/soc/intel/fsp_baytrail/Kconfig index 689e625..9655d74 100644 --- a/src/soc/intel/fsp_baytrail/Kconfig +++ b/src/soc/intel/fsp_baytrail/Kconfig @@ -91,10 +91,6 @@ config ENABLE_BUILTIN_COM1 configure the pads and enable it. This serial port can be used for the debug console. -config VGA_BIOS_FILE - string - default "../intel/cpu/baytrail/vbios/Vga.dat" if VGA_BIOS - config FSP_BAYTRAIL_GFX_INIT default n bool

1 0

Patch merged into coreboot/master: 3rdparty/libgfxinit: Update to latest master
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit f971dcbf25065384d52c41696684a30dad64f77d Author: Nico Huber <nico.huber(a)secunet.com> Date: Thu Dec 8 16:01:54 2016 +0100 3rdparty/libgfxinit: Update to latest master Changes: o Verification that the framebuffer matches the display mode o Automatic upscaling if the framebuffer resolution is lower than the display mode's o VGA-plane support o HDMI pixel rate is limited to hardware constraints o Error tolerant handling of EDID header-pattern Change-Id: Icbfdf5f37caf99f66847a71f784730aced0826ab Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/17775 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/17775 for details. -gerrit

1 0

Patch merged into coreboot/master: util/ifdfake: Add number of regions
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit e70bfee425da5ba44d1c14f95fed295168f93287 Author: Nico Huber <nico.huber(a)secunet.com> Date: Wed Nov 16 16:01:50 2016 +0100 util/ifdfake: Add number of regions To make the generated descriptor compatible with latest libflashrom. Change-Id: I005159dd24e72da9cc43119103c96c5dd5b90a55 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/17447 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> See https://review.coreboot.org/17447 for details. -gerrit

1 0

Patch merged into coreboot/master: mb/ga-945gcm-s2l: Fix resume from suspend
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 50ce16354ba3bfe257c47848d855de9dee9ec798 Author: Arthur Heymans <arthur(a)aheymans.xyz> Date: Sat Nov 26 16:46:56 2016 +0100 mb/ga-945gcm-s2l: Fix resume from suspend Checking for memory self refresh can generate false positives, as explained in faa6beb: "northbridge/intel/i945: CHECK_SLFRCS_ON_RESUME Kconfig option". This seems to be the case for this motherboard. TESTED on ga-945gcm-s2l. Change-Id: Iadf0a73b054470b652e1dc02557fb1715131f823 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/17617 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h(a)gmx.de> See https://review.coreboot.org/17617 for details. -gerrit

1 0

Patch merged into coreboot/master: smbios.h: add missing SKU field to type3 table
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 4863cc45a80dd690eceb5f23c9d035ee43db5a34 Author: Matt DeVillier <matt.devillier(a)gmail.com> Date: Thu Sep 1 00:55:40 2016 -0500 smbios.h: add missing SKU field to type3 table The type3 SMBIOS table has a non-optional SKU field at the end, which causes a parsing error when missing. Add but do not populate it. Change-Id: I988d0626b8680740697e1db58eb6d0b87874bfde Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/17851 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Martin Roth <martinroth(a)google.com> See https://review.coreboot.org/17851 for details. -gerrit

1 0

Patch merged into coreboot/master: ec/ene932: correct ACPI battery data fed into ToString()
by gerrit＠coreboot.org 15 Dec '16

15 Dec '16

the following patch was just integrated into master: commit 678923c2b7f8c50746be4e49f9ad3ccd1ca11c45 Author: Matt DeVillier <matt.devillier(a)gmail.com> Date: Fri Dec 9 18:14:57 2016 -0600 ec/ene932: correct ACPI battery data fed into ToString() ToString() requires the input buffer data to be null-terminated, but the data returned by the EC is not, leading Windows to fail to report any battery data at all. Correct this by concatenating a null terminator (0x00) to the end of the buffer data before inputting to ToString() where needed Change-Id: Ic86048d1d6354b9b0dac3c8957df318d0825c905 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/17783 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h(a)gmx.de> See https://review.coreboot.org/17783 for details. -gerrit

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2016