the following patch was just integrated into master:
commit 6e50e33aea6062df5c06652fe3617cb8b5df5e3b
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Dec 15 14:57:04 2016 +0100
util/broadcom: Close file after use
Change-Id: Ieea7ac7fbc618cd12f843f1606f9ebab37cae67e
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Found-by: Coverity Scan #1323508
Reviewed-on: https://review.coreboot.org/17879
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/17879 for details.
-gerrit
the following patch was just integrated into master:
commit 856a3ab7c7c216a90b8ae45d6a0931a8eb3b7d20
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Dec 15 14:55:10 2016 +0100
util/broadcom: Terminate string
filebuffer is treated like a string, so it should be zero-terminated
like a string.
Change-Id: I078aa39906394be64023424731fe0c7ae2019899
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Found-by: Coverity Scan #1323473
Reviewed-on: https://review.coreboot.org/17878
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/17878 for details.
-gerrit
the following patch was just integrated into master:
commit 5f771dca27dd54c1eb5857344caf235cab83e568
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Dec 15 14:51:08 2016 +0100
util/broadcom: close file on error
Change-Id: I5193c6a9f08398b881c971c7175654ba5775b34a
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Found-by: Coverity Scan #1323509
Reviewed-on: https://review.coreboot.org/17876
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth(a)google.com>
See https://review.coreboot.org/17876 for details.
-gerrit
the following patch was just integrated into master:
commit 1d1e141f2e2c44de514f34ae22e074e9a8718b7a
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Thu Dec 15 14:47:29 2016 +0100
mediatek/mt8173: Check the right set of bits in USB controller
Change-Id: Ic1d1b85a1d7e85b555a93b3a0b55fe310b26e34a
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
Found-by: Coverity Scan #1353362
Reviewed-on: https://review.coreboot.org/17875
Tested-by: build bot (Jenkins)
Reviewed-by: Julius Werner <jwerner(a)chromium.org>
Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net>
See https://review.coreboot.org/17875 for details.
-gerrit
Arthur Heymans (arthur(a)aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17900
-gerrit
commit 938b1bdee76a3862eca7b617ac2152f2b1579fde
Author: Arthur Heymans <arthur(a)aheymans.xyz>
Date: Fri Dec 16 15:32:32 2016 +0100
nb/x4x: Add other Eaglelake IGD PCI DID to list
Currently only there is only one eaglelake board in coreboot
(ga-g41m-es2l) featuring a G41 variant northbridge.
Adding boards with a different variant (Q43, Q45, G43, G45, B43) will
require this change for native graphic init to be used.
Change-Id: Ida32c563a99576b66685dfdadf9a534fd6e197dc
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
src/northbridge/intel/x4x/gma.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index 76ab893..74250fe 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -424,7 +424,13 @@ static struct device_operations gma_func0_ops = {
static const unsigned short pci_device_ids[] =
{
- 0x2e32, 0
+ 0x2e02, /* Eaglelake */
+ 0x2e12, /* Q43/Q45 */
+ 0x2e22, /* G43/G45 */
+ 0x2e32, /* G41 */
+ 0x2e42, /* B43 */
+ 0x2e92, /* B43_I */
+ 0
};
static const struct pci_driver gma __pci_driver = {
Patrick Georgi (pgeorgi(a)google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17899
-gerrit
commit 63a636326c4ee2f91c039bc058e730facc3ce9ae
Author: Patrick Georgi <pgeorgi(a)chromium.org>
Date: Fri Dec 16 14:51:53 2016 +0100
util/cbfstool: Don't print region information on stderr by default
It's usually not too interesting, so hide it behind -v.
Change-Id: Icffb5ea4d70300ab06dfa0c9134d265433260368
Signed-off-by: Patrick Georgi <pgeorgi(a)chromium.org>
---
util/cbfstool/cbfstool.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index d3c15e0..25b3f6c 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -1151,7 +1151,8 @@ static int dispatch_command(struct command command)
if (command.accesses_region) {
assert(param.image_file);
- if (partitioned_file_is_partitioned(param.image_file)) {
+ if (partitioned_file_is_partitioned(param.image_file) &&
+ verbose > 0) {
LOG("Performing operation on '%s' region...\n",
param.region_name);
}
Sumeet R Pawnikar (sumeet.r.pawnikar(a)intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17889
-gerrit
commit 7821345d55e5029447bd1f99e71d855b206f3fbb
Author: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
Date: Thu Dec 15 19:29:51 2016 +0530
skylake: Restore target offset value after exiting from S3
Before entering in S3, the target offset value is 10 degree C.
After exiting from S3, Coreboot is not restoring the target offset value
and it is setting it to the default value as 0.
With the default target offset value as 0 and target temperature Tjmax
value as 100 degree C, Pcode firmware starts taking prochot action at
100 degree C [Tjmax-Offset].
But before Pcode firmware starts prochot action at 100 degree C, device
is getting shutdown at 99 degree C due to DPTF critical CPU temperature
after exiting from S3.
So, this patch restores the target offset value after exiting from S3.
BUG=chrome-os-partner:59397
BRANCH=None.
TEST=Built for skylake platform and verified the target offset value
before and after S3.
Change-Id: Iacf64cbc40871bbec3bede65f196bf292e0149a6
Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com>
---
src/soc/intel/skylake/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 3ec8d2c..0458a93 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -206,6 +206,8 @@ static void configure_thermal_target(void)
wrmsr(MSR_TEMPERATURE_TARGET, msr);
}
msr = rdmsr(MSR_TEMPERATURE_TARGET);
+ msr.lo &= ~(0xf << 24); /* Bits 27:24 */
+ msr.lo |= 0xa << 24; /* set target offset as 10 degree C */
msr.lo &= ~0x7f; /* Bits 6:0 */
msr.lo |= 0xe6; /* setting 100ms thermal time window */
wrmsr(MSR_TEMPERATURE_TARGET, msr);