Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86553?usp=email
to look at the new patch set (#3).
Change subject: soc/mediatek/mt8196: Disable HWRot's clocks
......................................................................
soc/mediatek/mt8196: Disable HWRot's clocks
HWRot(Hardware Root of trust) are not used, so we disable its clocks to
save power. This is a Vcore sub-block item that decreases SOC power
consumption from 120mW to 90mW.
BRANCH=rauru
BUG=b:377628718
TEST=Bootup OK & Suspend/Resume passed
Signed-off-by: Guangjie Song <guangjie.song(a)mediatek.com>
Change-Id: I25e607e8e8b2d52608d279e1862f423ca50aab6a
---
M src/soc/mediatek/mt8196/pll.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/86553/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I25e607e8e8b2d52608d279e1862f423ca50aab6a
Gerrit-Change-Number: 86553
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jayvik Desai, Kapil Porwal, Pranava Y N, Tongtong Pan.
Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/86549?usp=email )
Change subject: mb/google/fatcat/var/felino: Enable CNVi wifi core
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/86549?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib5a98dc481b0c64612ffd50242262714f114b5b7
Gerrit-Change-Number: 86549
Gerrit-PatchSet: 1
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Fri, 21 Feb 2025 07:44:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86553?usp=email )
Change subject: soc/mediatek/mt8196: Disable HWRot's clocks
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86553/comment/161e26b2_88dbb19e?us… :
PS2, Line 10: save power.
do you have the number ?
https://review.coreboot.org/c/coreboot/+/86553/comment/0589786f_21bbe581?us… :
PS2, Line 14: OK
passed
--
To view, visit https://review.coreboot.org/c/coreboot/+/86553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I25e607e8e8b2d52608d279e1862f423ca50aab6a
Gerrit-Change-Number: 86553
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 21 Feb 2025 07:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86552?usp=email )
Change subject: soc/mediatek/mt8196: Adjust HW protect temperature
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86552/comment/4d7496e6_9d8dea2c?us… :
PS2, Line 7: HW protect temperature
> thermal trip points
Adjust thermal trip point parameters
https://review.coreboot.org/c/coreboot/+/86552/comment/dbaed4fa_cfaf9e36?us… :
PS2, Line 9: Adjust HW protect temperature so HW will trigger interrupt at expected
: trip point.
> Adjust thermal trip points so the thermal can trigger the interrupt at the expected trip point.
Adjust thermal trip point parameters so the thermal can trigger the interrupt at the expected trip point.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86552?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7361edd7f75b82fff4241ec94488ed1ef07346f
Gerrit-Change-Number: 86552
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Zhaoqing Jiu <zhaoqing.jiu(a)mediatek.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 21 Feb 2025 07:17:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86552?usp=email )
Change subject: soc/mediatek/mt8196: Adjust HW protect temperature
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86552/comment/8044976e_ecb5491c?us… :
PS2, Line 7: HW protect temperature
thermal trip points
https://review.coreboot.org/c/coreboot/+/86552/comment/e8e242de_a4051d9a?us… :
PS2, Line 9: Adjust HW protect temperature so HW will trigger interrupt at expected
: trip point.
Adjust thermal trip points so the thermal can trigger the interrupt at the expected trip point.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86552?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7361edd7f75b82fff4241ec94488ed1ef07346f
Gerrit-Change-Number: 86552
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Zhaoqing Jiu <zhaoqing.jiu(a)mediatek.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 21 Feb 2025 07:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Jarried Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86533?usp=email )
Change subject: soc/mediatek/mt8196: Adjust and save HW protect temperature to SRAM
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/86533?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied0a7e710e77a4e74372590374f9342c5edc9122
Gerrit-Change-Number: 86533
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Zhaoqing Jiu <zhaoqing.jiu(a)mediatek.corp-partner.google.com>