Attention is currently required from: Subrata Banik.
Hello Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86563?usp=email
to look at the new patch set (#2).
Change subject: chromeos/Kconfig: BMP_LOGO only if using FSP
......................................................................
chromeos/Kconfig: BMP_LOGO only if using FSP
Currently, CHROMEOS_FW_SPLASH_SCREEN selects BMP_LOGO and
HAVE_CUSTOME_BMP_LOGO, which are both defined in
src/drivers/intel/fsp2_0/Kconfig. Since they are intel-/fsp2_0-
specific, change the selection to be conditional on the use of
PLATFORM_USES_FSP2_0.
BUG=b:398621376
TEST=Compile Google/Rex and Google/Rauru
Change-Id: Ic1d5118401981917d86e09b4b3d2bab5af052d6e
Signed-off-by: Paz Zcharya <pazz(a)google.com>
---
M src/vendorcode/google/chromeos/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/86563/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86563?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1d5118401981917d86e09b4b3d2bab5af052d6e
Gerrit-Change-Number: 86563
Gerrit-PatchSet: 2
Gerrit-Owner: Paz Zcharya <pazz(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Paz Zcharya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86563?usp=email )
Change subject: chromeos/Kconfig: BMP_LOGO only if using FSP
......................................................................
chromeos/Kconfig: BMP_LOGO only if using FSP
Currently, CHROMEOS_FW_SPLASH_SCREEN selects BMP_LOGO and
HAVE_CUSTOME_BMP_LOGO, which are both defined in
src/drivers/intel/fsp2_0/Kconfig. Since they are intel/fsp2_0 specific,
change the selection to be conditional on the use of PLATFORM_USES_FSP2_0.
BUG=b:398621376
TEST=Compile Google/Rex and Google/Rauru
Change-Id: Ic1d5118401981917d86e09b4b3d2bab5af052d6e
Signed-off-by: Paz Zcharya <pazz(a)google.com>
---
M src/vendorcode/google/chromeos/Kconfig
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/86563/1
diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 60f48fe..934ea9b 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -82,8 +82,8 @@
config CHROMEOS_FW_SPLASH_SCREEN
bool "Display Splash Screen in firmware"
default n
- select BMP_LOGO
- select HAVE_CUSTOM_BMP_LOGO
+ select BMP_LOGO if PLATFORM_USES_FSP2_0
+ select HAVE_CUSTOM_BMP_LOGO if PLATFORM_USES_FSP2_0
help
Select this option to display the manufacturer's logo or
custom image (OEM splash screen) early in the boot process.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86563?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1d5118401981917d86e09b4b3d2bab5af052d6e
Gerrit-Change-Number: 86563
Gerrit-PatchSet: 1
Gerrit-Owner: Paz Zcharya <pazz(a)google.com>
Attention is currently required from: Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85732?usp=email
to look at the new patch set (#14).
Change subject: opensbi is a burden!
......................................................................
opensbi is a burden!
Update opensbi submodule to upstream master
Updating from commit id 5019fd124b4c:
2022-09-01 16:53:28 +0530 - (include: sbi: Reduce includes in sbi_pmu.h)
to commit id 1ad199124479:
2025-01-24 17:51:57 +0530 - (lib: sbi: fwft: Return SBI_ERR_DENIED_LOCKED
when setting a locked feature)
This brings in 755 new commits.
Change-Id: Ic050c7b8dc2e202ee3b7fe07c749181c0845f0e7
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M 3rdparty/opensbi
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/85732/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/85732?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic050c7b8dc2e202ee3b7fe07c749181c0845f0e7
Gerrit-Change-Number: 85732
Gerrit-PatchSet: 14
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Carlos López <carlos.lopezr4096(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas, Intel coreboot Reviewers.
Hello Eric Lai, Intel coreboot Reviewers, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82315?usp=email
to look at the new patch set (#12).
Change subject: intel/broadwell/spd: Use <spd.h> and <dram/ddr3.h>
......................................................................
intel/broadwell/spd: Use <spd.h> and <dram/ddr3.h>
Use already defined macros in <spd.h> and <dram/ddr3.h>.
TEST=Built purism/librem_bdw (Librem 13 v1) with BUILD_TIMELESS=1, no
change in output ROM.
Change-Id: Id38b97017b43f1421129fed0bb9c1fff5c3423d8
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/soc/intel/broadwell/spd.c
1 file changed, 13 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/82315/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/82315?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id38b97017b43f1421129fed0bb9c1fff5c3423d8
Gerrit-Change-Number: 82315
Gerrit-PatchSet: 12
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Intel coreboot Reviewers, Name of user not set #1005756, Patrick Rudolph.
Paul Menzel has posted comments on this change by Name of user not set #1005756. ( https://review.coreboot.org/c/coreboot/+/86562?usp=email )
Change subject: src/cpu/intel/car/romstage.c: Refactor stack guard code in romstage
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86562/comment/fb185b5d_e956cdde?us… :
PS2, Line 7: src/cpu/intel/car/romstage.c
I suggest: cpu/intel/car/romstage
https://review.coreboot.org/c/coreboot/+/86562/comment/794148bb_b0fad66f?us… :
PS2, Line 9: Refactor stack guard code in romstage.
Madybe more specific: Factor out stack_guard_set() and …() for improving readability.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86562?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I754e422c0023cd7824dd6109f031239756acff4b
Gerrit-Change-Number: 86562
Gerrit-PatchSet: 2
Gerrit-Owner: Name of user not set #1005756
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Patrick Rudolph
Gerrit-Attention: Name of user not set #1005756
Gerrit-Comment-Date: Sun, 23 Feb 2025 13:26:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151)
......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/lenovo/m900/cmos.layout:
https://review.coreboot.org/c/coreboot/+/74187/comment/67b29e4d_32db5a32?us… :
PS10, Line 21: 400 1 e 2 hyper_threading
Doesn't have a default
File src/mainboard/lenovo/m900/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74187/comment/6a34ac9a_3006f5fb?us… :
PS10, Line 42: register "PrimaryDisplay" = "Display_PEG"
Out of curiosity, why?
https://review.coreboot.org/c/coreboot/+/74187/comment/113e4607_5438e6f8?us… :
PS10, Line 122: register "gen1_dec" = "0x00fc0201"
: register "gen2_dec" = "0x003c0a01"
: register "gen3_dec" = "0x00040069"
: register "gen4_dec" = "0x000c0081"
Do we know what these decode ranges are used for?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22
Gerrit-Change-Number: 74187
Gerrit-PatchSet: 10
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sun, 23 Feb 2025 10:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alexander Couzens, Angel Pons, Jan Philipp Groß, Nicholas Chin, Paul Menzel.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add ThinkCentre M900 (Skylake/LGA 1151)
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74187?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22
Gerrit-Change-Number: 74187
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Sun, 23 Feb 2025 07:07:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes