Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Ian Feng has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86144?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86144?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63512e85052bce974ffb0b738164bea440bd413c
Gerrit-Change-Number: 86144
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 06:38:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Pranava Y N.
Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/84923?usp=email )
Change subject: mb/google/fatcat: Enable s0ix
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84923/comment/53e0c3db_e80b03a2?us… :
PS1, Line 1: Parent: 686b36ba (tree: Fix cast an object of type 'nullptr_t' to 'uintptr_t' error)
> BUG=b:392235839
Thanks Subrata. BUG info is added to commit message.
https://review.coreboot.org/c/coreboot/+/84923/comment/e7044d0d_fd813dc2?us… :
PS1, Line 8:
> We disable s0ix at the beginning of the program and enable once s0ix is verified and stable. […]
s0ix is verified with the latest CPFE and fatcat OS.
https://review.coreboot.org/c/coreboot/+/84923/comment/43d718d4_f84d08b4?us… :
PS1, Line 9: Change-Id: I80c65782830a2a22a9e8bb39615717a11183d30f
> No issue reference?
Thanks for comments. BUG information is added to commit message now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84923?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c65782830a2a22a9e8bb39615717a11183d30f
Gerrit-Change-Number: 84923
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 05:05:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jamie Ryu, Paul Menzel, Pranava Y N.
Hello Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84923?usp=email
to look at the new patch set (#2).
Change subject: mb/google/fatcat: Enable s0ix
......................................................................
mb/google/fatcat: Enable s0ix
BUG=b:392235839
TEST=Build fatcat and boot to OS. Run suspend_stress_test to ensure
s0ix entry and exit working.
Change-Id: I80c65782830a2a22a9e8bb39615717a11183d30f
Signed-off-by: Jamie Ryu <jamie.m.ryu(a)intel.com>
---
M src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/84923/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84923?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c65782830a2a22a9e8bb39615717a11183d30f
Gerrit-Change-Number: 84923
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Intel coreboot Reviewers, Patrick Rudolph, Vladimir Serbinenko.
Jérémy Compostella has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/86247?usp=email )
Change subject: intel/acpi: Put BSP as the first entry
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/86247?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I520a2e080c9f07a5866729ae2283990d20c0d691
Gerrit-Change-Number: 86247
Gerrit-PatchSet: 6
Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 04:33:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Kenji Yu has posted comments on this change by Kenji Yu. ( https://review.coreboot.org/c/blobs/+/86251?usp=email )
Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/86251/comment/cd13933c_58cd4be7?usp=e… :
PS6, Line 11: TEST=Build pass
> BRANCH=rauru
It is fixed.
--
To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3
Gerrit-Change-Number: 86251
Gerrit-PatchSet: 7
Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 02:02:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Kenji Yu.
Hello Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/86251?usp=email
to look at the new patch set (#7).
Change subject: soc/mediatek/mt8196: Update SSPM firmware to v3.0
......................................................................
soc/mediatek/mt8196: Update SSPM firmware to v3.0
Update sspm.bin to disable waking up SPM function.
BRANCH=rauru
TEST=Build pass
BUG=b:387181201, b:385829129
Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3
Signed-off-by: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/sspm.bin
M soc/mediatek/mt8196/sspm.bin.md5
M soc/mediatek/mt8196/sspm_release_notes.txt
3 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/51/86251/7
--
To view, visit https://review.coreboot.org/c/blobs/+/86251?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I836b23e1aa0d6808206365e38f29310e03900cc3
Gerrit-Change-Number: 86251
Gerrit-PatchSet: 7
Gerrit-Owner: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Kenji Yu <kenji.yu(a)mediatek.corp-partner.google.com>
Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86227?usp=email )
Change subject: soc/intel/adl: Handle critical low battery early in romstage
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/86227/comment/e6ee13ae_1341a45b?us… :
PS3, Line 446: early_shutdown_if_battery_below_critical_threshold();
> I think the motivation is to inform the user as much as possible through Graphical UI than text. […]
Oh, okay, so this isn't mutually exclusive with the ramstage version, this is only for the memory training / CSE update case, and in all other cases we want to wait until ramstage. That really isn't obvious from the code yet, it would be good to add a comment and expand the Kconfig help description to explain that more clearly.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86227?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4be86ed17818ee05b7bec0337a90f80017183c2
Gerrit-Change-Number: 86227
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 01:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email )
Change subject: soc/intel/adl: Display low battery message on screen
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> For alderlake platforms alone, libgfxinit is used for early (pre-ram stages) notification. […]
Okay, fair enough... if Alderlake will remain the only platform that uses the libgfxinit version I guess we can keep the code in there.
There still seems to be some duplication here regarding the fallback text when the locale-specific text wasn't found. Maybe we should move that hardcoded fallback into `ux_locales_get_text()` to avoid that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86224?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b24d2c89ade8cc62b7e47c487d52d47b7f3376d
Gerrit-Change-Number: 86224
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 01:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86253?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk_fsp_ramstage version v1.0
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/blobs/+/86253/comment/dee89f0e_53f87f06?usp=e… :
PS2, Line 15:
> BRANCH=rauru
Done
--
To view, visit https://review.coreboot.org/c/blobs/+/86253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I92479085a5a688b3fde241568bd06005a52e8dc1
Gerrit-Change-Number: 86253
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 01:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>