Yidi Lin has submitted this change. ( https://review.coreboot.org/c/blobs/+/86248?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
......................................................................
soc/mediatek/mt8186: Update SSPM firmware from v2.0.1 to v2.0.2
- Fix error handler for infra timeout in SSPM. The error handler for
infra timeout in SSPM was not handled properly, causing the ISR to
get stuck. As a result, tasks without ISR would not continue to
operate.
- Enable SSPM debug configs
BRANCH=corsola
BUG=b:360756645, b:374015969
TEST=get "MediaTek SSPM firmware: version 2.0.2" by
strings sspm.bin | grep version
Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905
Signed-off-by: jason-ch chen <jason-ch.chen(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8186/sspm.bin
M soc/mediatek/mt8186/sspm.bin.md5
M soc/mediatek/mt8186/sspm_release_notes.txt
3 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Yidi Lin: Looks good to me, approved
Yu-Ping Wu: Verified; Looks good to me, approved
diff --git a/soc/mediatek/mt8186/sspm.bin b/soc/mediatek/mt8186/sspm.bin
index f72c1f1..89cad15 100644
--- a/soc/mediatek/mt8186/sspm.bin
+++ b/soc/mediatek/mt8186/sspm.bin
Binary files differ
diff --git a/soc/mediatek/mt8186/sspm.bin.md5 b/soc/mediatek/mt8186/sspm.bin.md5
index 23130ca..534a51b 100644
--- a/soc/mediatek/mt8186/sspm.bin.md5
+++ b/soc/mediatek/mt8186/sspm.bin.md5
@@ -1 +1 @@
-634e532d6acb98e4b1807944233b8f81 *sspm.bin
+c39ba49caff7a4d94c547c391d8ef25b *sspm.bin
diff --git a/soc/mediatek/mt8186/sspm_release_notes.txt b/soc/mediatek/mt8186/sspm_release_notes.txt
index 244c06f..864728e 100644
--- a/soc/mediatek/mt8186/sspm_release_notes.txt
+++ b/soc/mediatek/mt8186/sspm_release_notes.txt
@@ -1,5 +1,9 @@
** Build from MediaTek Internal **
+# v2.0.2
+1. Fix error handler for infra timeout in SSPM.
+2. Enable SSPM debug configs.
+
# v2.0.1
1. Fix PMIC MT6315 regulator issue.
--
To view, visit https://review.coreboot.org/c/blobs/+/86248?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Id9491ecf7dde823f5ec034ae92d4b4bcfcdc6905
Gerrit-Change-Number: 86248
Gerrit-PatchSet: 3
Gerrit-Owner: jason-ch chen <Jason-ch.Chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, John Su, Kapil Porwal, Nick Vaccaro.
Jayvik Desai has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86144?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86144?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63512e85052bce974ffb0b738164bea440bd413c
Gerrit-Change-Number: 86144
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:07:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Ian Feng, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/86262?usp=email )
Change subject: mb/google/fatcat/var/francka: Enable CNVi wifi core
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
note if you have FW config for WIFI with different models then you can handle this using FW config.c as well like we did in fatcat
--
To view, visit https://review.coreboot.org/c/coreboot/+/86262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c38882aab801dedb05355774e5b930a8528fed
Gerrit-Change-Number: 86262
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Ian Feng, Kapil Porwal, Pranava Y N.
Jayvik Desai has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/86262?usp=email )
Change subject: mb/google/fatcat/var/francka: Enable CNVi wifi core
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c38882aab801dedb05355774e5b930a8528fed
Gerrit-Change-Number: 86262
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:05:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Ian Feng, Jayvik Desai, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/86262?usp=email )
Change subject: mb/google/fatcat/var/francka: Enable CNVi wifi core
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c38882aab801dedb05355774e5b930a8528fed
Gerrit-Change-Number: 86262
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 10:04:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Alok Agarwal, Anil Kumar K, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja.
Paul Menzel has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )
Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................
Patch Set 11:
(4 comments)
Patchset:
PS11:
What’s the difference to the implementation for other SoC types?
Commit Message:
https://review.coreboot.org/c/coreboot/+/85454/comment/64935157_9b7f4fb4?us… :
PS11, Line 12: initialization
Fits on the line above.
https://review.coreboot.org/c/coreboot/+/85454/comment/95bb9ffc_61dd8ee3?us… :
PS11, Line 47: The SOC_INTEL_PANTHERLAKE_SIGN_OF_LIFE flag also selects the LZ4
: compression algorithm for the Video BIOS Tables (VBT), as LZMA
: decompression is not available by default during the romstage
: phase. Integrating LZMA support would increase the romstage binary
: size by an amount greater than the reduction achieved by compressing
: the VBT binary using LZMA.
Please reflow for 72 characters per line.
https://review.coreboot.org/c/coreboot/+/85454/comment/ddc6d275_97fa3b05?us… :
PS11, Line 53:
Add a TEST= line and mention the new log messages.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85454?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I993eb0d59cd01fa62f35a77f84e262e389efb367
Gerrit-Change-Number: 85454
Gerrit-PatchSet: 11
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 09:24:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Paul Menzel has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/84923?usp=email )
Change subject: mb/google/fatcat: Enable s0ix
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84923/comment/e35f1cac_79159a62?us… :
PS1, Line 8:
> s0ix is verified with the latest CPFE and fatcat OS.
Please update the commit message with this information next time.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84923?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c65782830a2a22a9e8bb39615717a11183d30f
Gerrit-Change-Number: 84923
Gerrit-PatchSet: 4
Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 09:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jamie Ryu <jamie.m.ryu(a)intel.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Alok Agarwal, Anil Kumar K, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email )
Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training
......................................................................
Patch Set 11:
(2 comments)
File src/soc/intel/pantherlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/85454/comment/b1fb2688_f732281e?us… :
PS11, Line 420: SOC_INTEL_PANTHERLAKE_SIGN_OF_LIFE
can you please rely on https://review.coreboot.org/c/coreboot/+/83770 Kconfig.
File src/soc/intel/pantherlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85454/comment/1ac73feb_e653dae4?us… :
PS11, Line 375:
how about someone still using CSE sync in romstage ? (like non-CrOS usecase). we might still support there workflow ?
can you please take a look at MTL flow ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85454?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I993eb0d59cd01fa62f35a77f84e262e389efb367
Gerrit-Change-Number: 85454
Gerrit-PatchSet: 11
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 08:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Gavin Liu, Hung-Te Lin.
Yidi Lin has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email )
Change subject: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Gerrit-Change-Number: 86252
Gerrit-PatchSet: 3
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 08:15:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes