Attention is currently required from: Gavin Liu, Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email )
Change subject: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Gerrit-Change-Number: 86252
Gerrit-PatchSet: 3
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 07:40:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Gavin Liu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email )
Change subject: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86252/comment/78d8dffe_bfdb4c84?us… :
PS2, Line 7: Add TF-A static library path
> Specify MTKLIB_PATH for building BL31
Done
https://review.coreboot.org/c/coreboot/+/86252/comment/00e90f18_bf306257?us… :
PS2, Line 9: TF-A
> BL31
Done
https://review.coreboot.org/c/coreboot/+/86252/comment/60852869_ce974178?us… :
PS2, Line 10:
> BRANCH=rauru
Done
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86252/comment/974b8c91_deb8f668?us… :
PS1, Line 96: libmtk.a
> I like libbl31, as it's more consistent with BL31_MAKEARGS. libmtk is a too general name. […]
Ok, change to use libbl31.a
--
To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Gerrit-Change-Number: 86252
Gerrit-PatchSet: 3
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 07:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Gavin Liu, Hung-Te Lin.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86252?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
......................................................................
soc/mediatek/mt8196: Specify MTKLIB_PATH for building BL31
Add BL31 static library path to BL31 build argument.
BRANCH=rauru
BUG=b:317009620
TEST=Build pass with and without static library. boot ok.
Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Signed-off-by: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
---
M src/soc/mediatek/mt8196/Makefile.mk
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86252/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/86252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Gerrit-Change-Number: 86252
Gerrit-PatchSet: 3
Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com>
Attention is currently required from: Ian Feng, Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik.
Hello Jayvik Desai, Kapil Porwal, Pranava Y N, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86262?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/fatcat/var/francka: Enable CNVi wifi core
......................................................................
mb/google/fatcat/var/francka: Enable CNVi wifi core
Enable CNVi wifi core for francka.
BUG=b:391772114
TEST=Build and boot to OS in francka.
lspci:
00:14.3 Network controller: Intel Corporation Device e440
Change-Id: I80c38882aab801dedb05355774e5b930a8528fed
Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
---
M src/mainboard/google/fatcat/variants/francka/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/86262/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86262?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80c38882aab801dedb05355774e5b930a8528fed
Gerrit-Change-Number: 86262
Gerrit-PatchSet: 2
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin Roth, Matt DeVillier, Maximilian Brune, Raul Rangel.
Patrick Rudolph has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )
Change subject: soc/amd/common: Support sbin ucode files
......................................................................
Patch Set 9:
(4 comments)
File src/soc/amd/common/block/cpu/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/68122/comment/c6794507_331b6537?us… :
PS2, Line 21: hexdump
> I tried `dd` and `printf` in the shell and couldn't get it to work, but I did find another solution […]
Done
File src/soc/amd/common/block/cpu/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/68122/comment/5510864d_44eaebd1?us… :
PS5, Line 20: ucode
> This kind of shell code (if else stuff) is arguable harder to read if directly included inside the M […]
Done
https://review.coreboot.org/c/coreboot/+/68122/comment/f3eb6cef_f3b1cfbd?us… :
PS5, Line 41: $(amd_microcode_bins)
> Doesn't that make it unnecessarily complicated? We would still need 2 loops to filter sbin and bin. […]
Done
https://review.coreboot.org/c/coreboot/+/68122/comment/9c9c61a4_a6b673fe?us… :
PS5, Line 43: $(amd_microcode_sbins)
> $(filter %. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/68122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29768ea19543bdc76662e687f59bf31b76f555ae
Gerrit-Change-Number: 68122
Gerrit-PatchSet: 9
Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 04 Feb 2025 06:50:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Frank Wu has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86144?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for touchscreen
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86144?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63512e85052bce974ffb0b738164bea440bd413c
Gerrit-Change-Number: 86144
Gerrit-PatchSet: 2
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 04 Feb 2025 06:47:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes